Re: [ovs-dev] plan to integrate Hyper-V support

2014-07-25 Thread Guolin Yang
we have plan to make ovs as a inbox driver in Windows platform? Thanks Guolin - Original Message - From: "Ben Pfaff" To: dev@openvswitch.org Cc: "Alin Serdean" , "Alessandro Pilotti" , "Saurabh Shah" , "Nithin Raju" , "Guoli

Re: [ovs-dev] [PATCH v2] ofproto: Check ofproto_port_query_by_name() return value when adding port.

2013-11-07 Thread Guolin Yang
:06 PM, Ben Pfaff wrote: > Otherwise, if the port add succeeds but the query that looks up the port > number fails, then ofproto_port_add() would return zero as the OpenFlow > port number and ignore the error. > > Reported-by: Guolin Yang > Signed-off-by: Ben Pfaff > --- >

Re: [ovs-dev] [PATCH v2] ofproto: Check ofproto_port_query_by_name() return value when adding port.

2013-11-10 Thread Guolin Yang
>From my understanding, there is no cleanup to do, the pointers in the >"ofproto_port" will be 'memset' to NULL if query fails. [Guolin] I am just wondering when error is returned to caller, will the caller automatically cleanup ofport if it is already initialized. I may not fully understan

Re: [ovs-dev] [PATCH] Fix a bug in conversion between flow/mask and flow key

2013-08-30 Thread Guolin Yang, VMware
range of data type [-Werror=type-limits] > > lib/odp-util.c:2560:31: error: comparison is always false due to limited > > range of data type [-Werror=type-limits] > > > > It would be nice to describe the bug explicitly in the commit message. > > > > > > > &

Re: [ovs-dev] [PATCH] Fix a memory corruption in CFM

2013-09-04 Thread Guolin Yang, VMware
You are right, I send anew patch with proper description On Wed, Sep 4, 2013 at 8:00 AM, Ben Pfaff wrote: > On Wed, Sep 04, 2013 at 12:36:50AM -0700, gy...@nicira.com wrote: > > From: Guolin Yang > > > > In cfm, when allocating the rmp array, the size is not calculated