Re: [ovs-dev] kernel module testing

2015-07-28 Thread Finucane, Stephen
> > > For what it's worth, I also think that something like Gerrit would be > > > useful given the number of platforms that OVS is running on. Right > > > now, it's seems like we're doing the human-powered version, which is > > > Guru, Daniele, or Ben complain when something breaks Windows, DPDK, >

Re: [ovs-dev] kernel module testing

2015-07-28 Thread Finucane, Stephen
> On 7/28/15 3:19 AM, Finucane, Stephen wrote: > >>>> For what it's worth, I also think that something like Gerrit would be > >>>> useful given the number of platforms that OVS is running on. Right > >>>> now, it's seems like we're doi

[ovs-dev] '27: test atomic operations' unit test hanging

2014-12-19 Thread Finucane, Stephen
Hi, I'm seeing the following unit test hanging on multiple boards, while it passes on one board: 27: test atomic operations Before I invest time debugging, has anyone seen similar issues with this test? Regards, Stephen Finucane --- PS: The boards are on different kernels (failing: 3

Re: [ovs-dev] [PATCH] configure.ac: Enable 'tar-ustar' by default

2015-01-05 Thread Finucane, Stephen
> On Fri, Dec 19, 2014 at 10:19:10AM +, Stephen Finucane wrote: > > Automake defaults to the 'v7' legacy tar format in GNU tar, through > > passing of the '-o' parameter to GNU tar. Enabling this option results > > in errors for users with 32 bit UIDs: > > > > $ make dist > > ... > >

Re: [ovs-dev] [PATCH] configure: Omit -O2 from $CFLAGS when configuring with --enable-coverage.

2015-01-05 Thread Finucane, Stephen
I think it's worth adding that, while the below is using a different approach, Stack Overflow thinks this is a bad idea: http://stackoverflow.com/a/4680578/613428 I'm not confident enough with Autotools to say that this definitely should not be done, but there are some good points to be

[ovs-dev] Patchwork down?

2015-01-05 Thread Finucane, Stephen
The Open vSwitch Patchwork instance at 'patchwork.openvswitch.org' does not appear to have been updated since mid/late October? Is there an alternative, or is this dead in the water? Regards, Stephen ___ dev mailing list dev@openvswitch.org http://open

Re: [ovs-dev] Building OVS on Ubuntu 12.04 stuck in atomic operation unit test

2015-01-05 Thread Finucane, Stephen
I'm seeing the exact same issue on multiple version of Fedora. See here: http://openvswitch.org/pipermail/dev/2014-December/049833.html Regards, Stephen > When building OVS (the latest master) under Ubuntu 12.04, it stuck at the > unit test "test atomic operations” and never finishes (or it coul

Re: [ovs-dev] Patchwork down?

2015-01-05 Thread Finucane, Stephen
> On Mon, Jan 05, 2015 at 11:02:51AM +0000, Finucane, Stephen wrote: > > The Open vSwitch Patchwork instance at 'patchwork.openvswitch.org' > > does not appear to have been updated since mid/late October? Is there > > an alternative, or is this dead in the water? &

Re: [ovs-dev] [PATCH] configure.ac: Enable 'tar-ustar' by default

2015-01-06 Thread Finucane, Stephen
> On Mon, Jan 05, 2015 at 08:57:48AM +0000, Finucane, Stephen wrote: > > > On Fri, Dec 19, 2014 at 10:19:10AM +, Stephen Finucane wrote: > > > > Automake defaults to the 'v7' legacy tar format in GNU tar, through > > > > passing of the '-o&#x

Re: [ovs-dev] Building OVS on Ubuntu 12.04 stuck in atomic operation unit test

2015-01-07 Thread Finucane, Stephen
> We've heard similar reports before but it's challenging to find the > problem. I can't reproduce the problem on my 32-bit Debian system by > just, for example, switching to GCC 4.6. From [here]( http://openvswitch.org/pipermail/dev/2014-December/049833.html), you'll see I have a number of boar

Re: [ovs-dev] '27: test atomic operations' unit test hanging

2015-01-07 Thread Finucane, Stephen
> UPDATE: With a fresh "apt-get dist-upgrade" on Ubuntu 14.10 and a fresh > "git pull" on the openvswitch repo, the clang error and test #27 hangup are > not reproducible on that platform. > > The test #27 hangup is still reproducible on CentOS 7 after a fresh "yum > upgrade" and "git pull" on th

Re: [ovs-dev] Building OVS on Ubuntu 12.04 stuck in atomic operation unit test

2015-01-09 Thread Finucane, Stephen
> Jarno's idea of getting a disassembly is a good idea, but it might be > easier if you just pass along test-atomic.o from a broken machine. > Then we can just disassemble it and otherwise examine it for > ourselves. I applied Jarno's patch, but alas it had no effect. I've attached the '.o' file

Re: [ovs-dev] [PATCH] test-atomic: Stop testing when running slow.

2015-01-14 Thread Finucane, Stephen
Fixes issue for me also. Cheers. Stephen ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] configure.ac: Enable 'tar-ustar' by default

2015-01-14 Thread Finucane, Stephen
> Thanks for the followup. I hope that the Automake maintainers consider > the issue. No reply after > 1 week. How could we proceed here, as I'm still unable to run 'make dist' (without manual patching) in the interim? Based on my conversation with Eric, it looks like this is something that cou

Re: [ovs-dev] [PATCH] configure.ac: Enable 'tar-ustar' by default

2015-01-14 Thread Finucane, Stephen
> On 01/14/2015 01:15 PM, Finucane, Stephen wrote: > >> Thanks for the followup. I hope that the Automake maintainers consider > >> the issue. > > > > No reply after > 1 week. How could we proceed here, as I'm still unable > to run 'make dist'

Re: [ovs-dev] [PATCH] configure.ac: Enable 'tar-ustar' by default

2015-01-14 Thread Finucane, Stephen
> I dont remember the automake version I first encountered that, it was on > another project which had already been using ustar for several years but > then at some point during 2013 it started whining about large UIDs. Assuming said project was open source, how did they go about achieving this:

[ovs-dev] Markdown coding standard

2015-02-12 Thread Finucane, Stephen
I note that there are no coding standard for Markdown documents. Given this, I have some questions: * What's the expected format for code blocks (multi-line and single-line)? * Can we use GHFM-extensions (i.e. syntax-highlighted code fences) * Line limit? It's not necessary to wrap Markdown

Re: [ovs-dev] Markdown coding standard

2015-02-13 Thread Finucane, Stephen
> On 02/12/15 at 05:37pm, Finucane, Stephen wrote: > > I note that there are no coding standard for Markdown documents. Given > this, I have some questions: > > > > * What's the expected format for code blocks (multi-line and single- > line)? > > We ha

Re: [ovs-dev] Markdown coding standard

2015-02-13 Thread Finucane, Stephen
> On Thu, Feb 12, 2015 at 09:21:35PM +0100, Thomas Graf wrote: > > On 02/12/15 at 05:37pm, Finucane, Stephen wrote: > > > * Line limit? It's not necessary to wrap Markdown if you don't want > to, but files seem to alternate between 72, 79 and 80+ quite a bit >

Re: [ovs-dev] Markdown coding standard

2015-02-16 Thread Finucane, Stephen
> On Fri, Feb 13, 2015 at 05:28:34PM +0000, Finucane, Stephen wrote: > > > On Thu, Feb 12, 2015 at 09:21:35PM +0100, Thomas Graf wrote: > > > > On 02/12/15 at 05:37pm, Finucane, Stephen wrote: > > > > > * Line limit? It's not necessary to wrap Mark

[ovs-dev] Passing 'CFLAGS' to 'configure' or 'make' kills performance - DPDK datapath

2015-02-18 Thread Finucane, Stephen
Folks, I have a Makefile that defines multiple targets, including these two (for building OVS with DPDK support): config-ovs: cd $(OVS_DIR) && ./boot.sh && ./configure --with-dpdk=$(DPDK_BUILD) \ --disable-ssl --enable-silent-rules && cd $(ROOT_DIR)

Re: [ovs-dev] Passing 'CFLAGS' to 'configure' or 'make' kills performance - DPDK datapath

2015-02-24 Thread Finucane, Stephen
> Hi Stephen, > > The userspace fastpath backed by DPDK, more than other OVS components, > performs a lot worse when optimizations are disabled. We ended up > recommending "extreme" optimization flags in INSTALL.md ("-O3 > -march=native", ok if you don't need to run your build elsewhere). > > Tha

Re: [ovs-dev] [RFC] make: Add 'lint-docs' target

2015-11-12 Thread Finucane, Stephen
> This provides a quick, easy way to use the 'mdl' executable provided > in markdowlinter to validate documentation. > > This change does not resolve any of the issues this linter raises - > these will need to be done in a follow up patch. > > Signed-off-by: Stephen Finucane This is strictly an

Re: [ovs-dev] [RFC] make: Add 'lint-docs' target

2015-11-13 Thread Finucane, Stephen
On 13 Nov 14:08, Russell Bryant wrote: > On Thu, Nov 12, 2015 at 9:18 PM, Stephen Finucane > wrote: > > This provides a quick, easy way to use the 'mdl' executable provided > in markdowlinter to validate documentation. > > This change does not resolve any of the issues this linter ra

Re: [ovs-dev] [RFC] make: Add 'lint-docs' target

2015-11-13 Thread Finucane, Stephen
On 13 Nov 13:18, Russell Bryant wrote: > On Fri, Nov 13, 2015 at 11:40 AM, Finucane, Stephen < > stephen.finuc...@intel.com> wrote: > > > On 13 Nov 14:08, Russell Bryant wrote: > > > On Thu, Nov 12, 2015 at 9:18 PM, Stephen Finucane < > >

Re: [ovs-dev] [RFC] make: Add 'lint-docs' target

2015-11-20 Thread Finucane, Stephen
On 15 Nov 19:10, Russell Bryant wrote: [snip] > > > Thanks for sharing. > > > > > > It'd be nice to strip this down to errors that will actually negatively > > > affect the docs getting rendered properly. If it's something that breaks > > > viewing the doc on github or breaks the HTML version in

Re: [ovs-dev] [RFC] make: Add 'lint-docs' target

2015-11-25 Thread Finucane, Stephen
On 24 Nov 22:05, Ben Pfaff wrote: > On Fri, Nov 13, 2015 at 02:18:40AM +, Stephen Finucane wrote: > > This provides a quick, easy way to use the 'mdl' executable provided > > in markdowlinter to validate documentation. > > > > This change does not resolve any of the issues this linter raises -