From: Himangi Saraogi
Date: Sun, 27 Jul 2014 12:37:46 +0530
> This patch introduces the use of the macro IS_ERR_OR_NULL in place of
> tests for NULL and IS_ERR.
>
> The following Coccinelle semantic patch was used for making the change:
>
> @@
> expression e;
> @@
>
> - e == NULL || IS_ERR(e)
From: Thomas Graf
Date: Wed, 30 Jul 2014 02:31:08 +0200
> No need for the unlikely(), WARN_ON() and BUG_ON() internally use
> unlikely() on the condition.
>
> Signed-off-by: Thomas Graf
Applied, thanks.
___
dev mailing list
dev@openvswitch.org
http:/
From: Thomas Graf
Date: Tue, 29 Jul 2014 13:41:31 +0200
> Netlink sockets are maintained in a hash table to allow efficient lookup
> via the port ID for unicast messages. However, lookups currently require
> a read lock to be taken. This series adds a new generic, resizable,
> scalable, concurren
From: Thomas Graf
Date: Fri, 1 Aug 2014 00:56:00 +0200
> Netlink sockets are maintained in a hash table to allow efficient lookup
> via the port ID for unicast messages. However, lookups currently require
> a read lock to be taken. This series adds a new generic, resizable,
> scalable, concurren
From: David Miller
Date: Thu, 31 Jul 2014 22:39:46 -0700 (PDT)
> Looks great, series applied, thanks!
Actually, this needs more work, reverted:
net/netfilter/nft_hash.c: In function ‘nft_hash_destroy’:
net/netfilter/nft_hash.c:183:3: error: ‘ht’ undeclared (first use in this
function)
From: Thomas Graf
Date: Sat, 2 Aug 2014 11:47:43 +0200
> Netlink sockets are maintained in a hash table to allow efficient lookup
> via the port ID for unicast messages. However, lookups currently require
> a read lock to be taken. This series adds a new generic, resizable,
> scalable, concurren
From: Sasha Levin
Date: Mon, 04 Aug 2014 22:10:19 -0400
> On 08/02/2014 05:47 AM, Thomas Graf wrote:
>> static void *netlink_seq_start(struct seq_file *seq, loff_t *pos)
>> -__acquires(nl_table_lock)
>> {
>> -read_lock(&nl_table_lock);
>> +rcu_read_lock();
>> return *pos ? netl
From: Eric Dumazet
Date: Tue, 05 Aug 2014 07:50:07 +0200
> [PATCH net-next] netlink: fix lockdep splats
>
> With netlink_lookup() conversion to RCU, we need to use appropriate
> rcu dereference in netlink_seq_socket_idx() & netlink_seq_next()
>
> Reported-by: Sasha Levin
> Signed-off-by: Eric
From: Christoph Jaeger
Date: Tue, 12 Aug 2014 09:27:57 +0200
> ovs_vport_alloc() bails out without freeing the memory 'vport' points to.
>
> Picked up by Coverity - CID 1230503.
>
> Fixes: 5cd667b0a4 ("openvswitch: Allow each vport to have an array of
> 'port_id's.")
> Signed-off-by: Christoph
From: Jiri Benc
Date: Thu, 21 Aug 2014 21:33:44 +0200
> When there are multiple vlan headers present in a received frame, the first
> one is put into vlan_tci and protocol is set to ETH_P_8021Q. Anything in the
> skb beyond the VLAN TPID may be still non-linear, including the inner TCI
> and ethe
From: Andreea-Cristina Bernat
Date: Sun, 17 Aug 2014 16:29:43 +0300
> The "rcu_dereference()" call is used directly in a condition.
> Since its return value is never dereferenced it is recommended to use
> "rcu_access_pointer()" instead of "rcu_dereference()".
> Therefore, this patch makes the re
From: Simon Horman
Date: Thu, 21 Apr 2016 11:49:15 +1000
> When using masked actions the ipv6_proto field of an action
> to set IPv6 fields may be zero rather than the prevailing protocol
> which will result in skipping checksum recalculation.
>
> This patch resolves the problem by relying on th
From: Nicolas Dichtel
Date: Fri, 22 Apr 2016 17:31:15 +0200
> This is the continuation of the work done to align netlink attributes
> when these attributes contain some 64-bit fields.
>
> David, if the third patch is too big (or maybe the series), I can split it.
> Just tell me what you prefer.
From: Nicolas Dichtel
Date: Tue, 26 Apr 2016 10:06:10 +0200
> The last user of nla_put_u64() is block/drbd. This module does not use
> standard netlink API (see all the stuff in include/linux/genl_magic_struct.h
> and include/linux/genl_magic_func.h).
Yet another example where doing things in a
From: Jan Kara
Date: Tue, 26 Apr 2016 13:08:48 +0200
> On Tue 26-04-16 10:06:13, Nicolas Dichtel wrote:
>> Signed-off-by: Nicolas Dichtel
>
> OK, so I somewhat miss a description of what will this do to the netlink
> message so that I can judge whether the change is fine for the userspace
> cou
From: Lars Ellenberg
Date: Tue, 26 Apr 2016 13:54:27 +0200
> On Tue, Apr 26, 2016 at 10:06:10AM +0200, Nicolas Dichtel wrote:
>>
>> This is the continuation (series #3) of the work done to align netlink
>> attributes when these attributes contain some 64-bit fields.
>>
>> It's the last patchset
From: Nicolas Dichtel
Date: Wed, 27 Apr 2016 17:53:08 +0200
> The type TASKSTATS_TYPE_NULL should always be ignored.
>
> When jumping to the next attribute, only the length of the current
> attribute should be added, not the length of all nested attributes.
> This last bug was not visible before
From: Martynas Pumputis
Date: Tue, 9 Aug 2016 16:24:50 +0100
> The creation of a tunnel vport (geneve, gre, vxlan) brings up a
> corresponding netdev, a multi-step operation which can fail.
>
> For example, changing a vxlan vport's netdev state to 'up' binds the
> vport's socket to a UDP port -
From: Samuel Gauthier
Date: Tue, 28 Jun 2016 17:22:26 +0200
> Only the first and last netlink message for a particular conntrack are
> actually sent. The first message is sent through nf_conntrack_confirm when
> the conntrack is committed. The last one is sent when the conntrack is
> destroyed on
From: Samuel Gauthier
Date: Thu, 10 Mar 2016 17:14:59 +0100
> When we want to change a flow using netlink, we have to identify it to
> be able to perform a lookup. Both the flow key and unique flow ID
> (ufid) are valid identifiers, but we always have to specify the flow
> key in the netlink mess
From: Simon Horman
Date: Tue, 15 Mar 2016 12:00:35 +0900
> Currently output of MPLS packets on tunnel vports is not allowed by Open
> vSwitch. This is because historically encapsulation was done in such a way
> that the inner_protocol field of the skb needed to hold the inner protocol
> for both
From: Samuel Gauthier
Date: Wed, 16 Mar 2016 16:07:50 +0100
> This patchset adds a netlink api to refresh an existing flow in
> openvswitch.
This is too late for net-next, please resubmit this after the
merge window.
Thanks.
___
dev mailing list
dev@o
From: kbuild test robot
Date: Sat, 19 Mar 2016 00:54:50 +0800
> Signed-off-by: Fengguang Wu
Looks good, applied, thanks.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
From: Andy Zhou
Date: Thu, 17 Mar 2016 21:32:13 -0700
> Current openvswitch implementation allows up to 10 recirculation actions
> for each packet. This limit was sufficient for most use cases in the
> past, but with more new features, such as supporting connection
> tracking, and testing in larg
From: Arnd Bergmann
Date: Fri, 18 Mar 2016 14:33:45 +0100
> The openvswitch code has gained support for calling into the
> nf-nat-ipv4/ipv6 modules, however those can be loadable modules
> in a configuration in which openvswitch is built-in, leading
> to link errors:
>
> net/built-in.o: In funct
From: Haishuang Yan
Date: Mon, 28 Mar 2016 18:08:59 +0800
> For the input parameter count, it's better to use the size
> of destination buffer size, as nla_memcpy would take into
> account the length of the source netlink attribute when
> a data is copied from an attribute.
>
> Signed-off-by: Ha
From: Eric Dumazet
Date: Fri, 19 Aug 2016 12:56:56 -0700
> On Fri, 2016-08-19 at 16:47 -0300, Thadeu Lima de Souza Cascardo wrote:
>> Instead of using flow stats per NUMA node, use it per CPU. When using
>> megaflows, the stats lock can be a bottleneck in scalability.
>
> ...
>
>>
>> flo
From: Stephen Hemminger
Date: Mon, 22 Aug 2016 12:39:38 -0700
> This is a a real issue, but being buried in a huge patch series of include
> file stuff I don't think anyone would see it.
It hit netdev and thus patchwork, therefore anyone watching networking
patches saw it.
I would not call it b
From: Mikko Rapeli
Date: Mon, 22 Aug 2016 20:32:55 +0200
> Fixes userspace compiler error:
>
> error: unknown type name ‘uint32_t’
>
> Signed-off-by: Mikko Rapeli
Applied.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listi
From: Mikko Rapeli
Date: Mon, 22 Aug 2016 20:33:19 +0200
> Kernel uapi header are supposed to use them. Fixes userspace compile error:
>
> linux/openvswitch.h:583:2: error: unknown type name ‘uint32_t’
>
> Signed-off-by: Mikko Rapeli
Applied.
___
de
From: Eric Garver
Date: Wed, 7 Sep 2016 12:56:56 -0400
> This series adds 802.1ad support to openvswitch. It is a continuation of the
> work originally started by Thomas F Herbert - hence the large rev number.
...
Series applied, thanks.
___
dev mail
From: Thadeu Lima de Souza Cascardo
Date: Fri, 9 Sep 2016 17:42:30 -0300
> When userspace tries to create datapaths and the module is not loaded,
> it will simply fail. With this patch, the module will be automatically
> loaded.
>
> Signed-off-by: Thadeu Lima de Souza Cascardo
Applied to net-
From: Lance Richardson
Date: Tue, 13 Sep 2016 10:08:54 -0400
> The ovs kernel data path currently defers the execution of all
> recirc actions until stack utilization is at a minimum.
> This is too limiting for some packet forwarding scenarios due to
> the small size of the deferred action FIFO (
From: Thadeu Lima de Souza Cascardo
Date: Thu, 15 Sep 2016 19:11:53 -0300
> Instead of using flow stats per NUMA node, use it per CPU. When using
> megaflows, the stats lock can be a bottleneck in scalability.
>
> On a E5-2690 12-core system, usual throughput went from ~4Mpps to
> ~15Mpps when f
From: Thadeu Lima de Souza Cascardo
Date: Thu, 15 Sep 2016 19:11:52 -0300
> On a system with only node 1 as possible, all statistics is going to be
> accounted on node 0 as it will have a single writer.
>
> However, when getting and clearing the statistics, node 0 is not going
> to be considered
From: Jiri Benc
Date: Wed, 19 Oct 2016 11:26:35 +0200
> Removed unused functions and unnecessary EXPORT_SYMBOLs from openvswitch.
Series applied, thanks.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
From: Thomas Graf
Date: Tue, 21 Jul 2015 10:43:44 +0200
> This series combines the work previously posted by Roopa, Robert and
> myself. It's according to what we discussed at NFWS. The motivation
> of this series is to:
>
> * Consolidate code between OVS and the rest of the kernel and get
>
From: Chris J Arges
Date: Tue, 21 Jul 2015 12:36:33 -0500
> Some architectures like POWER can have a NUMA node_possible_map that
> contains sparse entries. This causes memory corruption with openvswitch
> since it allocates flow_cache with a multiple of num_possible_nodes() and
> assumes the node
From: Nicolas Dichtel
Date: Thu, 23 Jul 2015 11:29:07 +0200
> With CONFIG_VXLAN=m and CONFIG_OPENVSWITCH=y, there was the following
> compilation error:
> LD init/built-in.o
> net/built-in.o: In function `vxlan_tnl_create':
> .../net/openvswitch/vport-netdev.c:322: undefined reference
From: Thomas Graf
Date: Thu, 23 Jul 2015 13:04:44 +0200
> Retrieve the tunnel metadata for packets received by a net_device and
> provide it to ovs_vport_receive() for flow key extraction.
>
> [This hunk was in the GRE patch in the initial series and missed the
> cut for the initial submission
From: Thomas F Herbert
Date: Sun, 26 Jul 2015 10:52:34 -0400
> Signed-off-by: Thomas F Herbert
> ---
> include/linux/if_vlan.h | 17 +
> 1 file changed, 17 insertions(+)
>
> diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h
> index 67ce5bd..88d1be4 100644
> --- a/i
From: Thomas Graf
Date: Wed, 29 Jul 2015 13:52:06 +0200
> This readds the config option CONFIG_OPENVSWITCH_VXLAN to avoid a
> hard dependency of OVS on VXLAN. It moves the VXLAN config compat
> code to vport-vxlan.c and allows compliation as a module.
>
> Fixes: 614732eaa12d ("openvswitch: Use r
From: Glenn Griffin
Date: Mon, 3 Aug 2015 09:56:54 -0700
> openvswitch modifies the L4 checksum of a packet when modifying
> the ip address. When an IP packet is fragmented only the first
> fragment contains an L4 header and checksum. Prior to this change
> openvswitch would modify all fragments,
From: Wenyu Zhang
Date: Wed, 5 Aug 2015 00:30:47 -0700
> When sampling rate is 1, the sampling probability is UINT32_MAX. The packet
> should be sampled even the prandom32() generate the number of UINT32_MAX.
> And none packet need be sampled when the probability is 0.
>
> Signed-off-by: Wenyu Z
From: Glenn Griffin
Date: Mon, 10 Aug 2015 10:43:16 -0700
> On Mon, Aug 03, 2015 at 02:03:28PM -0700, David Miller wrote:
>> From: Glenn Griffin
>> Date: Mon, 3 Aug 2015 09:56:54 -0700
>>
>> > openvswitch modifies the L4 checksum of a packet when modifying
&
From: Simon Horman
Date: Sat, 29 Aug 2015 09:02:21 +0900
> When an error occurs skipping IPv6 extension headers retain the already
> parsed IP protocol and IPv6 addresses in the flow. Also assume that the
> packet is not a fragment in the absence of information to the contrary;
> that is always u
From: Wilfried Klaebe
Date: Sun, 11 May 2014 00:12:32 +
> net: get rid of SET_ETHTOOL_OPS
>
> Dave Miller mentioned he'd like to see SET_ETHTOOL_OPS gone.
> This does that.
>
> Mostly done via coccinelle script:
> @@
> struct ethtool_ops *ops;
> struct net_device *dev;
> @@
> - SET_ET
From: Jesse Gross
Date: Fri, 16 May 2014 14:07:27 -0700
> A set of OVS changes for net-next/3.16.
>
> The major change here is a switch from per-CPU to per-NUMA flow
> statistics. This improves scalability by reducing kernel overhead
> in flow setup and maintenance.
Pulled, thanks Jesse.
__
From: Jesse Gross
Date: Fri, 16 May 2014 15:57:59 -0700
> Pravin will be maintaining Open vSwitch going forward.
>
> CC: Pravin Shelar
> Signed-off-by: Jesse Gross
Applied, thank you.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/m
From: Pravin B Shelar
Date: Tue, 20 May 2014 01:59:38 -0700
> A set of OVS changes for net-next/3.16.
>
> Most of change are related to improving performance of flow setup by
> minimizing critical sections.
Pulled, thanks Pravin.
In the future please make your postings so that they have the cu
From: Simon Horman
Date: Fri, 30 May 2014 14:35:19 +0900
> If an MPLS packet requires segmentation then use mpls_features
> to determine if the software implementation should be used.
>
> As no driver advertises MPLS GSO segmentation this will always be
> the case.
>
> I had not noticed that th
From: Simon Horman
Date: Wed, 4 Jun 2014 08:53:17 +0900
> If an MPLS packet requires segmentation then use mpls_features
> to determine if the software implementation should be used.
>
> As no driver advertises MPLS GSO segmentation this will always be
> the case.
>
> I had not noticed that th
From: Jesse Gross
Date: Tue, 24 Jun 2014 16:24:37 -0700
> Applied, thanks for all your work. Time to break out the champagne :)
Congrats, what an amazing journey :-)
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
From: Pravin B Shelar
Date: Mon, 30 Jun 2014 23:33:16 -0700
> A set of fixes for net.
> First bug is related flow-table management. Second one is in sample
> action. Third is related flow stats and last one add gre-err handler for ovs.
Pulled, thanks Pravin.
From: Stephen Hemminger
Date: Wed, 16 Jul 2014 11:25:52 -0700
> Generic netlink tables can be const.
>
> Signed-off-by: Stephen Hemminger
Applied, thanks Stephen.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
From: Nicolas Dichtel
Date: Thu, 18 Sep 2014 10:31:03 +0200
> This function is the counterpart of the function netlink_has_listeners().
>
> Signed-off-by: Nicolas Dichtel
Applied.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailma
From: Nicolas Dichtel
Date: Thu, 18 Sep 2014 10:31:04 +0200
> From: Samuel Gauthier
>
> Since commit fb5d1e9e127a ("openvswitch: Build flow cmd netlink reply only if
> needed."),
> the new flows are not notified to the listeners of OVS_FLOW_MCGROUP.
>
> This commit fixes the problem by using
Pravin could you please review these two openvswitch kerneldoc
fixes from Fabian?
Thanks.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
From: Fabian Frederick
Date: Wed, 15 Oct 2014 21:03:18 +0200
> s/sock/gs
>
> Signed-off-by: Fabian Frederick
Applied.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
From: Fabian Frederick
Date: Wed, 15 Oct 2014 21:03:41 +0200
> All functions used struct vport *vport except
> ovs_vport_find_upcall_portid.
>
> This fixes 1 kerneldoc warning
>
> Signed-off-by: Fabian Frederick
Applied.
___
dev mailing list
dev@ope
From: Pravin Shelar
Date: Mon, 27 Oct 2014 17:27:11 -0700
> On Mon, Oct 27, 2014 at 2:47 PM, Thomas Graf wrote:
>> The patch also brings additional flexibility to users of
>> distributions. Distros typically ship something like an allmodconfig
>> so a user can either run openvswitch.ko with all
From: Thomas Graf
Date: Wed, 22 Oct 2014 17:29:06 +0200
> The internal and netdev vport remain part of openvswitch.ko. Encap
> vports including vxlan, gre, and geneve can be built as separate
> modules and are loaded on demand. Modules can be unloaded after use.
> Datapath ports keep a reference
From: Simon Horman
Date: Mon, 27 Oct 2014 16:12:16 +0900
> The original motivation for this change was to allow the helper to be used
> in files other than actions.c as part of work on an odp select group
> action.
>
> It was as pointed out by Thomas Graf that this helper would be best off
> liv
From: Alexei Starovoitov
Date: Tue, 28 Oct 2014 13:57:13 -0700
> On Tue, Oct 28, 2014 at 11:43 AM, David Miller wrote:
>> From: Thomas Graf
>> Date: Wed, 22 Oct 2014 17:29:06 +0200
>>
>>> The internal and netdev vport remain part of openvswitch.ko. Encap
>&g
From: Fabian Frederick
Date: Fri, 14 Nov 2014 19:32:58 +0100
> Signed-off-by: Fabian Frederick
Applied.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
From: Joe Stringer
Date: Tue, 18 Nov 2014 10:54:17 -0800
> When userspace doesn't provide a mask, OVS datapath generates a fully
> unwildcarded mask for the flow. This is done by taking a copy of the
> flow key, then iterating across its attributes, setting all values to
> 0xff. This works for mo
From: Simon Horman
Date: Fri, 18 Dec 2015 19:43:15 +0900
> In a set action tunnel attributes should be encoded in a
> nested action.
>
> I noticed this because ovs-dpctl was reporting an error
> when dumping flows due to the incorrect encoding of tunnel attributes
> in a set action.
>
> Fixes:
From: David Wragg
Date: Wed, 6 Jan 2016 13:33:04 +
> Prior to 4.3, openvswitch vxlan vports could transmit vxlan packets of
> any size, constrained only by the ability to transmit the resulting
> UDP packets. 4.3 introduced vxlan netdevs corresponding to vxlan
> vports. These netdevs have
From: David Wragg
Date: Wed, 06 Jan 2016 23:25:56 +
> Considering non-openvswitch scenarios, when using vxlan netdevs
> directly, a vxlan netdev locked to an underlying device supporting jumbo
> frames can use a larger MTU. It's only vxlan netdevs without an
> underlying device that have the
From: David Wragg
Date: Thu, 07 Jan 2016 23:42:52 +
> I'm willing to follow up on Jesse's request to look into the other
> tunnel types too, but at the moment I'm wondering what the chances are
> that the resulting submission would get accepted.
I'm ok with these fixes if you look into Jesse
From: Pablo Neira Ayuso
Date: Mon, 11 Jan 2016 19:50:33 +0100
> On Fri, Jan 08, 2016 at 10:29:53AM -0800, Jarno Rajahalme wrote:
>> This series adds NAT support to openvswitch kernel module. A few
>> changes are needed to the netfilter code to facilitate this (patches
>> 1-2/8). Patches 3-6 mak
There is no way I am applying any of these patches.
Improper Subject: prefixes, entire commit messages in the Subject
line, etc.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
It is not appropriate to submit net-next changes at this time.
If you wish to contribute to the networking kernel code, you should
read the netdev mailing lists, and read important announcements such
as this:
http://marc.info/?l=linux-netdev&m=145248145925834&w=2
THanks.
___
From: Konstantin Khlebnikov
Date: Fri, 08 Jan 2016 15:21:46 +0300
> Skb_gso_segment() uses skb control block during segmentation.
> This patch adds 32-bytes room for previous control block which
> will be copied into all resulting segments.
>
> This patch fixes kernel crash during fragmenting fo
From: Florian Westphal
Date: Thu, 14 Jan 2016 00:36:28 +0100
> David Miller wrote:
>> From: Konstantin Khlebnikov
>> Date: Fri, 08 Jan 2016 15:21:46 +0300
>>
>> > Skb_gso_segment() uses skb control block during segmentation.
>> > This patch adds 32-byte
From: David Wragg
Date: Wed, 10 Feb 2016 00:05:54 +
> Prior to 4.3, openvswitch tunnel vports (vxlan, gre and geneve) could
> transmit vxlan packets of any size, constrained only by the ability to
> send out the resulting packets. 4.3 introduced netdevs corresponding
> to tunnel vports. The
From: David Wragg
Date: Thu, 18 Feb 2016 16:54:14 +
> Tom Herbert writes:
>> Please implement like in ip_tunnel_change_mtu (or better yet call it),
>> that is the precedent for tunnels.
>
> I've made geneve_change_mtu follow ip_tunnel_change_mtu in v2.
>
> If it were to call it instead, ar
From: Thomas Graf
Date: Mon, 30 Mar 2015 13:57:41 +0200
> Return module reference before invoking the respective vport
> ->destroy() function. This is needed as ovs_vport_del() is not
> invoked inside an RCU read side critical section so the kfree
> can occur immediately before returning to ovs_v
net-next is not open at this time, please resubmit this when the
net-next tree is open for submissions again, thanks.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
From: Flavio Leitner
Date: Wed, 27 May 2015 10:24:14 -0300
> On Wed, May 27, 2015 at 10:50:21AM +0200, Jiri Benc wrote:
>> On Tue, 26 May 2015 15:03:56 -0700, Pravin Shelar wrote:
>> > OVS interface for generic networking device operation looks odd. have
>> > you considered adding new device ioct
From: Jesse Gross
Date: Mon, 6 Jan 2014 16:15:59 -0800
> Open vSwitch changes for net-next/3.14. Highlights are:
> * Performance improvements in the mechanism to get packets to userspace
>using memory mapped netlink and skb zero copy where appropriate.
> * Per-cpu flow stats in situations
From: Jesse Gross
Date: Wed, 8 Jan 2014 09:17:11 -0500
> On Wed, Jan 8, 2014 at 5:13 AM, Wei Yongjun wrote:
>> From: Wei Yongjun
>>
>> memory allocated by kmem_cache_alloc() should be freed using
>> kmem_cache_free(), not kfree().
>>
>> Fixes: e298e5057006 ('openvswitch: Per cpu flow stats.')
>
From: Thomas Graf
Date: Tue, 14 Jan 2014 16:27:49 +
> While the zerocopy method is correctly omitted if user space
> does not support unaligned Netlink messages. The attribute is
> still not padded correctly as skb_zerocopy() will not ensure
> padding and the attribute size is no longer pre c
From: Fernando Luis Vázquez Cao
Date: Tue, 04 Feb 2014 19:35:02 +0900
> We should check whether rtnetlink link operations
> are defined before calling get_slave_size().
>
> Without this, the following oops can occur when
> adding a tap device to OVS.
...
> Signed-off-by: Fernando Luis Vazquez C
From: Jesse Gross
Date: Tue, 4 Feb 2014 22:59:16 -0800
> A handful of bug fixes for net/3.14. High level fixes are:
> * Regressions introduced by the zerocopy changes, particularly with
>old userspaces.
> * A few bugs lingering from the introduction of megaflows.
> * Overly zealous error
From: Jiri Pirko
Date: Thu, 13 Feb 2014 19:12:57 +0100
>>> [ 3014.524118] [] ? __dev_queue_xmit+0x5/0x6a0
...
> I fail to see where bh is disabled. ovs_dp_process_received_packet() is
> called with rcu_read_lock...
It happens in __dev_queue_xmit(), which does rcu_read_lock_bh().
_
From: Jiri Pirko
Date: Thu, 13 Feb 2014 21:07:53 +0100
> Thu, Feb 13, 2014 at 08:26:54PM CET, da...@davemloft.net wrote:
>>From: Jiri Pirko
>>Date: Thu, 13 Feb 2014 19:12:57 +0100
>>
> [ 3014.524118] [] ? __dev_queue_xmit+0x5/0x6a0
>> ...
>>> I fail to see where bh is disabled. ovs_dp_proc
From: Joe Perches
Date: Tue, 18 Feb 2014 11:15:45 -0800
> It's slightly smaller/faster for some architectures.
>
> Signed-off-by: Joe Perches
I'll let Jesse take this via his tree, thanks Joe.
___
dev mailing list
dev@openvswitch.org
http://openvswit
From: Zoltan Kiss
Date: Tue, 18 Mar 2014 21:17:35 +
> skb_zerocopy can copy elements of the frags array between skbs, but it doesn't
> orphan them. Also, it doesn't handle errors, so this patch takes care of that
> as well.
>
> Signed-off-by: Zoltan Kiss
> ---
> net/openvswitch/datapath.c
From: Jesse Gross
Date: Thu, 20 Mar 2014 11:09:10 -0700
> Four small fixes for net/3.14. I realize that these are late in the cycle -
> just got back from vacation.
>
> The following changes since commit c14e0953ca51dbcb8d1ac92acbdcff23d0caa158:
>
> openvswitch: Suppress error messages on me
From: Zoltan Kiss
Date: Thu, 20 Mar 2014 16:02:34 +
> skb_zerocopy can copy elements of the frags array between skbs, but it doesn't
> orphan them. Also, it doesn't handle errors, so this patch takes care of that
> as well, and modify the callers accordingly. skb_tx_error() is also added to
>
From: Zoltan Kiss
Date: Fri, 21 Mar 2014 10:31:34 +
> skb_zerocopy can copy elements of the frags array between skbs, but it doesn't
> orphan them. Also, it doesn't handle errors, so this patch takes care of that
> as well, and modify the callers accordingly. skb_tx_error() is also added to
>
From: David Miller
Date: Wed, 26 Mar 2014 15:59:58 -0400 (EDT)
> From: Zoltan Kiss
> Date: Fri, 21 Mar 2014 10:31:34 +
>
>> skb_zerocopy can copy elements of the frags array between skbs, but it
>> doesn't
>> orphan them. Also, it doesn't handle err
From: Zoltan Kiss
Date: Wed, 26 Mar 2014 22:37:45 +
> skb_zerocopy can copy elements of the frags array between skbs, but it doesn't
> orphan them. Also, it doesn't handle errors, so this patch takes care of that
> as well, and modify the callers accordingly. skb_tx_error() is also added to
>
From: Flavio Leitner
Date: Thu, 27 Mar 2014 09:53:56 -0300
> There are two problematic situations.
>
> A deadlock can happen when is_percpu is false because it can get
> interrupted while holding the spinlock. Then it executes
> ovs_flow_stats_update() in softirq context which tries to get
> the
From: Flavio Leitner
Date: Thu, 27 Mar 2014 11:05:34 -0300
> There are two problematic situations.
>
> A deadlock can happen when is_percpu is false because it can get
> interrupted while holding the spinlock. Then it executes
> ovs_flow_stats_update() in softirq context which tries to get
> the
From: Joe Stringer
Date: Wed, 19 Nov 2014 13:54:49 -0800
> When userspace doesn't provide a mask, OVS datapath generates a fully
> unwildcarded mask for the flow by copying the flow and setting all bits
> in all fields. For IPv6 label, this creates a mask that matches on the
> upper 12 bits, caus
Please do not quote an entire patch just to add some simple feedback or
signoff/ack.
That means someone has to scroll past the entire patch in patchwork or
the mailing list archives, unnecessarily.
This is one of my largest pet peeves, please do not do this.
Thanks.
From: Jiri Benc
Date: Fri, 5 Dec 2014 17:24:28 +0100
> Respect what the caller passed to ovs_tunnel_get_egress_info.
>
> Fixes: 8f0aad6f35f7e ("openvswitch: Extend packet attribute for egress tunnel
> info")
> Signed-off-by: Jiri Benc
Applied, thanks.
From: Jarno Rajahalme
Date: Tue, 9 Dec 2014 16:10:25 -0800
> OVS userspace already probes the openvswitch kernel module for
> OVS_ACTION_ATTR_SET_MASKED support. This patch adds the kernel module
> implementation of masked set actions.
>
> The existing set action sets many fields at once. Whe
1 - 100 of 224 matches
Mail list logo
