[ovs-dev] [PATCH 0/3] skbuff: pskb_expand_head changes

2013-06-12 Thread Dave Wiltshire
he other patches are from looking at all the call sites to pskb_expand_head and since I was doing that I cleaned some of them up. Dave Wiltshire (3): skbuff: Update truesize in pskb_expand_head skbuff: skb_cow_head not used in some drivers. skbuff: Added new helper function skb_cow_clone

[ovs-dev] [PATCH 1/3] skbuff: Update truesize in pskb_expand_head

2013-06-12 Thread Dave Wiltshire
Some call sites to pskb_expand_head subsequently update the skb truesize and others don't (even with non-zero arguments). This is likely a memory audit leak. Fixed this up by moving the memory accounting to the skbuff.c file and removing it from the calling sites. Signed-off-by: Dave Wilt

[ovs-dev] [PATCH 3/3] skbuff: Added new helper function skb_cow_clone_head.

2013-06-12 Thread Dave Wiltshire
In a few different drivers there is a check of (skb_cloned && !skb_clone_writable) before then using pskb_expand_head to copy the skb if that is required. There are already some skb_cow_* functions for other conditions, so added this one and changed the call sites. Signed-off-by: Dave W

[ovs-dev] [PATCH 2/3] skbuff: skb_cow_head not used in some drivers.

2013-06-12 Thread Dave Wiltshire
There is a helper function skb_cow_head which checks if a skb needs to be expanded. This was unused in some drivers. Fixing that leads to cleaner code in the drivers. Signed-off-by: Dave Wiltshire --- drivers/net/ethernet/atheros/atl1c/atl1c_main.c |8 ++-- drivers/net/ethernet