This patch adds an additional include file while compiling under MSVC.
Found by compiling under MSVC x64 and hitting the following problem:
http://stackoverflow.com/questions/23144151/64-bit-function-returns-32-bit-pointer
Signed-off-by: Alin Gabriel Serdean
---
lib/stream-tcp.c | 2 ++
1 file
MSVC does not support zero-size array unless it is the last member of
a defined structure.
The error is hit only on MSVC 64 bit because the size of
uint64_t is equal with sizeof(struct tun_table *).
This patch ifdef's out the pad member of the structure tun_metadata
in case we are on the MSVC 64
We will support x64 bit compiling making this build assert outdated.
Signed-off-by: Alin Gabriel Serdean
---
lib/netlink-socket.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/netlink-socket.c b/lib/netlink-socket.c
index 42eb232..6722a86 100644
--- a/lib/netlink-socket.c
+++ b/lib/netl
In case of MSVC 64 bit compiler use ovs-atomic-pthreads for now.
Signed-off-by: Alin Gabriel Serdean
---
lib/ovs-atomic.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/ovs-atomic.h b/lib/ovs-atomic.h
index b38c9ef..f5459d6 100644
--- a/lib/ovs-atomic.h
+++ b/lib/ovs-ato
This patch adds the modifications needed to compile under x64 under
Windows:
- created a new macro for testing if we are compiling under x64.
this will define the linker flag: "/MACHINE:X64" as per documentation
(https://msdn.microsoft.com/en-us/library/9yb4317s.aspx).
- added x64 pthread librarie
This patch includes dirs.h because ovs_rundir is used.
Found while compiling with MSVC x64.
Signed-off-by: Alin Gabriel Serdean
---
lib/daemon-windows.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/daemon-windows.c b/lib/daemon-windows.c
index 04e1f1a..696ec1c 100644
--- a/lib/daemon
Windows does not support VXLAN hardware offloading.
Currently we do not compute IP/TCP/UDP checksums for the inner packet. This
patch computes the checksums mentioned above in regards with the enabled
settings.
i.e. if IP checksum offloading is enabled for the inner packet we compute it.
The same
This patch adds the file DpInternal.h to the ovsetx.sln.
Signed-off-by: Alin Gabriel Serdean
---
This patch is meant for branch-2.4 as well
---
datapath-windows/ovsext/ovsext.vcxproj | 1 +
1 file changed, 1 insertion(+)
diff --git a/datapath-windows/ovsext/ovsext.vcxproj
b/datapath-windows/ov
Currently in the case of IP fragmentation we send to the userspace that
the flag for the last fragment is 3 when it actually should be a value
between 0..2.
This patch fixes the problem and also uses the values used in the common
header of the datapath.
Signed-off-by: Alin Gabriel Serdean
---
Th
This patch adds OVS_KEY_ATTR_TCP_FLAGS to our flow mechanism.
Also clean unecesarry parts of code.
Signed-off-by: Alin Gabriel Serdean
---
This patch is intended for branch-2.4 as well
---
datapath-windows/ovsext/DpInternal.h | 9 +---
datapath-windows/ovsext/Flow.c | 40
Commit ID:7845b70384d75bd7d753648cb547be5c6c75ddca changed the hardcoded
names of 'internal' and 'external.1'.
This patch updates the documentation to accomodate the patches.
Signed-off-by: Alin Gabriel Serdean
---
This patch is intended for branch-2.4 as well
---
INSTALL.Windows.md | 71 ++
I added my comments inlined.
> -Mesaj original-
> De la: Nithin Raju [mailto:nit...@vmware.com]
> Trimis: Wednesday, September 23, 2015 9:05 AM
> Către: Jesse Gross
> Cc: Alin Serdean ; Ben Pfaff
> ; dev@openvswitch.org
> Subiect: Re: [ovs-dev] [PATCH v4] dat
I could not get the patch to apply. You will probably need to rebase.
Other comments inline.
Alin.
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju
> Trimis: Tuesday, September 15, 2015 9:52 PM
> Către: dev@openvswitch.org
> Subiect: [ovs-dev] [P
Acked-by: Alin Gabriel Serdean
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju
> Trimis: Tuesday, September 15, 2015 9:52 PM
> Către: dev@openvswitch.org
> Subiect: [ovs-dev] [PATCH 2/4] datapath-windows: reset the IRP pointer
> after use in Ovs
You could probably use NlFillNlHdr to prepare the netlink message.
Shouldn't this be apply to OVS_IOCTL_READ also?
Alin.
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju
> Trimis: Tuesday, September 15, 2015 9:52 PM
> Către: dev@openvswitch.org
>
Looks good to me just two small things:
When poll_wevent_wait finishes could you use GetOverlappedResult to see if
there were no error codes.
The function pend_io_request could be Boolean; we do not take into acquire
other values.
Alin.
> -Mesaj original-
> De la: dev [mailto:dev-boun..
You are right Guru.
_M_IX86 is not defined in the case of x64 processors.
This patch can be dropped.
Alin
> -Mesaj original-
> De la: Gurucharan Shetty [mailto:shet...@nicira.com]
> Trimis: Wednesday, September 23, 2015 5:56 PM
> Către: Alin Serdean
> Cc: dev@openvswitc
Thanks!
> -Mesaj original-
> De la: Gurucharan Shetty [mailto:shet...@nicira.com]
> Trimis: Wednesday, September 23, 2015 6:04 PM
> Către: Alin Serdean
> Cc: dev@openvswitch.org
> Subiect: Re: [ovs-dev] [PATCH 5/7] Include headers where ovs_rundir is used
>
> On
Către: Alin Serdean
> Cc: dev@openvswitch.org
> Subiect: Re: [ovs-dev] [PATCH 6/7] Remove build assert
>
> On Tue, Sep 22, 2015 at 12:53 PM, Alin Serdean
> wrote:
> > We will support x64 bit compiling making this build assert outdated.
> >
> > Signed-off-by: A
I'll respin the patch.
Alin.
> -Mesaj original-
> De la: Gurucharan Shetty [mailto:shet...@nicira.com]
> Trimis: Wednesday, September 23, 2015 6:54 PM
> Către: Alin Serdean
> Cc: dev@openvswitch.org
> Subiect: Re: [ovs-dev] [PATCH 7/7] Add build system for com
This patch adds the modifications needed to compile under x64 under
Windows:
- created a new macro for testing if we are compiling under x64.
this will define the linker flag: "/MACHINE:X64" as per documentation
(https://msdn.microsoft.com/en-us/library/9yb4317s.aspx).
- added x64 pthread librarie
Ifdef out nl_sock_fd to make users aware it is not used.
Signed-off-by: Alin Gabriel Serdean
---
lib/netlink-socket.c | 7 ++-
lib/netlink-socket.h | 2 ++
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/lib/netlink-socket.c b/lib/netlink-socket.c
index 42eb232..f30142f 100644
Still can't get it to apply:
error: patch failed: datapath-windows/ovsext/Datapath.c:1593
error: datapath-windows/ovsext/Datapath.c: patch does not apply
Maybe my git is acting up.
Acked-by: Alin Gabriel Serdean
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În num
Acked-by: Alin Gabriel Serdean
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju
> Trimis: Wednesday, September 23, 2015 7:16 PM
> Către: dev@openvswitch.org
> Subiect: [ovs-dev] [PATCH 3/4 v2] datapath-windows: return netlink error for
> read oper
Thanks for the review.
Comments inline.
Alin.
> -Mesaj original-
> De la: Sairam Venugopal [mailto:vsai...@vmware.com]
> Trimis: Saturday, September 26, 2015 12:24 AM
> Către: Alin Serdean ;
> dev@openvswitch.org
> Subiect: Re: [ovs-dev] [PATCH v2] datapath-windows:
ra.com]
> Trimis: Tuesday, September 29, 2015 7:42 AM
> Către: Gurucharan Shetty
> Cc: Alin Serdean ;
> dev@openvswitch.org
> Subiect: Re: [ovs-dev] [PATCH v2 7/7] Add build system for compiling under
> MSVC x64
>
> On Mon, Sep 28, 2015 at 08:18:54AM -0700, Gurucharan Shetty wrot
Ty!
> -Mesaj original-
> De la: Gurucharan Shetty [mailto:shet...@nicira.com]
> Trimis: Tuesday, September 29, 2015 9:19 PM
> Către: Ben Pfaff
> Cc: Alin Serdean ;
> dev@openvswitch.org
> Subiect: Re: [ovs-dev] [PATCH v2 7/7] Add build system for compiling under
>
I am trying to find the root cause also Guru, it seems that someone is passing
an invalid handle.
Alin.
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Gurucharan
> Shetty
> Trimis: Wednesday, September 30, 2015 12:40 AM
> Către: Ben Pfaff
> Cc: Ilya Maxim
I think there is much more behind the scenes.
Alin.
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Ben Pfaff
> Trimis: Wednesday, September 30, 2015 1:26 AM
> Către: Gurucharan Shetty
> Cc: Ilya Maximets ; dev
> ; Dyasly Sergey
> Subiect: Re: [ovs-dev] [P
gt; De la: Gurucharan Shetty [mailto:shet...@nicira.com]
> Trimis: Wednesday, September 30, 2015 2:34 AM
> Către: Alin Serdean
> Cc: Ben Pfaff ; Ilya Maximets ;
> dev ; Dyasly Sergey
> Subiect: Re: [ovs-dev] [PATCH] poll-loop: fix assertion in poll_create_node
>
> Alin,
> R
1
Into two:
node->pollfd.fd == fd under *UNIX
node->wevent == wevent under MSVC.
I think we need a dedicated flag when we want to skip a given fd.
Alin.
> -Mesaj original-
> De la: Gurucharan Shetty [mailto:shet...@nicira.com]
> Trimis: Wednesday, September 30, 2015 5:24 AM
Commit ID:7845b70384d75bd7d753648cb547be5c6c75ddca changed the hardcoded
names of 'internal' and 'external.1'.
This patch updates the documentation to accomodate the patches.
Signed-off-by: Alin Gabriel Serdean
Acked-by: Sorin Vinturis
Acked-by: Nithin Raju
Acked-by: Sairam Venugopal
---
v2:
Currently in the case of IP fragmentation we send to the userspace that
the flag for the last fragment is 3 when it actually should be a value
between 0..2.
This patch fixes the problem and also uses the values used in the common
header of the datapath.
Signed-off-by: Alin Gabriel Serdean
Acked-
This patch adds the file DpInternal.h to the ovsetx.sln.
Signed-off-by: Alin Gabriel Serdean
Acked-by: Nithin Raju
Acked-by: Sairam Venugopal
---
v2: Add Acked-by's
This patch is meant for branch-2.4 as well
---
datapath-windows/ovsext/ovsext.vcxproj | 1 +
1 file changed, 1 insertion(+)
diff
Windows does not support VXLAN hardware offloading.
Currently we do not compute IP/TCP/UDP checksums for the inner packet. This
patch computes the checksums mentioned above in regards with the enabled
settings.
i.e. if IP checksum offloading is enabled for the inner packet we compute it.
The same
> > >
> > > The patches I've seen from the Hyper-V developers so far are just in
> > > Hyper-V specific code, that can't really affect the stability of the
> > > rest of the platform. I have questions about the value of doing
> > > this on 2.4, given that 2.5 will branch in a reasonable amount of
saj original-
> De la: Gurucharan Shetty [mailto:shet...@nicira.com]
> Trimis: Thursday, October 1, 2015 12:19 AM
> Către: dev@openvswitch.org
> Cc: Alin Serdean ; Gurucharan Shetty
>
> Subiect: [PATCH] poll-loop: Fix a bug while finding a poll node.
>
> When a poll_node i
This reverts commit a26b2023ce33fed1ef962012dc2c03765d2e92cb.
This patch punishes performance without the implementation of
megaflows on Windows.
Once megaflows is implemented in the flow logic this patch will be
revisited.
Signed-off-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/DpInte
Report invalid parameter to the userspace if the user tries to add a vport
tunnel type which is not supported by the kernel extension.
Signed-off-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/Vport.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/datapath-windows/ov
Acked-by: Alin Gabriel Serdean
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju
> Trimis: Wednesday, November 18, 2015 6:14 PM
> Către: dev@openvswitch.org
> Subiect: [ovs-dev] [PATCH 1/6 v2] datapath-windows: refactor port
> enumeration code
>
>
Acked-by: Alin Gabriel Serdean
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju
> Trimis: Wednesday, November 18, 2015 6:14 PM
> Către: dev@openvswitch.org
> Subiect: [ovs-dev] [PATCH 3/6 v2] datapath-windows: cleanup events code
>
> Turns out th
Acked-by: Alin Gabriel Serdean
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju
> Trimis: Wednesday, November 18, 2015 6:14 PM
> Către: dev@openvswitch.org
> Subiect: [ovs-dev] [PATCH 6/6 v2] datapath-windows: Fix HvUpdateNic() to
> handle name ch
Acked-by: Alin Gabriel Serdean
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju
> Trimis: Wednesday, November 18, 2015 6:14 PM
> Către: dev@openvswitch.org
> Subiect: [ovs-dev] [PATCH 4/6 v2] datapath-windows: nuke port # argument
> in IP helper
>
Acked-by: Alin Gabriel Serdean
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju
> Trimis: Wednesday, November 18, 2015 6:14 PM
> Către: dev@openvswitch.org
> Subiect: [ovs-dev] [PATCH 5/6 v2] datapath-windows: cleanup
> AssignNicNameSpecial()
>
>
Acked-by: Alin Gabriel Serdean
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju
> Trimis: Wednesday, November 18, 2015 6:14 PM
> Către: dev@openvswitch.org
> Subiect: [ovs-dev] [PATCH 2/6 v2] datapath-windows: cleanup
> InitHvVportCommon()
>
> Th
This patch adds the sequence tunneling information which will be needed for
GRE tunneling.
Signed-off-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/Flow.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/datapath-windows/ovsext/Flow.h b/datapath-windows/ovsext/Flow.h
index 74b9dfb..0d4
This patch introduces the support for GRE TEB (trasparent ethernet bridging)
for the windows datapath.
The GRE support is based on http://tools.ietf.org/html/rfc2890 and supports
only the GRE protocol type 6558 (trasparent ethernet bridging) like its linux
counterpart.
Util.h: define the GRE pool
Remove double include for Flow.h and sort the includes alphabetically.
Also remove tabs.
Found by inspection.
Signed-off-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/Stt.c | 44 +--
1 file changed, 22 insertions(+), 22 deletions(-)
diff --git a/d
This patch introduces the support for GRE TEB (trasparent ethernet bridging)
for the windows datapath.
The GRE support is based on http://tools.ietf.org/html/rfc2890 and supports
only the GRE protocol type 6558 (trasparent ethernet bridging) like its linux
counterpart.
Util.h: define the GRE pool
Currently when building the windows datapath from the command line we specify
the type (Release or Debug), which will build both versions (Win 8 and Win 8.1)
of that type. This made a strict requirement of WDK 8.1.
This patch allows the user to specify a specific version and type of the
datapath w
Fix broken compilation in Debug/Release versions introduced by commit 4ac0645.
Signed-off-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/Actions.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/datapath-windows/ovsext/Actions.c
b/datapath-windows/ovsext/Actions.c
inde
Thanks for the review Nithin trimming the reply a bit so we have more
visibility.
Regarding the sequence number, I was keeping in mind GRE64 supported by OVS but
that is deprecated now so we can remove it.
> >+RtlZeroMemory(grePort, sizeof(*grePort));
> >+grePort->dstPort = udpDestPort
Acked-by: Alin Gabriel Serdean
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju
> Trimis: Thursday, December 10, 2015 3:35 AM
> Către: Sairam Venugopal ; dev@openvswitch.org
> Subiect: Re: [ovs-dev] [PATCH] datapath-windows: Fix compilation issue
Oops. I did not saw patch: https://patchwork.ozlabs.org/patch/554961/.
This patch can be dropped.
> -Mesaj original-
> De la: Alin Serdean
> Trimis: Thursday, December 10, 2015 6:03 PM
> Către: dev@openvswitch.org
> Cc: Alessandro Pilotti ; Alin Serdean
>
> Subi
Acked-by: Alin Gabriel Serdean
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sairam
> Venugopal
> Trimis: Tuesday, December 8, 2015 9:06 PM
> Către: Nithin Raju ; dev@openvswitch.org
> Subiect: Re: [ovs-dev] [PATCH] datapath-windows: reduce padding size i
Acked-by: Alin Gabriel Serdean
Thanks,
Alin.
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju
> Trimis: Thursday, December 10, 2015 9:17 PM
> Către: dev@openvswitch.org
> Subiect: [ovs-dev] [PATCH] datapath-windows: remove ASSERT in
> OvsDoFlowLo
Patch 43000bc introduced a portability improvement.
This patch adds the command for $SED 's' and also changes to x86 for 32 bit
instead of x64.
Signed-off-by: Alin Gabriel Serdean
---
m4/openvswitch.m4 | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/m4/openvswitch.m4 b/m
Remove double include for Flow.h and sort the includes alphabetically.
Also remove tabs.
Found by inspection.
Signed-off-by: Alin Gabriel Serdean
Acked-by: Nithin Raju
Acked-by: Sairam Venugopal
Acked-by: Sorin Vinturis
---
v2: Add Acked-by's
---
datapath-windows/ovsext/Stt.c | 44 ++
Thanks for the review Sorin.
I will incorporate your comments in v3.
> -Mesaj original-
> De la: Sorin Vinturis
> Trimis: Thursday, December 3, 2015 11:44 AM
> Către: Alin Serdean ;
> dev@openvswitch.org
> Subiect: RE: [PATCH 3/3 v2] datapath-windows: Add GRE TEB sup
ecember 2, 2015 10:25 PM
> Către: Alin Serdean ;
> dev@openvswitch.org
> Subiect: Re: [ovs-dev] [PATCH 3/3] datapath-windows: Add GRE TEB support
> for windows datapath
>
> Thanks for the patch Alin. I had very minor comments that I have added
> inline. Looks good otherwise.
>
This patch introduces the support for GRE TEB (trasparent ethernet bridging)
for the windows datapath.
The GRE support is based on http://tools.ietf.org/html/rfc2890 and supports
only the GRE protocol type 6558 (trasparent ethernet bridging) like its linux
counterpart.
Util.h: define the GRE pool
This patch adds LSO version 2 support for the windows datapath.
(https://msdn.microsoft.com/en-us/library/windows/hardware/ff568840%28v=vs.85%29.aspx)
Tested using psping and iperf3.
Signed-off-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/Vxlan.c | 19 ---
1 file changed
This patch removes unused variables defined in stt and vxlan ports.
Signed-off-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/Stt.h | 5 -
datapath-windows/ovsext/Vxlan.h | 4
2 files changed, 9 deletions(-)
diff --git a/datapath-windows/ovsext/Stt.h b/datapath-windows/ovsext/S
:51 PM
> Către: Alin Serdean ;
> dev@openvswitch.org
> Subiect: Re: [ovs-dev] [PATCH v3] datapath-windows: Add GRE TEB support
> for windows datapath
>
> Alin,
> The only quip I have is the claim that we support RFC 2890 in the commit
> message. I went throught RFC 2890. It
This patch introduces the support for GRE TEB (trasparent ethernet bridging)
for the windows datapath.
The GRE support is based on http://tools.ietf.org/html/rfc2890, without
taking into account the GRE sequence, and it supports only the GRE protocol
type 6558 (trasparent ethernet bridging) like i
Allow STT encapsulation to take place in the case we have a TCP payload
without LSO.
Signed-off-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/Stt.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/datapath-windows/ovsext/Stt.c b/datapath-windows/ovsext/Stt.c
index dc2910f..fc9d7e5 10064
It would be awesome to apply it on 2.5 as well.
I will update the matrix once it is applied.
Thanks,
Alin.
> -Mesaj original-
> De la: Justin Pettit [mailto:jpet...@ovn.org]
> Trimis: Friday, December 11, 2015 10:33 PM
> Către: Alin Serdean
> Cc: dev@openvswitch.org
>
+1
> -Mesaj original-
> De la: Justin Pettit [mailto:jpet...@ovn.org]
> Trimis: Friday, December 11, 2015 11:32 PM
> Către: Nithin Raju
> Cc: Alin Serdean ;
> dev@openvswitch.org
> Subiect: Re: [ovs-dev] [PATCH v4] datapath-windows: Add GRE TEB support
> for windo
Ty!
> -Mesaj original-
> De la: Justin Pettit [mailto:jpet...@ovn.org]
> Trimis: Friday, December 11, 2015 11:49 PM
> Către: Alin Serdean
> Cc: Nithin Raju ; dev@openvswitch.org
> Subiect: Re: [ovs-dev] [PATCH v4] datapath-windows: Add GRE TEB support
> for windows d
Allow GRE encapsulation to take place in the case we have a TCP payload
without LSO.
Signed-off-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/Gre.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/datapath-windows/ovsext/Gre.c b/datapath-windows/ovsext/Gre.c
index 3ebfda3..5abd4a4 10064
This patch adds LSO version 2 support for the windows datapath.
(https://msdn.microsoft.com/en-us/library/windows/hardware/ff568840%28v=vs.85%29.aspx)
Tested using psping and iperf3.
Signed-off-by: Alin Gabriel Serdean
---
v2: Allow VXLAN encapsulation to take place if no LSO is available
---
d
@openvswitch.org; Alessandro Pilotti; Alin Serdean;
Saurabh Shah
Subject: Re: [ovs-dev] Windows port status
On Tue, Nov 19, 2013 at 8:37 AM, Ben Pfaff wrote:
> On Tue, Nov 19, 2013 at 12:22:40PM +, Alessandro Pilotti wrote:
>> The freshly released Visual Studio 2013 is the minimum supported
>&
One can only hope :).
Kind Regards,
Alin.
From: Saurabh Shah [ssaur...@vmware.com]
Sent: Tuesday, November 19, 2013 8:19 PM
To: Alin Serdean; Gurucharan Shetty; Ben Pfaff
Cc: dev@openvswitch.org; Saurabh Shah; Gurucharan Shetty
Subject: Re: [ovs-dev
Bellow the whole patch required for the PRI_ZU macro:
diff --git a/CodingStyle b/CodingStyle
index 2f24ee3..a9417de 100644
--- a/CodingStyle
+++ b/CodingStyle
@@ -394,7 +394,7 @@ from .
integer types. Use the PRId, PRIu, and PRIx macros from
for formatting them with printf() and related functi
le)
2. We define a header that is included in every source file
3. We define a wrapper over the (like the ./lib/string.h) and
whenever they want to use the PRIuSIZE macro they have to include in
.
Kind Regards,
Alin.
From: Ben Pfaff [b...@nicir
> That reads like a non sequitur, I don't see how it responds to my
> comments.
My problem is where to insert the macro exactly.
Alin.
From: Ben Pfaff [b...@nicira.com]
Sent: Saturday, November 23, 2013 2:04 AM
To: Alin Serdean
Cc: Alessandro P
As you wish.
Alin.
From: Ben Pfaff [b...@nicira.com]
Sent: Saturday, November 23, 2013 4:27 AM
To: Alin Serdean
Cc: Alessandro Pilotti; dev@openvswitch.org
Subject: Re: [ovs-dev] Windows port status
On Sat, Nov 23, 2013 at 12:23:41AM +, Alin Serdean
Hey,
Bellow is the patch for the %z modifier.
Please take a closer look over the Makefile and comments (I hope they are
inline with your previous ones :) ).
diff --git a/CodingStyle b/CodingStyle
index 2f24ee3..1597302 100644
--- a/CodingStyle
+++ b/CodingStyle
@@ -394,7 +394,7 @@ from .
inte
Sure :).
Signed-off-by: Alin Serdean
---
CodingStyle |2 +-
Makefile.am | 13
lib/bundle.c |4 +-
lib/coverage.c|2 +-
lib/hmap.c|2 +-
lib/multipath.c |2
Hey,
Continuing patches for the windows build.
The next problem that we are facing is that the include_next directive is
missing from the VStudio compiler.
The affected files will be:
include/linux/types.h
#include
#ifndef _WIN32
#include_next
#endif
lib/string.h
#ifdef _WIN32
#include <../
Hey,
Sorry to barge in again but another problem that we are facing while trying to
use the autoconf/msys solution is the following:
make all-recursive
make[1]: Entering directory `/home/aserdean/2_12_2013/openvswitch'
Making all in datapath
make[2]: Entering directory `/home/aserdean/2_12_2013/
Super. I will give it another go tomorrow :).
Thanks Gurucharan.
Kind Regards,
Alin.
From: Gurucharan Shetty [shet...@nicira.com]
Sent: Tuesday, December 03, 2013 1:05 AM
To: Alin Serdean
Cc: Ben Pfaff; Alessandro Pilotti; dev@openvswitch.org
Subject: Re
Shetty [shet...@nicira.com]
Sent: Tuesday, December 03, 2013 8:29 PM
To: Alin Serdean
Cc: Ben Pfaff; dev@openvswitch.org
Subject: Re: [ovs-dev] Windows port status
On Mon, Dec 2, 2013 at 2:20 PM, Alin Serdean
wrote:
> Hey,
>
> Continuing patches for the windows build.
>
> The ne
...@openvswitch.org] on behalf of
Alin Serdean [aserd...@cloudbasesolutions.com]
Sent: Tuesday, December 03, 2013 1:32 AM
To: Gurucharan Shetty
Cc: dev@openvswitch.org
Subject: Re: [ovs-dev] Autoconf limits on Windows
Super. I will give it another go tomorrow :).
Thanks Gurucharan.
Kind Regards,
Alin
+#else
#include_next
+#endif
/* Glibc 2.7 has a bug in strtok_r when compiling with optimization that can
* cause segfaults if the delimiters argument is a compile-time constant that
This will solve the include_next from the lib folder.
Kind Regards,
Alin.
From: Alin S
Signed-off-by: Alin Serdean
---
lib/string.h |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/lib/string.h b/lib/string.h
index 2b7b454..6981742 100644
--- a/lib/string.h
+++ b/lib/string.h
@@ -17,7 +17,11 @@
#ifndef STRING_WRAPPER_H
#define STRING_WRAPPER_H 1
I think we should use _WIN32 (it is predefined for both Win32 and Win64) :).
http://msdn.microsoft.com/en-us/library/b0084kay.aspx
Kind Regards,
Alin.
From: Gurucharan Shetty [shet...@nicira.com]
Sent: Friday, December 06, 2013 9:47 PM
To: Alin Serdean
Cc
10:54 PM
To: Alin Serdean
Cc: Gurucharan Shetty; Alessandro Pilotti; dev@openvswitch.org
Subject: Re: [PATCH] lib: Bypass include_next preprocessor directives on
Windows platform
On Fri, Dec 06, 2013 at 12:51:25PM -0800, Ben Pfaff wrote:
> On Fri, Dec 06, 2013 at 07:35:45PM +0000, Alin Serd
Hey,
After the include_next from string.h(wrapper) will be solved we will be faced
with another scenario.
Unfortunately on MSVC we don't have inline we have __inline(see
http://msdn.microsoft.com/en-us/library/cx3b23a3.aspx for more information) so
it is either autoconf magic again :-) or an i
Hey,
The following is a quick patch for secure pseudorandom number generator on
windows. I split the functionality with a brutal ifdef macro. Feedback on the
code and suggestions for a nicer implementation is appreciated :).
diff --git a/lib/entropy.c b/lib/entropy.c
index 02f56e0..ec9d95c 100
I applied the patches and everything seems in order.
The same remark about adding string.h to lib/.gitignore
Thanks,
Alin.
From: dev-boun...@openvswitch.org [dev-boun...@openvswitch.org] on behalf of
Gurucharan Shetty [shet...@nicira.com]
Sent: Thursday,
Saurabh Shah [ssaur...@vmware.com]
Sent: Wednesday, December 11, 2013 9:53 PM
To: Alin Serdean; b...@nicira.com; shet...@nicira.com
Cc: dev@openvswitch.org
Subject: Re: [ovs-dev] [Windows thread 3]
Hey,
The following is a quick patch for secure pseudorandom number generator on
windows. I spl
[shet...@nicira.com]
Sent: Wednesday, December 11, 2013 8:27 PM
To: Alin Serdean
Cc: Ben Pfaff; dev@openvswitch.org
Subject: Re: [ovs-dev] [Windows thread 2]
On Wed, Dec 11, 2013 at 9:43 AM, Alin Serdean
wrote:
> Hey,
>
> After the include_next from string.h(wrapper) will be solved we will
.
From: Saurabh Shah [ssaur...@vmware.com]
Sent: Friday, December 13, 2013 2:41 AM
To: Alin Serdean; b...@nicira.com; shet...@nicira.com
Cc: dev@openvswitch.org
Subject: Re: [ovs-dev] [Windows thread 3]
Looks good to me. Just one minor comment. You probably also want to include the
13 8:40 PM
To: Alin Serdean
Cc: Ben Pfaff; dev@openvswitch.org
Subject: Re: [ovs-dev] [Windows thread 2]
Would you mind sending in a proper patch which includes your changes
added to the mentioned patch for a review with a commit message and
rationale. (The reviewers usually do a "git am '
This patch is to add for secure pseudorandom number generator on windows.
Signed-off-by: Alin Serdean
---
lib/entropy.c | 13 +
1 files changed, 13 insertions(+), 0 deletions(-)
---
diff --git a/lib/entropy.c b/lib/entropy.c
index 02f56e0..45e83ec 100644
--- a/lib/entropy.c
+++ b
___
From: Ben Pfaff [b...@nicira.com]
Sent: Saturday, December 14, 2013 7:22 PM
To: Alin Serdean
Cc: Gurucharan Shetty; dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH] windows pseudorandom number generator
On Sat, Dec 14, 2013 at 01:20:31AM +, Alin Serdean wr
>> +//Disable warnings and runtime checks
>> +#pragma warning( disable : 4116 4090 4700 4005 4133 4028 4098 4293 4715
>> 4047)
>> +#pragma runtime_checks( "", off )
>> +#pragma warning( disable : 4996 ) //deprecated functions
>> +#pragma warning( disable : 4244 ) //possible loss of data
>> +#pragm
I added also syslog.h as you suggested(this will help us in the future patches).
Regarding the warnings I will send a detailed list iwth their corespondence in
another mail and we can discuss further if we want to add them or not.
I hope everything is in order now :).
Signed-off-by: Alin
701 - 799 of 799 matches
Mail list logo
