Allow the port to be updated if it the type is only:
NdisSwitchPortTypeSynthetic
Signed-off-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/Vport.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/datapath-windows/ovsext/Vport.c b/datapath-windows/ovsext/Vport.c
index
Acked-by: Alin Gabriel Serdean
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sorin Vinturis
Trimis: Wednesday, March 25, 2015 10:14 PM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [PATCH 10/11] datapath-windows: Added specific pool tag for
user code
All m
Acked-by: Alin Gabriel Serdean
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sorin Vinturis
Trimis: Wednesday, March 25, 2015 10:14 PM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [PATCH 11/11] datapath-windows: Added specific pool tag for
vport code
All
Acked-by: Alin Gabriel Serdean
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sorin Vinturis
Trimis: Wednesday, March 25, 2015 10:14 PM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [PATCH 08/11] datapath-windows: Added specific pool tag for
oid code
All me
Acked-by: Alin Gabriel Serdean
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sorin Vinturis
Trimis: Wednesday, March 25, 2015 10:14 PM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [PATCH 09/11] datapath-windows: Added specific pool tag for
switch code
All
Acked-by: Alin Gabriel Serdean
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sorin Vinturis
Trimis: Wednesday, March 25, 2015 10:14 PM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [PATCH 07/11] datapath-windows: Added specific pool tag for
iphelper code
A
Acked-by: Alin Gabriel Serdean
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sorin Vinturis
Trimis: Wednesday, March 25, 2015 10:14 PM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [PATCH 06/11] datapath-windows: Added specific pool tag for
vxlan code
All
Acked-by: Alin Gabriel Serdean
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sorin Vinturis
Trimis: Wednesday, March 25, 2015 10:14 PM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [PATCH 04/11] datapath-windows: Added specific pool tag for
event code
All
Acked-by: Alin Gabriel Serdean
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sorin Vinturis
Trimis: Wednesday, March 25, 2015 10:14 PM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [PATCH 05/11] datapath-windows: Added specific pool tag for
flow code
All m
Acked-by: Alin Gabriel Serdean
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sorin Vinturis
Trimis: Wednesday, March 25, 2015 10:14 PM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [PATCH 02/11] datapath-windows: Added specific pool tag for
datapath code
A
Acked-by: Alin Gabriel Serdean
It would be nice if we have somewhere in the documentation(i.e.
INSTALL.Windows.md) which pool is which.
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sorin Vinturis
Trimis: Wednesday, March 25, 2015 10:14 PM
Către: dev@openvs
This patch changes the behaviour in case the configure argument: --with-debug
was specified.
Currently the optimization flag in the case of debugging is the following:
https://msdn.microsoft.com/en-us/library/f9534wye.aspx
which does not fully disable optimization, that is why it was changed with
This patch changes the behaviour in case the configure argument: --with-debug
was specified.
Currently the optimization flag in the case of debugging is the following:
https://msdn.microsoft.com/en-us/library/f9534wye.aspx
which does not fully disable optimization, that is why it was changed with
Currently paths that have only forward slashes like the following
"C:/package/binaries/conf.db" work seamlessly.
If we try the native windows filepaths i.e. "C:\package\binaries\conf.db" we
will hit the following problem:
2015-03-31T15:54:17Z|1|lockfile|WARN|.c:\package\binaries\conf.db.~lock~
Currently paths that have only forward slashes like the following
"C:/package/binaries/conf.db" work seamlessly.
If we try the native windows filepaths i.e. "C:\package\binaries\conf.db" we
will hit the following problem:
2015-03-31T15:54:17Z|1|lockfile|WARN|.c:\package\binaries\conf.db.~lock~
Just a small nit, indentation issue:
+static NTSTATUS OvsGetPidHandler(POVS_USER_PARAMS_CONTEXT usrParamsCtx,
+UINT32 *replyLen);
Acked-by: Alin Gabriel Serdean
Tested-by: Alin Gabriel Serdean
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitc
Release switchContext->dispatchLock in case the vport has bot been found.
v2: Modify commit message and add Acked-by lines.
Acked-by: Eitan Eliahu
Acked-by: Sorin Vinturis
Signed-off-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/Vport.c | 1 +
1 file changed, 1 insertion(+)
diff --git
Allow the port to be updated if it the type is only:
NdisSwitchPortTypeSynthetic
v2: Add Acked-by lines.
Acked-by: Nithin Raju
Acked-by: Eitan Eliahu
Acked-by: Sorin Vinturis
Signed-off-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/Vport.c | 4 ++--
1 file changed, 2 insertions(+), 2
In nl_sock_transact_multiple__ we do the following:
if (!DeviceIoControl(sock->handle, OVS_IOCTL_TRANSACT,
txn->request->data,
txn->request->size,
reply_buf, sizeof reply_buf,
&reply
Add testsuite.tmp.orig to .gitignore
Signed-off-by: Alin Gabriel Serdean
---
.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/.gitignore b/.gitignore
index e37a690..8f0d41f 100644
--- a/.gitignore
+++ b/.gitignore
@@ -66,3 +66,4 @@ _debian
odp-netlink.h
OvsDpInterface.h
/.vagran
This commit is a POC on how to build the installer from the command line.
One could issue the following commands to build the binaries, driver and
installer.
./boot.sh;./configure CC=./build-aux/cccl LD="`which link`" LIBS="-lws2_32" \
--prefix="C:/openvswitch/usr" --localstatedir="C:/openvswit
: Gurucharan Shetty [mailto:shet...@nicira.com]
Trimis: Thursday, April 23, 2015 4:33 AM
Către: Alin Serdean
Cc: dev@openvswitch.org
Subiect: Re: [ovs-dev] [PATCH 1/3] Windows installer
On Mon, Apr 20, 2015 at 11:58 AM, Alin Serdean
wrote:
> This commit adds the windows installer to the OVS t
Add testsuite.tmp.orig to .gitignore
Signed-off-by: Alin Gabriel Serdean
---
.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/.gitignore b/.gitignore
index e37a690..8f0d41f 100644
--- a/.gitignore
+++ b/.gitignore
@@ -66,3 +66,4 @@ _debian
odp-netlink.h
OvsDpInterface.h
/.vagran
This commit is a POC on how to build the installer from the command line.
One could issue the following commands to build the binaries, driver and
installer.
./boot.sh;./configure CC=./build-aux/cccl LD="`which link`" LIBS="-lws2_32" \
--prefix="C:/openvswitch/usr" --localstatedir="C:/openvswit
This commit is a POC on how to build the installer from the command line.
One could issue the following commands to build the binaries, driver and
installer.
./boot.sh;./configure CC=./build-aux/cccl LD="`which link`" LIBS="-lws2_32" \
--prefix="C:/openvswitch/usr" --localstatedir="C:/openvswit
Add testsuite.tmp.orig to .gitignore
Signed-off-by: Alin Gabriel Serdean
---
v3: Respin
v2: Respin
.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/.gitignore b/.gitignore
index e37a690..8f0d41f 100644
--- a/.gitignore
+++ b/.gitignore
@@ -66,3 +66,4 @@ _debian
odp-netlink.h
OvsD
Change the documentation for the possible vaues of WDK.
Signed-off-by: Alin Gabriel Serdean
---
INSTALL.Windows.md | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/INSTALL.Windows.md b/INSTALL.Windows.md
index 78af0a1..2402b5c 100644
--- a/INSTALL.Windows.md
+++ b/INSTALL.Wind
Add testsuite.tmp.orig to .gitignore
Signed-off-by: Alin Gabriel Serdean
---
v3: Respin
v2: Respin
.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/.gitignore b/.gitignore
index e37a690..8f0d41f 100644
--- a/.gitignore
+++ b/.gitignore
@@ -66,3 +66,4 @@ _debian
odp-netlink.h
OvsD
This commit is a POC on how to build the installer from the command line.
One could issue the following commands to build the binaries, driver and
installer.
./boot.sh;./configure CC=./build-aux/cccl LD="`which link`" LIBS="-lws2_32" \
--prefix="C:/openvswitch/usr" --localstatedir="C:/openvswit
Change the documentation for the possible vaues of WDK.
Signed-off-by: Alin Gabriel Serdean
---
INSTALL.Windows.md | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/INSTALL.Windows.md b/INSTALL.Windows.md
index 78af0a1..2402b5c 100644
--- a/INSTALL.Windows.md
+++ b/INSTALL.Wind
This commit is a POC on how to build the installer from the command line.
One could issue the following commands to build the binaries, driver and
installer.
./boot.sh;./configure CC=./build-aux/cccl LD="`which link`" LIBS="-lws2_32" \
--prefix="C:/openvswitch/usr" --localstatedir="C:/openvswit
Add testsuite.tmp.orig to .gitignore
Signed-off-by: Alin Gabriel Serdean
---
v3: Respin
v2: Respin
.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/.gitignore b/.gitignore
index e37a690..8f0d41f 100644
--- a/.gitignore
+++ b/.gitignore
@@ -66,3 +66,4 @@ _debian
odp-netlink.h
OvsD
Change the documentation for the possible vaues of WDK.
Signed-off-by: Alin Gabriel Serdean
---
INSTALL.Windows.md | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/INSTALL.Windows.md b/INSTALL.Windows.md
index 78af0a1..2402b5c 100644
--- a/INSTALL.Windows.md
+++ b/INSTALL.Wind
No ignore v2/v3. V4 is the latest now.
I will wait for Nithin comments and spin v5 together with the comments you
pointed out also.
Thanks,
Alin.
From: Gurucharan Shetty<mailto:shet...@nicira.com>
Sent: 4/29/2015 11:04 PM
To: Alin Serdean<mai
I will remove the copyright and respin the patches!
Alin.
-Mesaj original-
De la: Gurucharan Shetty [mailto:shet...@nicira.com]
Trimis: Thursday, April 30, 2015 12:34 AM
Către: Alin Serdean
Cc: dev@openvswitch.org
Subiect: Re: [ovs-dev] [PATCH v3 1/4] Windows installer
On Wed, Apr 29
This patch implements two functionalities needed for an active manager:
1. ARP lookup
2. Next hop
The first functionality relies on the internal Windows API:
https://msdn.microsoft.com/en-us/library/windows/desktop/aa365956%28v=vs.85%29.aspx
The second one:
https://msdn.microsoft.com/en-us/librar
This patch fixes the warning when datapath-windows/misc/OVS.psm1 is
imported.
Signed-off-by: Alin Gabriel Serdean
Reported-by: Hemanth Kumar Mantri
Reported-at: https://github.com/openvswitch/ovs-issues/issues/69
---
datapath-windows/misc/OVS.psm1 | 8 +---
1 file changed, 5 insertions(+),
This patch implements two functionalities needed for an active manager:
1. ARP lookup
2. Next hop
The first functionality relies on the internal Windows API:
https://urldefense.proofpoint.com/v2/url?u=https-3A__msdn.microsoft.com_en-2Dus_library_windows_desktop_aa365956-2528v-3Dvs.85-2529.aspx&d=A
This patch implements two functionalities needed for an active manager:
1. ARP lookup
2. Next hop
The first functionality relies on the internal Windows API:
https://urldefense.proofpoint.com/v2/url?u=https-3A__msdn.microsoft.com_en-2Dus_library_windows_desktop_aa365956-2528v-3Dvs.85-2529.aspx&d=A
Will need this patch in the installer :) because I will bundle both of the
drivers.
Acked-by: Alin Gabriel Serdean
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju
Trimis: Tuesday, May 26, 2015 9:20 AM
Către: dev@openvswitch.org
Subiect: [ovs-dev]
Removing a variable which breaks the windows forwarding extension build.
The error:
warning C4189: 'bufContext' : local variable is initialized but not referenced
c:\temp_may\ovs\datapath-windows\ovsext\PacketIO.c
Signed-off-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/PacketIO.c | 1
Sorry but unfortunately I could not get the patch on the ML.
Created the following pull request instead:
https://github.com/openvswitch/ovs/pull/49 .
Thank you,
Alin.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Sure.
Alin.
-Mesaj original-
De la: Gurucharan Shetty [mailto:shet...@nicira.com]
Trimis: Friday, June 5, 2015 9:00 PM
Către: Alin Serdean
Cc: dev@openvswitch.org
Subiect: Re: [ovs-dev] [PATCH] ARP lookup and next hop functionality on windows
On Tue, May 19, 2015 at 10:02 AM, Alin
Sure.
Alin.
-Mesaj original-
De la: Gurucharan Shetty [mailto:shet...@nicira.com]
Trimis: Friday, June 5, 2015 5:57 PM
Către: Alin Serdean
Cc: dev@openvswitch.org; Nithin Raju; Eitan Eliahu
Subiect: Re: [PATCH v6] This commit adds the windows installer to the OVS tree.
Alin,
I do not
Add the library iphlpapi to the appveyor.yml build script.
Signed-off-by: Alin Gabriel Serdean
---
appveyor.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/appveyor.yml b/appveyor.yml
index a14f0fc..863b561 100644
--- a/appveyor.yml
+++ b/appveyor.yml
@@ -39,5 +39,5 @@ bu
I just sent the fix: http://openvswitch.org/pipermail/dev/2015-June/056007.html
.
Sorry for the failing build.
I will repost the pull request after this one is merged.
Thanks,
Alin.
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Alin Serdean
Trimis: Friday
Acked-by: Alin Serdean .
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Gurucharan Shetty
Trimis: Friday, June 5, 2015 10:27 PM
Către: dev@openvswitch.org
Cc: Gurucharan Shetty
Subiect: [ovs-dev] [PATCH] appveyor: Add a newer ssl link.
The older version is no
Rebased and added the sign off:
https://github.com/openvswitch/ovs/pull/50
Alin.
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Alin Serdean
Trimis: Friday, June 5, 2015 9:20 PM
Către: Gurucharan Shetty
Cc: dev@openvswitch.org
Subiect: Re: [ovs-dev] [PATCH v6
Monday, June 8, 2015 12:43 AM
Către: Alin Serdean
Cc: dev@openvswitch.org
Subiect: Re: [PATCH v6] This commit adds the windows installer to the OVS tree.
On Fri, Jun 5, 2015 at 4:23 PM, Alin Serdean
wrote:
> Rebased and added the sign off:
>
> https://github.com/openvswitch/ovs/pull/50
T
Acked-by: Alin Gabriel Serdean
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sorin Vinturis
Trimis: Thursday, May 28, 2015 11:31 PM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [PATCH] datapath-windows: BSOD when disabling the extension
When the filter det
Acked-by: Alin Gabriel Serdean
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sorin Vinturis
Trimis: Thursday, June 18, 2015 4:48 PM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [PATCH] datapath-windows: Return pending for IRPs completed
later
Return STATUS
Acked-by: Alin Gabriel Serdean
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sorin Vinturis
Trimis: Thursday, June 18, 2015 8:48 PM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [PATCH] datapath-windows: Return success for already
existing WFP objects
Ther
I have no issue with it if it is tested.
Yes Nithin you are right we agreed that you will work on it but it was in the
backlog for some time and it is a show stopper because it also
fixes(https://github.com/openvswitch/ovs-issues/issues/62).
Alin.
-Mesaj original-
De la: dev [mailto:de
Delete internal port
Test connectivity
Add internal port
Test connectivity
Delete external port
Test connectivity
Add external port
Test connectivity
Delete internal port
Delete external port
Test connectivity
Add internal port
Test connectivity
Add external port
Test connectivity
Uninstall exte
Acked-by: Alin Gabriel Serdean
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sorin Vinturis
Trimis: Thursday, June 18, 2015 9:37 PM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [PATCH v2] datapath-windows: Return success for already
existing WFP objects
Th
This patch disables features which are not currently supported in the
windows datapath.
Unfortunately we have to do it in userspace because dpif_probe_feature is
not treated accordingly in the windows the datapath.
I opened the issue to track the feature for later implementations:
https://github.
This patch disables features which are not currently supported
in the windows datapath.
Unfortunately we have to do it in userspace because dpif_probe_feature is
not treated accordingly in the windows the datapath.
I opened the issue to track the feature for later implementations:
https://github.
If we have a flow rule in the following form:
actions=strip_vlan,set_tunnel:0x3e9,15,16,17
(Where port 15, 16 and 17 are VXLAN tunnels with different tunnelling
information)
A packet which will hit that specific flow will only be sent out encapsulated
with the first tunnelling information.
This p
Just a personal preference maybe we could drop OvsIpHlprCbVxlan all togheter.
Rest looks fine with me.
Acked-by: Alin Gabriel Serdean
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju
Trimis: Friday, June 19, 2015 7:00 AM
Către: dev@openvswitch.org
S
I would rather leave them the way they are until we fix the actual problem
(disable from userspace, treat the dpif_probe_feature correctly)
Thanks,
Alin.
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju
Trimis: Friday, June 19, 2015 7:02 AM
Către: de
Cool!
Waiting for v3.
Alin.
-Mesaj original-
De la: Nithin Raju [mailto:nit...@vmware.com]
Trimis: Friday, June 19, 2015 7:01 PM
Către: Alin Serdean
Cc: dev@openvswitch.org
Subiect: Re: [ovs-dev] [PATCH v2] datapath-windows: use correct dst port during
Vxlan Tx
> On Jun 19, 2015,
To do it the proper way yes.
I really hate to do it this way but given the timeframe for 2.4 we could nuke
it later on.
Alin.
-Mesaj original-
De la: Nithin Raju [mailto:nit...@vmware.com]
Trimis: Friday, June 19, 2015 7:36 PM
Către: Alin Serdean
Cc: dev@openvswitch.org
Subiect: Re
+1
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju
Trimis: Friday, June 19, 2015 7:13 PM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [PATCH v3] datapath-windows: use correct dst port during
Vxlan Tx
A previous commit used the wrong DST port in the
Hi Nithin,
Thanks for the patch!
I managed to hit the assert again.
Child-SP RetAddr Call Site
d001`7b8db7f0 f801`4446530b nt!RtlAssert+0xeb
d001`7b8dbd50 f801`444620df OVSExt!OvsRemoveAndDeleteVport+0x25b
[c:\temp_june\19_06_2015\ovs\datapath-windows\ovsext\v
Reedited:
Steps to reproduce:
Install extension
*Enable extension on vSwitch
*Run vswitchd
Add internal/external port
*Stop the vswitchd
*Remove the vSwitch.
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Alin Serdean
Trimis: Friday, June 19, 2015 9:55 PM
No worries. Take your time :).
Alin.
-Mesaj original-
De la: Nithin Raju [mailto:nit...@vmware.com]
Trimis: Friday, June 19, 2015 10:01 PM
Către: Alin Serdean
Cc: dev@openvswitch.org
Subiect: Re: [ovs-dev] [PATCH 1/2 v2] datapath-windows: Code refactoring and
fixes in Vport.c
> On
Add
utilities/ovs-sim
utilities/ovs-sim.1
Found by issuing make.
Signed-off-by: Alin Gabriel Serdean
---
utilities/.gitignore | 2 ++
1 file changed, 2 insertions(+)
diff --git a/utilities/.gitignore b/utilities/.gitignore
index dda889b..1d59e28 100644
--- a/utilities/.gitignore
+++ b/utilitie
Yes, I will do it later on today.
I was yesterday on a mini "holiday".
Kind Regards,
Alin.
From: Ben Pfaff [b...@nicira.com]
Sent: Wednesday, December 18, 2013 11:52 PM
To: Alin Serdean
Cc: Saurabh Shah; shet...@nicira.com; dev@openvswitch.org
S
Signed-off-by: Alin Serdean
---
diff --git a/lib/entropy.c b/lib/entropy.c
index 02f56e0..a7dac34 100644
--- a/lib/entropy.c
+++ b/lib/entropy.c
@@ -20,6 +20,9 @@
#include
#include
#include
+#ifdef _WIN32
+#include
+#endif
#include "socket-util.h"
#include "vlog.h&
Signed-off-by: Alin Serdean
---
diff --git a/Makefile.am b/Makefile.am
index 0faed67..558bf63 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -10,6 +10,11 @@ ACLOCAL_AMFLAGS = -I m4
SUBDIRS = datapath
AM_CPPFLAGS = $(SSL_CFLAGS)
+
+if WIN32
+AM_CPPFLAGS += -I $(top_srcdir)/include/windows
: Wednesday, December 18, 2013 7:30 PM
To: Gurucharan Shetty
Cc: Alin Serdean; dev
Subject: Re: [ovs-dev] [PATCH] V2 windefs: common include for MSVC
On Tue, Dec 17, 2013 at 07:49:45AM -0800, Gurucharan Shetty wrote:
> For the files that you add, I think you can add your copyright instead
> of the Nici
Acked-by: Alin Gabriel Serdean
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sorin Vinturis
Trimis: Monday, November 24, 2014 6:26 PM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [PATCH] datapath-windows: Fixed Release broken build
The release configuratio
Removing unused local variable.
Signed-off-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/Flow.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/datapath-windows/ovsext/Flow.c b/datapath-windows/ovsext/Flow.c
index ceac37f..1257377 100644
--- a/datapath-windows/ovsext/Flow.c
+++ b/da
Add an additional check to see if the flowTable is not NULL.
kd> k
Child-SP RetAddr Call Site
d000`26166af8 f802`dde5e7c6 nt!DbgBreakPointWithStatus
d000`26166b00 f802`dde5e0d7 nt!KiBugCheckDebugBreak+0x12
d000`26166b60 f802`51a4 nt!KeBugCheck2+0x8ab
12:10 AM
Către: Alin Serdean
Cc: dev@openvswitch.org
Subiect: Re: [ovs-dev] [PATCH] datapath-windows: Fix BSOD when uninstalling
driver
On Tue, Nov 25, 2014 at 05:09:29PM +, Alin Serdean wrote:
> Add an additional check to see if the flowTable is not NULL.
Hi Alin, can you provide a Sig
Acked-by: Alin Gabriel Serdean
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Gurucharan Shetty
Trimis: Tuesday, December 16, 2014 7:00 PM
Către: dev@openvswitch.org
Cc: Gurucharan Shetty
Subiect: [ovs-dev] [PATCH] daemon-windows: Add a missing header.
Witho
Move the the tail of the netlink buffer accordingly to the input data.
Currently _MapFlowStatsToNlStats overrides the netlink header information.
Signed-off-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/Flow.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/d
Alin Serdean
Cc: dev@openvswitch.org
Subiect: Re: [ovs-dev] [PATCH] datapath-windows: set the nlBuf tail properly
On Jan 5, 2015, at 11:17 AM, Alin Serdean
wrote:
> Move the the tail of the netlink buffer accordingly to the input data.
> Currently _MapFlowStatsToNlStats overrides the net
Current flow commands: new, set, get, del need to respond with a NETLINK
error in the case OVS_FLOW_ATTR_KEY is missing.
OVS_FLOW_ATTR_KEY is now an optional attribute.
Also add OVS_FLOW_ATTR_UFID attribute to the kernel for further use.
Signed-off-by: Alin Gabriel Serdean
---
datapath-window
Current flow commands: new, set, get, del need to respond with a NETLINK
error in the case OVS_FLOW_ATTR_KEY is missing.
OVS_FLOW_ATTR_KEY is now an optional attribute.
Also add OVS_FLOW_ATTR_UFID attribute to the kernel for further use.
v2 Remove redundant return code
Acked-by: Eitan Eliahu
Current flow commands: new, set, get, del need to respond with a NETLINK
error in the case OVS_FLOW_ATTR_KEY is missing.
OVS_FLOW_ATTR_KEY is now an optional attribute.
Also add OVS_FLOW_ATTR_UFID attribute to the kernel for further use.
v3 Fix broken commit
v2 Remove redundant return code
Ack
Thank you all for the feedback.
I will take into account in my next patch series :).
Alin.
-Mesaj original-
De la: Joe Stringer [mailto:joestrin...@nicira.com]
Trimis: Thursday, February 5, 2015 6:33 AM
Către: Ankur Sharma
Cc: Alin Serdean; dev@openvswitch.org
Subiect: Re: [ovs-dev
Nice one Guru.
If you want I can look up to also build for the extension.
I also need to update the documentation for it :).
Alin.
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Gurucharan Shetty
Trimis: Thursday, February 5, 2015 10:31 PM
Către: Ben Pfaff
Cc
Ok will update it first things tomorrow.
Thanks,
Alin.
-Mesaj original-
De la: Gurucharan Shetty [mailto:shet...@nicira.com]
Trimis: Thursday, February 5, 2015 11:38 PM
Către: Alin Serdean
Cc: Ben Pfaff; dev; Gurucharan Shetty
Subiect: Re: [ovs-dev] [PATCH 2/2] appveyor: Provide a
Hi Nithin,
No worries go for it.
Thanks,
Alin.
-Mesaj original-
De la: Nithin Raju [mailto:nit...@vmware.com]
Trimis: Friday, February 6, 2015 2:41 AM
Către: Alin Serdean
Cc: Gurucharan Shetty; dev@openvswitch.org; Gurucharan Shetty
Subiect: Re: [ovs-dev] [PATCH 2/2] appveyor: Provide
Remove pad member from struct ofpact_nest.
Also MSVC does not support parameters with __declspec as stated in:
https://msdn.microsoft.com/en-us/library/373ak2y1.aspx so accommodate the
code to the new format.
Signed-off-by: Alin Gabriel Serdean
---
lib/ofp-actions.c | 12 ++--
lib/
Hi Ben,
I have sent out a patch
(http://openvswitch.org/pipermail/dev/2015-March/052465.html).
If you want to revert back to 4 bytes please tell me.
Alin.
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Ben Pfaff
Trimis: Friday, March 13, 2015 11:58 PM
Către
Adding the file: tests/testsuite.tmp.orig to tests/.gitignore
Signed-off-by: Alin Gabriel Serdean
---
tests/.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/.gitignore b/tests/.gitignore
index b4a54c9..966fcb3 100644
--- a/tests/.gitignore
+++ b/tests/.gitignore
@@ -48,3 +48,
Ty!
-Mesaj original-
De la: Jarno Rajahalme [mailto:jrajaha...@nicira.com]
Trimis: Tuesday, March 17, 2015 12:27 AM
Către: Alin Serdean
Cc: Ben Pfaff; Nithin Raju; dev@openvswitch.org
Subiect: Re: [ovs-dev] ofpact alignment problem on Windows
This is now reverted in master,
Jarno
The idea is there are two type of errors:
- those returned by the system: i.e. the result code that you pointed below
which gets interpreted by
(https://github.com/openvswitch/ovs/blob/master/lib/netlink-socket.c#L567).
Which means that was a system error.
- netlink errors which will determine
Thanks for the review Sairam.
I trimmed the message a bit.
See my answers inlined.
> status = OvsAllocateNBLContext(context, newNbl); diff --git
>a/datapath-windows/ovsext/Checksum.c
>b/datapath-windows/ovsext/Checksum.c
>index 510a094..5d9b035 100644
>--- a/datapath-windows/ovsext/Checksum
Please modify also the documentation INSTALL.Windows.md to be inline with the
modified port names.
Small nit: you should delete also the defines for internal/external
(https://github.com/openvswitch/ovs/blob/master/datapath-windows/ovsext/Vport.h#L37-L40)
For this to work in the case for the in
>
>>@@ -504,9 +517,14 @@ CalculateChecksumNB(const PNET_BUFFER nb,
>>+/*
>>+ * To this point we do not have VXLAN offloading.
>>+ * Apply defined checksums
>>+ */
>
>Sai: Correct me if am wrong, this computes checksum for the inner
>packet if there is no segmentatio
Hi Sairam,
Thank you for the patch.
Maybe I am missing something conceptually, but I do not understand why you are
computing computing the checksums on receive (decapsulation) for the inner
packet.
IMO it should be the other way around: you should compute the checksums for the
inner packet in
If we have a flow rule of the following form:
actions=strip_vlan,set_tunnel:0x3e9,15,16,17 (Where port 15, 16 and 17 are
VXLAN OF ports with different tunnelling information)
Current implementation is that if a packet will hit that specific flow,
only one packet will be sent out with the first t
If we have a flow rule of the following form:
actions=strip_vlan,set_tunnel:0x3e9,15,16,17 (Where port 15, 16 and 17 are
VXLAN OF ports with different tunnelling information)
Current implementation is that if a packet will hit that specific flow,
only one packet will be sent out with the first t
Currently when running the vswitch daemon we get a lot of messages of the
form:
2015-09-10T23:04:21Z|07255|dpif(revalidator11)|WARN|system@ovs-system: failed
to flow_del (Invalid argument).
The userspace expects after sending a delete flow command, to receive the flow
key of the deleted flow.
Cur
Change variable name to fix compiling.
Signed-off-by: Alin Gabriel Serdean
---
This patch is intended only for the branch-2.4
---
datapath-windows/ovsext/Flow.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/datapath-windows/ovsext/Flow.c b/datapath-windows/ovsext
This patch series adds the build system, documentation and various
fixes needed to compile under x64 MSVC.
The patch series are intended for branch-2.4 minus the following
patch: MSVC 64 bit compile error.
Alin Gabriel Serdean (7):
Add x64 bit configuration to windows installer
MSVC 64 bit
This patch defines the x64 in the configuration of the visual studio
solution: ovs-windows-installer.sln
Signed-off-by: Alin Gabriel Serdean
---
windows/ovs-windows-installer.sln | 4 ++-
.../ovs-windows-installer.wixproj | 41 +-
2 files ch
601 - 700 of 799 matches
Mail list logo
