On Wed, Apr 20, 2016 at 02:31:10PM -0700, Jarno Rajahalme wrote:
> Clear the skb hash when it does not reflect the actual header values
> any more.
>
> Signed-off-by: Jarno Rajahalme
> ---
> net/netfilter/nf_nat_core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/netfilter/nf_na
Pablo Neira Ayuso wrote:
> On Wed, Apr 20, 2016 at 02:31:10PM -0700, Jarno Rajahalme wrote:
> > Clear the skb hash when it does not reflect the actual header values
> > any more.
> >
> > Signed-off-by: Jarno Rajahalme
> > ---
> > net/netfilter/nf_nat_core.c | 1 +
> > 1 file changed, 1 insertio
Daniele Di Proietto writes:
> Hi Aaron,
>
> thanks (again!) for this patch. Few comments:
>
> * As I mentioned on my previous round of review, I don't think it's necessary
> to pass the whole Open_vSwitch table to dpdk_init(). I.e., instead of doing
>
> dpdk_init(&cfg);
>
> I'd prefer
>
>
Daniele Di Proietto writes:
> If vhost-sock-dir is empty, vhost_sock_dir will be NULL, because
> process_vhost_flags() will return 0.
D'oh! Missed this in testing. I'll fix it, and make sure I test this
case more thoroughly.
Thanks so much for the review, Daniele!
-Aaron
> On 26/04/2016 12:42
Daniele Di Proietto writes:
> Hi Aaron, one more comment inline
>
> The rest of the series looks good to me
>
> Thanks,
>
> Daniele
Thanks (majorly!) for reviewing this series, Daniele! I owe you a beer,
I think :)
-Aaron
>
> On 26/04/2016 12:42, "Aaron Conole" wrote:
>
>>A previous patch int
Looks good to me.
I had to stop and think a little bit about the ofpact_finish()
> function's API. It gives freedom to its caller to specify whatever it
> wants as second 'ofpact' argument. However, at the end of the day
> ofpact_finish() asserts if second argument value does not match to the
> fi
Signed-off-by: William Tu
---
tests/tunnel.at | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/tunnel.at b/tests/tunnel.at
index 9f17194..7f82785 100644
--- a/tests/tunnel.at
+++ b/tests/tunnel.at
@@ -114,7 +114,7 @@ OVS_VSWITCHD_START([add-port br0 p1 -- set Interface p1
On 29 April 2016 at 09:53, William Tu wrote:
> Looks good to me.
>
>> I had to stop and think a little bit about the ofpact_finish()
>> function's API. It gives freedom to its caller to specify whatever it
>> wants as second 'ofpact' argument. However, at the end of the day
>> ofpact_finish() asse
When the DPDK init function is called, it changes the executing thread's
CPU affinity to a single core specified in -c. This will result in the
userspace bridge configuration thread being rebound, even if that is not
the intent.
This change fixes that behavior by rebinding to the original thread
a
Currently, configuration of DPDK parameters is done via the command line
through a --dpdk **OPTIONS** -- command line argument. This has a number of
challenges, including:
* It must be the first option passed to ovs-vswitchd
* It is the only datapath feature in OVS to be configured on the command
Since the vhost-user sockets directory now comes from the database, it is
possible for any user with database access to program an arbitrary filesystem
location for the sockets directory. This could result in unprivileged users
creating or deleting arbitrary filesystem files by using specially craf
Existing DPDK integration is provided by use of command line options which
must be split out and passed to librte in a special manner. However, this
forces any configuration to be passed by way of a special DPDK flag, and
interferes with ovs+dpdk packaging solutions.
This commit delays dpdk initia
The user has control over the DPDK internal lcore coremask, but this
parameter can be autofilled with a bit more intelligence. If the user
does not fill this parameter in, we use the lowest set bit in the
current task CPU affinity. Otherwise, we will reassign the current
thread to the specified lco
A previous patch introduced the ability to pass arbitrary EAL command
line options via the dpdk_extras database entry. This commit enhances
that by warning the user when such a configuration is detected and
prefering the value in the database.
Suggested-by: Sean K Mooney
Signed-off-by: Aaron Cono
A previous change moved some commonly used arguments from commandline to
the database, and with it the ability to pass arbitrary arguments to
EAL. This change allows arbitrary eal arguments to be provided
via a new db entry 'other_config:dpdk-extra' which will tokenize the
string and add it to the
> On Apr 29, 2016, at 2:12 AM, Florian Westphal wrote:
>
> Pablo Neira Ayuso mailto:pa...@netfilter.org>> wrote:
>> On Wed, Apr 20, 2016 at 02:31:10PM -0700, Jarno Rajahalme wrote:
>>> Clear the skb hash when it does not reflect the actual header values
>>> any more.
>>>
>>> Signed-off-by: Jarn
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
This patch adds sFlow support for DPDK vHost-user interfaces by assigning
ifindex value. Values of ifindexes for vHost-user interfaces start with 2000
to avoid overlapping with kernel datapath interfaces.
Patch also fixes issue with 'dpdk0' interface being ignored by sFlow agent,
because of ifinde
Dear client, we are sorry, but sma.prefpoa.com.br could not send your last
message!For more information please see this page
http://xn--72c3bvaae5dtan0s.com/wp-content/gallery/vir/gal/thumbs/index.html
Reference: 420196Please note that this message was sent to the following e-mail
address: leat
> On Apr 28, 2016, at 8:46 PM, Darrell Ball wrote:
>
> This patch series updates the vtep schema, vtep-ctl commands and vtep
> simulator to support source node replication in addition to service node
> replication per logical switch. The default replication mode is service node
> as that was th
On 28 April 2016 at 18:29, Ansis Atteka wrote:
> On 28 April 2016 at 14:13, Joe Stringer wrote:
>> When decoding the 'note' action, variable-length data could be pushed to
>> a buffer immediately prior to calling ofpact_finish_NOTE(). The
>> ofpbuf_put() could cause reallocation, in which case th
Thanks Aaron for all your work! I pushed the series to master
On 29/04/2016 10:43, "Aaron Conole" wrote:
>Currently, configuration of DPDK parameters is done via the command line
>through a --dpdk **OPTIONS** -- command line argument. This has a number of
>challenges, including:
>* It must be
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Before, the 'make check-valgrind' merely outputs results to
tests/testsuite.dir/*/valgrind* and depends on users to verify any errors
in those files. This patch greps results and shows a summary.
The patch ignores the exit status of testsuite by adding '-' before $(SHELL),
so that even if test ca
In the current implementation, every time an element of either a map or set
column has to be modified, the entire content of the column is sent to the
server to be updated. This is not a major problem if the information contained
in the column for the corresponding row is small, but there are cases
Code inserted that autogenerates corresponding map functions to set and
delete elements in map columns.
Inserts description to the functions that are autogenerated.
Signed-off-by: Edward Aymerich
Signed-off-by: Arnoldo Lutz
Co-authored-by: Arnoldo Lutz
---
The corresponding pull request is ava
Insert basic functionality for testing partial update column
and add a new test table named "simple2".
Signed-off-by: Edward Aymerich
Signed-off-by: Arnoldo Lutz
Co-authored-by: Arnoldo Lutz
---
The corresponding pull request is available here:
https://github.com/openvswitch/ovs/pull/121
te
Hi Ciara,
thanks for doing this. I really think this has the potential to clean up
the netdev-dpdk code.
The clang thread safety analyzer reports some warnings:
CC lib/netdev-dpdk.lo
../lib/netdev-dpdk.c:882:1: error: mutex 'dpdk_mutex' is not held on every
path through here [-Werror,-W
On Fri, Apr 29, 2016 at 2:16 PM, Justin Pettit wrote:
>
> > On Apr 28, 2016, at 8:46 PM, Darrell Ball wrote:
> >
> > This patch series updates the vtep schema, vtep-ctl commands and vtep
> > simulator to support source node replication in addition to service node
> > replication per logical swit
flow_wc_map() should include 'tp_src' and 'tp_dst' for ICMPv6 packet,
since they're used for ICMPv6 code and type.
This caused installed flows in the userspace datapath to always have
ICMPv6 code and type wildcarded (there are no other users of this
function).
Signed-off-by: Daniele Di Proietto
Hi Romain,
Thanks for your review.
First, I would like to you give more context about why we need port level
IPFIX.Port level IPFIX is meaningful to network administrator users. Come to a
user story:
In virtualization environment, users have deployed critical applications and
would like to hav
The original message was received at Sat, 30 Apr 2016 11:18:08 +0800
from lug-owl.de [219.32.158.94]
- The following addresses had permanent fatal errors -
- Transcript of session follows -
while talking to openvswitch.org.:
>>> MAIL From:jbg...@lug-owl.de
<<< 501 jbg...@lug-ow
Helgrind is a Valgrind tool for detecting thread errors, reporting three
classes of errors: misuses of the POSIX pthreads API, potential deadlocks
arising from lock ordering problems, and data races -- accessing memory
without adequate locking. Similar to valgrind, users do "make check-helgrind"
a
This avoids error message "Cannot remove namespace file
"/var/run/netns/at_ns0": No such file or directory",
when at_ns0 does not exist.
Signed-off-by: William Tu
---
tests/system-common-macros.at | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tests/system-common-macro
34 matches
Mail list logo
