Re: [ovs-dev] [RFC 2/2] dpdk: Update INSTALL.DPDK.md to reflect new config

2015-12-07 Thread Gray, Mark D
> > Why delay the inevitable? :) > Absolutely, I agree with the approach. I was just pointing out that issue. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] ofproto-dpif: add reply on error in ofproto/tnl-push-pop

2015-12-07 Thread Ilya Maximets
Fixes hang of 'ovs-appctl ofproto/tnl-push-pop' when an invalid argument passed. Signed-off-by: Ilya Maximets --- ofproto/ofproto-dpif.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c index d920ed0..6561c65 100644 --- a/ofproto/ofproto-dpif.

Re: [ovs-dev] [PATCH] ofproto-dpif: add reply on error in ofproto/tnl-push-pop

2015-12-07 Thread Thadeu Lima de Souza Cascardo
On Mon, Dec 07, 2015 at 01:02:41PM +0300, Ilya Maximets wrote: > Fixes hang of 'ovs-appctl ofproto/tnl-push-pop' when an invalid > argument passed. > > Signed-off-by: Ilya Maximets > --- > ofproto/ofproto-dpif.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/ofproto/ofproto-dpif.c b

Re: [ovs-dev] [RFC 2/2] dpdk: Update INSTALL.DPDK.md to reflect new config

2015-12-07 Thread Zoltan Kiss
On 04/12/15 16:15, Gray, Mark D wrote: 5. Start vswitchd: > >- DPDK configuration arguments can be passed to vswitchd via `--dpdk` >- argument. This needs to be first argument passed to vswitchd process. >- dpdk arg -c is ignored by ovs-dpdk, but it is a required parameter >- for dpdk

Re: [ovs-dev] [RFC 2/2] dpdk: Update INSTALL.DPDK.md to reflect new config

2015-12-07 Thread Traynor, Kevin
> -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Zoltan Kiss > Sent: Monday, December 7, 2015 11:57 AM > To: Gray, Mark D; Aaron Conole; dev@openvswitch.org > Cc: Flavio Leitner > Subject: Re: [ovs-dev] [RFC 2/2] dpdk: Update INSTALL.DPDK.md to reflect new

[ovs-dev] [PATCH 2/2] support L3 logical router in vtep emulator

2015-12-07 Thread Shuangmin Zhang
This patch is to support L3 DLR E-W traffic functionality in ovs-vtep. So it is focus on supporting switch-binding field in Logical_Router Table schema. Like what we do for logical switch, there are 2 parts of work 1> physical handling In this part, create binding between logical router and

Re: [ovs-dev] [PATCH 0/7] Enable NSH based Service Function Chaining support in OVS

2015-12-07 Thread Jesse Gross
On Fri, Nov 6, 2015 at 4:23 PM, Jesse Gross wrote: > On Tue, Nov 3, 2015 at 10:20 AM, Liu, Mengke wrote: >>> > So for NSH header, we need to add the TLV support. For the fixed >>> > fields of NSH header like NSI, NSP, we’d like to add specific >>> > meta-flow fields for them, for example: >>> > >

Re: [ovs-dev] [PATCH] vtep: support L3 logical router E-W traffic in Hardware vtep emulator

2015-12-07 Thread Guru Shetty
On 6 December 2015 at 23:23, Shuangmin Zhang wrote: > Signed-off-by: Shuangmin Zhang > How did you send this patch? Are you able to download this mail and apply it with 'git am'? If not, try sending a mail to yourself with 'git send-email' and then download that mail (if destination is gmail, y

Re: [ovs-dev] [PATCH] ofproto-dpif: add reply on error in ofproto/tnl-push-pop

2015-12-07 Thread Ben Pfaff
On Mon, Dec 07, 2015 at 01:02:41PM +0300, Ilya Maximets wrote: > Fixes hang of 'ovs-appctl ofproto/tnl-push-pop' when an invalid > argument passed. > > Signed-off-by: Ilya Maximets Thanks, applied to master, branch-2.5, branch-2.4. ___ dev mailing list

Re: [ovs-dev] [PATCH 2/2] support L3 logical router in vtep emulator

2015-12-07 Thread Ben Pfaff
On Tue, Dec 08, 2015 at 07:35:44AM +0800, Shuangmin Zhang wrote: > This patch is to support L3 DLR E-W traffic functionality in ovs-vtep. So it > is focus on supporting switch-binding field in Logical_Router Table schema. > > Like what we do for logical switch, there are 2 parts of work Is ther

Re: [ovs-dev] [PATCH] seq: Add a coverage counter for seq_change.

2015-12-07 Thread Ben Pfaff
On Fri, Dec 04, 2015 at 03:57:09PM -0800, Jarno Rajahalme wrote: > Having a coverage counter tracking the value of the internal seq_next > should help in debugging. > > Suggested-by: Justin Pettit > Signed-off-by: Jarno Rajahalme Acked-by: Ben Pfaff

[ovs-dev] [PATCH] INSTALL.DPDK.md: Clarify DPDK arguments.

2015-12-07 Thread Kevin Traynor
Add some information about the DPDK -c and -n parameters. Signed-off-by: Kevin Traynor Reported-by: Zoltan Kiss --- INSTALL.DPDK.md | 14 -- 1 files changed, 12 insertions(+), 2 deletions(-) diff --git a/INSTALL.DPDK.md b/INSTALL.DPDK.md index 96b686c..ee016da 100644 --- a/INSTAL

Re: [ovs-dev] [PATCH 2/2] support L3 logical router in vtep emulator

2015-12-07 Thread Justin Pettit
> On Dec 7, 2015, at 9:15 AM, Ben Pfaff wrote: > > On Tue, Dec 08, 2015 at 07:35:44AM +0800, Shuangmin Zhang wrote: >> This patch is to support L3 DLR E-W traffic functionality in ovs-vtep. So it >> is focus on supporting switch-binding field in Logical_Router Table schema. >> >> Like what we

Re: [ovs-dev] ovn-nbctl:What are router commands like?

2015-12-07 Thread Russell Bryant
On 12/04/2015 12:10 AM, Wei Li wrote: > I have created a pull request on git for adding db commands help Saw it, and replied. :-) https://github.com/openvswitch/ovs/pull/93 > and I want to change the output of "/ovn-nbctl show/" > > 1: "ovn-nbctl show" will print all switch and all router like

[ovs-dev] [PATCH] datapath: Avoid warning for unused static data on Linux <=3.9.0.

2015-12-07 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- datapath/actions.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/datapath/actions.c b/datapath/actions.c index 0d6375f..9dccf47 100644 --- a/datapath/actions.c +++ b/datapath/actions.c @@ -68,7 +68,9 @@ struct ovs_frag_data { u8 l2_data[MAX_L2_LEN]; }

Re: [ovs-dev] new warnings

2015-12-07 Thread Ben Pfaff
On Fri, Dec 04, 2015 at 08:22:31AM -0800, Ben Pfaff wrote: > I'm getting the following new warnings since the big backports series. > This is with GCC 4.9 and Linux 3.2: I sent a patch for one of the warnings: http://openvswitch.org/pipermail/dev/2015-December/063108.html _

[ovs-dev] [PATCH] FAQ: Add entry about different datapaths features.

2015-12-07 Thread Daniele Di Proietto
This is an easy way to keep track of the features supported by the different datapaths. Nithin helped filling the list for the Hyper-V port. CC: Nithin Raju Signed-off-by: Daniele Di Proietto --- FAQ.md | 64 1 file changed, 64 i

[ovs-dev] [PATCH] datapath-windows: reduce padding size in _OVS_PACKET_HDR_INFO

2015-12-07 Thread Nithin Raju
Fixing a little buglet from commit: efee3309. Signed-by: Nithin Raju --- datapath-windows/ovsext/NetProto.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datapath-windows/ovsext/NetProto.h b/datapath-windows/ovsext/NetProto.h index a364869..c60081a 100644 --- a/datapath-wi

Re: [ovs-dev] [PATCH 2/2] support L3 logical router in vtep emulator

2015-12-07 Thread Shuangmin Zhang
Yeah, while I generated patch with form-patch, it generated 2 patches, another is 0001-ofproto-dpif-Validate-NAT-action-support.patch, but that is not my code change, don¹t know why it comes up. It is a already checkin-patch by Daniele Di. Thanks Shuangmin. On 12/8/15, 1:58 AM, "Justin Pettit"

Re: [ovs-dev] [PATCH 2/2] support L3 logical router in vtep emulator

2015-12-07 Thread Ben Pfaff
Using "git format-patch -1" if you want to generate one patch. On Mon, Dec 07, 2015 at 11:19:41PM +, Shuangmin Zhang wrote: > Yeah, while I generated patch with form-patch, it generated 2 patches, > another is 0001-ofproto-dpif-Validate-NAT-action-support.patch, but that > is not my code cha

[ovs-dev] [PATCH] NEWS: Improve organization.

2015-12-07 Thread Ben Pfaff
From: Ben Pfaff Signed-off-by: Ben Pfaff --- I'd like to apply this to master and branch-2.5. I think it makes it a little easier to read. NEWS | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/NEWS b/NEWS index e1f3d33..a6b1599 100644 --- a/NEWS +++ b/NEWS @@ -1

Re: [ovs-dev] [PATCH] NEWS: Improve organization.

2015-12-07 Thread Ben Pfaff
On Mon, Dec 07, 2015 at 03:29:08PM -0800, Ben Pfaff wrote: > From: Ben Pfaff > > Signed-off-by: Ben Pfaff > --- > I'd like to apply this to master and branch-2.5. I think it makes > it a little easier to read. I've been sitting on this for a while, so it still has old email addresses on it. I

Re: [ovs-dev] [PATCH] NEWS: Improve organization.

2015-12-07 Thread Justin Pettit
> On Dec 7, 2015, at 3:31 PM, Ben Pfaff wrote: > > On Mon, Dec 07, 2015 at 03:29:08PM -0800, Ben Pfaff wrote: >> From: Ben Pfaff >> >> Signed-off-by: Ben Pfaff >> --- >> I'd like to apply this to master and branch-2.5. I think it makes >> it a little easier to read. > > I've been sitting on

Re: [ovs-dev] ovn-nbctl:What are router commands like?

2015-12-07 Thread Ben Pfaff
On Mon, Dec 07, 2015 at 01:13:27PM -0500, Russell Bryant wrote: > I'm looking at this again and I think it's worth keeping because the > output is a bit friendlier. > > How about supporting both "show LSWITCH" and "show LROUTER". The > implementation would just have to search both tables for a ma

Re: [ovs-dev] [PATCH] FAQ: Add entry about different datapaths features.

2015-12-07 Thread Ben Pfaff
On Mon, Dec 07, 2015 at 01:00:46PM -0800, Daniele Di Proietto wrote: > This is an easy way to keep track of the features supported by the > different datapaths. > > Nithin helped filling the list for the Hyper-V port. > > CC: Nithin Raju > Signed-off-by: Daniele Di Proietto This looks really n

Re: [ovs-dev] [PATCH] datapath: Avoid warning for unused static data on Linux <=3.9.0.

2015-12-07 Thread Pravin Shelar
On Mon, Dec 7, 2015 at 12:34 PM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff Acked-by: Pravin B Shelar Thanks. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] NEWS: Improve organization.

2015-12-07 Thread Ben Pfaff
On Mon, Dec 07, 2015 at 03:36:24PM -0800, Justin Pettit wrote: > > > On Dec 7, 2015, at 3:31 PM, Ben Pfaff wrote: > > > > On Mon, Dec 07, 2015 at 03:29:08PM -0800, Ben Pfaff wrote: > >> From: Ben Pfaff > >> > >> Signed-off-by: Ben Pfaff > >> --- > >> I'd like to apply this to master and branc

Re: [ovs-dev] [PATCH] datapath-windows: Support for OVS_KEY_ATTR_MPLS attribute

2015-12-07 Thread Nithin Raju
Hi Sorin, I found some bugs in OvsActionMplsPush(). Can you pls. clarify if my comments are valid? If they are genuine bugs, did your testing not catch them? Apologies, if I missed anything. I¹ll review the rest of the patch after the claritification. Thanks, -- Nithin -Original Message-

Re: [ovs-dev] [PATCH] FAQ: Add entry about different datapaths features.

2015-12-07 Thread Daniele Di Proietto
On 07/12/2015 15:49, "Ben Pfaff" wrote: >On Mon, Dec 07, 2015 at 01:00:46PM -0800, Daniele Di Proietto wrote: >> This is an easy way to keep track of the features supported by the >> different datapaths. >> >> Nithin helped filling the list for the Hyper-V port. >> >> CC: Nithin Raju >> Signe

[ovs-dev] [PATCH 2/4] datapath: Backport: openvswitch: properly refcount vport-vxlan module

2015-12-07 Thread Pravin B Shelar
Upstream commit: After 614732eaa12d, no refcount is maintained for the vport-vxlan module. This allows the userspace to remove such module while vport-vxlan devices still exist, which leads to later oops. v1 -> v2: - move vport 'owner' initialization in ovs_vport_ops_register(

[ovs-dev] [PATCH 0/4] datapath: Backported upstream fixes.

2015-12-07 Thread Pravin B Shelar
Few important bugfixes for OVS out of tree module. Pravin B Shelar (4): datapath: Backport: openvswitch: fix hangup on vxlan/gre/geneve device deletion datapath: Backport: openvswitch: properly refcount vport-vxlan module datapath: Backport: vxlan: fix incorrect RCO bit in VXLAN header

[ovs-dev] [PATCH 4/4] datapath: Backport: vxlan: interpret IP headers for ECN correctly

2015-12-07 Thread Pravin B Shelar
Upstream commit: When looking for outer IP header, use the actual socket address family, not the address family of the default destination which is not set for metadata based interfaces (and doesn't have to match the address family of the received packet even if it was set). Fi

[ovs-dev] [PATCH 3/4] datapath: Backport: vxlan: fix incorrect RCO bit in VXLAN header

2015-12-07 Thread Pravin B Shelar
Upstream commit: Commit 3511494ce2f3d ("vxlan: Group Policy extension") changed definition of VXLAN_HF_RCO from 0x0020 to BIT(24). This is obviously incorrect. It's also in violation with the RFC draft. Fixes: 3511494ce2f3d ("vxlan: Group Policy extension") Cc: Thomas Graf

[ovs-dev] [PATCH 1/4] datapath: Backport: openvswitch: fix hangup on vxlan/gre/geneve device deletion

2015-12-07 Thread Pravin B Shelar
Upstream commit: Each openvswitch tunnel vport (vxlan,gre,geneve) holds a reference to the underlying tunnel device, but never released it when such device is deleted. Deleting the underlying device via the ip tool cause the kernel to hangup in the netdev_wait_allrefs() loop.

Re: [ovs-dev] [PATCH 0/4] datapath: Backported upstream fixes.

2015-12-07 Thread Jesse Gross
On Mon, Dec 7, 2015 at 6:23 PM, Pravin B Shelar wrote: > Few important bugfixes for OVS out of tree module. > > Pravin B Shelar (4): > datapath: Backport: openvswitch: fix hangup on vxlan/gre/geneve > device deletion > datapath: Backport: openvswitch: properly refcount vport-vxlan module >

Re: [ovs-dev] [ovs] ovn-nbctl:add db commands help (#93)

2015-12-07 Thread Wei Li
在 2015/12/7 23:30, Russell Bryant 写道: Can you update the man page, as well? I would like to do this,but have a question There is a reference to /db-ctl-base.man/ in /ovn-sbctl.8.in/ implement by "/.so lib/db-ctl-base.man/" but ovn-nbctl`s manpage is xml format How to add a reference to

[ovs-dev] Returned mail: Data format error

2015-12-07 Thread Post Office
Dear user dev@openvswitch.org, Your email account was used to send a huge amount of junk email during this week. Probably, your computer was infected by a recent virus and now runs a trojaned proxy server. Please follow the instructions in order to keep your computer safe. Best wishes, The ope