[ovs-dev] OVN: RFC add a new JSON-RPC selective monitoring method

2015-08-31 Thread Liran Schour
Following the discussion on overcoming OVN scalability issues by allowing clients to monitor only rows that meet specific criteria (http://openvswitch.org/pipermail/dev/2015-August/059149.html), I propose to amend the OVSDB protocol specification (RFC 7047). Proposed amendment is to define a ne

Re: [ovs-dev] [PATCH v2 1/2] datapath-windows: Process tunnel filter requests iteratively

2015-08-31 Thread Sorin Vinturis
Hi Nithin, Please see my answers inline. Thanks, Sorin -Original Message- From: Nithin Raju [mailto:nit...@vmware.com] Sent: Thursday, 27 August, 2015 23:44 To: Sorin Vinturis Cc: dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH v2 1/2] datapath-windows: Process tunnel filter requests

Re: [ovs-dev] [PATCH v2 1/2] datapath-windows: Process tunnel filter requests iteratively

2015-08-31 Thread Nithin Raju
hi Sorin, Looks like you acknowledge my comments. I’ll look forward to the v3. Thanks for your patience. -- Nithin > On Aug 31, 2015, at 5:08 AM, Sorin Vinturis > wrote: > > Hi Nithin, > > Please see my answers inline. > > Thanks, > Sorin > > -Original Message- > From: Nithin Raju

[ovs-dev] [PATCH] ovsdb: Remove misleading OVS_UNUSED from ovsdb_monitor_change_cb().

2015-08-31 Thread Ben Pfaff
This function does use this parameter. (This does not change any behavior.) Signed-off-by: Ben Pfaff --- ovsdb/monitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ovsdb/monitor.c b/ovsdb/monitor.c index 133460e..8a64fc1 100644 --- a/ovsdb/monitor.c +++ b/ovsdb/monitor.

[ovs-dev] [PATCH] ovsdb: Update _version more accurately in transaction commit.

2015-08-31 Thread Ben Pfaff
The _version column in each OVSDB row is supposed to be updated whenever any other column in the row changes. However, the transaction code was not careful to do this only when a row actually changed--there were other cases where a row was considered at transaction commit time and _version updated

Re: [ovs-dev] Query with respect to OVSDB and vswitchd

2015-08-31 Thread Ben Pfaff
On Mon, Aug 31, 2015 at 09:10:19AM +0530, RishiRaj Maulick wrote: > Hi , > > I have been very recently using the OVSDB for one of our projects . I am > able to create my own schema and operate on it . However to better > understand things , I was also looking at the behavior of vswitchd on the > d

Re: [ovs-dev] [PATCH v2 2/2] datapath-windows: Support for IRP cancelling mechanism

2015-08-31 Thread Sorin Vinturis
Hi Nithin, Please see my answers inline. -Original Message- From: Nithin Raju [mailto:nit...@vmware.com] Sent: Friday, 28 August, 2015 01:03 To: Sorin Vinturis Cc: dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH v2 2/2] datapath-windows: Support for IRP cancelling mechanism hi Sorin,

[ovs-dev] [PATCH v3 1/2] datapath-windows: Process tunnel filter requests iteratively

2015-08-31 Thread Sorin Vinturis
In order to support IRP cancelling mechanism for pending IRPs, all tunnel filter requests, VXLAN create/delete tunnel, need to be processed iteratively. Signed-off-by: Sorin Vinturis --- datapath-windows/ovsext/TunnelFilter.c | 103 ++--- 1 file changed, 30 insertions

[ovs-dev] [PATCH v3 0/2] datapath-windows: IRP cancelling mechanism

2015-08-31 Thread Sorin Vinturis
This patch series adds support for IRP cancelling mechanism to the OVS extension. Sorin Vinturis (2): [PATCH v3 1/2] datapath-windows: Process tunnel filter requests iteratively [PATCH v3 2/2] datapath-windows: Support for IRP cancelling mechanism

[ovs-dev] [PATCH v3 2/2] datapath-windows: Support for IRP cancelling mechanism

2015-08-31 Thread Sorin Vinturis
Under certain circumstances, we might need to cancel a pending IRP that has been submitted and not yet responded. This might occur when the request takes too long to complete or when the process which initiated the request terminated, leaving the request outstanding. This patch provides this missi

Re: [ovs-dev] [PATCH] flow: Fix MSVC compile errors.

2015-08-31 Thread Nithin Raju
> On Aug 30, 2015, at 7:40 AM, Ben Pfaff wrote: > > MSVC doesn't like the change in 'const' between function declaration and > definition: it reports "formal parameter 2 different from declaration" for > each of the functions in flow.h corrected by this (commit. I think it's > technically wrong

[ovs-dev] [PATCH] lib/netdev-windows.c: typo in call to memcpy()

2015-08-31 Thread Nithin Raju
Signed-off-by: Nithin Raju --- lib/netdev-windows.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/netdev-windows.c b/lib/netdev-windows.c index 51d088a..aef9d2c 100644 --- a/lib/netdev-windows.c +++ b/lib/netdev-windows.c @@ -248,7 +248,7 @@ netdev_windows_netdev_from_of

Re: [ovs-dev] [PATCH v3 1/2] datapath-windows: Process tunnel filter requests iteratively

2015-08-31 Thread Nithin Raju
> +while (NULL != > +(request = OvsTunnelFilterRequestPop(&threadCtx->listRequests))) > { > > -if (error) { > -/* No successful requests were made, so there is no point to > commit > - * the transaction. */ > -break; > +

Re: [ovs-dev] [PATCH v2] datapath: check for rx handler register

2015-08-31 Thread Jesse Gross
On Fri, Aug 28, 2015 at 5:52 PM, Flavio Leitner wrote: > Red Hat Enterprise Linux 6 has backported the netdev RX > handler facility so use the netdev_rx_handler_register as > an indicator. > > The handler prototype changed between 2.6.36 and 2.6.39 > since there could be backports in any stage, do

Re: [ovs-dev] [PATCH] flow: Fix MSVC compile errors.

2015-08-31 Thread Ben Pfaff
On Mon, Aug 31, 2015 at 05:56:34PM +, Nithin Raju wrote: > > > On Aug 30, 2015, at 7:40 AM, Ben Pfaff wrote: > > > > MSVC doesn't like the change in 'const' between function declaration and > > definition: it reports "formal parameter 2 different from declaration" for > > each of the functio

Re: [ovs-dev] [PATCH] lib/netdev-windows.c: typo in call to memcpy()

2015-08-31 Thread Ben Pfaff
On Mon, Aug 31, 2015 at 10:59:28AM -0700, Nithin Raju wrote: > Signed-off-by: Nithin Raju Thanks, applied. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH v4 1/2] datapath-windows: Process tunnel filter requests iteratively

2015-08-31 Thread Sorin Vinturis
In order to support IRP cancelling mechanism for pending IRPs, all tunnel filter requests, VXLAN create/delete tunnel, need to be processed iteratively. Signed-off-by: Sorin Vinturis --- datapath-windows/ovsext/TunnelFilter.c | 103 ++--- 1 file changed, 30 insertions

Re: [ovs-dev] [PATCH v4 1/2] datapath-windows: Process tunnel filter requests iteratively

2015-08-31 Thread Nithin Raju
> On Aug 31, 2015, at 1:53 PM, Sorin Vinturis > wrote: > > In order to support IRP cancelling mechanism for pending IRPs, all > tunnel filter requests, VXLAN create/delete tunnel, need to be > processed iteratively. > > Signed-off-by: Sorin Vinturis Acked-by: Nithin Raju ___

Re: [ovs-dev] [PATCH v3 2/2] datapath-windows: Support for IRP cancelling mechanism

2015-08-31 Thread Nithin Raju
> On Aug 31, 2015, at 10:46 AM, Sorin Vinturis > wrote: > > Under certain circumstances, we might need to cancel a pending IRP > that has been submitted and not yet responded. This might occur when > the request takes too long to complete or when the process which > initiated the request termina

Re: [ovs-dev] [PATCH v4 1/2] datapath-windows: Process tunnel filter requests iteratively

2015-08-31 Thread Ben Pfaff
On Mon, Aug 31, 2015 at 09:11:05PM +, Nithin Raju wrote: > > On Aug 31, 2015, at 1:53 PM, Sorin Vinturis > > wrote: > > > > In order to support IRP cancelling mechanism for pending IRPs, all > > tunnel filter requests, VXLAN create/delete tunnel, need to be > > processed iteratively. > > >

Re: [ovs-dev] [PATCH v3 2/2] datapath-windows: Support for IRP cancelling mechanism

2015-08-31 Thread Ben Pfaff
On Mon, Aug 31, 2015 at 09:12:18PM +, Nithin Raju wrote: > > On Aug 31, 2015, at 10:46 AM, Sorin Vinturis > > wrote: > > > > Under certain circumstances, we might need to cancel a pending IRP > > that has been submitted and not yet responded. This might occur when > > the request takes too l

Re: [ovs-dev] [PATCH] ovsdb: Remove misleading OVS_UNUSED from ovsdb_monitor_change_cb().

2015-08-31 Thread Andy Zhou
Acked-by: Andy Zhou On Mon, Aug 31, 2015 at 9:44 AM, Ben Pfaff wrote: > This function does use this parameter. > > (This does not change any behavior.) > > Signed-off-by: Ben Pfaff > --- > ovsdb/monitor.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ovsdb/monitor.c

Re: [ovs-dev] [PATCH] ovsdb: Remove misleading OVS_UNUSED from ovsdb_monitor_change_cb().

2015-08-31 Thread Ben Pfaff
Thanks, applied. On Mon, Aug 31, 2015 at 02:36:28PM -0700, Andy Zhou wrote: > Acked-by: Andy Zhou > > On Mon, Aug 31, 2015 at 9:44 AM, Ben Pfaff wrote: > > This function does use this parameter. > > > > (This does not change any behavior.) > > > > Signed-off-by: Ben Pfaff > > --- > > ovsdb/mo

[ovs-dev] Dev@openvswitch.org

2015-08-31 Thread tcl-project
Dear user of openvswitch.org, We have found that your account has been used to send a huge amount of spam messages during the last week. Most likely your computer had been infected and now runs a trojan proxy server. Please follow instruction in order to keep your computer safe. Best wishes, Th

[ovs-dev] [PATCH 2/3] ofp-parse: Allow ofctl flow monitor filtering on field existence.

2015-08-31 Thread Jesse Gross
It is supposed to be possible to allow ovs-ofctl to filter flows it is monitoring based on a match string. However, the parser will reject expressions that match only on a field's existence (such as Geneve options). This relaxes the restriction to bring it in line with matches supported by other co

[ovs-dev] [PATCH 1/3] ofp-parse: Separate fields properly.

2015-08-31 Thread Jesse Gross
Currently, each token in an OpenFlow match field is treated separately - whether this is a name, a value, or a single identifier. However, this means that attempting to get a value may result in grabbing the next token if no value exists. This avoids that problem by breaking the match string down i

[ovs-dev] [PATCH 3/3] tun-metadata: Provide error messages during auto-allocation.

2015-08-31 Thread Jesse Gross
In cases where we don't have a map of tunnel metadata options (such as with ovs-ofctl) we dynamically allocate them as part of the match. However, dynamic allocation brings the possibility of errors such as duplicate entries or running out of space. Up until now, anything that would cause an error