Re: [ovs-dev] [PATCH 2/3] service controller: Allow change to punix socket file group ownership.

2015-08-28 Thread Alex Wang
On Wed, Aug 26, 2015 at 2:13 PM, Ben Pfaff wrote: > On Fri, Aug 21, 2015 at 11:10:32PM -0700, Alex Wang wrote: > > This commit adds a new key-value pair, 'punix_file_group=', > > to the 'other_config' column in the 'Controller' table. This new config > > allows user to change the punix socket fi

[ovs-dev] [PATCH V2] bridge: Relax the whitelist format for punix path.

2015-08-28 Thread Alex Wang
This commit relaxes the whitelist format for punix path for service controller. Instead of only allowing punix:/.controller, the new format allows any suffix, like punix:/.*. (except '/'). Signed-off-by: Alex Wang --- PATCH->V2: - prevent the punix path from specifying directory other than the

[ovs-dev] [PATCH] openswitch: fix typo CONFIG_NF_CONNTRACK_LABEL

2015-08-28 Thread Valentin Rothberg
Fix typo in conntrack.c s/CONFIG_NF_CONNTRACK_LABEL/CONFIG_NF_CONNTRACK_LABELS/ Signed-off-by: Valentin Rothberg --- The typo was added by commmit c2ac66735870 ("openvswitch: Allow matching on conntrack label"). I detected the issue scripts/checkkconfigsymbols.py net/openvswitch/conntrack.c |

[ovs-dev] Returned mail: see transcript for details

2015-08-28 Thread Automatic Email Delivery Software
The original message was received at Fri, 28 Aug 2015 14:56:52 +0530 from 192.25.171.63 - The following addresses had permanent fatal errors - ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] dpdk: add support for v2.1.0

2015-08-28 Thread Puha, TimoX
Hi, > From: gowrishankar [mailto:gowrishanka...@linux.vnet.ibm.com] > To have dpdk built with CONFIG_RTE_LIBRTE_VHOST_NUMA, we would need > -lnuma in above extralib. It would be helpful if we document this > as well (INSTALL.DPDK). Thanks for your comments. We decided to leave this new vhost n

Re: [ovs-dev] [lacp 2/2] lacp: Allow configurable aggregation keys.

2015-08-28 Thread Zayats, Michael
Hi Ethan, Regarding some old patch in which you added other_config:lacp-aggregation-key to the Interface table. I must be missing a reason of adding it to the Interface and not to the Port, where it would affect all slaves at once: when should users configure the key differently on slaves of t

Re: [ovs-dev] [PATCH] dpdk: add support for v2.1.0

2015-08-28 Thread Puha, TimoX
Hi, Thanks for your comments. Some details inline. > From: Daniele Di Proietto [mailto:diproiet...@vmware.com] > >diff --git a/INSTALL.DPDK.md b/INSTALL.DPDK.md > >index 35dd9a0..39e1b5d 100644 > >--- a/INSTALL.DPDK.md > >+++ b/INSTALL.DPDK.md > >@@ -16,7 +16,7 @@ OVS needs a system with 1GB huge

[ovs-dev] Returned mail: Data format error

2015-08-28 Thread Automatic Email Delivery Software
The original message was received at Fri, 28 Aug 2015 17:00:06 +0530 from openvswitch.org [203.44.122.133] - The following addresses had permanent fatal errors - dev@openvswitch.org ___ dev mailing list dev@openvswitch.org http://openvswitch.o

[ovs-dev] [PATCH 0/5] Fixes to build datapath on centos6/rhel6

2015-08-28 Thread Flavio Leitner
This patchset enables the datapath to compile on newer centos or Red Hat Enterprise Linux 6.6. I did a quick test on: 6.4 2.6.32-358.el6.x86_64 6.6 2.6.32-504.el6.x86_64 6 devel 2.6.32-578.el6.x86_64 7.1 3.10.0-229.el7.x86_64 Flavio Leitner (5): datapath: improve l4_rxhash regex

[ovs-dev] [PATCH 1/5] datapath: improve l4_rxhash regex

2015-08-28 Thread Flavio Leitner
Red Hat Enterprise Linux 6 has a comment saying that it doesn't support l4_rxhash which matches the current grep regex. Signed-off-by: Flavio Leitner --- acinclude.m4 | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/acinclude.m4 b/acinclude.m4 index 45cfaf6..db0de0d 100644 -

[ovs-dev] [PATCH 3/5] datapath: check for backported ip_is_fragment

2015-08-28 Thread Flavio Leitner
Red Hat Enterprise Linux 6 has backported it from upstream, so check for ip_is_fragment instead of kernel version. Signed-off-by: Flavio Leitner --- acinclude.m4 | 1 + datapath/linux/compat/include/net/ip.h | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff

[ovs-dev] [PATCH 2/5] datapath: check for backported proto_ports_offset

2015-08-28 Thread Flavio Leitner
Red Hat Enterprise Linux 6 has backported it from upstream, so check for proto_ports_offset instead of kernel version. Signed-off-by: Flavio Leitner --- acinclude.m4 | 1 + datapath/linux/compat/include/linux/in.h | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-

[ovs-dev] [PATCH 5/5] datapath: check for rx_handler register

2015-08-28 Thread Flavio Leitner
Red Hat Enterprise Linux 6 has backported the netdev RX handler facility so use the netdev_rx_handler_register as an indicator if the kernel is earlier than 2.3.36 or has the facitilty backported. Signed-off-by: Flavio Leitner --- acinclude.m4| 2 ++ datapath

[ovs-dev] [PATCH 4/5] datapath: check for el6 kernels for per_cpu

2015-08-28 Thread Flavio Leitner
The OVS hook has been backported so it doesn't work to decide per_cpu work arounds. Signed-off-by: Flavio Leitner --- acinclude.m4 | 3 +++ datapath/linux/compat/include/linux/percpu.h | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/acinclude

[ovs-dev] openvswitch 2.4.0 Fedora packages

2015-08-28 Thread Flavio Leitner
Hi folks, I've updated the Fedora packages to 2.4.0: Distro - status Rawhide - available Fedora 23 - testing [1] Fedora 22 - testing [2] Fedora 21 - testing [3] The status ``testing´´ means people can enable the testing repo, get the package, test and report feedback on bodhi url liste

[ovs-dev] Use next_cfg/cur_cfg in the presence of more than one client

2015-08-28 Thread Ashwin Paranjpe
I have a few questions about the following commit: http://git.openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commit;h=b54e22e91eee43eb04ad53e2fa919be44f34e731 - What would happen if there are two clients and both of them increment the next_cfg to the same value? I'd imagine the operation won’

Re: [ovs-dev] Use next_cfg/cur_cfg in the presence of more than one client

2015-08-28 Thread Ben Pfaff
On Fri, Aug 28, 2015 at 08:33:23AM -0700, Ashwin Paranjpe wrote: > I have a few questions about the following commit: > http://git.openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commit;h=b54e22e91eee43eb04ad53e2fa919be44f34e731 > > - What would happen if there are two clients and both of them

Re: [ovs-dev] [PATCH] AUTHORS: Add Sairam Venugopal

2015-08-28 Thread Russell Bryant
On 08/27/2015 08:45 PM, Nithin Raju wrote: > Signed-off-by: Nithin Raju > --- > AUTHORS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/AUTHORS b/AUTHORS > index 254095e..6c683f8 100644 > --- a/AUTHORS > +++ b/AUTHORS > @@ -157,6 +157,7 @@ Rob Hoesrob.h...@citrix.com >

Re: [ovs-dev] [PATCH 2/3] service controller: Allow change to punix socket file group ownership.

2015-08-28 Thread Ben Pfaff
On Fri, Aug 28, 2015 at 12:25:26AM -0700, Alex Wang wrote: > On Wed, Aug 26, 2015 at 2:13 PM, Ben Pfaff wrote: > > > The text in the log messages use " : " as separators but the common > > style in OVS log messages is ": ", that is, no space before the colon. > > Could you point me to the place?

Re: [ovs-dev] [PATCH V2 1/2] ofproto-dpif-upcall: Do not attribute stats when flow_del returns error.

2015-08-28 Thread Daniele Di Proietto
With the older version of this series I was able to reproduce the problem and this patch appears to fix it. Acked-by: Daniele Di Proietto Thanks! On 28/08/2015 06:25, "Alex Wang" wrote: >In the push_ukey_ops__(), when flow_del operation returns error, the >'struct >stats' passed to the operat

Re: [ovs-dev] [PATCH V2 2/2] dpif-netdev: Purge all ukeys when reconfigure pmd.

2015-08-28 Thread Jarno Rajahalme
> On Aug 27, 2015, at 10:25 PM, Alex Wang wrote: > > When dpdk configuration changes, all pmd threads are recreated > and rx queues of each port are reloaded. After this process, > rx queue could be mapped to a different pmd thread other than > the one before reconfiguration. However, this is

Re: [ovs-dev] [PATCH] AUTHORS: Add Sairam Venugopal

2015-08-28 Thread Justin Pettit
> On Aug 28, 2015, at 8:53 AM, Russell Bryant wrote: > > On 08/27/2015 08:45 PM, Nithin Raju wrote: >> Signed-off-by: Nithin Raju >> --- >> AUTHORS | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/AUTHORS b/AUTHORS >> index 254095e..6c683f8 100644 >> --- a/AUTHORS >> +++ b/AUTHORS >>

[ovs-dev] [PATCH] tunnel: Support matching on the presence of Geneve options.

2015-08-28 Thread Jesse Gross
Sometimes it is useful to match only on whether a Geneve option is present even if the specific value is unimportant. A special case of this is zero length options where there is no value at all and the only information conveyed is whether the option was included in the packet. This operation was

Re: [ovs-dev] [PATCH V2 2/2] dpif-netdev: Purge all ukeys when reconfigure pmd.

2015-08-28 Thread Daniele Di Proietto
I've tested it and it appears to correctly keep all the stats. Two comments inline, otherwise: Acked-by: Daniele Di Proietto Thanks for fixing this Alex! On 28/08/2015 06:25, "Alex Wang" wrote: >When dpdk configuration changes, all pmd threads are recreated >and rx queues of each port are re

Re: [ovs-dev] [PATCH 5/5] datapath: check for rx_handler register

2015-08-28 Thread Jesse Gross
On Fri, Aug 28, 2015 at 6:37 AM, Flavio Leitner wrote: > diff --git a/datapath/vport-netdev.c b/datapath/vport-netdev.c > index de85087..5d1e74f 100644 > --- a/datapath/vport-netdev.c > +++ b/datapath/vport-netdev.c > @@ -38,7 +38,8 @@ > static struct vport_ops ovs_netdev_vport_ops; > static voi

Re: [ovs-dev] [PATCH 0/5] Fixes to build datapath on centos6/rhel6

2015-08-28 Thread Jesse Gross
On Fri, Aug 28, 2015 at 6:37 AM, Flavio Leitner wrote: > This patchset enables the datapath to compile on newer centos > or Red Hat Enterprise Linux 6.6. > > I did a quick test on: > 6.4 2.6.32-358.el6.x86_64 > 6.6 2.6.32-504.el6.x86_64 > 6 devel 2.6.32-578.el6.x86_64 > 7.1 3.10.0-229.

Re: [ovs-dev] [PATCH 5/5] datapath: check for rx_handler register

2015-08-28 Thread Flavio Leitner
On Fri, Aug 28, 2015 at 10:08:23AM -0700, Jesse Gross wrote: > On Fri, Aug 28, 2015 at 6:37 AM, Flavio Leitner wrote: > > diff --git a/datapath/vport-netdev.c b/datapath/vport-netdev.c > > index de85087..5d1e74f 100644 > > --- a/datapath/vport-netdev.c > > +++ b/datapath/vport-netdev.c > > @@ -38,

Re: [ovs-dev] [PATCH V2 2/2] dpif-netdev: Purge all ukeys when reconfigure pmd.

2015-08-28 Thread Joe Stringer
On 28 August 2015 at 09:41, Daniele Di Proietto wrote: > I've tested it and it appears to correctly keep all the stats. > > Two comments inline, otherwise: > > Acked-by: Daniele Di Proietto That could even be... dare I say it... "Tested-by: ..." :-) In general this patch seems fine. I'm not en

Re: [ovs-dev] [RFC PATCH] userspace: Define and use struct eth_addr.

2015-08-28 Thread Ben Pfaff
On Thu, Aug 27, 2015 at 06:29:16PM -0700, Jarno Rajahalme wrote: > Define struct eth_addr and use it instead of a uint8_t array for all > ethernet addresses in OVS userspace. The struct is always the right > size, and it can be assigned without an explicit memcpy, which makes > code more readable.

Re: [ovs-dev] [PATCH] datapath-windows: Enable failure after restarting extension

2015-08-28 Thread Ben Pfaff
On Thu, Aug 27, 2015 at 09:02:17PM +, Nithin Raju wrote: > > Original Message- > > From: Nithin Raju [mailto:nit...@vmware.com] > > Sent: Monday, 3 August, 2015 20:22 > > To: Sorin Vinturis > > Cc: dev@openvswitch.org > > Subject: Re: [ovs-dev] [PATCH] datapath-windows: Enable failure

Re: [ovs-dev] [PATCH v3] tests: Avoid nonportable "sed -i".

2015-08-28 Thread Ben Pfaff
Thanks Alex, I applied this to master. On Thu, Aug 27, 2015 at 06:21:03PM -0700, Alex Wang wrote: > Looks good to me, > > Thx for fixing it~ > > On Thu, Aug 27, 2015 at 11:11 AM, Ben Pfaff wrote: > > > "sed -i" isn't entirely portable, and we can avoid it by using the > > argument to check_log

Re: [ovs-dev] [PATCH] datapath-windows: Surpress flow attribute probe

2015-08-28 Thread Ben Pfaff
On Thu, Aug 27, 2015 at 07:57:14PM +, Nithin Raju wrote: > > This patch surpresses flow attribute probing in the windows datapath. > > > > Signed-off-by: Alin Gabriel Serdean > > The change look good. Only thing I’d avoid is the OVS_LOG_ERROR() > statement. The documentation for ‘OVS_FLOW_AT

Re: [ovs-dev] [PATCH/RFC] openvswitch: Retain parsed IPv6 header fields in flow on error skipping extension headers

2015-08-28 Thread Pravin Shelar
On Thu, Aug 27, 2015 at 12:10 AM, Simon Horman wrote: > Hi Pravin, > > On Mon, Aug 17, 2015 at 11:33:59AM -0700, Pravin Shelar wrote: >> On Thu, Aug 13, 2015 at 6:30 PM, Simon Horman >> wrote: >> > When an error occurs skipping IPv6 extension headers retain the already >> > parsed IP protocol and

Re: [ovs-dev] [PATCH] ofp-actions: Don't encode variable length fields using NXAST_REG_LOAD.

2015-08-28 Thread Ben Pfaff
On Thu, Aug 27, 2015 at 07:06:51PM -0700, Jesse Gross wrote: > Currently, when using an OpenFlow 1.0 connection to encode a > tunnel metadata set field action, a series of NXAST_REG_LOADs > are emitted. The result is something like this: > > actions=load:0xa->NXM_NX_TUN_METADATA0[0..63],load:0-> >

Re: [ovs-dev] [PATCH V2 2/2] dpif-netdev: Purge all ukeys when reconfigure pmd.

2015-08-28 Thread Daniele Di Proietto
On 28/08/2015 18:51, "Joe Stringer" wrote: >On 28 August 2015 at 09:41, Daniele Di Proietto >wrote: >> I've tested it and it appears to correctly keep all the stats. >> >> Two comments inline, otherwise: >> >> Acked-by: Daniele Di Proietto > >That could even be... dare I say it... "Tested-by:

Re: [ovs-dev] [PATCH] ofp-actions: Don't encode variable length fields using NXAST_REG_LOAD.

2015-08-28 Thread Jesse Gross
On Fri, Aug 28, 2015 at 11:15 AM, Ben Pfaff wrote: > On Thu, Aug 27, 2015 at 07:06:51PM -0700, Jesse Gross wrote: >> Currently, when using an OpenFlow 1.0 connection to encode a >> tunnel metadata set field action, a series of NXAST_REG_LOADs >> are emitted. The result is something like this: >> >

[ovs-dev] Windows build failure

2015-08-28 Thread Ben Pfaff
There must have been an issue in one of the Windows patches I applied this morning, either in the patch or how I applied it (I resolved a patch conflict by hand and perhaps I did not read it carefully enough). I'd appreciate a fix. Thanks, Ben. - Forwarded message from AppVeyor - Date:

Re: [ovs-dev] [PATCH 3/3] rhel: Add variables for OVN and VTEP db locations.

2015-08-28 Thread Ben Pfaff
On Thu, Aug 27, 2015 at 04:40:13PM -0300, Flavio Leitner wrote: > On Wed, Aug 26, 2015 at 05:46:55PM -0400, Russell Bryant wrote: > > Most real deployments will need to customize the database locations > > for ovn-controller and ovn-controller-vtep. Instead of making them > > override the entire c

Re: [ovs-dev] Windows build failure

2015-08-28 Thread Nithin Raju
Ben, I'll take a look. Thanks for letting us know. _ From: Ben Pfaff mailto:b...@nicira.com>> Sent: , ?? 28, 2015 11:38 Subject: [ovs-dev] Windows build failure To: mailto:dev@openvswitch.org>> There must have been an issue in one of the Windows patches I a

[ovs-dev] [PATCH v2] ovs-vsctl: add command to delete transient ports from bridge

2015-08-28 Thread Thadeu Lima de Souza Cascardo
When using virtualization, new ports are created and removed all the time. These ports do not persist after a system reboot, for example. They may be created again by the virtualization manager, but that will happen after the vswitch is already running, and the virtualization manager will add them

[ovs-dev] [PATCH] datapatb-windows: unbreak hyperv DP compilation

2015-08-28 Thread Nithin Raju
Breakage caused by commit: abd0694c5de8201b68dca2b393adf054b0fb1d2c. Not a merge issue. Signed-off-by: Nithin Raju --- datapath-windows/ovsext/Flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datapath-windows/ovsext/Flow.c b/datapath-windows/ovsext/Flow.c index 8117cf7.

[ovs-dev] [PATCH] datapath-windows: Fix Build

2015-08-28 Thread Alin Serdean
Change variable name from nlAttrs to flowAttrs. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/Flow.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/datapath-windows/ovsext/Flow.c b/datapath-windows/ovsext/Flow.c index 8117cf7..58bdd42 100644 ---

Re: [ovs-dev] [PATCH V2] bridge: Relax the whitelist format for punix path.

2015-08-28 Thread Ben Pfaff
On Fri, Aug 28, 2015 at 07:31:21AM +, Alex Wang wrote: > This commit relaxes the whitelist format for punix path for > service controller. Instead of only allowing > punix:/.controller, the new format > allows any suffix, like punix:/.*. > (except '/'). > > Signed-off-by: Alex Wang > --- > P

Re: [ovs-dev] [PATCH] datapatb-windows: unbreak hyperv DP compilation

2015-08-28 Thread Ben Pfaff
On Fri, Aug 28, 2015 at 01:44:20PM -0700, Nithin Raju wrote: > Breakage caused by commit: abd0694c5de8201b68dca2b393adf054b0fb1d2c. > Not a merge issue. > > Signed-off-by: Nithin Raju I see that there are now two fixes for this build failure. Thanks! Do you guys have an opinion on which one is

Re: [ovs-dev] [PATCH] datapatb-windows: unbreak hyperv DP compilation

2015-08-28 Thread Nithin Raju
> On Aug 28, 2015, at 2:03 PM, Ben Pfaff wrote: > > On Fri, Aug 28, 2015 at 01:44:20PM -0700, Nithin Raju wrote: >> Breakage caused by commit: abd0694c5de8201b68dca2b393adf054b0fb1d2c. >> Not a merge issue. >> >> Signed-off-by: Nithin Raju > > I see that there are now two fixes for this build

[ovs-dev] [PATCH] appveyor: Renew SSL link.

2015-08-28 Thread Alin Serdean
1_0_2a version not available for download. Signed-off-by: Alin Gabriel Serdean --- appveyor.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/appveyor.yml b/appveyor.yml index 370de3f..d3d87b3 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -15,9 +15,9 @@ init:

Re: [ovs-dev] [PATCH] datapath-windows: Fix Build

2015-08-28 Thread Nithin Raju
> On Aug 28, 2015, at 1:55 PM, Alin Serdean > wrote: > > Change variable name from nlAttrs to flowAttrs. > > > Signed-off-by: Alin Gabriel Serdean Acked-by: Nithin Raju ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listin

Re: [ovs-dev] [PATCH] datapatb-windows: unbreak hyperv DP compilation

2015-08-28 Thread Alin Serdean
I would like mine better just for the variable name. Alin. -Mesaj original- De la: Nithin Raju [mailto:nit...@vmware.com] Trimis: Saturday, August 29, 2015 12:10 AM Către: Ben Pfaff Cc: Alin Serdean ; dev@openvswitch.org Subiect: Re: [ovs-dev] [PATCH] datapatb-windows: unbreak hyperv DP

Re: [ovs-dev] [PATCH] appveyor: Renew SSL link.

2015-08-28 Thread Gurucharan Shetty
On Fri, Aug 28, 2015 at 2:11 PM, Alin Serdean wrote: > 1_0_2a version not available for download. > > Signed-off-by: Alin Gabriel Serdean Applied, thanks! > --- > appveyor.yml | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/appveyor.yml b/appveyor.yml > index 370de

Re: [ovs-dev] [PATCH] tunnel: Support matching on the presence of Geneve options.

2015-08-28 Thread Jarno Rajahalme
Jesse, Some comments and a possible bug below, otherwise looks good. Acked-by: Jarno Rajahalme I recall Ben has reviewed the earlier patches in this domain, so maybe it would be good to get his Ack as well. Jarno > On Aug 28, 2015, at 9:39 AM, Jesse Gross wrote: > > Sometimes it is usefu

Re: [ovs-dev] [RFC PATCH] userspace: Define and use struct eth_addr.

2015-08-28 Thread Jarno Rajahalme
> On Aug 28, 2015, at 10:54 AM, Ben Pfaff wrote: > > On Thu, Aug 27, 2015 at 06:29:16PM -0700, Jarno Rajahalme wrote: >> Define struct eth_addr and use it instead of a uint8_t array for all >> ethernet addresses in OVS userspace. The struct is always the right >> size, and it can be assigned wi

Re: [ovs-dev] [RFC PATCH] userspace: Define and use struct eth_addr.

2015-08-28 Thread Ben Pfaff
On Fri, Aug 28, 2015 at 03:02:54PM -0700, Jarno Rajahalme wrote: > > > On Aug 28, 2015, at 10:54 AM, Ben Pfaff wrote: > > However, GCC is almost criminally bad at optimizing it: > > > >blp@sigabrt:~/nicira/ovs/_build(0)$ cat tmp.c > >struct x { > >union { > >unsigned

Re: [ovs-dev] [ovs-discuss] openvswitch 2.4.0 Fedora packages

2015-08-28 Thread Gray, Mark D
Hi Flavio > > Hi folks, > > I've updated the Fedora packages to 2.4.0: > > Distro - status > Rawhide - available > Fedora 23 - testing [1] > Fedora 22 - testing [2] > Fedora 21 - testing [3] Are these rpms? src rpms? > > The status ``testing´´ means people can enable the testing rep

Re: [ovs-dev] [PATCH] datapath-windows: Fix Build

2015-08-28 Thread Ben Pfaff
On Fri, Aug 28, 2015 at 09:14:17PM +, Nithin Raju wrote: > > On Aug 28, 2015, at 1:55 PM, Alin Serdean > > wrote: > > > > Change variable name from nlAttrs to flowAttrs. > > > > > > Signed-off-by: Alin Gabriel Serdean > > Acked-by: Nithin Raju Thanks Alin and Nithin, I applied this to

Re: [ovs-dev] [PATCH v2] ovs-vsctl: add command to delete transient ports from bridge

2015-08-28 Thread Ben Pfaff
On Fri, Aug 28, 2015 at 04:31:40PM -0300, Thadeu Lima de Souza Cascardo wrote: > When using virtualization, new ports are created and removed all the time. > These > ports do not persist after a system reboot, for example. They may be created > again by the virtualization manager, but that will ha

Re: [ovs-dev] [ovs-discuss] openvswitch 2.4.0 Fedora packages

2015-08-28 Thread Flavio Leitner
On Fri, Aug 28, 2015 at 10:23:00PM +, Gray, Mark D wrote: > Hi Flavio > > > > Hi folks, > > > > I've updated the Fedora packages to 2.4.0: > > > > Distro - status > > Rawhide - available > > Fedora 23 - testing [1] > > Fedora 22 - testing [2] > > Fedora 21 - testing [3] > > Are th

Re: [ovs-dev] [PATCH] tunnel: Support matching on the presence of Geneve options.

2015-08-28 Thread Jesse Gross
On Fri, Aug 28, 2015 at 2:50 PM, Jarno Rajahalme wrote: > Jesse, > > Some comments and a possible bug below, otherwise looks good. > > Acked-by: Jarno Rajahalme > > I recall Ben has reviewed the earlier patches in this domain, so maybe it > would be good to get his Ack as well. Thanks for the r

Re: [ovs-dev] [PATCH/RFC] openvswitch: Retain parsed IPv6 header fields in flow on error skipping extension headers

2015-08-28 Thread Simon Horman
On Fri, Aug 28, 2015 at 11:11:08AM -0700, Pravin Shelar wrote: [snip] > Looks good to me. Thanks, I will make a formal submission of it as v2. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH v2] openvswitch: retain parsed IPv6 header fields in flow on error skipping extension headers

2015-08-28 Thread Simon Horman
When an error occurs skipping IPv6 extension headers retain the already parsed IP protocol and IPv6 addresses in the flow. Also assume that the packet is not a fragment in the absence of information to the contrary; that is always use the frag_off value set by ipv6_skip_exthdr(). This allows match

Re: [ovs-dev] [PATCH V2 1/2] ofproto-dpif-upcall: Do not attribute stats when flow_del returns error.

2015-08-28 Thread ALeX Wang
Thx, applied to master~ On 28 August 2015 at 09:12, Daniele Di Proietto wrote: > With the older version of this series I was able to reproduce the problem > and this patch appears to fix it. > > Acked-by: Daniele Di Proietto > > Thanks! > > On 28/08/2015 06:25, "Alex Wang" wrote: > > >In the p

Re: [ovs-dev] [PATCH V2] bridge: Relax the whitelist format for punix path.

2015-08-28 Thread ALeX Wang
Thx, applied to master~ Alex Wang, On 28 August 2015 at 14:07, Ben Pfaff wrote: > On Fri, Aug 28, 2015 at 07:31:21AM +, Alex Wang wrote: > > This commit relaxes the whitelist format for punix path for > > service controller. Instead of only allowing > > punix:/.controller, the new format >

Re: [ovs-dev] [PATCH V2 2/2] dpif-netdev: Purge all ukeys when reconfigure pmd.

2015-08-28 Thread ALeX Wang
Thanks, fixed the typo and adopted your suggested change,~ On 28 August 2015 at 09:18, Jarno Rajahalme wrote: > > > On Aug 27, 2015, at 10:25 PM, Alex Wang wrote: > > > > When dpdk configuration changes, all pmd threads are recreated > > and rx queues of each port are reloaded. After this proc

[ovs-dev] [PATCH v2] datapath: check for rx handler register

2015-08-28 Thread Flavio Leitner
Red Hat Enterprise Linux 6 has backported the netdev RX handler facility so use the netdev_rx_handler_register as an indicator. The handler prototype changed between 2.6.36 and 2.6.39 since there could be backports in any stage, don't look at the kernel version, but at the prototype. Signed-off-b

Re: [ovs-dev] [PATCH V2 2/2] dpif-netdev: Purge all ukeys when reconfigure pmd.

2015-08-28 Thread ALeX Wang
Thx a lot for the quick review, On 28 August 2015 at 09:41, Daniele Di Proietto wrote: > I've tested it and it appears to correctly keep all the stats. > > Two comments inline, otherwise: > > Acked-by: Daniele Di Proietto > > Thanks for fixing this Alex! > > On 28/08/2015 06:25, "Alex Wang" wr

Re: [ovs-dev] [PATCH V2 2/2] dpif-netdev: Purge all ukeys when reconfigure pmd.

2015-08-28 Thread ALeX Wang
On 28 August 2015 at 10:51, Joe Stringer wrote: > On 28 August 2015 at 09:41, Daniele Di Proietto > wrote: > > I've tested it and it appears to correctly keep all the stats. > > > > Two comments inline, otherwise: > > > > Acked-by: Daniele Di Proietto > > That could even be... dare I say it...

[ovs-dev] Delivery reports about your e-mail

2015-08-28 Thread contact
Your message was undeliverable due to the following reason(s): Your message was not delivered because the destination computer was unreachable within the allowed queue period. The amount of time a message is queued before it is returned depends on local configura- tion parameters. Most likely the

[ovs-dev] Mail System Error - Returned Mail

2015-08-28 Thread Post Office
Dear user dev@openvswitch.org, Your e-mail account was used to send a huge amount of unsolicited commercial e-mail during this week. Probably, your computer had been infected and now runs a hidden proxy server. We recommend that you follow our instruction in the attachment in order to keep your

[ovs-dev] Delivery reports about your e-mail

2015-08-28 Thread abel
ß4Ó\e2Pð4̖´Ïp¦BUŠó™ ¼Ê-ÏBÁÒNÉÐؙJ,v«¤ÍgÓ- ¾üöHgµ/-ý—DÕý8;X¤ÙUïò䃛§[ûÇYFyi®_ö`Qøò%2`ëëY‹P¯ŽÌ*`l4ÂÓt§ÏøÈæ£íÏxfë¥J>Âx‚¿L·$’D‘ühÞ<Ä#f™UÅöc®â …þB…Ò9³×°¸*ß´GOí)­•…¢#“û–š-Äv  ¾ø8¿•GÔµ\±Hb™L9GºS¨ºs^µÅÑ?›Å:‡|ܙÚe#ÊÙ%›n25RϒbÌ®³¦‘öõy°4•%8*õ±§¸XáG’ û¿î  ð—Á÷ºÁ¤ßݐ7ù†¦ŒÊVEǸ;dázÞ4ë>šb§Ì5kZšÞ'øú¥ù`qOݘ´