[ovs-dev] Returned mail: see transcript for details

The original message was received at Wed, 12 Aug 2015 15:58:59 +0800 from [77.200.136.166] - The following addresses had permanent fatal errors - dev@openvswitch.org - Transcript of session follows - ... while talking to openvswitch.org.: >>> MAIL FROM:"Mail Administrator" <<< 5

Re: [ovs-dev] [PATCH 1/2] dpif-netdev: Purge all ukeys when reconfigure pmd.

Ok, but why don't just put dp->dp_purge_cb(dp->dp_purge_aux) right after dp_netdev_destroy_all_pmds(dp) in dpif_netdev_pmd_set() ? In that case, disabling of upcalls will not be necessary. P.S. The second letter of my name is 'L'. On 11.08.2015 21:06, Alex Wang wrote: > Thx, IIya for the review,

[ovs-dev] [PATCH V1 Resend 10/10] net: Drop unlikely before IS_ERR(_OR_NULL)

IS_ERR(_OR_NULL) already contain an 'unlikely' compiler flag and there is no need to do that again from its callers. Drop it. Acked-by: Neil Horman Signed-off-by: Viresh Kumar --- net/openvswitch/datapath.c | 2 +- net/sctp/socket.c | 2 +- net/socket.c | 6 +++--- 3 file

Re: [ovs-dev] [PATCH RFC] coverage: fix coverage accounting for pmd threads

I agree, that this solution is much more simple, but I don't like this race for coverage_mutex. Why this all done so? I mean, why we should run coverage_clear every second? What if we change type of thread_local unsigned int counter_##COUNTER from unsigned int to unsigned long long and will call

Re: [ovs-dev] [PATCH] netdev-dpdk: Add some missing statistics.

Hi, From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Puha, TimoX > From: Weglicki, MichalX > > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Daniele Di > Proietto > > >Do you know how much it is going to impact the vhost throughput? Other than > > this the change looks goo

Re: [ovs-dev] [PATCH 1/2] dpif-netdev: Purge all ukeys when reconfigure pmd.

On Wed, Aug 12, 2015 at 1:10 AM, Ilya Maximets wrote: > Ok, but why don't just put dp->dp_purge_cb(dp->dp_purge_aux) right after > dp_netdev_destroy_all_pmds(dp) in dpif_netdev_pmd_set() ? In that case, > disabling of upcalls will not be necessary. > > Hey Ilya, Calling it before 'dp_netdev_dest

Re: [ovs-dev] [PATCH RFC] coverage: fix coverage accounting for pmd threads

Hey Ilya, Thanks for the reply please see my comments inline, Thanks, Alex Wang, On Wed, Aug 12, 2015 at 4:19 AM, Ilya Maximets wrote: > I agree, that this solution is much more simple, but I don't like this > race for > coverage_mutex. > Why this all done so? > Before implementing pmd thread

[ovs-dev] [PATCHv2 0/5] Extend system tests to include tunnel test.

Add various minor fixups and improvements to the system tests, and a basic tunnel sanity test for vxlan. v2: Applied one patch Tested series on Ubuntu 14.04.2 Better detection of tool support for tunnels Joe Stringer (5): system-common-macros: Allow quotes in NS_EXEC(). system-traffic

[ovs-dev] [PATCHv2 1/5] system-common-macros: Allow quotes in NS_EXEC().

This allows arbitrary commands to be passed into the NS_EXEC macro to be executed within a namespace, including commands that have quotes and commands chained together. Signed-off-by: Joe Stringer --- Daniele, thanks for the suggestion, this seems to work pretty well. My only complaint is that th

[ovs-dev] [PATCHv2 4/5] system-macros: Don't explicitly remove bridge.

Depending on the kernel in use, manually removing a bridge during OVS_VSWITCHD_STOP can cause the kernel to send a route update that refers to the bridge device which is being deleted. OVS can't make sense of these messages, resulting in logs like the following: route_table|DBG|Could not find inte

[ovs-dev] [PATCHv2 3/5] system-macros: Create ADD_BR variant.

This patch splits ADD_BR into two commands, so they can be used from different contexts: ADD_BR(...) is a standalone command to add a bridge to OVS, and allows additional ovs-vsctl arguments to be passed. It uses _ADD_BR(). _ADD_BR(...) is the implementation-specific ovs-vsctl arguments to set up

[ovs-dev] [PATCHv2 5/5] kmod-traffic: Add basic vxlan tunnel sanity test.

This test is skipped if the 'ip' command cannot interpret the vxlan 'dstport' option; this is used as a proxy for detecting native kernel support for this tunnel type. Signed-off-by: Joe Stringer --- This initial sanity test uses a linux device tunnel in combination with an OVS-based tunnel, so I

[ovs-dev] [PATCHv2 2/5] system-traffic: Check ping-by-ping output.

Rather than saving all of the ping output to a file then checking at the end, check each ping and fail as soon as there is a connectivity failure. Signed-off-by: Joe Stringer --- tests/system-common-macros.at | 6 ++ tests/system-traffic.at | 44 ---

Re: [ovs-dev] [PATCH v4 5/9] classifier: Remove unused hash functions.

On 7 August 2015 at 16:57, Jarno Rajahalme wrote: > Remove unused cls_rule_hash() and minimatch_hash() functions. > > Signed-off-by: Jarno Rajahalme Acked-by: Joe Stringer ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinf

Re: [ovs-dev] [PATCH v4 6/9] classifier: Do not use mf_value.

On 7 August 2015 at 16:57, Jarno Rajahalme wrote: > mf_value has grown bigger than needed for storing the biggest > supported prefix (IPv6 address length). Define a new type to be used > instead of mf_value. > > This makes classifier lookups a bit faster. > > Signed-off-by: Jarno Rajahalme > ---

Re: [ovs-dev] [PATCH v4 7/9] classifier: Simplify minimask_hash().

On 7 August 2015 at 16:57, Jarno Rajahalme wrote: > minimask_hash() can be simplified as each value is known to be non-zero. > > Move miniflow_hash() into test-classifier.c as miniflow_hash__() as it > is no longer needed elsewhere. > > Signed-off-by: Jarno Rajahalme Acked-by: Joe Stringer

Re: [ovs-dev] [PATCH v4 1/9] classifier: Fix comment.

On 7 August 2015 at 16:57, Jarno Rajahalme wrote: > Signed-off-by: Jarno Rajahalme Acked-by: Joe Stringer ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] Status of Open vSwitch with DPDK

There has been some discussion lately about the status of the Open vSwitch port to DPDK. While part of the code has been tested for quite some time, I think we can agree that there are a few rough spots that prevent it from being easily deployed and used. I was hoping to get some feedback from th

Re: [ovs-dev] [PATCH v4 2/9] flow: Avoid compile errors.

On 7 August 2015 at 16:57, Jarno Rajahalme wrote: > GCC (4.7) sees too wide shifts when there are none, refactor to > circumvent the false error. > > Signed-off-by: Jarno Rajahalme > --- > lib/flow.c | 35 ++- > 1 file changed, 22 insertions(+), 13 deletions(-) >

[ovs-dev] [PATCH v2] ovn: Add lflow-list to ovn-sbctl.

I frequently view the contents of the Logical_Flow table while working on OVN. Add a command that can output the contents of this table in a sorted way that makes it easier to read through. It's sorted by logical datapath, pipeline, table id, priority, and match. Signed-off-by: Russell Bryant -

Re: [ovs-dev] [PATCH v2 1/2] upcall: Fix minor race when deleting ukeys.

Ah, that's a good point I had missed. I think the logic is fine as is then. I think I'll add a comment to that affect at the beginning of the function. Ethan On Tue, Aug 11, 2015 at 1:51 PM, Joe Stringer wrote: > FWIW the "slice" logic in the for loop is meant to ensure that no > revalidator t

Re: [ovs-dev] [PATCH v2] ovn: Add lflow-list to ovn-sbctl.

Thx a lot for the refinement, Minor comments below, On Wed, Aug 12, 2015 at 3:04 PM, Russell Bryant wrote: > I frequently view the contents of the Logical_Flow table while working > on OVN. Add a command that can output the contents of this table in a > sorted way that makes it easier to read

[ovs-dev] [PATCH v3 1/2] ofproto-dpif-upcall: Make ukey actions modifiable with RCU.

From: Ethan Jackson Future patches will need to modify ukey actions in some instances. This patch makes this possible by protecting them with RCU. It also adds thread safety checks to enforce the new protection mechanism. Signed-off-by: Ethan J. Jackson --- ofproto/ofproto-dpif-upcall.c | 47

[ovs-dev] [PATCH v3 2/2] ofproto: Allow in-place modifications of datapath flows.

From: Ethan Jackson There are certain use cases (such as bond rebalancing) where a datapath flow's actions may change, while it's wildcard pattern remains the same. Before this patch, revalidators would note the change, delete the flow, and wait for the handlers to install an updated version. T

Re: [ovs-dev] [PATCH v2] ovn: Add lflow-list to ovn-sbctl.

On 08/12/2015 06:51 PM, Alex Wang wrote: > Thx a lot for the refinement, > > Minor comments below, > > > On Wed, Aug 12, 2015 at 3:04 PM, Russell Bryant > wrote: > > I frequently view the contents of the Logical_Flow table while working > on OVN. Add a comma

[ovs-dev] [PATCH v3] ovn: Add lflow-list to ovn-sbctl.

I frequently view the contents of the Logical_Flow table while working on OVN. Add a command that can output the contents of this table in a sorted way that makes it easier to read through. It's sorted by logical datapath, pipeline, table id, priority, and match. Signed-off-by: Russell Bryant -

Re: [ovs-dev] [PATCH v4 1/9] classifier: Fix comment.

Pushed to master, Jarno > On Aug 12, 2015, at 2:33 PM, Joe Stringer wrote: > > On 7 August 2015 at 16:57, Jarno Rajahalme wrote: >> Signed-off-by: Jarno Rajahalme > > Acked-by: Joe Stringer ___ dev mailing list dev@openvswitch.org http://openvs

Re: [ovs-dev] [PATCH v4 2/9] flow: Avoid compile errors.

> On Aug 12, 2015, at 2:38 PM, Joe Stringer wrote: > > On 7 August 2015 at 16:57, Jarno Rajahalme > wrote: >> GCC (4.7) sees too wide shifts when there are none, refactor to >> circumvent the false error. >> >> Signed-off-by: Jarno Rajahalme >> --- >> lib/flow.c

Re: [ovs-dev] [PATCH v4 7/9] classifier: Simplify minimask_hash().

Thanks for the review! Pushed to master, Jarno > On Aug 12, 2015, at 2:32 PM, Joe Stringer wrote: > > On 7 August 2015 at 16:57, Jarno Rajahalme wrote: >> minimask_hash() can be simplified as each value is known to be non-zero. >> >> Move miniflow_hash() into test-classifier.c as miniflow_

Re: [ovs-dev] [PATCH v4 5/9] classifier: Remove unused hash functions.

Thanks for the review, pushed to master, Jarno > On Aug 12, 2015, at 2:12 PM, Joe Stringer wrote: > > On 7 August 2015 at 16:57, Jarno Rajahalme wrote: >> Remove unused cls_rule_hash() and minimatch_hash() functions. >> >> Signed-off-by: Jarno Rajahalme > > Acked-by: Joe Stringer __

Re: [ovs-dev] [PATCH v4 6/9] classifier: Do not use mf_value.

> On Aug 12, 2015, at 2:18 PM, Joe Stringer wrote: > > On 7 August 2015 at 16:57, Jarno Rajahalme > wrote: >> mf_value has grown bigger than needed for storing the biggest >> supported prefix (IPv6 address length). Define a new type to be used >> instead of mf_val

Re: [ovs-dev] [PATCH v4 6/9] classifier: Do not use mf_value.

On 12 August 2015 at 16:48, Jarno Rajahalme wrote: > > On Aug 12, 2015, at 2:18 PM, Joe Stringer wrote: > > On 7 August 2015 at 16:57, Jarno Rajahalme wrote: > > mf_value has grown bigger than needed for storing the biggest > supported prefix (IPv6 address length). Define a new type to be used

Re: [ovs-dev] [PATCH v3] ovn: Add lflow-list to ovn-sbctl.

Thx, applied to master~ On Wed, Aug 12, 2015 at 4:20 PM, Russell Bryant wrote: > I frequently view the contents of the Logical_Flow table while working > on OVN. Add a command that can output the contents of this table in a > sorted way that makes it easier to read through. It's sorted by > lo

Re: [ovs-dev] [PATCH v3 1/2] ofproto-dpif-upcall: Make ukey actions modifiable with RCU.

> On Aug 12, 2015, at 4:13 PM, Ethan J. Jackson wrote: > > From: Ethan Jackson > > Future patches will need to modify ukey actions in some instances. > This patch makes this possible by protecting them with RCU. It also > adds thread safety checks to enforce the new protection mechanism. > >

Re: [ovs-dev] [PATCH v4 6/9] classifier: Do not use mf_value.

> On Aug 12, 2015, at 4:51 PM, Joe Stringer wrote: > > On 12 August 2015 at 16:48, Jarno Rajahalme > wrote: >> >> On Aug 12, 2015, at 2:18 PM, Joe Stringer wrote: >> >> On 7 August 2015 at 16:57, Jarno Rajahalme wrote: >> >> mf_value has grown bigger than need

Re: [ovs-dev] [PATCH v3 2/2] ofproto: Allow in-place modifications of datapath flows.

This seems good to go for me, Jarno Acked-by: Jarno Rajahalme > On Aug 12, 2015, at 4:13 PM, Ethan J. Jackson wrote: > > From: Ethan Jackson > > There are certain use cases (such as bond rebalancing) where a > datapath flow's actions may change, while it's wildcard pattern > remains the s

[ovs-dev] [PATCH 2/2] ovn-sbctl: Print stage name in addition to table number.

Signed-off-by: Justin Pettit --- ovn/utilities/ovn-sbctl.c | 11 +++ 1 files changed, 7 insertions(+), 4 deletions(-) diff --git a/ovn/utilities/ovn-sbctl.c b/ovn/utilities/ovn-sbctl.c index 9976215..06bc0ca 100644 --- a/ovn/utilities/ovn-sbctl.c +++ b/ovn/utilities/ovn-sbctl.c @@ -481

[ovs-dev] [PATCH 1/2] ovn-northd: Store name of the logical flow stage in external-ids.

This will be useful in a future commit. It also introduces #define's for logical stages instead of in-place constants. Signed-off-by: Justin Pettit --- ovn/northd/ovn-northd.c | 86 -- ovn/ovn-sb.ovsschema|5 ++- ovn/ovn-sb.xml |

[ovs-dev] [PATCH v4 1/2] ofproto-dpif-upcall: Make ukey actions modifiable with RCU.

From: Ethan Jackson Future patches will need to modify ukey actions in some instances. This patch makes this possible by protecting them with RCU. It also adds thread safety checks to enforce the new protection mechanism. Signed-off-by: Ethan J. Jackson --- ofproto/ofproto-dpif-upcall.c | 42

Re: [ovs-dev] [PATCH v3 1/2] ofproto-dpif-upcall: Make ukey actions modifiable with RCU.

agreed, sent a new version. Ethan On Wed, Aug 12, 2015 at 5:01 PM, Jarno Rajahalme wrote: > >> On Aug 12, 2015, at 4:13 PM, Ethan J. Jackson wrote: >> >> From: Ethan Jackson >> >> Future patches will need to modify ukey actions in some instances. >> This patch makes this possible by protecting

[ovs-dev] [PATCH v4 2/2] ofproto: Allow in-place modifications of datapath flows.

From: Ethan Jackson There are certain use cases (such as bond rebalancing) where a datapath flow's actions may change, while it's wildcard pattern remains the same. Before this patch, revalidators would note the change, delete the flow, and wait for the handlers to install an updated version. T

[ovs-dev] Mail System Error - Returned Mail

Dear user dev@openvswitch.org, administration of openvswitch.org would like to inform you We have found that your account has been used to send a large amount of junk e-mail during this week. Most likely your computer had been infected by a recent virus and now contains a hidden proxy server.

[ovs-dev] [PATCH] db-ctl-base: Allow print rows that weak reference to table in 'cmd_show_table'.

Sometimes, it is desirable to print the table with weak reference to the table specified in 'struct cmd_show_table'. For example the Port_Binding table rows in OVN_Southbound database that refer to the same Chassis table row can be printed under the same chassis entry in 'ovn-sbctl show' output.

Re: [ovs-dev] [PATCH 2/2] ovn-sbctl: Print stage name in addition to table number.

Acked-by: Alex Wang On Wed, Aug 12, 2015 at 6:02 PM, Justin Pettit wrote: > Signed-off-by: Justin Pettit > --- > ovn/utilities/ovn-sbctl.c | 11 +++ > 1 files changed, 7 insertions(+), 4 deletions(-) > > diff --git a/ovn/utilities/ovn-sbctl.c b/ovn/utilities/ovn-sbctl.c > index 9976

Re: [ovs-dev] [PATCH 1/2] ovn-northd: Store name of the logical flow stage in external-ids.

Acked-by: Alex Wang On Wed, Aug 12, 2015 at 6:02 PM, Justin Pettit wrote: > This will be useful in a future commit. > > It also introduces #define's for logical stages instead of in-place > constants. > > Signed-off-by: Justin Pettit > --- > ovn/northd/ovn-northd.c | 86 > ++

Re: [ovs-dev] [PATCH] db-ctl-base: Allow print rows that weak reference to table in 'cmd_show_table'.

> On Aug 12, 2015, at 9:49 PM, Alex Wang wrote: > > diff --git a/lib/db-ctl-base.c b/lib/db-ctl-base.c > index 3028c09..cbafff1 100644 > --- a/lib/db-ctl-base.c > +++ b/lib/db-ctl-base.c > @@ -1620,6 +1620,12 @@ pre_cmd_show(struct ctl_context *ctx) > ovsdb_idl_add_column(ctx->id

Re: [ovs-dev] [PATCH 2/2] ovn-sbctl: Print stage name in addition to table number.

Thanks, Alex. I pushed the series. --Justin > On Aug 12, 2015, at 10:12 PM, Alex Wang wrote: > > Acked-by: Alex Wang > > On Wed, Aug 12, 2015 at 6:02 PM, Justin Pettit wrote: > Signed-off-by: Justin Pettit > --- > ovn/utilities/ovn-sbctl.c | 11 +++ > 1 files changed, 7 inserti

Re: [ovs-dev] [PATCH] db-ctl-base: Allow print rows that weak reference to table in 'cmd_show_table'.

I should have added that if you use the attached patch, you'll need to update the ovn-sbctl unit test you were nice enough to include in this patch. --Justin > On Aug 12, 2015, at 11:52 PM, Justin Pettit wrote: > > >> On Aug 12, 2015, at 9:49 PM, Alex Wang wrote: >> >> diff --git a/lib/db-