Re: [ovs-dev] [PATCH v2] dpif_probe_feature not suported in windows datapath

2015-07-11 Thread Ben Pfaff
What, don't the Windows developers run "make check" on their dev systems regularly? Does that mean we've had this in the tree for 2.4 for weeks and the Windows developers haven't fixed it? That makes me unhappy. I guess the problem must be that the patch disabled these features on every datapath

[ovs-dev] [PATCH] dpif-netlink: Suppress DPIF_FP_PROBE here instead of in ofproto-dpif.

2015-07-11 Thread Ben Pfaff
Commit 22b4ccf4f (ofproto-dpif: Don't try to use dpif_probe_feature() with Windows datapath.) stopped ofproto-dpif from trying to use the DPIF_FP_PROBE feature of the datapath interface, because it doesn't work with Windows yet. However, it was *too* broad--it also stopped ofproto-dpif from using

Re: [ovs-dev] [PATCH 2/2] CodingStyle: Remove designated initialzers as acceptable.

2015-07-11 Thread Ben Pfaff
On Fri, Jul 10, 2015 at 09:26:07PM -0700, Gurucharan Shetty wrote: > MSVC 2013 does not like designated initializers when > structs are initialized inside structs. > > Signed-off-by: Gurucharan Shetty Ugh. Acked-by: Ben Pfaff (Patch 1 looked OK too but I'm not really an expert on that code an

[ovs-dev] [PATCH] [OVN] Add QoS to NB schema

2015-07-11 Thread Gal Sagie
Add QoS profile and QoS rule tables and explanations to the NB schema. Add specific bandwidth limit rule configurations in the document Signed-off-by: Gal Sagie --- ovn/ovn-nb.ovsschema | 25 ++ ovn/ovn-nb.xml | 72 2 fil