Re: [ovs-dev] [PATCH] INSTALL.DPDK: remove experimental statement

2015-06-26 Thread Gray, Mark D
> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Thomas F > > On 6/25/15 12:39 PM, Flavio Leitner wrote: > > On Tue, Jun 23, 2015 at 06:48:20PM -0700, Pravin Shelar wrote: > >> On Tue, Jun 23, 2015 at 11:42 AM, Ben Pfaff wrote: > >>> Do you two have an opinion on this? If DPDK suppo

Re: [ovs-dev] [PATCH] dpif-netdev: Check for PKT_RX_RSS_HASH flag.

2015-06-26 Thread Traynor, Kevin
> -Original Message- > From: Daniele Di Proietto [mailto:diproiet...@vmware.com] > Sent: Wednesday, June 24, 2015 5:00 PM > To: Traynor, Kevin > Cc: dev@openvswitch.org; Flavio Leitner; Panu Matilainen; Jesse Gross; Pravin > Shelar > Subject: Re: [ovs-dev] [PATCH] dpif-netdev: Check for PK

Re: [ovs-dev] [PATCH v2] Do not flush tx queue which is shared among CPUs since it is always flushed

2015-06-26 Thread Gray, Mark D
> From: Pravin Shelar [mailto:pshe...@nicira.com] > > On Wed, Jun 17, 2015 at 3:17 AM, Gray, Mark D > wrote: > > > > > >> -Original Message- > >> From: Daniele Di Proietto [mailto:diproiet...@vmware.com] > >> Sent: Tuesday, June 16, 2015 6:45 PM > >> To: Pravin Shelar; Wei li; Gray, Mark

[ovs-dev] [ovn-controller-gw 0/4] Add ovn controller for VTEP enabled switch.

2015-06-26 Thread Alex Wang
This series adds a ovn controller, ovn-controller-gw, for VTEP enabled switch. The high level architecture is similar to the ovn-controller. Of course the module implementation is vtep specific. To be able to test the ovn-controller-gw in autotest, this series include the implementation of ovn-sb

[ovs-dev] [ovn-controller-gw 3/4] ovn-sbctl: Add ovn-sbctl.

2015-06-26 Thread Alex Wang
This commit adds ovn-sbctl to ovn family by using the db-ctl-base library. Signed-off-by: Alex Wang --- manpages.mk| 12 + ovn/.gitignore |2 + ovn/automake.mk|9 + ovn/ovn-sbctl.8.in | 159 ++ ovn/ovn-sbctl.c| 842 +

[ovs-dev] [ovn-controller-gw 2/4] ofproto-macros.at: Allow user to specify file to check in check_logs().

2015-06-26 Thread Alex Wang
Later commit will call check_logs() and specify ovn-northd.log as check_logs target. Signed-off-by: Alex Wang --- tests/ofproto-macros.at |9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/tests/ofproto-macros.at b/tests/ofproto-macros.at index 74b02b7..796b828 10064

[ovs-dev] [ovn-controller-gw 1/4] ovn: Add ovn/lib/libovn.sym to .gitignore.

2015-06-26 Thread Alex Wang
Signed-off-by: Alex Wang --- ovn/lib/.gitignore |1 + 1 file changed, 1 insertion(+) diff --git a/ovn/lib/.gitignore b/ovn/lib/.gitignore index 846df01..a80a1bc 100644 --- a/ovn/lib/.gitignore +++ b/ovn/lib/.gitignore @@ -1,3 +1,4 @@ +/libovn.sym /ovn-nb-idl.c /ovn-nb-idl.h /ovn-nb-idl.ov

Re: [ovs-dev] [PATCH] ofp-actions: Support mixing "conjunction" and "note" actions.

2015-06-26 Thread Ben Pfaff
On Thu, Jun 25, 2015 at 04:27:00PM -0700, Andy Zhou wrote: > On Mon, Jun 15, 2015 at 1:58 PM, Ben Pfaff wrote: > > It doesn't make sense to mix "conjunction" actions with most other kinds > > of actions. That's because flows with "conjunction" actions aren't ever > > actually executed, so any act

[ovs-dev] [ovn-controller-gw RFC 4/4] ovn: Add controller for VTEP switch.

2015-06-26 Thread Alex Wang
This commit adds a controller 'ovn-controller-gw' for controlling vtep enabled physical switches. Following are the short summary of each module: gateway.c = register the physical switches in vtep and constantly update the gateway_ports entries in Chassis table and the vlan_map in

Re: [ovs-dev] [PATCH] ofproto: Fix use-after-free in bridge destruction with groups.

2015-06-26 Thread Ben Pfaff
On Thu, Jun 25, 2015 at 12:48:27PM +0900, Simon Horman wrote: > Hi Ben, > > On Tue, Jun 23, 2015 at 11:38:56AM -0700, Ben Pfaff wrote: > > Groups were not destroyed until after lots of other important bridge > > data had been destroyed, including the connection manager. There was an > > indirect

Re: [ovs-dev] [ovn-controller-gw 3/4] ovn-sbctl: Add ovn-sbctl.

2015-06-26 Thread Alex Wang
Hey Ben, Russell, Want to discuss if we may want to refine ovn-nbctl to the same format as ovn-sbctl (using lib/db-ctl-cmds module). The benefit of such refinement is that ovn-nbctl can have the common ovsdb operations (e.g. list, set, create, ... like in ovs-vsctl). Since my testing does not re

Re: [ovs-dev] [PATCH] ovn: Take advantage of OVSDB garbage collection in OVN_Northbound schema.

2015-06-26 Thread Aaron Rosen
Hi Ben, I just tested out this patch and it seems to work as expected for me. I do have a few quick questions/thoughts. - One thing I noticed is if I create a logical_port but don't append the port.uuid to the Logical_Switch.ports column it seems like the port isn't showing up in ovsdb. I'm

Re: [ovs-dev] [PATCH] ovn: Take advantage of OVSDB garbage collection in OVN_Northbound schema.

2015-06-26 Thread Ben Pfaff
On Fri, Jun 26, 2015 at 05:20:16PM +, Aaron Rosen wrote: > I just tested out this patch and it seems to work as expected for > me. I do have a few quick questions/thoughts. > > - One thing I noticed is if I create a logical_port but don't append > the port.uuid to the Logical_Switch.ports colu

[ovs-dev] [PATCH 2/2 v3][branch 2.4] datapath-windows: Rename 'vport->isPresentOnHv' to 'isAbsentOnHv'

2015-06-26 Thread Nithin Raju
Looking at the code, the flag 'vport->isPresentOnHv' is actually indicating if the vport is present on the Hyper-V switch or not, but the logic seems to be inverse. 'isPresentOnHv == TRUE' indicates that the vport is not present on the Hyper-V switch. Eg. VXLAN port, would have isPresentOnHv == TRU

[ovs-dev] [PATCH 1/2 v3][branch 2.4] datapath-windows: Code refactoring and fixes in Vport.c

2015-06-26 Thread Nithin Raju
In this patch, there a couple of fixes and some code refactoring: 1. During deletion of "internal" and "external" in OvsRemoveAndDeleteVport(), we need to check if 'hvDelete' is TRUE before updating the data structures. Added code comments explaining the same. 2. Added a OvsRemoveTunnelPo

Re: [ovs-dev] [PATCH] ovn: Take advantage of OVSDB garbage collection in OVN_Northbound schema.

2015-06-26 Thread Aaron Rosen
Would it be possible to keep the lswitch.uuid value on the port like before, but not enforce the integrity there if the network does not exist. Then, have the garbage collector here remove the ports on the network for us when the network is deleted? This way we don't need to have any retry logic

Re: [ovs-dev] [PATCH] tunneling: Userspace datapath support for Geneve options.

2015-06-26 Thread Ben Pfaff
On Thu, Jun 25, 2015 at 11:22:00AM -0700, Jesse Gross wrote: > Currently the userspace datapath only supports Geneve in a > basic mode - without options - since the rest of userspace > previously didn't support options either. This enables the > userspace datapath to send and receive options as wel

Re: [ovs-dev] [PATCH] ovn: Take advantage of OVSDB garbage collection in OVN_Northbound schema.

2015-06-26 Thread Ben Pfaff
OVSDB can't enforce those exact semantics. OVSDB can express operations like "add element X to this column (regardless of what's currently there)". If this were exposed through the IDL (currently it's not) then that would solve the problem with retries due to burstiness. Does that sound like a g

Re: [ovs-dev] [PATCH] ovn: Take advantage of OVSDB garbage collection in OVN_Northbound schema.

2015-06-26 Thread Aaron Rosen
That sounds like it would solve this problem for us :) In the delete logical_port case we'd just need to delete the port entry and the garbage collector will automatically handle updating the logical_switch.ports with the current ports right? ___ From: Ben

Re: [ovs-dev] [PATCH] tunneling: Userspace datapath support for Geneve options.

2015-06-26 Thread Jesse Gross
On Fri, Jun 26, 2015 at 12:47 PM, Ben Pfaff wrote: > On Thu, Jun 25, 2015 at 11:22:00AM -0700, Jesse Gross wrote: >> Currently the userspace datapath only supports Geneve in a >> basic mode - without options - since the rest of userspace >> previously didn't support options either. This enables th

Re: [ovs-dev] [PATCH] ovn: Take advantage of OVSDB garbage collection in OVN_Northbound schema.

2015-06-26 Thread Ben Pfaff
On Fri, Jun 26, 2015 at 08:05:53PM +, Aaron Rosen wrote: > That sounds like it would solve this problem for us :) I think so. > In the delete logical_port case we'd just need to delete the port > entry and the garbage collector will automatically handle updating the > logical_switch.ports wi

Re: [ovs-dev] [PATCH] tunneling: Userspace datapath support for Geneve options.

2015-06-26 Thread Ben Pfaff
On Fri, Jun 26, 2015 at 01:14:17PM -0700, Jesse Gross wrote: > On Fri, Jun 26, 2015 at 12:47 PM, Ben Pfaff wrote: > > On Thu, Jun 25, 2015 at 11:22:00AM -0700, Jesse Gross wrote: > >> Currently the userspace datapath only supports Geneve in a > >> basic mode - without options - since the rest of u

Re: [ovs-dev] [PATCH] tunneling: Userspace datapath support for Geneve options.

2015-06-26 Thread Jesse Gross
On Fri, Jun 26, 2015 at 2:16 PM, Ben Pfaff wrote: > On Fri, Jun 26, 2015 at 01:14:17PM -0700, Jesse Gross wrote: >> On Fri, Jun 26, 2015 at 12:47 PM, Ben Pfaff wrote: >> > On Thu, Jun 25, 2015 at 11:22:00AM -0700, Jesse Gross wrote: >> >> Currently the userspace datapath only supports Geneve in a

Re: [ovs-dev] [PATCH 3/4] ovn-integrate: A new OVN utility script.

2015-06-26 Thread Ben Pfaff
On Thu, Jun 25, 2015 at 02:37:41PM -0700, Ben Pfaff wrote: > On Thu, Jun 25, 2015 at 01:51:02PM -0700, Gurucharan Shetty wrote: > > > I was really heading more in the direction of suggesting a name that > > > mentioned docker. I'm OK with including the nics-to-bridge > > > functionality. > > > >

Re: [ovs-dev] [PATCH] ovn: Take advantage of OVSDB garbage collection in OVN_Northbound schema.

2015-06-26 Thread Aaron Rosen
inline From: Ben Pfaff Sent: Friday, June 26, 2015 2:12 PM To: Aaron Rosen Cc: dev@openvswitch.org Subject: Re: [PATCH] ovn: Take advantage of OVSDB garbage collection in OVN_Northbound schema. On Fri, Jun 26, 2015 at 08:05:53PM +, Aaron Rosen wrote:

Re: [ovs-dev] [RFC v2 4/4] Introduce an openvswitch driver for Docker networking.

2015-06-26 Thread Ben Pfaff
On Mon, Jun 22, 2015 at 02:19:45AM -0700, Gurucharan Shetty wrote: > Docker committed experimental support for multi-host > networking yesterday. This commit adds a driver that > works with that experimental support. Since Docker > code is not part of any official Docker releases yet, > this patch

Re: [ovs-dev] [PATCH v4] ovs-ofctl: replace-flows and diff-flows support for multiple tables

2015-06-26 Thread Ben Pfaff
On Thu, Jun 25, 2015 at 02:19:40AM -0700, Shashank Shanbhag wrote: > From: Shashank Shanbhag > > Fix replace-flows and diff-flows to modify/diff flows in multiple tables. > Add a --tables(-T) option that allows the user to specify a comma-separated > list of table indexes to replace/diff. > > Si

Re: [ovs-dev] [PATCH] ovn: Take advantage of OVSDB garbage collection in OVN_Northbound schema.

2015-06-26 Thread Ben Pfaff
On Fri, Jun 26, 2015 at 09:35:04PM +, Aaron Rosen wrote: > > In the delete logical_port case we'd just need to delete the port > > entry and the garbage collector will automatically handle updating the > > logical_switch.ports with the current ports right? > > If this proposed patch is applied

Re: [ovs-dev] [PATCH 1/2 v3][branch 2.4] datapath-windows: Code refactoring and fixes in Vport.c

2015-06-26 Thread Alin Serdean
Acked-by: Alin Gabriel Serdean -Mesaj original- De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju Trimis: Friday, June 26, 2015 9:51 PM Către: dev@openvswitch.org Subiect: [ovs-dev] [PATCH 1/2 v3][branch 2.4] datapath-windows: Code refactoring and fixes in Vport.c I

Re: [ovs-dev] [PATCH 2/2 v3][branch 2.4] datapath-windows: Rename 'vport->isPresentOnHv' to 'isAbsentOnHv'

2015-06-26 Thread Alin Serdean
Acked-by: Alin Gabriel Serdean -Mesaj original- De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju Trimis: Friday, June 26, 2015 9:51 PM Către: dev@openvswitch.org Subiect: [ovs-dev] [PATCH 2/2 v3][branch 2.4] datapath-windows: Rename 'vport->isPresentOnHv' to 'isAbsen

Re: [ovs-dev] [PATCH] ovn: Take advantage of OVSDB garbage collection in OVN_Northbound schema.

2015-06-26 Thread Aaron Rosen
Sounds good, thanks Ben! From: Ben Pfaff Sent: Friday, June 26, 2015 2:50 PM To: Aaron Rosen Cc: dev@openvswitch.org Subject: Re: [PATCH] ovn: Take advantage of OVSDB garbage collection in OVN_Northbound schema. On Fri, Jun 26, 2015 at 09:35:04PM +, A

Re: [ovs-dev] [PATCHv2 1/2] vlog: abstract out interface to syslog daemon

2015-06-26 Thread Ben Pfaff
On Thu, Jun 25, 2015 at 12:54:22PM -0700, Ansis Atteka wrote: > This patch helps to address two issues that are present on Ubuntu > 15.04 (and most likely other Linux distributions) where rsyslog daemon > is configured to relay log messages from OVS to a remote log collector > and syslog format bei

Re: [ovs-dev] [PATCHv2 2/2] vlog: add "vlog/list-pattern" command

2015-06-26 Thread Ben Pfaff
On Thu, Jun 25, 2015 at 12:54:23PM -0700, Ansis Atteka wrote: > This patch allows to query logging format at the runtime for each destination > with "vlog/list-pattern" command. > > Signed-Off-By: Ansis Atteka Compiler warnings: ../lib/vlog.c:618:58: error: unused parameter 'argc'

[ovs-dev] [PATCH]: ovsdb: add capability to dump table content in ovsdb-client

2015-06-26 Thread Sabyasachi Sengupta
Added capability of displaying tables through an optional 'table' argument to 'ovsdb-client dump'. When specified, ovsdb-client will iterate through all tables in the chosen ovsdb, and create a transaction only for that table instead of all, and then print the response for that transaction. Sign