Re: [ovs-dev] [ovsdb join 0/5] ovsdb join

2015-06-22 Thread Andy Zhou
You are right, the man page should be augmented. In a nutshell, it allows multiple schemas to be pass in wherever 'SCHEMA' was mentioned in the man page. It is a good idea to look at 5/5 for examples of those changes. On Sun, Jun 21, 2015 at 12:03 PM, Ansis Atteka wrote: > > > On 15 June 2015 at

Re: [ovs-dev] [RFC PATCH 0/9] Geneve option matching

2015-06-22 Thread Ben Pfaff
On Mon, Jun 15, 2015 at 02:41:29PM -0700, Jesse Gross wrote: > OVN people: > As the presumable first user, any OpenFlow level interface issues that > might make it more complicated to use. In particular, I think it's > a little unfortunate that we don't have a better way to gracefully > handle chan

Re: [ovs-dev] [PATCH branch-2.3] ofproto: Don't report that group chaining is supported.

2015-06-22 Thread Ben Pfaff
On Fri, Jun 05, 2015 at 10:42:10PM -0700, Ben Pfaff wrote: > Group chaining hasn't been supported, so we shouldn't report that it is. > (This is a good demonstration of why I don't like feature bits like this. > It's too easy for even well-intentioned implementers to get them wrong.) > > Signed-of

[ovs-dev] [PATCH] rpms: Exclude OVN files from openvswitch packages.

2015-06-22 Thread Gurucharan Shetty
Currently rhel rpm doesnot build because of OVN files. This patch only fixes the build failures. We eventually may have to add OVN packages RHEL, Xenserver and Debian. Signed-off-by: Gurucharan Shetty --- Did not test the change for Xenserver. It likely fails there too. --- rhel/openvswitch.spec

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Add support for OpenFlow group chaining.

2015-06-22 Thread Ben Pfaff
This patch could still use a review. On Fri, Jun 05, 2015 at 10:45:35PM -0700, Ben Pfaff wrote: > Requested-by: Vinllen Chen > Signed-off-by: Ben Pfaff > --- > AUTHORS | 1 + > ofproto/ofproto-dpif-xlate.c | 29 +++-- > ofproto/ofproto-dpif.c

Re: [ovs-dev] [PATCH v9] ovs-ofctl:Implementation of eviction on the basis of Importance

2015-06-22 Thread Ben Pfaff
On Mon, Jun 08, 2015 at 05:44:37PM +0530, Saloni Jain wrote: > Hi Ben, > > Thanks for your inputs. We will share the updated patch. > Kindly suggest for the below point.. > > >This adds abstracted OFPUTIL_TABLE_CONFIG_* but it doesn't do any > >translation between them and OFPTC14_*. > > As per

Re: [ovs-dev] [PATCH] vswitchd: adding plugin infrastructre

2015-06-22 Thread Ben Pfaff
On Wed, Jun 10, 2015 at 01:15:21AM -0700, michael.zay...@hp.com wrote: > Per this patch ovs-vswitchd searches for shared objects, with > a certain set of exposed routines, in a specific configurable path. > Once found, all compatible plugins are loaded and their routines are > called at appropri

Re: [ovs-dev] [PATCH] vswitchd: adding plugin infrastructre

2015-06-22 Thread Ben Pfaff
On Thu, Jun 11, 2015 at 06:01:42PM +, Gray, Mark D wrote: > As a general comment, why didn’t you pluginize (if that is a word) the > current set of netdevs and ofprotos in this patch? That's the direction that I think we'd have to go for this kind of thing to be maintainable. If the community

Re: [ovs-dev] [PATCH v2 0/2] Increase Python prerequisite from 2.4 to 2.7

2015-06-22 Thread Ben Pfaff
On Wed, Jun 10, 2015 at 09:04:21AM -0700, Ben Pfaff wrote: > v1->v2: Correct statements about XenServer/XCP, by stating that versions > with Python 2.4 work if you install Python 2.7 on them. > > Ben Pfaff (2): > Increase prerequisite from Python 2.4 to Python 2.7. > Makefiles: Stop distribu

Re: [ovs-dev] [PATCH v2 2/2] tests: Adjust output of vconn for windows.

2015-06-22 Thread Alin Serdean
Acked-by: Alin Gabriel Serdean -Mesaj original- De la: dev [mailto:dev-boun...@openvswitch.org] În numele Gurucharan Shetty Trimis: Friday, June 19, 2015 12:18 AM Către: dev@openvswitch.org Cc: Gurucharan Shetty Subiect: [ovs-dev] [PATCH v2 2/2] tests: Adjust output of vconn for windows.

Re: [ovs-dev] [PATCH v2 1/2] ofproto.at: Don't specify the specific error.

2015-06-22 Thread Alin Serdean
Acked-by: Alin Gabriel Serdean -Mesaj original- De la: dev [mailto:dev-boun...@openvswitch.org] În numele Gurucharan Shetty Trimis: Friday, June 19, 2015 12:17 AM Către: dev@openvswitch.org Cc: Gurucharan Shetty Subiect: [ovs-dev] [PATCH v2 1/2] ofproto.at: Don't specify the specific err

Re: [ovs-dev] [PATCH branch-2.3] ofproto: Don't report that group chaining is supported.

2015-06-22 Thread Alex Wang
Acked-by: Alex Wang On Mon, Jun 22, 2015 at 8:42 AM, Ben Pfaff wrote: > On Fri, Jun 05, 2015 at 10:42:10PM -0700, Ben Pfaff wrote: > > Group chaining hasn't been supported, so we shouldn't report that it is. > > (This is a good demonstration of why I don't like feature bits like this. > > It's

Re: [ovs-dev] [PATCH 1/3] ovsdb: add ovsdb_monitor_row_update_type()

2015-06-22 Thread Ben Pfaff
On Wed, Jun 10, 2015 at 06:37:57PM -0700, Andy Zhou wrote: > The logic of determining row update type will be useful in the following > patch. Make it into a function. > > Signed-off-by: Andy Zhou You can change the types here from 'const void *' to just 'bool', if you think that it's clearer:

Re: [ovs-dev] [PATCH 2/3] OVSDB: only update monitor when necessary

2015-06-22 Thread Ben Pfaff
On Wed, Jun 10, 2015 at 06:37:58PM -0700, Andy Zhou wrote: > Some DB modification transactions won't affect the columns of a monitor. > Skip those updates. > > Signed-off-by: Andy Zhou It wasn't obvious to me until patch 3 that the order of the OVSDB_CHANGES_* enums was important. Would you min

Re: [ovs-dev] [PATCH 3/3] OVSDB: Flush JSON cache only when necessary

2015-06-22 Thread Ben Pfaff
On Wed, Jun 10, 2015 at 06:37:59PM -0700, Andy Zhou wrote: > Currently, JSON cache is always flushed whenever the monitor receives > a transaction. This patch improves the JSON cache efficiency by only > flush the JSON cache when a transaction causes client visible > changes, avoiding unnecessary f

Re: [ovs-dev] [PATCH 1/2] Include datapath actions with sampled-packet upcall to userspace.

2015-06-22 Thread Ben Pfaff
On Thu, Jun 11, 2015 at 09:43:58AM -0700, Neil McKee wrote: > If new optional attribute OVS_USERSPACE_ATTR_ACTIONS is added to an > OVS_ACTION_ATTR_USERSPACE action, then include the datapath actions > in the upcall. > > This Directly associates the sampled packet with the path it takes > through

Re: [ovs-dev] [PATCH] rpms: Exclude OVN files from openvswitch packages.

2015-06-22 Thread Ben Pfaff
On Mon, Jun 22, 2015 at 07:29:19AM -0700, Gurucharan Shetty wrote: > Currently rhel rpm doesnot build because of OVN files. This > patch only fixes the build failures. We eventually may have > to add OVN packages RHEL, Xenserver and Debian. > > Signed-off-by: Gurucharan Shetty > --- > Did not tes

Re: [ovs-dev] [PATCH v2] datapath-windows: Return success for already existing WFP objects

2015-06-22 Thread Sorin Vinturis
Hi Eitan/Nithin, In normal execution flow all WFP objects are released after the extension is disabled. The patch was meant to address the cases when the extension was not properly disabled due to some unforeseen error, which does not deletes all WFP objects like the OVS sublayer or callout. Ma

Re: [ovs-dev] [PATCH v2] datapath-windows: Return success for already existing WFP objects

2015-06-22 Thread Nithin Raju
> On Jun 22, 2015, at 10:25 AM, Sorin Vinturis > wrote: > > Hi Eitan/Nithin, > > In normal execution flow all WFP objects are released after the extension is > disabled. The patch was meant to address the cases when the extension was not > properly disabled due to some unforeseen error, which

Re: [ovs-dev] [RFC PATCH 0/9] Geneve option matching

2015-06-22 Thread Jesse Gross
On Mon, Jun 22, 2015 at 8:35 AM, Ben Pfaff wrote: > On Mon, Jun 15, 2015 at 02:41:29PM -0700, Jesse Gross wrote: >> OVN people: >> As the presumable first user, any OpenFlow level interface issues that >> might make it more complicated to use. In particular, I think it's >> a little unfortunate th

Re: [ovs-dev] [PATCH 1/2] Include datapath actions with sampled-packet upcall to userspace.

2015-06-22 Thread Jesse Gross
On Mon, Jun 22, 2015 at 10:11 AM, Ben Pfaff wrote: > On Thu, Jun 11, 2015 at 09:43:58AM -0700, Neil McKee wrote: >> If new optional attribute OVS_USERSPACE_ATTR_ACTIONS is added to an >> OVS_ACTION_ATTR_USERSPACE action, then include the datapath actions >> in the upcall. >> >> This Directly assoc

Re: [ovs-dev] [PATCH v2] datapath-windows: Return success for already existing WFP objects

2015-06-22 Thread Eitan Eliahu
Hi Sorin, Although the patch by itself can't hurt but I would suggest that we would root cause the issue of not freeing WFP object on error conditions. Thank you, Eitan -Original Message- From: Sorin Vinturis [mailto:svintu...@cloudbasesolutions.com] Sent: Monday, June 22, 2015 10:26 AM

Re: [ovs-dev] [PATCH v2 2/2] tests: Adjust output of vconn for windows.

2015-06-22 Thread Gurucharan Shetty
On Mon, Jun 22, 2015 at 9:26 AM, Alin Serdean wrote: > Acked-by: Alin Gabriel Serdean Thanks, Alin. I pushed both the changes to master. > > > -Mesaj original- > De la: dev [mailto:dev-boun...@openvswitch.org] În numele Gurucharan Shetty > Trimis: Friday, June 19, 2015 12:18 AM > Către:

Re: [ovs-dev] [PATCH] rpms: Exclude OVN files from openvswitch packages.

2015-06-22 Thread Gurucharan Shetty
> > Acked-by: Ben Pfaff Applied. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v2 2/2] Makefiles: Stop distributing files because building them requires Python.

2015-06-22 Thread Alex Wang
On Wed, Jun 10, 2015 at 9:04 AM, Ben Pfaff wrote: > A long time ago, the Open vSwitch build did not depend on Python (whereas > the runtime did), so the "make dist" based distribution included the > results of Python build tools. Later, the build began building on Python, > but the distribution

Re: [ovs-dev] [PATCH 1/2] Include datapath actions with sampled-packet upcall to userspace.

2015-06-22 Thread Neil McKee
Yes. I separated this into 2 parts because the first one (datapath changes) is just to bring the in-tree module into line with netdev net-next. The second part contains the user-space changes and unit tests. There are some comments marked with "XXX" to invite close scrutiny. If this approach is

Re: [ovs-dev] [PATCH v2] datapath-windows: Return success for already existing WFP objects

2015-06-22 Thread Sorin Vinturis
Hi Nithin, I didn't thought about your idea. I have added instrumentation code in order to force the EEXIST error and test the patch and the code performs as expected. The extension is able to be activated, in case of both the sublayer and callout are already present, and everything works as fi

Re: [ovs-dev] OVN and OpenStack Provider Networks

2015-06-22 Thread Russell Bryant
(Apologies for the slow follow-up to the responses on this thread. I've been on vacation.) On 06/15/2015 08:00 PM, Ben Pfaff wrote: > On Wed, Jun 10, 2015 at 03:13:54PM -0400, Russell Bryant wrote: >> Provider Networks >> = >> >> OpenStack Neutron currently has a feature referred

Re: [ovs-dev] [ovsdb join 5/5] tests: add ovsdb-tool join schema tests

2015-06-22 Thread Ansis Atteka
On 15 June 2015 at 19:35, Andy Zhou wrote: > Add unit tests for ovsdb-tools that deals with multiple schemas. > > Signed-off-by: Andy Zhou > --- > tests/ovsdb-tool.at | 152 > > 1 file changed, 152 insertions(+) > This series don't address t

[ovs-dev] [PATCH 3/4] ovn-integrate: A new OVN utility script.

2015-06-22 Thread Gurucharan Shetty
Signed-off-by: Gurucharan Shetty --- ovn/utilities/.gitignore| 1 + ovn/utilities/automake.mk | 9 ++- ovn/utilities/ovn-integrate.in | 167 rhel/openvswitch-fedora.spec.in | 1 + 4 files changed, 177 insertions(+), 1 deletion(-) crea

[ovs-dev] [PATCH 2/4] ovs-lib: Ability to move ip address and routes.

2015-06-22 Thread Gurucharan Shetty
The ability to move IP address and routes between two interfaces is useful when we want to make a physical interface (say eth0) as a port of OVS bridge (say breth0) with all its IP address and route information transferred to OVS bridge. An upcoming commit uses the new ability. Signed-off-by: Guru

[ovs-dev] [RFC 4/4] Introduce an openvswitch driver for Docker networking.

2015-06-22 Thread Gurucharan Shetty
Docker committed experimental support for multi-host networking yesterday. This commit adds a driver that works with that experimental support. Since Docker code is not part of any official Docker releases yet, this patch is sent as a RFC. Signed-off-by: Gurucharan Shetty --- INSTALL.Docker.md

[ovs-dev] [PATCH 1/4] ovs-save: Refactor and move some code to ovs-lib.

2015-06-22 Thread Gurucharan Shetty
An upcoming commit becomes the second user of the new functions. Signed-off-by: Gurucharan Shetty --- utilities/ovs-lib.in | 65 utilities/ovs-save | 63 +++--- 2 files changed, 73 insertions(+), 5

[ovs-dev] [PATCH v2 1/4] ovs-save: Refactor and move some code to ovs-lib.

2015-06-22 Thread Gurucharan Shetty
An upcoming commit becomes the second user of the new functions. Signed-off-by: Gurucharan Shetty --- v1-v2: No change. --- utilities/ovs-lib.in | 65 utilities/ovs-save | 63 +++--- 2 files change

[ovs-dev] [PATCH v2 3/4] ovn-integrate: A new OVN utility script.

2015-06-22 Thread Gurucharan Shetty
Signed-off-by: Gurucharan Shetty --- v1-v2: No change --- ovn/utilities/.gitignore| 1 + ovn/utilities/automake.mk | 9 ++- ovn/utilities/ovn-integrate.in | 167 rhel/openvswitch-fedora.spec.in | 1 + 4 files changed, 177 insertions(+)

[ovs-dev] [PATCH v2 2/4] ovs-lib: Ability to move ip address and routes.

2015-06-22 Thread Gurucharan Shetty
The ability to move IP address and routes between two interfaces is useful when we want to make a physical interface (say eth0) as a port of OVS bridge (say breth0) with all its IP address and route information transferred to OVS bridge. An upcoming commit uses the new ability. Signed-off-by: Guru

[ovs-dev] [RFC v2 4/4] Introduce an openvswitch driver for Docker networking.

2015-06-22 Thread Gurucharan Shetty
Docker committed experimental support for multi-host networking yesterday. This commit adds a driver that works with that experimental support. Since Docker code is not part of any official Docker releases yet, this patch is sent as a RFC. Signed-off-by: Gurucharan Shetty --- INSTALL.Docker.md

Re: [ovs-dev] [ovsdb join 2/5] ovsdb: add supporting functions for schemata

2015-06-22 Thread Andy Zhou
On Sun, Jun 21, 2015 at 1:29 PM, Ansis Atteka wrote: > > > On 15 June 2015 at 19:35, Andy Zhou wrote: >> >> Add functions to support dealing with multiple schemas as a set. These > > > It seems that you are not using plural form of "schema" consistently (i.e. > in the actual code you are using "s

Re: [ovs-dev] [PATCH 2/3] OVSDB: only update monitor when necessary

2015-06-22 Thread Andy Zhou
> I'm not sure that 'efficacy' is the best term here, but it is at least > distinctive. > How about 'update_level'? Any other suggestions? > Acked-by: Ben Pfaff Thanks. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/d

Re: [ovs-dev] [PATCH 1/3] ovsdb: add ovsdb_monitor_row_update_type()

2015-06-22 Thread Andy Zhou
On Mon, Jun 22, 2015 at 9:35 AM, Ben Pfaff wrote: > On Wed, Jun 10, 2015 at 06:37:57PM -0700, Andy Zhou wrote: >> The logic of determining row update type will be useful in the following >> patch. Make it into a function. >> >> Signed-off-by: Andy Zhou > > You can change the types here from 'cons

Re: [ovs-dev] [ovsdb join 2/5] ovsdb: add supporting functions for schemata

2015-06-22 Thread Ansis Atteka
On 22 June 2015 at 13:00, Andy Zhou wrote: > On Sun, Jun 21, 2015 at 1:29 PM, Ansis Atteka > wrote: > > > > > > On 15 June 2015 at 19:35, Andy Zhou wrote: > >> > >> Add functions to support dealing with multiple schemas as a set. These > > > > > > It seems that you are not using plural form of

Re: [ovs-dev] OVN and OpenStack Provider Networks

2015-06-22 Thread Russell Bryant
On 06/13/2015 06:12 PM, Salvatore Orlando wrote: > Second, much of the flows currently programmed by ovn-controller > would be useful for provider networks. We still want to implement port > security and ACLs (security groups). The major difference is that > unless the packet is d

Re: [ovs-dev] [ovsdb join 2/5] ovsdb: add supporting functions for schemata

2015-06-22 Thread Ansis Atteka
On 22 June 2015 at 13:31, Ansis Atteka wrote: > > > On 22 June 2015 at 13:00, Andy Zhou wrote: > >> On Sun, Jun 21, 2015 at 1:29 PM, Ansis Atteka >> wrote: >> > >> > >> > On 15 June 2015 at 19:35, Andy Zhou wrote: >> >> >> >> Add functions to support dealing with multiple schemas as a set. The

Re: [ovs-dev] [PATCH 2/3] OVSDB: only update monitor when necessary

2015-06-22 Thread Ben Pfaff
On Mon, Jun 22, 2015 at 01:21:10PM -0700, Andy Zhou wrote: > > I'm not sure that 'efficacy' is the best term here, but it is at least > > distinctive. > > > > How about 'update_level'? Any other suggestions? Let's stick with efficacy for now, it's growing on me. _

Re: [ovs-dev] [PATCH v2 2/2] Makefiles: Stop distributing files because building them requires Python.

2015-06-22 Thread Ben Pfaff
On Mon, Jun 22, 2015 at 10:50:55AM -0700, Alex Wang wrote: > On Wed, Jun 10, 2015 at 9:04 AM, Ben Pfaff wrote: > > > A long time ago, the Open vSwitch build did not depend on Python (whereas > > the runtime did), so the "make dist" based distribution included the > > results of Python build tools

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Add support for OpenFlow group chaining.

2015-06-22 Thread Ben Pfaff
Thanks, applied to master. On Mon, Jun 22, 2015 at 09:38:52AM -0700, Alex Wang wrote: > Acked-by: Alex Wang > > On Mon, Jun 22, 2015 at 8:40 AM, Ben Pfaff wrote: > > > This patch could still use a review. > > > > On Fri, Jun 05, 2015 at 10:45:35PM -0700, Ben Pfaff wrote: > > > Requested-by: Vi

Re: [ovs-dev] [PATCH branch-2.3] ofproto: Don't report that group chaining is supported.

2015-06-22 Thread Ben Pfaff
Thanks, applied to branch-2.3 and branch-2.4 (since the bug was still on that branch when we forked it from master). On Mon, Jun 22, 2015 at 09:33:15AM -0700, Alex Wang wrote: > Acked-by: Alex Wang > > On Mon, Jun 22, 2015 at 8:42 AM, Ben Pfaff wrote: > > > On Fri, Jun 05, 2015 at 10:42:10PM -

[ovs-dev] [PATCH] Makefiles: Move xml2nroff rule from ovn directory to top level.

2015-06-22 Thread Ben Pfaff
Originally only the OVN documentation used the XML format, but now it's used outside the ovn directory (initially for ovs-sim.1) so it's more logical to have the xml->nroff rule at the top level. Reported-by: Alex Wang Signed-off-by: Ben Pfaff --- Makefile.am | 18 ++ ovn/au

[ovs-dev] [PATCH 2/3] Remove the windows service in case it failed to start

2015-06-22 Thread Alin Serdean
In case the ovsdb-server failed to start, the defined service was not properly cleaned. Add a run-if-false command in case the service failed to start. Signed-off-by: Alin Gabriel Serdean --- tests/daemon.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/daemon.at b/t

Re: [ovs-dev] [ovsdb join 3/5] ovsdb: Add logic for parsing schema filenames from string

2015-06-22 Thread Andy Zhou
Thanks for the review. Will fix them in the next rev. On Sun, Jun 21, 2015 at 1:39 PM, Ansis Atteka wrote: > > > On 15 June 2015 at 19:35, Andy Zhou wrote: >> >> Any ovsdb programs that accepts a single schema file name will be >> extended to accepts multiple file names. This patch implements th

[ovs-dev] [PATCH 0/3] Windows unit tests fixes

2015-06-22 Thread Alin Serdean
Various fixes for windows unit tests. Alin Gabriel Serdean (3): Add OVS_VSWITCHD_STOP to bfd unit tests Remove the windows service in case it failed to start Update windows test documentation INSTALL.Windows.md | 3 +++ tests/bfd.at | 4 tests/daemon.at| 2 +- 3 files change

[ovs-dev] [PATCH 3/3] Update windows test documentation

2015-06-22 Thread Alin Serdean
Describe explictly where to add the pthread library to the PATH variable. In case the pthread library directory was added to the user PATH variable the service failed to start. Signed-off-by: Alin Gabriel Serdean --- INSTALL.Windows.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/INST

[ovs-dev] [PATCH 1/3] Add OVS_VSWITCHD_STOP to bfd unit tests

2015-06-22 Thread Alin Serdean
On Windows the following tests hang unless we also call the OVS_VSWITCHD_STOP macro to stop the executable. Tested on Windows and Linux Signed-off-by: Alin Gabriel Serdean --- tests/bfd.at | 4 1 file changed, 4 insertions(+) diff --git a/tests/bfd.at b/tests/bfd.at index 8bf88f2..5215d2e

Re: [ovs-dev] [PATCH] Makefiles: Move xml2nroff rule from ovn directory to top level.

2015-06-22 Thread Alex Wang
On Mon, Jun 22, 2015 at 3:42 PM, Ben Pfaff wrote: > Originally only the OVN documentation used the XML format, but now it's > used outside the ovn directory (initially for ovs-sim.1) so it's more > logical to have the xml->nroff rule at the top level. > > Reported-by: Alex Wang > Signed-off-by:

Re: [ovs-dev] [PATCH 1/2] Include datapath actions with sampled-packet upcall to userspace.

2015-06-22 Thread Ben Pfaff
OK that makes sense, thanks. On Mon, Jun 22, 2015 at 10:52:59AM -0700, Neil McKee wrote: > Yes. I separated this into 2 parts because the first one (datapath > changes) is just to bring the in-tree module into line with netdev > net-next. The second part contains the user-space changes and unit

Re: [ovs-dev] [PATCH] Makefiles: Move xml2nroff rule from ovn directory to top level.

2015-06-22 Thread Alex Wang
On Mon, Jun 22, 2015 at 3:58 PM, Alex Wang wrote: > > > On Mon, Jun 22, 2015 at 3:42 PM, Ben Pfaff wrote: > >> Originally only the OVN documentation used the XML format, but now it's >> used outside the ovn directory (initially for ovs-sim.1) so it's more >> logical to have the xml->nroff rule a

Re: [ovs-dev] [PATCH 1/3] Add OVS_VSWITCHD_STOP to bfd unit tests

2015-06-22 Thread Gurucharan Shetty
On Mon, Jun 22, 2015 at 3:45 PM, Alin Serdean wrote: > On Windows the following tests hang unless we also call > the OVS_VSWITCHD_STOP macro to stop the executable. This concerns me a bit. In _OVS_VSWITCHD_START, we call ON_EXIT_UNQUOTED([kill `cat ovs-vswitchd.pid`]) ON_EXIT_UNQUOTED([kill `cat

Re: [ovs-dev] [PATCH 1/3] Add OVS_VSWITCHD_STOP to bfd unit tests

2015-06-22 Thread Alin Serdean
For a rather strange reason I am missing tskill on my system. However if I replace tskill with taskkill everything is fine. Alin. -Mesaj original- De la: Gurucharan Shetty [mailto:shet...@nicira.com] Trimis: Tuesday, June 23, 2015 2:45 AM Către: Alin Serdean Cc: dev@openvswitch.org Sub

Re: [ovs-dev] [PATCH v2] datapath-windows: Return success for already existing WFP objects

2015-06-22 Thread Nithin Raju
> On Jun 22, 2015, at 10:58 AM, Sorin Vinturis > wrote: > > Hi Nithin, > > I didn't thought about your idea. I have added instrumentation code in order > to force the EEXIST error and test the patch and the code performs as > expected. The extension is able to be activated, in case of both th

Re: [ovs-dev] [PATCH 5/7] db-ctl-base: Librarize database command manual.

2015-06-22 Thread Ben Pfaff
I like the idea. (Currently skimming through this series before I review in detail.) On Thu, Jun 11, 2015 at 07:34:14PM -0700, Alex Wang wrote: > not sure if doing this totally makes sense, would like to hear comments,~ > > On Thu, Jun 11, 2015 at 7:37 PM, Alex Wang wrote: > > > This commit ex

Re: [ovs-dev] [PATCH 1/3] Add OVS_VSWITCHD_STOP to bfd unit tests

2015-06-22 Thread Alin Serdean
I could send another patch with the following: -tskill $i +taskkill //PID $i //F >/dev/null Alin. -Mesaj original- De la: Gurucharan Shetty [mailto:shet...@nicira.com] Trimis: Tuesday, June 23, 2015 2:45 AM Către: Alin Serdean Cc: dev@openv

Re: [ovs-dev] [PATCH] dpif-netdev: Check for PKT_RX_RSS_HASH flag.

2015-06-22 Thread Pravin Shelar
On Fri, Jun 19, 2015 at 11:24 AM, Daniele Di Proietto wrote: > > > On 18/06/2015 23:57, "Traynor, Kevin" wrote: > >> >> >>> -Original Message- >> >>> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Daniele Di >> >>> Proietto >> >>> Sent: Tuesday, June 16, 2015 7:39 PM >> >>> T

Re: [ovs-dev] [PATCH v2 2/2] Makefiles: Stop distributing files because building them requires Python.

2015-06-22 Thread Alex Wang
Thx for the explanation, Looks good to me, On Mon, Jun 22, 2015 at 3:06 PM, Ben Pfaff wrote: > On Mon, Jun 22, 2015 at 10:50:55AM -0700, Alex Wang wrote: > > On Wed, Jun 10, 2015 at 9:04 AM, Ben Pfaff wrote: > > > > > A long time ago, the Open vSwitch build did not depend on Python > (whereas