[ovs-dev] [PATCH V2] xenserver: Use kernel uname version for XenServer 6.5

2015-05-01 Thread Alex Wang
From: Edwin Chiu In XenServer 6.5, multiple kernel packages with different rpm versions can have the same uname. So, it is not necessary for openvswitch kernel module to require the exact rpm version. Instead, the kernel module package should check the uname version. This commit will add a new

[ovs-dev] [PATCH] dpctl: cleaner dpctl output for tunnel ports.

2015-05-01 Thread Pravin B Shelar
Currently dont-fragment and TTL are initialized to zero, but those are not default config for tunnel ports. dpctl does not show default config of a port. So by setting these values to default we can get cleaner `dpctl show` output. % ovs-dpctl show system@ovs-system: port 0: ovs-system (

Re: [ovs-dev] [PATCH] dpctl: cleaner dpctl output for tunnel ports.

2015-05-01 Thread Ben Pfaff
On Fri, May 01, 2015 at 11:02:02AM -0700, Pravin B Shelar wrote: > Currently dont-fragment and TTL are initialized to zero, but > those are not default config for tunnel ports. dpctl > does not show default config of a port. So by setting these > values to default we can get cleaner `dpctl show`

Re: [ovs-dev] [RFCv4 09/10] xlate: Clear conntrack fields when traversing peers.

2015-05-01 Thread Joe Stringer
Thanks for the quick response, On 30 April 2015 at 14:18, Jarno Rajahalme wrote: >> @@ -748,6 +748,11 @@ struct ofpact_unroll_xlate { >> /* Metadata in xlate context, visible to controller via PACKET_INs. */ >> uint8_t rule_table_id; /* 0xFF if none. */ >> ovs_be64 rule_cookie;

[ovs-dev] [PATCH ovn 1/2] ovn-controller: Fix invalid br_int_name handling.

2015-05-01 Thread Russell Bryant
While doing some testing, I noticed the following error message: Integration bridge '' dissapeared The reason is that the code kept around the value of the "ovn-bridge" configuration without copying it. The result was pointing to bogus memory. You would only see this if you set "ovn_bridge".

[ovs-dev] [PATCH ovn 2/2] ovn-controller: Free some more memory before exit.

2015-05-01 Thread Russell Bryant
Free a few pointers to malloc'd memory before exit. Signed-off-by: Russell Bryant --- ovn/controller/ovn-controller.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ovn/controller/ovn-controller.c b/ovn/controller/ovn-controller.c index 778dd43..9d61a48 100644 --- a/ovn/

Re: [ovs-dev] [PATCH ovn 1/2] ovn-controller: Fix invalid br_int_name handling.

2015-05-01 Thread Kyle Mestery
On Fri, May 1, 2015 at 1:22 PM, Russell Bryant wrote: > While doing some testing, I noticed the following error message: > > Integration bridge '' dissapeared > > The reason is that the code kept around the value of the "ovn-bridge" > configuration without copying it. The result was pointing t

Re: [ovs-dev] [PATCH ovn 2/2] ovn-controller: Free some more memory before exit.

2015-05-01 Thread Kyle Mestery
On Fri, May 1, 2015 at 1:22 PM, Russell Bryant wrote: > Free a few pointers to malloc'd memory before exit. > > Signed-off-by: Russell Bryant > --- > ovn/controller/ovn-controller.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/ovn/controller/ovn-controller.c > b/

Re: [ovs-dev] [PATCH ovn v5 02/15] ovn-controller: Implement translation of OVN flows into OpenFlow.

2015-05-01 Thread Russell Bryant
On 04/30/2015 02:48 AM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > ovn/controller/automake.mk | 4 +- > ovn/controller/ovn-controller.c | 4 + > ovn/controller/pipeline.c | 373 > > ovn/controller/pipeline.h | 26 +++ > ovn/

[ovs-dev] [PATCH] datapath: gre: Reset fix_segment pointer.

2015-05-01 Thread Pravin B Shelar
For kernel version 3.12 to 3.18, GRE uses compat code to transmit packets which used fix_segment to segment packets. but ovs_gso_cb->fix_segment is not initialized for GRE tunnels. Following patches fixes it by resetting fix_segment. Signed-off-by: Pravin B Shelar --- datapath/linux/compat/gre.c

[ovs-dev] Rackspace Users List

2015-05-01 Thread Alaysa Martinez
Hi, Would you be interested in *Rackspace* contact information in excel sheet for unlimited marketing usage? We provide Top Decision Makers information like Name, Email, Title, Phone and company details of companies using Rackspace *Salesforce* *Savvis* *Peer 1 Hosting* *SoftLayer* *Akama

Re: [ovs-dev] [RFCv4 09/10] xlate: Clear conntrack fields when traversing peers.

2015-05-01 Thread Jarno Rajahalme
> On May 1, 2015, at 11:11, Joe Stringer wrote: > > Thanks for the quick response, > > On 30 April 2015 at 14:18, Jarno Rajahalme wrote: >>> @@ -748,6 +748,11 @@ struct ofpact_unroll_xlate { >>>/* Metadata in xlate context, visible to controller via PACKET_INs. */ >>>uint8_t rule_tabl

Re: [ovs-dev] [RFCv4 09/10] xlate: Clear conntrack fields when traversing peers.

2015-05-01 Thread Joe Stringer
On 1 May 2015 at 13:07, Jarno Rajahalme wrote: > >> On May 1, 2015, at 11:11, Joe Stringer wrote: >> >> Thanks for the quick response, >> >> On 30 April 2015 at 14:18, Jarno Rajahalme wrote: @@ -748,6 +748,11 @@ struct ofpact_unroll_xlate { /* Metadata in xlate context, visible to c

Re: [ovs-dev] [PATCH] dpctl: cleaner dpctl output for tunnel ports.

2015-05-01 Thread Jesse Gross
On Fri, May 1, 2015 at 11:02 AM, Pravin B Shelar wrote: > Currently dont-fragment and TTL are initialized to zero, but > those are not default config for tunnel ports. dpctl > does not show default config of a port. So by setting these > values to default we can get cleaner `dpctl show` output.

Re: [ovs-dev] [PATCH] dpctl: cleaner dpctl output for tunnel ports.

2015-05-01 Thread Pravin Shelar
On Fri, May 1, 2015 at 2:20 PM, Jesse Gross wrote: > On Fri, May 1, 2015 at 11:02 AM, Pravin B Shelar wrote: >> Currently dont-fragment and TTL are initialized to zero, but >> those are not default config for tunnel ports. dpctl >> does not show default config of a port. So by setting these >>

Re: [ovs-dev] [PATCH] datapath: gre: Reset fix_segment pointer.

2015-05-01 Thread Jesse Gross
On Fri, May 1, 2015 at 12:40 PM, Pravin B Shelar wrote: > For kernel version 3.12 to 3.18, GRE uses compat code to > transmit packets which used fix_segment to segment packets. > but ovs_gso_cb->fix_segment is not initialized for GRE tunnels. > Following patches fixes it by resetting fix_segment.

Re: [ovs-dev] [PATCH ovn 1/2] ovn-controller: Fix invalid br_int_name handling.

2015-05-01 Thread Justin Pettit
> On May 1, 2015, at 11:55 AM, Kyle Mestery wrote: > > On Fri, May 1, 2015 at 1:22 PM, Russell Bryant wrote: > > Nice catch! Seems sensible too. :) > > Acked-by: Kyle Mestery Agreed, nice catch. I added Kyle's ACKs and pushed the series. --Justin

Re: [ovs-dev] [PATCH ovn v5 02/15] ovn-controller: Implement translation of OVN flows into OpenFlow.

2015-05-01 Thread Ben Pfaff
On Fri, May 01, 2015 at 03:28:28PM -0400, Russell Bryant wrote: > On 04/30/2015 02:48 AM, Ben Pfaff wrote: > > Signed-off-by: Ben Pfaff > > +ldp = ldp_lookup(&pipeline->logical_datapath); > > +if (!ldp) { > > +static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 1

[ovs-dev] [PATCH ovn v6 0/9] Make OVN work

2015-05-01 Thread Ben Pfaff
v1->v2: Add patch 5. v2->v3: Break patch 5 into a series of 6 patches, each of which actually makes sense and is ready for review. v3->v4: Drop patches 1 to 6 because they were applied. Update patch 3 based on Justin's comments (changing "resubmit" to "next"). Add patches 5 through 9 (patch

[ovs-dev] [PATCH ovn v6 2/9] ovn-controller: Implement translation of OVN flows into OpenFlow.

2015-05-01 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- ovn/controller/automake.mk | 4 +- ovn/controller/ovn-controller.c | 4 + ovn/controller/pipeline.c | 373 ovn/controller/pipeline.h | 26 +++ 4 files changed, 406 insertions(+), 1 deletion(-) create mode

[ovs-dev] [PATCH ovn v6 1/9] ovn: New module for parsing OVN actions as OpenFlow.

2015-05-01 Thread Ben Pfaff
Signed-off-by: Ben Pfaff Acked-by: Justin Pettit --- ovn/lib/actions.c| 247 +++ ovn/lib/actions.h| 38 ovn/lib/automake.mk | 2 + ovn/lib/expr.c | 179 + ovn/lib/expr.h | 15 +++

[ovs-dev] [PATCH ovn v6 3/9] rconn: Only increment seqno when connection actually drops or reconnects.

2015-05-01 Thread Ben Pfaff
rconn_get_connection_seqno() is documented to change only when an rconn connects or disconnnects, but in fact it was also changing whenever an rconn went into or out of the "idle" state (following sending an echo request). This fixes the problem. rconn_get_connection_seqno() didn't have any exist

[ovs-dev] [PATCH ovn v6 7/9] ovs-architecture: Recommend disable-in-band=true for integration bridge.

2015-05-01 Thread Ben Pfaff
Also implement in ovs-sandbox. Signed-off-by: Ben Pfaff --- ovn/ovn-architecture.7.xml | 27 +++ tutorial/ovs-sandbox | 3 ++- 2 files changed, 25 insertions(+), 5 deletions(-) diff --git a/ovn/ovn-architecture.7.xml b/ovn/ovn-architecture.7.xml index f092141..94c

[ovs-dev] [PATCH ovn v6 4/9] ovs-sandbox: Use "secure" mode for br-int, in OVN mode.

2015-05-01 Thread Ben Pfaff
This is documented in ovn-architecture(7). Signed-off-by: Ben Pfaff --- tutorial/ovs-sandbox | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tutorial/ovs-sandbox b/tutorial/ovs-sandbox index 1520cb7..f2ec0d5 100755 --- a/tutorial/ovs-sandbox +++ b/tutorial/ovs-sandbox @@ -291

[ovs-dev] [PATCH ovn v6 8/9] pipeline: Add macros to map logical registers to MFF_REG6 and MFF_REG7.

2015-05-01 Thread Ben Pfaff
This will allow upcoming code to refer to the logical inport and outport by symbolic names. Signed-off-by: Ben Pfaff --- ovn/controller/pipeline.c | 29 + ovn/controller/pipeline.h | 4 2 files changed, 17 insertions(+), 16 deletions(-) diff --git a/ovn/control

[ovs-dev] [PATCH ovn v6 5/9] match: Add MATCH_CATCHALL_INITIALIZER.

2015-05-01 Thread Ben Pfaff
An upcoming patch will add the first user. Signed-off-by: Ben Pfaff --- lib/match.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/match.h b/lib/match.h index 6633304..638c49d 100644 --- a/lib/match.h +++ b/lib/match.h @@ -1,5 +1,5 @@ /* - * Copyright (c) 2009, 2010

[ovs-dev] [PATCH ovn v6 6/9] ovn-controller: Install generated pipeline flows into OVS via OpenFlow.

2015-05-01 Thread Ben Pfaff
This implementation is really simple, but it seems effective enough in my minimal testing. We still need code to generate flows for logical-to-physical and physical-to-logical translation. With that, plus code to set up tunnels, we should be able to start end-to-end testing. Signed-off-by: Ben P

[ovs-dev] [PATCH ovn v6 9/9] ovn-controller: Implement logical/physical translation flows.

2015-05-01 Thread Ben Pfaff
This last piece allows us to start testing and debugging a complete OVN installation. It is so far tested only in the sandbox, where the flows created seem plausible at first glance. Signed-off-by: Ben Pfaff --- ovn/controller/automake.mk| 4 +- ovn/controller/ovn-controller.c

Re: [ovs-dev] [PATCH ovn v5 00/15] complete end-to-end OVN system

2015-05-01 Thread Ben Pfaff
On Wed, Apr 29, 2015 at 11:48:54PM -0700, Ben Pfaff wrote: > v1->v2: Add patch 5. > v2->v3: Break patch 5 into a series of 6 patches, each of which actually > makes sense and is ready for review. > v3->v4: Drop patches 1 to 6 because they were applied. Update patch 3 > based on Justin's commen

Re: [ovs-dev] [PATCH] datapath: gre: Reset fix_segment pointer.

2015-05-01 Thread Pravin Shelar
On Fri, May 1, 2015 at 2:41 PM, Jesse Gross wrote: > On Fri, May 1, 2015 at 12:40 PM, Pravin B Shelar wrote: >> For kernel version 3.12 to 3.18, GRE uses compat code to >> transmit packets which used fix_segment to segment packets. >> but ovs_gso_cb->fix_segment is not initialized for GRE tunnels

[ovs-dev] [PATCH v2] datapath: gre: Reset fix_segment pointer.

2015-05-01 Thread Pravin B Shelar
For kernel version 3.12 to 3.18, GRE uses compat code to transmit packets which used fix_segment to segment packets. but ovs_gso_cb->fix_segment is not initialized for GRE tunnels. Following patches fixes it by resetting fix_segment. Signed-off-by: Pravin B Shelar --- Fixed for kernel 3.12 and ne

[ovs-dev] [PATCH] datapath: define compat __skb_gso_segment()

2015-05-01 Thread Pravin B Shelar
OVS correctly define skb_gso_segment() to handle MPLS and VLAN segmentation correctly. But OVS also uses __skb_gso_segment() in some cases. Following patch defines compat __skb_gso_segment() to handle all segmentation cases. Signed-off-by: Pravin B Shelar --- acinclude.m4

Re: [ovs-dev] [PATCH v2] datapath: gre: Reset fix_segment pointer.

2015-05-01 Thread Jesse Gross
On Fri, May 1, 2015 at 5:30 PM, Pravin B Shelar wrote: > For kernel version 3.12 to 3.18, GRE uses compat code to > transmit packets which used fix_segment to segment packets. > but ovs_gso_cb->fix_segment is not initialized for GRE tunnels. > Following patches fixes it by resetting fix_segment. >

Re: [ovs-dev] [PATCH] datapath: define compat __skb_gso_segment()

2015-05-01 Thread Jesse Gross
On Fri, May 1, 2015 at 5:44 PM, Pravin B Shelar wrote: > OVS correctly define skb_gso_segment() to handle MPLS and VLAN > segmentation correctly. But OVS also uses __skb_gso_segment() in > some cases. Following patch defines compat __skb_gso_segment() > to handle all segmentation cases. > > Signed

[ovs-dev] [PATCH v2] datapath: define compat __skb_gso_segment()

2015-05-01 Thread Pravin B Shelar
OVS correctly define skb_gso_segment() to handle MPLS and VLAN segmentation correctly. But OVS also uses __skb_gso_segment() in some cases. Following patch defines compat __skb_gso_segment() to handle all segmentation cases. Signed-off-by: Pravin B Shelar --- Fixed __skb_gso_segment() compatibili

Re: [ovs-dev] [PATCH] datapath: define compat __skb_gso_segment()

2015-05-01 Thread Pravin Shelar
On Fri, May 1, 2015 at 6:31 PM, Jesse Gross wrote: > On Fri, May 1, 2015 at 5:44 PM, Pravin B Shelar wrote: >> OVS correctly define skb_gso_segment() to handle MPLS and VLAN >> segmentation correctly. But OVS also uses __skb_gso_segment() in >> some cases. Following patch defines compat __skb_gso

Re: [ovs-dev] [PATCH] ofproto/trace: Fix parsing error.

2015-05-01 Thread Alex Wang
After confirming with Jacob, found that there was actually a bug in the parse_flag() function.~ Will send the bug fix~ Thanks, Alex Wang, On Thu, Apr 30, 2015 at 2:00 PM, Jarno Rajahalme wrote: > Alex, > > I think that the non-support for the mask has been deliberate, as the mask > operates on

[ovs-dev] [PATCH] odp-util: Fix a bug in parse_flag().

2015-05-01 Thread Alex Wang
This commit fixes a bug in the parse_flag() function which causes failure of parsing tunnel flags like: tunnel(tun_id=0x0,src=1.2.3.4,dst=1.2.3.5,tos=0,ttl=64,flags(-df+csum+key)) Reported-by: Jacob Cherkas Signed-off-by: Alex Wang --- lib/odp-util.c | 12 +++- 1 file changed, 7 inse

[ovs-dev] Returned mail: Data format error

2015-05-01 Thread sqlmoz
The original message was received at Sat, 2 May 2015 12:54:25 +0700 from facebook.com [94.128.113.228] - The following addresses had permanent fatal errors - ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/de