[ovs-dev] I am Mrs Josie Wilson,

2015-01-28 Thread Mrs Josie Wilson
 Greetings to you and your family, My Message is attached, From Mrs. Josie Wilson, ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] OVS - issue related to OF-CONFIG build

2015-01-28 Thread Tomáš Čejka
Hello, I'm studying source codes of the OpenFlow implementation (in OVS) because of the OF-CONFIG project. I would like to discuss an issue that we've found. We've discovered that OVS installs static libraries without necessary header files. I think that the reason is based on inappropriate M

Re: [ovs-dev] OVS - issue related to OF-CONFIG build

2015-01-28 Thread Tomáš Čejka
Sorry for the second message, I realized I should specify my environment more precisely... I tested the package available at: http://openvswitch.org/releases/openvswitch-2.3.1.tar.gz and the older version 2.3.0. Installation was done in standard way by ./boot.sh&&./configure --prefix=/some/pre

Re: [ovs-dev] [PATCH 0/3] Add support for IETF Auto Attach standard (v5)

2015-01-28 Thread Ben Pfaff
Hi. I spent some more time on this series last night. I think that it needs some basic tests before I'll feel comfortable with it. Otherwise, there's no way to have any confidence that it hasn't been broken as part of changes in OVS as OVS evolves, or, more immediately, as part of style changes

Re: [ovs-dev] OVS - issue related to OF-CONFIG build

2015-01-28 Thread Ben Pfaff
On Wed, Jan 28, 2015 at 03:38:37PM +0100, Tomáš Čejka wrote: > I'm studying source codes of the OpenFlow implementation (in OVS) because of > the OF-CONFIG project. I would like to discuss an issue that we've found. > > We've discovered that OVS installs static libraries without necessary header >

Re: [ovs-dev] OFP14 set/get async cfg dev

2015-01-28 Thread Ben Pfaff
On Tue, Jan 27, 2015 at 11:29:59PM -0800, Shashaankar Reddy wrote: > Wanted to touch base, if any of other developers started implementing OF > 1.4 set/get async cfg feature ? I see this feature is still open under > OPENFLOW-1.1+.md/OpenFlow 1.4 only (Not sure if there's any other doc with > updat

Re: [ovs-dev] [PATCH 1/5 V6] Add support for 802.1AD (qinq)

2015-01-28 Thread Ben Pfaff
On Thu, Jan 08, 2015 at 04:29:11PM -0500, Thomas F Herbert wrote: > Signed-off-by: Thomas F Herbert I haven't seen a review of these patches so here's a start. > NEWS | 2 ++ > utilities/ovs-ofctl.8.in | 3 +-- It's pretty unusual to document a new feature before it's implem

Re: [ovs-dev] [PATCH 2/5 V6] Flow changes for 802.1ad

2015-01-28 Thread Ben Pfaff
On Thu, Jan 08, 2015 at 04:29:12PM -0500, Thomas F Herbert wrote: > This patch adds support for 802.1ad by adding customer tci and tpid to the > flow structure. > > Signed-off-by: Thomas F Herbert This seems to be only half-general because it only allows for different TPIDs in one position. It

Re: [ovs-dev] [PATCH 3/5 V6] Vlan parsing: 802.1AD and encapsulated Vlan

2015-01-28 Thread Ben Pfaff
On Thu, Jan 08, 2015 at 04:29:13PM -0500, Thomas F Herbert wrote: > This patch adds support for 802.1AD by adding parsing of 802.1AD double > stacked vlans. > > Signed-off-by: Thomas F Herbert It looks like odp_flow_key_from_flow__() only ever pushes one VLAN header into the ODP flow key (or may

Re: [ovs-dev] [PATCH 4/5 V6] Actions changes 802.1ad Customer TCI

2015-01-28 Thread Ben Pfaff
On Thu, Jan 08, 2015 at 04:29:14PM -0500, Thomas F Herbert wrote: > This patch changes the actions processing to support popping and pushing of > double stacked vlans (qinq.) > > Signed-off-by: Thomas F Herbert This updates a BUILD_ASSERT_DECL on FLOW_WC_SEQ without updating FLOW_WC_SEQ. This m

Re: [ovs-dev] [PATCH 0/5 V6] Add 802.1ad (qinq) support

2015-01-28 Thread Ben Pfaff
My big comment on this series is that I don't understand how this is going to interact with OpenFlow, especially in a backward-compatibility sense. Here's an example: in OpenFlow 1.0, one can drop all double-tagged VLANs by matching on packets that have a Ethertype of 0x88aa or 0x8100, since the s

[ovs-dev] Bug#763428: test with kernel 3.18.4

2015-01-28 Thread Mehdi Abaakouk
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi, I have retested with kernel 3.18.4, and now it works again. I have dig into changelogs since the latest kernel I have tested, and the only relevant change around ixgbe and ovs I have found is https://git.kernel.org/cgit/linux/kernel/git/st

[ovs-dev] [PATCH] autotest: Fix kernel module unit test teardown

2015-01-28 Thread Christoph Jaeger
Due to a misnaming, the macro calls OVS_SWITCHD_STOP([$1]) AT_CHECK([modprobe -r openvswitch]) in OVS_KMOD_VSWITCHD_STOP make up a syntactically correct function definition (OVS_SWITCHD_STOP does not exist, and therefore the call does not expand): OVS_SWITCHD_STOP() { set +x $as_echo "

Re: [ovs-dev] [PATCH] ofp-parse: Correctly update bucket lists if they are empty

2015-01-28 Thread Ben Pfaff
On Tue, Jan 27, 2015 at 09:22:00AM +0900, Simon Horman wrote: > Hi Ben, Hi Thomas, > > On Mon, Jan 26, 2015 at 11:19:53AM -0800, Ben Pfaff wrote: > > On Mon, Jan 26, 2015 at 02:44:07PM +0100, Thomas Graf wrote: > > > On 01/26/15 at 05:30pm, Simon Horman wrote: > > > > On Mon, Jan 26, 2015 at 04:40

[ovs-dev] [PATCH] vlog: Don't fail syslog initialization in chroot.

2015-01-28 Thread Gurucharan Shetty
When OVS unit tests are run inside chroot environment, there is no syslog infrastructure available. In a situation like that, don't fail or log additional messages. Signed-off-by: Gurucharan Shetty --- python/ovs/vlog.py |5 + 1 file changed, 5 insertions(+) diff --git a/python/ovs/vlog

Re: [ovs-dev] [PATCH] ofp-parse: Correctly update bucket lists if they are empty

2015-01-28 Thread Thomas Graf
On 01/28/15 at 01:22pm, Ben Pfaff wrote: > Are you sure? What *gms points to, that is, **gms, is freed, but *gms > should still point to the same location. list_moved() never > dereferences 'orig', only compares it against list->next. In a very > language-lawyer way, working with a pointer to fr

Re: [ovs-dev] [PATCH] ofp-parse: Correctly update bucket lists if they are empty

2015-01-28 Thread Simon Horman
On Wed, Jan 28, 2015 at 11:33:05PM +0100, Thomas Graf wrote: > On 01/28/15 at 01:22pm, Ben Pfaff wrote: > > Are you sure? What *gms points to, that is, **gms, is freed, but *gms > > should still point to the same location. list_moved() never > > dereferences 'orig', only compares it against list-

[ovs-dev] [PATCH net-next] openvswitch: Add support for checksums on UDP tunnels.

2015-01-28 Thread Jesse Gross
Currently, it isn't possible to request checksums on the outer UDP header of tunnels - the TUNNEL_CSUM flag is ignored. This adds support for requesting that UDP checksums be computed on transmit and properly reported if they are present on receive. Signed-off-by: Jesse Gross --- include/net/gen

Re: [ovs-dev] [PATCH] autotest: Fix kernel module unit test teardown

2015-01-28 Thread Andy Zhou
Thanks for the patch. I will push it to master and add your name to the AUTHORS file. On Wed, Jan 28, 2015 at 11:02 AM, Christoph Jaeger wrote: > Due to a misnaming, the macro calls > > OVS_SWITCHD_STOP([$1]) > AT_CHECK([modprobe -r openvswitch]) > > in OVS_KMOD_VSWITCHD_STOP make up a synta

Re: [ovs-dev] [PATCH net-next] openvswitch: Add support for checksums on UDP tunnels.

2015-01-28 Thread David Miller
From: Jesse Gross Date: Wed, 28 Jan 2015 16:32:46 -0800 > Currently, it isn't possible to request checksums on the outer UDP > header of tunnels - the TUNNEL_CSUM flag is ignored. This adds > support for requesting that UDP checksums be computed on transmit > and properly reported if they are pre