[ovs-dev] HOST to SWITCH packets

2015-01-23 Thread Sree Vidya S D
Hello I am working with the "void ovs_dp_process_received_packet(struct vport *p, struct sk_buff *skb)" function in datapath.c If I am right this function deals with packets that is send from a switch to another switch, does it deal with packets that are passed from a host to a switch? My sce

[ovs-dev] RETURNED MAIL: DATA FORMAT ERROR

2015-01-23 Thread The Post Office
The original message was received at Fri, 23 Jan 2015 02:45:15 -0600 from [119.5.140.252] - The following addresses had permanent fatal errors - dev@openvswitch.org ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listin

Re: [ovs-dev] [PATCH] DPDK Initialization in OVS: Modification done in DPDK initialization functions to reflect recent modifications to DPDK codebase

2015-01-23 Thread Traynor, Kevin
Hi Shankari, I can't see any attachment. Can you send the patch using git send-email ? Few questions - What version and recent changes in DPDK are you referring to? - What compiler/linker errors are you fixing? - Did you run make distcheck? FYI - There was a patch submitted for DPDK v1.8.0 supp

Re: [ovs-dev] [PATCH 0/4] Apple Mac OSX Support for CTL commands

2015-01-23 Thread Thomas Graf
On 01/22/15 at 09:22pm, Ben Pfaff wrote: > On Fri, Jan 23, 2015 at 01:17:34AM +, Dave Tucker wrote: > > This patch sets adds Apple Mac OSX Support for the ovs-vsctl and > > ovs-ofctl. This is useful for administrators who are managing OVS > > instances and whose primary desktop environment is

Re: [ovs-dev] [PATCH] test-sflow: Fix error message when a socket cannot be opened.

2015-01-23 Thread Thomas Graf
On 01/22/15 at 10:03pm, Ben Pfaff wrote: > The error message should name the socket, which is 'target', not argv[1], > which might be anything. > > Signed-off-by: Ben Pfaff Acked-by: Thomas Graf ___ dev mailing list dev@openvswitch.org http://openvswi

Re: [ovs-dev] [PATCH 1/4] autoconf: Add macros to detect Apple Mac OSX

2015-01-23 Thread Thomas Graf
On 01/23/15 at 01:17am, Dave Tucker wrote: > Signed-off-by: Dave Tucker Looks good. You might want to move the whitespace fixes into a separate commit. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 2/4] lib: Add Mac OSX compatability

2015-01-23 Thread Thomas Graf
On 01/23/15 at 01:17am, Dave Tucker wrote: > diff --git a/lib/socket-util.c b/lib/socket-util.c > index 8949da7..732fd89 100644 > --- a/lib/socket-util.c > +++ b/lib/socket-util.c > @@ -112,6 +112,11 @@ set_dscp(int fd, uint8_t dscp) > return 0; > #endif > > +#ifdef __APPLE__ > +/* ToDo

Re: [ovs-dev] [PATCH 3/4] ofproto: Fix duplicate wait function from OSX

2015-01-23 Thread Thomas Graf
On 01/23/15 at 01:17am, Dave Tucker wrote: > Signed-off-by: Dave Tucker > --- > ofproto/ofproto-dpif.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c > index bf15d04..a922544 100644 > --- a/ofproto/ofproto-dpif.c > +++ b/ofproto/ofprot

Re: [ovs-dev] [PATCH 4/4] docs: Add README.OSX.md

2015-01-23 Thread Thomas Graf
On 01/23/15 at 01:17am, Dave Tucker wrote: > Signed-off-by: Dave Tucker Acked-by: Thomas Graf ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] layer 3 ports and OVS_KEY_ATTR_PACKET_ETHERTYPE (was Re: [PATCH v8 5/5] datapath: add layer 3 support to ovs_packet_cmd_execute())

2015-01-23 Thread Lori Jakab
On 1/20/15 12:52 PM, Thomas Morin wrote: Hi Jarno, Lori, On 12/10/2014 02:45 AM, Jarno Rajahalme wrote: We should add a new metadata key field OVS_KEY_ATTR_PACKET_ETHERTYPE, that contains the ethertype of the associated packet attribute. While this would be strictly needed only for L3 packets,

Re: [ovs-dev] [PATCH 11/11] ofproto: Add NXM_NX_TUN_GBP_ID and NXM_NX_TUN_GBP_FLAGS

2015-01-23 Thread Thomas Graf
On 01/22/15 at 03:07pm, Ben Pfaff wrote: > On Thu, Jan 22, 2015 at 10:44:33PM +0100, Thomas Graf wrote: > > From: Madhu Challa > > > > Introduces two new NXMs to represent VXLAN-GBP [0] fields. > > > > actions=load:0x10->NXM_NX_TUN_GBP_ID[],NORMAL > > tun_gbp_id=0x10,actions=drop > > > > Th

Re: [ovs-dev] [PATCH 0/4] Apple Mac OSX Support for CTL commands

2015-01-23 Thread Kyle Mestery
On Fri, Jan 23, 2015 at 5:16 AM, Thomas Graf wrote: > On 01/22/15 at 09:22pm, Ben Pfaff wrote: > > On Fri, Jan 23, 2015 at 01:17:34AM +, Dave Tucker wrote: > > > This patch sets adds Apple Mac OSX Support for the ovs-vsctl and > > > ovs-ofctl. This is useful for administrators who are managin

Re: [ovs-dev] [PATCH 2/4] lib: Add Mac OSX compatability

2015-01-23 Thread Dave Tucker
On 23 Jan 2015, at 11:37, Thomas Graf wrote: On 01/23/15 at 01:17am, Dave Tucker wrote: diff --git a/lib/socket-util.c b/lib/socket-util.c index 8949da7..732fd89 100644 --- a/lib/socket-util.c +++ b/lib/socket-util.c @@ -112,6 +112,11 @@ set_dscp(int fd, uint8_t dscp) return 0; #endif +#if

Re: [ovs-dev] [PATCH 3/4] ofproto: Fix duplicate wait function from OSX

2015-01-23 Thread Dave Tucker
On 23 Jan 2015, at 11:38, Thomas Graf wrote: On 01/23/15 at 01:17am, Dave Tucker wrote: Signed-off-by: Dave Tucker --- ofproto/ofproto-dpif.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c index bf15d04..a922544 100644 --- a/ofproto/ofpr

Re: [ovs-dev] [PATCH 0/4] Apple Mac OSX Support for CTL commands

2015-01-23 Thread Dave Tucker
On 23 Jan 2015, at 11:16, Thomas Graf wrote: On 01/22/15 at 09:22pm, Ben Pfaff wrote: On Fri, Jan 23, 2015 at 01:17:34AM +, Dave Tucker wrote: This patch sets adds Apple Mac OSX Support for the ovs-vsctl and ovs-ofctl. This is useful for administrators who are managing OVS instances and wh

Re: [ovs-dev] [PATCH 3/4] ofproto: Fix duplicate wait function from OSX

2015-01-23 Thread Thomas Graf
On 01/23/15 at 04:10pm, Dave Tucker wrote: > > > On 23 Jan 2015, at 11:38, Thomas Graf wrote: > >I doubt that the Darwin implementation takes a struct ofproto ;-) > > Yeah I brute-forced a way around it that only generates some compile time > warnings :) > > >I think you have to rename the wait

Re: [ovs-dev] [PATCH 2/4] lib: Add Mac OSX compatability

2015-01-23 Thread Thomas Graf
On 01/23/15 at 04:07pm, Dave Tucker wrote: > >This needs some style changes ;-) > > Wait, you mean its obvious I'm not a C coder? > Will take a look and see what I can do... Have a look at CodingStyle.md ;-) ___ dev mailing list dev@openvswitch.org http

Re: [ovs-dev] HOST to SWITCH packets

2015-01-23 Thread Jesse Gross
On Fri, Jan 23, 2015 at 12:17 AM, Sree Vidya S D wrote: > Hello > > I am working with the > > "void ovs_dp_process_received_packet(struct vport *p, struct sk_buff *skb)" > > function in datapath.c > > If I am right this function deals with packets that is send from a switch > to another switch, d

[ovs-dev] [PATCH] INSTALL.DPDK.md: Provide a little a more consistency to documentation.

2015-01-23 Thread Gurucharan Shetty
A few users (based on the reports in disc...@openvswitch.org) have been literally following the instructions in INSTALL.DPDK.md and mixing up pre-installed utilities and daemons with freshly compiled utilities because the current documentation does not consistently call out using utilities from the

Re: [ovs-dev] appveyor - windows autobuild service

2015-01-23 Thread Gurucharan Shetty
On Thu, Jan 22, 2015 at 9:19 PM, Ben Pfaff wrote: > The travis autobuilder has been pretty awesome for GNU/Linux continuous > integration. I'd like to have autobuilders for other platforms too. > After a few minutes searching, I see that appveyor.com offers a similar > service, with similar Githu

[ovs-dev] [PATCH] RFC: Geneve OpenFlow support.

2015-01-23 Thread Madhu Challa
This commit adds support for Geneve flow mods via two nicira extensions. NXM_NX_TUN_METADATA for being able to match on tun_metadata nxms and NXAST_RAW_TUN_METADATA for tun_metadata actions. Matching On the match side multiple NXM_NX_TUN_METADATA nxms can appear in a flow mod in any order

Re: [ovs-dev] HOST to SWITCH packets

2015-01-23 Thread Ben Pfaff
On Fri, Jan 23, 2015 at 01:47:40PM +0530, Sree Vidya S D wrote: > I am working with the > > "void ovs_dp_process_received_packet(struct vport *p, struct sk_buff *skb)" > > function in datapath.c > > If I am right this function deals with packets that is send from a switch > to another switch, d

Re: [ovs-dev] [PATCH] test-sflow: Fix error message when a socket cannot be opened.

2015-01-23 Thread Ben Pfaff
On Fri, Jan 23, 2015 at 12:17:04PM +0100, Thomas Graf wrote: > On 01/22/15 at 10:03pm, Ben Pfaff wrote: > > The error message should name the socket, which is 'target', not argv[1], > > which might be anything. > > > > Signed-off-by: Ben Pfaff > > Acked-by: Thomas Graf Thanks, applied to maste

Re: [ovs-dev] [PATCH 2/4] lib: Add Mac OSX compatability

2015-01-23 Thread Ben Pfaff
On Fri, Jan 23, 2015 at 01:17:36AM +, Dave Tucker wrote: > Signed-off-by: Dave Tucker > -#ifndef _WIN32 > +#if !defined(__APPLE__) && !defined(_WIN32) > static inline ovs_be64 > htonll(uint64_t n) It's probably time to add an autoconf test for htonll() instead of using OS-specific tests.

Re: [ovs-dev] [PATCH 3/4] ofproto: Fix duplicate wait function from OSX

2015-01-23 Thread Ben Pfaff
On Fri, Jan 23, 2015 at 05:31:06PM +0100, Thomas Graf wrote: > On 01/23/15 at 04:10pm, Dave Tucker wrote: > > > > > > On 23 Jan 2015, at 11:38, Thomas Graf wrote: > > >I doubt that the Darwin implementation takes a struct ofproto ;-) > > > > Yeah I brute-forced a way around it that only generate

Re: [ovs-dev] [PATCH 4/4] docs: Add README.OSX.md

2015-01-23 Thread Ben Pfaff
On Fri, Jan 23, 2015 at 01:17:38AM +, Dave Tucker wrote: > +Usage > +- > + > +> NOTE: Currently the userspace utilities will *only* work with the > equivalent OVS version Why? > +Assuming you have an Open vSwitch instance listening on `ptcp:6640`, you can > interact with it as follows: >

[ovs-dev] format_uint32_masked call for printing reg value in match_format

2015-01-23 Thread Sabyasachi Sengupta
Hi, I see that in ovs-2.3 onwards, we use format_uint32_masked from match_format for printing register values. While use of format_uint32_masked for printing recirc_id, dp_hash and pkt_mark are fine, register values can have a legit value of 0. As format_uint32_masked uses "%#x", we may end u

Re: [ovs-dev] format_uint32_masked call for printing reg value in match_format

2015-01-23 Thread Ben Pfaff
On Fri, Jan 23, 2015 at 02:52:46PM -0800, Sabyasachi Sengupta wrote: > I see that in ovs-2.3 onwards, we use format_uint32_masked from > match_format for printing register values. While use of > format_uint32_masked for printing recirc_id, dp_hash and pkt_mark > are fine, register values can have a

Re: [ovs-dev] format_uint32_masked call for printing reg value in match_format

2015-01-23 Thread Sabyasachi Sengupta
Yes, just wondering about the flow parsing scripts out there that may be break.. On Fri, 23 Jan 2015, Ben Pfaff wrote: On Fri, Jan 23, 2015 at 02:52:46PM -0800, Sabyasachi Sengupta wrote: I see that in ovs-2.3 onwards, we use format_uint32_masked from match_format for printing register valu

[ovs-dev] [PATCH] ovs-bugtool: Add --help message.

2015-01-23 Thread Ben Pfaff
Seemed a little embarrassing when I realized that ovs-bugtool has no usage message on a customer call this morning. Signed-off-by: Ben Pfaff --- utilities/bugtool/ovs-bugtool.in | 30 +- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a/utilities/bugtool

Re: [ovs-dev] [PATCH] ovs-bugtool: Add --help message.

2015-01-23 Thread Alex Wang
Thx for fixing this, --output-fd=FD is not valid option, do you mean --outfile and --outfd ? Otherwise, looks good~ Acked-by: Alex Wang On Fri, Jan 23, 2015 at 3:19 PM, Ben Pfaff wrote: > Seemed a little embarrassing when I realized that ovs-bugtool has no usage > message on a customer call