[ovs-dev] [PATCH] lib/route-table-*: Fix non-Linux builds

2014-11-25 Thread YAMAMOTO Takashi
Fix build failures introduced by commit 1bc50ef389d40be9ee215e66b49cf66fcbdb9eeb ("dpctl: Fix crash.") Signed-off-by: YAMAMOTO Takashi --- lib/route-table-bsd.c | 2 +- lib/route-table-stub.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/route-table-bsd.c b/lib/rout

[ovs-dev] [PATCH] ovs-ofctl.at: Fix test for TCP flags

2014-11-25 Thread YAMAMOTO Takashi
Update the test after commit 847ddeab372220170f431f1b9dd504237066729a ("meta-flow: Add support for ONF OpenFlow 1.3 extension ONFOXM_ET_TCP_FLAGS.") Signed-off-by: YAMAMOTO Takashi --- tests/ovs-ofctl.at | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/tests/ov

[ovs-dev] Bug#768095: openvswitch-datapath-dkms fails to build on Debian 7.7 3.2.0-4-amd64 (3.2.63-2+deb7u1)

2014-11-25 Thread Thomas Goirand
On 11/25/2014 12:32 AM, Jonathan Dupart wrote: > Hi, > > I am looking for a sponsor for the package openvswitch to correct bug > #768095. > > This bug prevents building the openvswitch kernel module with the last > stable kernel. > > As openvswitch maintainer requested an NMU, i built a package

Re: [ovs-dev] [PATCH] lib/route-table-*: Fix non-Linux builds

2014-11-25 Thread Ben Pfaff
On Tue, Nov 25, 2014 at 05:01:13PM +0900, YAMAMOTO Takashi wrote: > Fix build failures introduced by > commit 1bc50ef389d40be9ee215e66b49cf66fcbdb9eeb > ("dpctl: Fix crash.") > > Signed-off-by: YAMAMOTO Takashi Acked-by: Ben Pfaff ___ dev mailing list

Re: [ovs-dev] [PATCH] datapath/linux: add KCFLAGS var to modules Makefile.main.in

2014-11-25 Thread Ben Pfaff
On Tue, Oct 28, 2014 at 07:51:16AM -0700, Ben Pfaff wrote: > From: Alexandru Ardelean > > This is mostly required because of GCC 4.9 which seems > to error out with: > openvswitch/datapath/linux/datapath.c:2108:10: >error: macro "DATE" might prevent reproducible builds > > We would hav

[ovs-dev] [PATCH] datapath-windows: Broken build on MSVC

2014-11-25 Thread Alin Serdean
Removing unused local variable. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/Flow.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/datapath-windows/ovsext/Flow.c b/datapath-windows/ovsext/Flow.c index ceac37f..1257377 100644 --- a/datapath-windows/ovsext/Flow.c +++ b/da

Re: [ovs-dev] [PATCH] datapath/linux: add KCFLAGS var to modules Makefile.main.in

2014-11-25 Thread Thomas Graf
On 11/25/14 at 07:47am, Ben Pfaff wrote: > On Tue, Oct 28, 2014 at 07:51:16AM -0700, Ben Pfaff wrote: > > From: Alexandru Ardelean > > > > This is mostly required because of GCC 4.9 which seems > > to error out with: > > openvswitch/datapath/linux/datapath.c:2108:10: > >error: macro "DA

Re: [ovs-dev] ofport_open and alloc_ofp_port

2014-11-25 Thread Ben Pfaff
On Thu, Nov 20, 2014 at 12:38:47PM -0800, Prashanth Mundkur wrote: > I'm able to resolve the assert with the following patch to > ofproto.c:ofport_open(): > > diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c > index 653b2a8..48ceff7 100644 > --- a/ofproto/ofproto.c > +++ b/ofproto/ofproto.c > @@

Re: [ovs-dev] [PATCH] vswitch.xml: Describe NetFlow passive timeout.

2014-11-25 Thread Ben Pfaff
On Wed, Nov 05, 2014 at 08:35:56AM -0800, Ben Pfaff wrote: > Reported-by: Martin Vizvary > Signed-off-by: Ben Pfaff I'd appreciate a review. Thanks, Ben. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] Makefile: Add static check for misuse of LITTLE_ENDIAN and BIG_ENDIAN.

2014-11-25 Thread Ben Pfaff
On Tue, Nov 04, 2014 at 11:42:55AM -0800, Ben Pfaff wrote: > I've pointed out two misuses of these macros in review in the last week, > by different authors. It's time to make it difficult to screw this up. > > Signed-off-by: Ben Pfaff I'd appreciate a review. __

Re: [ovs-dev] [PATCH] ovs-vsctl: Prevent creating duplicate VLAN bridges.

2014-11-25 Thread Ben Pfaff
On Thu, Nov 06, 2014 at 02:59:48PM -0800, Ben Pfaff wrote: > ovs-vsctl has the concept of a VLAN (or "fake") bridge, which is a > sort of a sub-bridge that receives only packets on a particular VLAN. > There is no way to distinguish two VLAN bridges with the same parent on the > same VLAN, but unti

Re: [ovs-dev] [PATCH] openflow: Note that element 4 of enum ofp15_group_mod_command is reserved

2014-11-25 Thread Ben Pfaff
On Fri, Nov 21, 2014 at 10:15:32AM +0900, Simon Horman wrote: > The spec has been clarified to note that element 4 of > enum ofp_group_mod_command is reserved. This patch reflects > that change. > > ONF-JIRA: EXT-350 > Signed-off-by: Simon Horman Thanks, applied!

Re: [ovs-dev] [PATCH] openflow: Use *_array_len names in struct ofp15_bucket and ofp15_group_mod

2014-11-25 Thread Ben Pfaff
On Fri, Nov 21, 2014 at 10:16:23AM +0900, Simon Horman wrote: > The spec has been clarified to use _list_len in palce of _list_len > terminology to make it clearer that the data is not an ordered list > (it is a set). The code present in Open vSwitch already avoided > the _list_len terminology. Thi

Re: [ovs-dev] [PATCH] Makefile: Add static check for misuse of LITTLE_ENDIAN and BIG_ENDIAN.

2014-11-25 Thread Thomas Graf
On 11/04/14 at 11:42am, Ben Pfaff wrote: > I've pointed out two misuses of these macros in review in the last week, > by different authors. It's time to make it difficult to screw this up. > > Signed-off-by: Ben Pfaff > --- > Makefile.am | 17 + > 1 file changed, 17 insertions

Re: [ovs-dev] [PATCH] Makefile: Add static check for misuse of LITTLE_ENDIAN and BIG_ENDIAN.

2014-11-25 Thread Thomas Graf
On 11/25/14 at 05:19pm, Thomas Graf wrote: > On 11/04/14 at 11:42am, Ben Pfaff wrote: > > I've pointed out two misuses of these macros in review in the last week, > > by different authors. It's time to make it difficult to screw this up. > > > > Signed-off-by: Ben Pfaff > > Missed s// above ^^^

Re: [ovs-dev] [PATCH] ovs-ofctl: Implementation of eviction on the basis of Importance

2014-11-25 Thread Ben Pfaff
On Fri, Nov 21, 2014 at 03:13:40PM +0530, Saloni Jain wrote: > >There is no need for this code in handle_table_desc_request() because > >higher-level code has already checked these properties for > >correctness: > >    ofpbuf_use_const(&msg, request, ntohs(request->length)); > >   ofpraw_pull_asser

Re: [ovs-dev] [PATCH 2/2] ofproto-dpif: fix OF1.4 packet-in wire protocol version

2014-11-25 Thread Ben Pfaff
On Fri, Nov 21, 2014 at 11:44:24AM -0800, Shu Shen wrote: > Previously even when OF1.4 is used between the controller and the > switch, packet-in messages has OF1.3 as wire protocol version. > > Signed-off-by: Shu Shen It looks like this was already fixed by Simon Horman's patch last week. I'll

Re: [ovs-dev] [PATCH] ovs-vsctl: Prevent creating duplicate VLAN bridges.

2014-11-25 Thread Thomas Graf
On 11/06/14 at 02:59pm, Ben Pfaff wrote: > ovs-vsctl has the concept of a VLAN (or "fake") bridge, which is a > sort of a sub-bridge that receives only packets on a particular VLAN. > There is no way to distinguish two VLAN bridges with the same parent on the > same VLAN, but until now ovs-vsctl di

Re: [ovs-dev] [PATCH] datapath/linux: add KCFLAGS var to modules Makefile.main.in

2014-11-25 Thread Alexandru Ardelean
It's been a while since I made that patch. I'll have to check. I'll be back in a while with a few findings. Thanks On Tue, Nov 25, 2014 at 6:10 PM, Thomas Graf wrote: > On 11/25/14 at 07:47am, Ben Pfaff wrote: > > On Tue, Oct 28, 2014 at 07:51:16AM -0700, Ben Pfaff wrote: > > > From: Alexandru

[ovs-dev] [PATCH] tests: Fix test broken by introduction of ONFOXM_ET_TCP_FLAGS.

2014-11-25 Thread Ben Pfaff
Commit 847ddeab372220 (meta-flow: Add support for ONF OpenFlow 1.3 extension ONFOXM_ET_TCP_FLAGS.) failed to update a test to match the new OXM extension. This fixes the problem. Signed-off-by: Ben Pfaff --- I already applied this as an obvious fix for the problem that I introduced yesterday wit

Re: [ovs-dev] [PATCH 1/2] ofproto-dpif: add test case for OF1.4 packet-in

2014-11-25 Thread Ben Pfaff
On Fri, Nov 21, 2014 at 11:44:23AM -0800, Shu Shen wrote: > The test case current fails and shows a bug when OF1.4 is used between > the controller and the switch, the packet-in message still uses OF1.3 > wire protocol version. > > Signed-off-by: Shu Shen Normally, I would not add a test before

Re: [ovs-dev] [PATCH] datapath-windows: Fixed Release broken build

2014-11-25 Thread Ben Pfaff
On Mon, Nov 24, 2014 at 04:26:00PM +, Sorin Vinturis wrote: > The release configurations of the OVSEXT project were not compiling. > This was due to a warning that was treated as error. Fixed that. > > I did not want to remove that variable, because it is used in an > ASSERT in that function.

Re: [ovs-dev] [PATCH] datapath-windows: Update OVSEXT VS project to support 6.40

2014-11-25 Thread Ben Pfaff
On Mon, Nov 24, 2014 at 04:17:34PM +, Sorin Vinturis wrote: > Added support for creating OVS extension driver NDIS 6.40 compliant. > > Currently the OVSEXT Visual Studio project has four build configurations, > 'Win8 Release', 'Win8 Debug', 'Win8.1 Release' and 'Win8.1 Debug'. All of > them ar

Re: [ovs-dev] [PATCH] ovs-ofctl.at: Fix test for TCP flags

2014-11-25 Thread Ben Pfaff
On Tue, Nov 25, 2014 at 05:13:10PM +0900, YAMAMOTO Takashi wrote: > Update the test after commit 847ddeab372220170f431f1b9dd504237066729a > ("meta-flow: Add support for ONF OpenFlow 1.3 extension ONFOXM_ET_TCP_FLAGS.") > > Signed-off-by: YAMAMOTO Takashi Oops, sorry, I fixed this when I noticed

Re: [ovs-dev] [PATCH] datapath-windows: Broken build on MSVC

2014-11-25 Thread Ben Pfaff
On Tue, Nov 25, 2014 at 03:52:28PM +, Alin Serdean wrote: > Removing unused local variable. > > > Signed-off-by: Alin Gabriel Serdean Applied, thanks! ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] Makefile: Add static check for misuse of LITTLE_ENDIAN and BIG_ENDIAN.

2014-11-25 Thread Ben Pfaff
On Tue, Nov 25, 2014 at 05:20:37PM +0100, Thomas Graf wrote: > On 11/25/14 at 05:19pm, Thomas Graf wrote: > > On 11/04/14 at 11:42am, Ben Pfaff wrote: > > > I've pointed out two misuses of these macros in review in the last week, > > > by different authors. It's time to make it difficult to screw

Re: [ovs-dev] [PATCH] ovs-vsctl: Prevent creating duplicate VLAN bridges.

2014-11-25 Thread Ben Pfaff
On Tue, Nov 25, 2014 at 05:25:56PM +0100, Thomas Graf wrote: > On 11/06/14 at 02:59pm, Ben Pfaff wrote: > > ovs-vsctl has the concept of a VLAN (or "fake") bridge, which is a > > sort of a sub-bridge that receives only packets on a particular VLAN. > > There is no way to distinguish two VLAN bridge

[ovs-dev] [PATCH v3] datapath-windows: update DESIGN document

2014-11-25 Thread Nithin Raju
In this patch, we update the design document to reflect the netlink based kernel-userspace interface implementation and a few other changes. I have covered at a high level. Please feel free to extend the document with more details that you think got missed out. Signed-off-by: Nithin Raju Acked-b

Re: [ovs-dev] [PATCH v3] datapath-windows: update DESIGN document

2014-11-25 Thread Ben Pfaff
On Tue, Nov 25, 2014 at 09:06:43AM -0800, Nithin Raju wrote: > In this patch, we update the design document to reflect the netlink > based kernel-userspace interface implementation and a few other changes. > I have covered at a high level. > > Please feel free to extend the document with more deta

[ovs-dev] [PATCH] datapath-windows: Fix BSOD when uninstalling driver

2014-11-25 Thread Alin Serdean
Add an additional check to see if the flowTable is not NULL. kd> k Child-SP RetAddr Call Site d000`26166af8 f802`dde5e7c6 nt!DbgBreakPointWithStatus d000`26166b00 f802`dde5e0d7 nt!KiBugCheckDebugBreak+0x12 d000`26166b60 f802`51a4 nt!KeBugCheck2+0x8ab

Re: [ovs-dev] [PATCH] datapath-windows: Fix BSOD when uninstalling driver

2014-11-25 Thread Sorin Vinturis
Acked-by: Sorin Vinturis -Original Message- From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Alin Serdean Sent: Tuesday, 25 November, 2014 19:09 To: dev@openvswitch.org Subject: [ovs-dev] [PATCH] datapath-windows: Fix BSOD when uninstalling driver Add an additional check to se

Re: [ovs-dev] [PATCH] datapath-windows: Fix BSOD when uninstalling driver

2014-11-25 Thread Eitan Eliahu
Hi Alin, Thank you for fixing this issue. Do you think we can acquire the lock in OvsDeleteFlowTable() ? Eitan -Original Message- From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Alin Serdean Sent: Tuesday, November 25, 2014 9:09 AM To: dev@openvswitch.org Subject: [ovs-dev] [

Re: [ovs-dev] [PATCH] datapath-windows: Fix BSOD when uninstalling driver

2014-11-25 Thread Nithin Raju
On Nov 25, 2014, at 9:09 AM, Alin Serdean wrote: > +if (datapath->flowTable == NULL) { > +status = STATUS_INVALID_PARAMETER; > +goto dp_unlock; > +} Alin, We allocate the flow table in OvsAllocateFlowTable() when the datapath is allocated, which is when the 'gOvsSwitchC

Re: [ovs-dev] [PATCH] tests/ovs_client: Remove broken debug code

2014-11-25 Thread Pravin Shelar
On Wed, Nov 19, 2014 at 4:03 AM, Stephen Finucane wrote: > There is some debug "logging" code included in the 'ovs_client' > application. This code appears to be broken as it spams stdout with > duplicated "log" messages. Remove this code. > > In addition, add the 'ovsclient' executable to the 'te

[ovs-dev] [PATCH] route-table: Remove Unregister.

2014-11-25 Thread Pravin B Shelar
Since dpif registering for routing table at initialization there is no need to unregister it. Following patch removes support for turning routing table notifications on and off. Due to this change OVS always listens for these notifications. Reported-by: YAMAMOTO Takashi Signed-off-by: Pravin B Sh

Re: [ovs-dev] [PATCHv10 ovs 00/15] Revalidate flows with unique identifiers.

2014-11-25 Thread Joe Stringer
On 13 November 2014 at 11:17, Joe Stringer wrote: > > This series modifies the dpif interface for flow commands to use 128-bit > unique > identifiers as an alternative to the netlink-formatted flow key, and caches > the > mask/actions in the udpif_key. This significantly reduces the cost of > as

Re: [ovs-dev] [PATCH] vswitch.xml: Describe NetFlow passive timeout.

2014-11-25 Thread Jarno Rajahalme
Acked-by: Jarno Rajahalme On Nov 5, 2014, at 8:35 AM, Ben Pfaff wrote: > Reported-by: Martin Vizvary > Signed-off-by: Ben Pfaff > --- > AUTHORS | 1 + > vswitchd/vswitch.xml | 18 ++ > 2 files changed, 15 insertions(+), 4 deletions(-) > > diff --git a/AUTHORS b/AU

Re: [ovs-dev] [PATCH] tests: Fix test broken by introduction of ONFOXM_ET_TCP_FLAGS.

2014-11-25 Thread Jarno Rajahalme
LGTM, Acked-by: Jarno Rajahalme Jarno On Nov 25, 2014, at 8:39 AM, Ben Pfaff wrote: > Commit 847ddeab372220 (meta-flow: Add support for ONF OpenFlow 1.3 > extension ONFOXM_ET_TCP_FLAGS.) failed to update a test to match the new > OXM extension. This fixes the problem. > > Signed-off-by: B

Re: [ovs-dev] [PATCH] vswitch.xml: Describe NetFlow passive timeout.

2014-11-25 Thread Ben Pfaff
Thanks! Applied to master. On Tue, Nov 25, 2014 at 12:35:12PM -0800, Jarno Rajahalme wrote: > Acked-by: Jarno Rajahalme > > On Nov 5, 2014, at 8:35 AM, Ben Pfaff wrote: > > > Reported-by: Martin Vizvary > > Signed-off-by: Ben Pfaff > > --- > > AUTHORS | 1 + > > vswitchd/vswitch

Re: [ovs-dev] [PATCH] route-table: Remove Unregister.

2014-11-25 Thread Ben Pfaff
On Tue, Nov 25, 2014 at 11:41:45AM -0800, Pravin B Shelar wrote: > Since dpif registering for routing table at initialization > there is no need to unregister it. Following patch removes > support for turning routing table notifications on and off. > Due to this change OVS always listens for these

Re: [ovs-dev] [PATCH] datapath-windows: Fix BSOD when uninstalling driver

2014-11-25 Thread Ben Pfaff
On Tue, Nov 25, 2014 at 05:09:29PM +, Alin Serdean wrote: > Add an additional check to see if the flowTable is not NULL. Hi Alin, can you provide a Signed-off-by? Thanks, Ben. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/

Re: [ovs-dev] [PATCH] datapath-windows: Fix BSOD when uninstalling driver

2014-11-25 Thread Nithin Raju
Hi Ben, This change is not good to go. Alin has filed a bug for investigating this. Sorin or I will address it soon. Thanks, -- Nithin - sent from mobile - > On Nov 25, 2014, at 14:11, "Ben Pfaff" wrote: > >> On Tue, Nov 25, 2014 at 05:09:29PM +, Alin Serdean wrote: >> Add an additional c

Re: [ovs-dev] [PATCH] datapath-windows: Fix BSOD when uninstalling driver

2014-11-25 Thread Ben Pfaff
OK, thanks for letting me know, I had the impression it was ready. On Tue, Nov 25, 2014 at 10:15:19PM +, Nithin Raju wrote: > Hi Ben, > This change is not good to go. Alin has filed a bug for investigating this. > Sorin or I will address it soon. > > Thanks, > -- Nithin > > - sent from mobi

Re: [ovs-dev] [PATCH 1/2] lib: Add new header to versioning info

2014-11-25 Thread Ben Pfaff
On Mon, Nov 24, 2014 at 12:49:00PM +0100, Thomas Graf wrote: > Exposes the package version as string and the library versioning > as numeric macro. > > OVS_LIB_VERSION may be used to check for a particular version of > the interface. > > OVS_LIB_REVISION and OVS_LIB_AGE exist to map a set of inst

Re: [ovs-dev] [PATCH 2/2] lib: Add API to set program name and version

2014-11-25 Thread Ben Pfaff
On Mon, Nov 24, 2014 at 12:49:01PM +0100, Thomas Graf wrote: > Required to have reasonable logging messages. > > Signed-off-by: Thomas Graf Applied, thanks! ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] ofproto: fix checking of packet_in_mask in async config

2014-11-25 Thread Shu Shen
Hi Ben, Have you got a chance to look at the below patch? In the test case, wire_reason() translate OFPR_ACTION to OFPR_NO_MATCH, but OFPR_ACTION (as the value of pin->up.reason) was still passed to ofconn_receives_async_msg() to check whether the packet-in shall be sent or not - which it deci

Re: [ovs-dev] [PATCH] ofproto: fix checking of packet_in_mask in async config

2014-11-25 Thread Ben Pfaff
On Fri, Nov 21, 2014 at 04:27:25PM -0800, Shu Shen wrote: > The check shall use wire protool reasons, which could be different from > the internal packet-in reason. > > Signed-off-by: Shu Shen Thanks for finding the bug and for fixing it! I applied this to master. __

Re: [ovs-dev] [PATCH] ofproto: fix checking of packet_in_mask in async config

2014-11-25 Thread Ben Pfaff
On Tue, Nov 25, 2014 at 11:18:38PM +, Shu Shen wrote: > Have you got a chance to look at the below patch? I was behind in review (I still am). Thanks for the patch! ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH/RFC 1/9] Add Netronome vendor Id

2014-11-25 Thread Ben Pfaff
On Wed, Nov 19, 2014 at 09:44:55AM +0900, Simon Horman wrote: > Add Netronome vendor Id: NMX_VENDOR_ID = 0x1540. > > This is based on the Netronome IEEE OUI, 00154D. > And it has been registered with the ONF: > > https://rs.opennetworking.org/wiki/display/PUBLIC/ONF+Registry > > Signed-off-b

Re: [ovs-dev] [PATCH/RFC 0/9] Group Select: Selection Method Extension

2014-11-25 Thread Ben Pfaff
On Wed, Nov 19, 2014 at 09:44:54AM +0900, Simon Horman wrote: > this patch set implements the group select selection method extension that > I circulated some months ago on the d...@openvswtich.org mailing list. For > reference a copy of that proposal (updated for the existence of an Open > Flow 1

Re: [ovs-dev] [PATCH/RFC 0/9] Group Select: Selection Method Extension

2014-11-25 Thread Ben Pfaff
On another note, the description of the extension at the end of this message is useful. Does one of the patches add it to the tree somewhere? ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 01/10] flow.h: Simplify MAP_FOR_EACH_INDEX()

2014-11-25 Thread Ben Pfaff
On Thu, Nov 20, 2014 at 04:42:48PM -0800, Jarno Rajahalme wrote: > Avoid comparing against specific values. > > Signed-off-by: Jarno Rajahalme Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 02/10] flow: Define MINIFLOW_GET__() to simplify code.

2014-11-25 Thread Ben Pfaff
On Thu, Nov 20, 2014 at 04:42:49PM -0800, Jarno Rajahalme wrote: > Signed-off-by: Jarno Rajahalme Can this be an inline function instead of a macro? I'd prefer that. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 03/10] flow.c: Improve minimask_equal() and minimask_has_extra().

2014-11-25 Thread Ben Pfaff
On Thu, Nov 20, 2014 at 04:42:50PM -0800, Jarno Rajahalme wrote: > minimask_equal() and minimask_has_extra() can take benefit from the > fact that minimasks have no zero data. > > Signed-off-by: Jarno Rajahalme I suspect that the new macro introduced in this patch could also be an inline functio

[ovs-dev] [PATCH] dpif-netdev: Fix a race.

2014-11-25 Thread Alex Wang
On current master, the 'struct dp_netdev_port' is destroyed immediately when the ref count reaches 0. However, non-pmd threads calling the dpif_netdev_execute() for sending packets could hold pointer to 'port' that is not ref-counted. Thusly those threads could possibly access freed memory when t

Re: [ovs-dev] [PATCH] dpif-netdev: Fix a race.

2014-11-25 Thread Ben Pfaff
On Tue, Nov 25, 2014 at 04:01:40PM -0800, Alex Wang wrote: > On current master, the 'struct dp_netdev_port' is destroyed > immediately when the ref count reaches 0. However, non-pmd > threads calling the dpif_netdev_execute() for sending packets > could hold pointer to 'port' that is not ref-count

Re: [ovs-dev] [PATCH 04/10] lib: Use MAP_FOR_EACH_INDEX to improve readability.

2014-11-25 Thread Ben Pfaff
On Thu, Nov 20, 2014 at 04:42:51PM -0800, Jarno Rajahalme wrote: > Signed-off-by: Jarno Rajahalme In most of the cases this just improves readability and should not change the generated code much if at all. In miniflow_hash(), though, the previous code did not need to use raw_ctz(), which is rel

[ovs-dev] [PATCH] ofproto: add support of OPRO_GROUP as packet-in reason for OF1.4+

2014-11-25 Thread Shu Shen
When the Packet-In message is triggered by a group action, OFPR_GROUP is passed internally as the reason. The wire_reason() function converts the reason to OFPR_ACTION if the wire protocol is earlier than OF1.4. The wire_reason() function also converts other unsupported reasons (i.e., OFPR_ACTION_

Re: [ovs-dev] [PATCH 05/10] lib: inline miniflow trivial functions.

2014-11-25 Thread Ben Pfaff
On Thu, Nov 20, 2014 at 04:42:52PM -0800, Jarno Rajahalme wrote: > miniflow_clone_inline(), miniflow_destroy(), miniflow_expand(), > miniflow_get(), miniflow_equal(), minimask_init(), minimask_clone(), > minimask_move(), minimask_destroy(), minimask_expand(), > minimask_expand, minimask_get(), mini

Re: [ovs-dev] [PATCH] dpif-netdev: Fix a race.

2014-11-25 Thread Alex Wang
On Tue, Nov 25, 2014 at 4:02 PM, Ben Pfaff wrote: > On Tue, Nov 25, 2014 at 04:01:40PM -0800, Alex Wang wrote: > > On current master, the 'struct dp_netdev_port' is destroyed > > immediately when the ref count reaches 0. However, non-pmd > > threads calling the dpif_netdev_execute() for sending

[ovs-dev] [PATCH] dpif-netlink: Fix windows build.

2014-11-25 Thread Joe Stringer
Commit 7af12bd "dpif: Generate flow_hash for revalidators in dpif." broke compilation on windows. Fix it. Signed-off-by: Joe Stringer --- lib/dpif-netlink.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/dpif-netlink.c b/lib/dpif-netlink.c index 6c0cc07..f290cc6 10064

Re: [ovs-dev] [PATCH] dpif-netlink: Fix windows build.

2014-11-25 Thread Ben Pfaff
On Tue, Nov 25, 2014 at 04:39:49PM -0800, Joe Stringer wrote: > Commit 7af12bd "dpif: Generate flow_hash for revalidators in dpif." > broke compilation on windows. Fix it. > > Signed-off-by: Joe Stringer Are you doing regular Windows builds? That's nice, thanks. Acked-by: Ben Pfaff __

Re: [ovs-dev] [PATCH] dpif-netlink: Fix windows build.

2014-11-25 Thread Joe Stringer
On 25 November 2014 at 16:44, Ben Pfaff wrote: > On Tue, Nov 25, 2014 at 04:39:49PM -0800, Joe Stringer wrote: >> Commit 7af12bd "dpif: Generate flow_hash for revalidators in dpif." >> broke compilation on windows. Fix it. >> >> Signed-off-by: Joe Stringer > > Are you doing regular Windows builds

[ovs-dev] [PATCHv11 1/5] datapath: Add UFID interface to openvswitch.h.

2014-11-25 Thread Joe Stringer
An upcoming set of patches will implement support for indexing flows by Unique Flow IDentifiers (UFID) rather than the traditional unmasked key. This patch implements the interface changes required. The implementation will follow. Signed-off-by: Joe Stringer CC: Pravin B Shelar --- v11: Split fr

[ovs-dev] [PATCHv11 0/5] Revalidate flows with unique identifiers.

2014-11-25 Thread Joe Stringer
=== Summary === Patches 1,4,5 are not yet reviewed. The linux datapath patches are not included in this series, as I intend to rebase them against linux net-next and push them through the review process on the netdev list. This series is also made available here to assist review: https://github.c

[ovs-dev] [PATCHv11 2/5] dpif: Index flows using unique identifiers.

2014-11-25 Thread Joe Stringer
This patch modifies the dpif interface to allow flows to be manipulated using a 128-bit identifier. This allows revalidator threads to perform datapath operations faster, as they do not need to serialise the entire flow key for operations like flow_get and flow_delete. In conjunction with a future

[ovs-dev] [PATCHv11 5/5] ovs-bugtool: Log more detail for dumped flows.

2014-11-25 Thread Joe Stringer
The standard mode for printing flows doesn't always provide the full range of information that is available, particularly with the UFID changes. Turn on more detail. Suggested-by: Justin Pettit Signed-off-by: Joe Stringer --- v10-v11: No change. v9: First post. --- utilities/bugtool/ovs-bugtool

[ovs-dev] [PATCHv11 3/5] dpif: Minimize memory copy for revalidation.

2014-11-25 Thread Joe Stringer
One of the limiting factors on the number of flows that can be supported in the datapath is the overhead of assembling flow dump messages in the datapath. This patch modifies the dpif to allow revalidators to skip dumping the key, mask and actions from the datapath, by making use of the unique flow

Re: [ovs-dev] [PATCH 06/10] flow.c: Only support inline values in miniflow_extract().

2014-11-25 Thread Ben Pfaff
On Thu, Nov 20, 2014 at 04:42:53PM -0800, Jarno Rajahalme wrote: > All the users of miniflow extract supply a miniflow with inlined data. > Make the extraction a bit more efficient by only supporting this. > > Also, clean up miniflow building utilities in preparation for moving > them to lib/flow.

[ovs-dev] [PATCHv11 4/5] dpctl: Add support for using UFID to add/del flows.

2014-11-25 Thread Joe Stringer
Signed-off-by: Joe Stringer --- XXX: Windows doesn't have a 'strndup' implementation, apparently. Should do something about this. v11: Rebase. v10: First post. --- lib/dpctl.c| 41 + lib/odp-util.c | 35 +++ lib/odp-

Re: [ovs-dev] [PATCH/RFC 1/9] Add Netronome vendor Id

2014-11-25 Thread Simon Horman
On Tue, Nov 25, 2014 at 03:22:04PM -0800, Ben Pfaff wrote: > On Wed, Nov 19, 2014 at 09:44:55AM +0900, Simon Horman wrote: > > Add Netronome vendor Id: NMX_VENDOR_ID = 0x1540. > > > > This is based on the Netronome IEEE OUI, 00154D. > > And it has been registered with the ONF: > > > > https:/

Re: [ovs-dev] [PATCH/RFC 0/9] Group Select: Selection Method Extension

2014-11-25 Thread Simon Horman
On Tue, Nov 25, 2014 at 03:30:01PM -0800, Ben Pfaff wrote: > On Wed, Nov 19, 2014 at 09:44:54AM +0900, Simon Horman wrote: > > this patch set implements the group select selection method extension that > > I circulated some months ago on the d...@openvswtich.org mailing list. For > > reference a c

Re: [ovs-dev] [PATCH/RFC 0/9] Group Select: Selection Method Extension

2014-11-25 Thread Simon Horman
On Tue, Nov 25, 2014 at 03:31:50PM -0800, Ben Pfaff wrote: > On another note, the description of the extension at the end of this > message is useful. Does one of the patches add it to the tree > somewhere? No, but I'm happy to add such a patch. It could go into a header or .c file somewhat but

[ovs-dev] [PATCH 2/2] ovs-command-completion: Autotest integration.

2014-11-25 Thread Alex Wang
This commit integrates the unit tests defined in utilities/ovs-command-compgen-test.bash into 'make check'. The tests will be skipped if the current shell is not '/bin/bash'. Signed-off-by: Alex Wang --- Makefile.am |1 + tests/automake.mk |

[ovs-dev] [PATCH 1/2] ovs-command-completion: Fix unwanted whitespace.

2014-11-25 Thread Alex Wang
This commit fixes unwanted whitespace in the ovs bash completion script output. Signed-off-by: Alex Wang --- utilities/ovs-command-compgen.bash |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utilities/ovs-command-compgen.bash b/utilities/ovs-command-compgen.bash index c8

Re: [ovs-dev] [PATCH] route-table: Remove Unregister.

2014-11-25 Thread YAMAMOTO Takashi
> On Tue, Nov 25, 2014 at 11:41:45AM -0800, Pravin B Shelar wrote: >> Since dpif registering for routing table at initialization >> there is no need to unregister it. Following patch removes >> support for turning routing table notifications on and off. >> Due to this change OVS always listens for

Re: [ovs-dev] [PATCH] lib/route-table-*: Fix non-Linux builds

2014-11-25 Thread YAMAMOTO Takashi
> On Tue, Nov 25, 2014 at 05:01:13PM +0900, YAMAMOTO Takashi wrote: >> Fix build failures introduced by >> commit 1bc50ef389d40be9ee215e66b49cf66fcbdb9eeb >> ("dpctl: Fix crash.") >> >> Signed-off-by: YAMAMOTO Takashi > > Acked-by: Ben Pfaff thank you. applied. YAMAMOTO Takashi _

Re: [ovs-dev] [PATCH] route-table: Remove Unregister.

2014-11-25 Thread Ben Pfaff
On Wed, Nov 26, 2014 at 11:20:54AM +0900, YAMAMOTO Takashi wrote: > > On Tue, Nov 25, 2014 at 11:41:45AM -0800, Pravin B Shelar wrote: > >> Since dpif registering for routing table at initialization > >> there is no need to unregister it. Following patch removes > >> support for turning routing tab

Re: [ovs-dev] [PATCH] ovs-ofctl.at: Fix test for TCP flags

2014-11-25 Thread YAMAMOTO Takashi
> On Tue, Nov 25, 2014 at 05:13:10PM +0900, YAMAMOTO Takashi wrote: >> Update the test after commit 847ddeab372220170f431f1b9dd504237066729a >> ("meta-flow: Add support for ONF OpenFlow 1.3 extension >> ONFOXM_ET_TCP_FLAGS.") >> >> Signed-off-by: YAMAMOTO Takashi > > Oops, sorry, I fixed this w

Re: [ovs-dev] [PATCH/RFC 1/9] Add Netronome vendor Id

2014-11-25 Thread Ben Pfaff
On Wed, Nov 26, 2014 at 10:33:29AM +0900, Simon Horman wrote: > On Tue, Nov 25, 2014 at 03:22:04PM -0800, Ben Pfaff wrote: > > On Wed, Nov 19, 2014 at 09:44:55AM +0900, Simon Horman wrote: > > > Add Netronome vendor Id: NMX_VENDOR_ID = 0x1540. > > > > > > This is based on the Netronome IEEE OU

Re: [ovs-dev] [PATCH v5 11/13] datapath: Allow masks for set actions.

2014-11-25 Thread Jesse Gross
On Fri, Sep 5, 2014 at 4:05 PM, Jarno Rajahalme wrote: > Masked set action allows more megaflow wildcarding. Masked set action > is now supported for all writeable key types, except for the tunnel > key. > > The set tunnel action is an exception as any input tunnel info is > cleared before action

Re: [ovs-dev] [PATCH] route-table: Remove Unregister.

2014-11-25 Thread YAMAMOTO Takashi
> Since dpif registering for routing table at initialization > there is no need to unregister it. Following patch removes > support for turning routing table notifications on and off. > Due to this change OVS always listens for these > notifications. probably rename route_table_register to route_t

Re: [ovs-dev] [PATCH v5 12/13] datapath: Relax flow set-up time validations.

2014-11-25 Thread Jesse Gross
On Fri, Sep 5, 2014 at 4:05 PM, Jarno Rajahalme wrote: > Allow setting of fields without matching on the same fields. Field > existence check is done on set action execution time instead, using > the extracted flow key. > > Signed-off-by: Jarno Rajahalme I guess it makes sense to switch to a ru

[ovs-dev] hello

2014-11-25 Thread Favour
favour_richa...@yahoo.com It is my great pleasure establishing a contact saw  your email hoping we can be friends contact me with thislooking forward to hearing from you Favour ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/list

[ovs-dev] hello

2014-11-25 Thread Naomi
naomiemman...@yahoo.com It is my great pleasure establishing a contact with you when i saw your email hoping we can be friends contact me with this (naomiemman...@yahoo.com) looking forward to hearing from you Naomi ___ dev mailing list dev@openvswitch.o