Ben, there were no differences between v1 and v2 patches, except the addition
of the acked-by message from patch description. Thanks!
-Original Message-
From: Ben Pfaff [mailto:b...@nicira.com]
Sent: Saturday, 15 November, 2014 00:12
To: Sorin Vinturis
Cc: dev@openvswitch.org
Subject: Re
Processing commands for cont...@bugs.debian.org:
> tags 768095 + patch
Bug #768095 [openvswitch-datapath-dkms] openvswitch-datapath-dkms fails to
build on Debian 7.7 3.2.0-4-amd64 (3.2.63-2+deb7u1)
Added tag(s) patch.
> thanks
Stopping processing here.
Please contact me if you need assistance.
-
Processing commands for cont...@bugs.debian.org:
> affects 768095 + openvswitch-switch
Bug #768095 [openvswitch-datapath-dkms] openvswitch-datapath-dkms fails to
build on Debian 7.7 3.2.0-4-amd64 (3.2.63-2+deb7u1)
Added indication that 768095 affects openvswitch-switch
> thanks
Stopping processin
Lieber Webmaster,
Als Betreiber der Webseite Datenverkehr.org möchte ich Sie einladen, Links
mit uns auszutauschen.
Wir werden die ganze Woche lang einen einzigartigen Linktausch
durchführen, der sich auf echte Links mit echtem Traffic von echten Seiten
mit echten Inhalten konzentriert!
Warum s
Processing commands for cont...@bugs.debian.org:
> severity 768095 grave
Bug #768095 [openvswitch-datapath-dkms] openvswitch-datapath-dkms fails to
build on Debian 7.7 3.2.0-4-amd64 (3.2.63-2+deb7u1)
Severity set to 'grave' from 'important'
> thanks
Stopping processing here.
Please contact me if
Hi,
I have been bittend by this bug.
I am raising this bug severity to grave, as it renders openvswitch
unusable after upgrading to the last stable kernel.
I tested the patch and it works flawlessly. It should be quite easy to
update the package in stable.
Regards,
--
Jonathan Dupart
> The problem must be that the port number and the hash value get out of sync,
> i.e., when the port number is changed. Please try the patch below on top of
> your patch and check if you still have the same problem.
With your modifications pertaining the hashmap those tests passed.
I had to reve
Packet metadata for layer 3 packets is expected to contain
OVS_KEY_ATTR_ETHERTYPE to indicate the network protocol.
Signed-off-by: Lorand Jakab
---
datapath/datapath.c | 14 +-
datapath/flow.c | 1 -
datapath/flow_netlink.c | 12
3 files changed, 13 insertio
This series implements support for layer 3 ports, of which we have one example
so far, the LISP vport. LISP support is currently implemented with a hack, by
adding/removing the Ethernet header within the datapath/vport-lisp.c file. By
removing the assumption that all packets/flows have Ethernet h
These actions will allow L2->L3 and L3->L2 switching, and are supposed
to be added to flows installed in the datapath transparently by
ovs-vswitchd.
Signed-off-by: Lorand Jakab
---
datapath/linux/compat/include/linux/openvswitch.h | 12 +
lib/dpif-netdev.c |
This is needed for sending a packet back to the datapath after a miss upcall
was processed. The presence of a layer 2 packet is signaled by adding
OVS_KEY_ATTR_ETHERNET to the packet metadata sent with the ovs_packet netlink
message. Layer 3 packets need to be accompanied by OVS_KEY_ATTR_ETHERTYP
Implementation of the pop_eth and push_eth actions in the kernel, and
layer 3 flow support.
Signed-off-by: Lorand Jakab
---
datapath/actions.c| 87 ---
datapath/flow.c | 45 --
datapath/flow.h |
This commit relaxes the assumption that all packets have an Ethernet
header, and adds support for layer 3 flows. For each packet received on
the Linux kernel datapath the l2 and l3 members of struct ofpbuf are
intialized appropriately, and some functions now expect this (notably
flow_extract()), i
On 11/14/14 11:02 PM, Jesse Gross wrote:
On Fri, Nov 14, 2014 at 3:51 AM, Lorand Jakab wrote:
diff --git a/datapath/datapath.c b/datapath/datapath.c
index 3607170..3ecb3cc 100644
--- a/datapath/datapath.c
+++ b/datapath/datapath.c
@@ -570,6 +558,23 @@ static int ovs_packet_cmd_execute(struct sk
Thanks!
-Original Message-
From: Eitan Eliahu [mailto:elia...@vmware.com]
Sent: Monday, 17 November, 2014 19:24
To: Sorin Vinturis
Subject: RE: [ovs-dev] [PATCH v3] datapath-windows: Avoid BSOD when switch
context is NULL
Acked-by: Eitan Eliahu
Thanks Sorin.
Eitan
-Original Messa
I came around a BSOD that happened when trying to access pidHashLock
from the gOvsSwitchContext, which was NULL. The stop happened in
OvsAcquirePidHashLock function.
To reproduce this BSOD, make sure the extension is enabled and running,
disable it and, after that, execute 'ovs-dpctl.exe show'. Th
On Mon, Nov 17, 2014 at 9:24 AM, Lorand Jakab wrote:
> diff --git a/datapath/flow.c b/datapath/flow.c
> index b01f7bd..3caa364 100644
> --- a/datapath/flow.c
> +++ b/datapath/flow.c
> @@ -462,7 +462,6 @@ static int key_extract(struct sk_buff *skb, struct
> sw_flow_key *key)
> /* Link laye
On Mon, Nov 17, 2014 at 9:24 AM, Lorand Jakab wrote:
> diff --git a/datapath/flow.c b/datapath/flow.c
> index 69b13b3..b01f7bd 100644
> --- a/datapath/flow.c
> +++ b/datapath/flow.c
> @@ -459,28 +459,31 @@ static int key_extract(struct sk_buff *skb, struct
> sw_flow_key *key)
>
> skb_rese
On 11/17/14 8:28 PM, Jesse Gross wrote:
On Mon, Nov 17, 2014 at 9:24 AM, Lorand Jakab wrote:
diff --git a/datapath/flow.c b/datapath/flow.c
index 69b13b3..b01f7bd 100644
--- a/datapath/flow.c
+++ b/datapath/flow.c
@@ -459,28 +459,31 @@ static int key_extract(struct sk_buff *skb, struct
sw_flow
On Mon, Nov 17, 2014 at 10:46 AM, Lori Jakab wrote:
> On 11/17/14 8:28 PM, Jesse Gross wrote:
>>
>> On Mon, Nov 17, 2014 at 9:24 AM, Lorand Jakab wrote:
>>>
>>> diff --git a/datapath/flow.c b/datapath/flow.c
>>> index 69b13b3..b01f7bd 100644
>>> --- a/datapath/flow.c
>>> +++ b/datapath/flow.c
>>>
On 11/17/14 8:48 PM, Jesse Gross wrote:
On Mon, Nov 17, 2014 at 10:46 AM, Lori Jakab wrote:
On 11/17/14 8:28 PM, Jesse Gross wrote:
On Mon, Nov 17, 2014 at 9:24 AM, Lorand Jakab wrote:
diff --git a/datapath/flow.c b/datapath/flow.c
index 69b13b3..b01f7bd 100644
--- a/datapath/flow.c
+++ b/da
On Mon, Nov 17, 2014 at 10:53 AM, Lori Jakab wrote:
> On 11/17/14 8:48 PM, Jesse Gross wrote:
>>
>> On Mon, Nov 17, 2014 at 10:46 AM, Lori Jakab wrote:
>>>
>>> On 11/17/14 8:28 PM, Jesse Gross wrote:
On Mon, Nov 17, 2014 at 9:24 AM, Lorand Jakab wrote:
>
> diff --git a/datapath
This patch adds set-field operations for nd_target, nd_sll, and nd_tll fields
using Nicira extensions and OpenFlow 1.2 protocol. Unit tests are included.
This version performs all ND set-field processing in userspace. All ND
set-field functions pass functional testing, including ICMPv6 checksu
On 11/17/14 8:03 PM, Jesse Gross wrote:
On Mon, Nov 17, 2014 at 9:24 AM, Lorand Jakab wrote:
diff --git a/datapath/flow.c b/datapath/flow.c
index b01f7bd..3caa364 100644
--- a/datapath/flow.c
+++ b/datapath/flow.c
@@ -462,7 +462,6 @@ static int key_extract(struct sk_buff *skb, struct
sw_flow_k
On Mon, Nov 17, 2014 at 1:50 PM, Lori Jakab wrote:
> On 11/17/14 8:03 PM, Jesse Gross wrote:
>> On Mon, Nov 17, 2014 at 9:24 AM, Lorand Jakab wrote:
>>> diff --git a/datapath/flow_netlink.c b/datapath/flow_netlink.c
>>> index 54510c8..8ca3469 100644
>>> --- a/datapath/flow_netlink.c
>>> +++ b/dat
On 11/18/14 12:33 AM, Jesse Gross wrote:
On Mon, Nov 17, 2014 at 1:50 PM, Lori Jakab wrote:
On 11/17/14 8:03 PM, Jesse Gross wrote:
On Mon, Nov 17, 2014 at 9:24 AM, Lorand Jakab wrote:
diff --git a/datapath/flow_netlink.c b/datapath/flow_netlink.c
index 54510c8..8ca3469 100644
--- a/datapath
On Mon, Nov 17, 2014 at 2:37 PM, Lori Jakab wrote:
> On 11/18/14 12:33 AM, Jesse Gross wrote:
>>
>> On Mon, Nov 17, 2014 at 1:50 PM, Lori Jakab wrote:
>>>
>>> On 11/17/14 8:03 PM, Jesse Gross wrote:
On Mon, Nov 17, 2014 at 9:24 AM, Lorand Jakab wrote:
>
> diff --git a/datapath/
Minor comments inline.
Acked-by: Ankur Sharma
From: dev on behalf of Nithin Raju
Sent: Tuesday, November 11, 2014 7:04 PM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH 2/7] datapath-windows: add WCHAR version of
OvsFindVportByHvName()
In this pa
Acked-by: Ankur Sharma
From: dev on behalf of Nithin Raju
Sent: Tuesday, November 11, 2014 7:04 PM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH 3/7] datapath-windows: clarify 'portIdHashArray'
in the swithc context
In this patch, we update th
Hi,
this short series makes some corrections to documentation
of group syntax.
Simon Horman (2):
ovs-ofctl: Consistently escape '-' in group documentation
ovs-ofctl: Document that mod-group requires the type field
utilities/ovs-ofctl.8.in | 20 ++--
1 file changed, 10 insert
Document that mod-group rather than del-group requires the type field.
Signed-off-by: Simon Horman
---
utilities/ovs-ofctl.8.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/utilities/ovs-ofctl.8.in b/utilities/ovs-ofctl.8.in
index d632f03..8eebe03 100644
--- a/utilities/ov
I am unsure of the reason for escaping '-' inside of control
sequences but regardless this patch makes the group documentation
consistent with other portions of the ovs-ofctl(8) in this regard.
Signed-off-by: Simon Horman
---
utilities/ovs-ofctl.8.in | 20 ++--
1 file changed, 10
hi Ankur,
Thanks for the review. I'll send out a v2 once all the patches get reviewed.
On Nov 17, 2014, at 5:38 PM, Ankur Sharma
wrote:
> Minor comments inline.
>
> Acked-by: Ankur Sharma
> +static POVS_VPORT_ENTRY OvsFindVportByHvNameW(
> + POVS_SWITCH_CONTEXT switchContext, PWST
Sorin,
Thanks for this patch. Even though it is committed, I had the following
comments.
It is nice to get rid of the checks to gOvsSwitchContext in multiple places. On
thing though is that while a netlink command handler is being executed, we
could get the detach handler from NDIS, and that mi
hi Sorin,
_FlowNlGetCmdHandler() is used for a Flow command sent down as a transaction as
shown in the following code:
NTSTATUS
OvsFlowNlGetCmdHandler(POVS_USER_PARAMS_CONTEXT usrParamsCtx,
UINT32 *replyLen)
hi Sorin,
Like I mentioned in another review, pls. don't combine unrelated changes into
one patch. Here I see a fix to buffer management code, and the other one is
related to device handle cleanup.
Can you pls. split them into separate reviews and send it as a series?
For now, I've reviewed the
On Nov 17, 2014, at 9:39 AM, Sorin Vinturis
wrote:
> I came around a BSOD that happened when trying to access pidHashLock
> from the gOvsSwitchContext, which was NULL. The stop happened in
> OvsAcquirePidHashLock function.
>
> To reproduce this BSOD, make sure the extension is enabled and runni
Hi Nithin,
I will follow your recommendation to not combine different patches into one.
Please find my answers to your comments inline.
Sorin
-Original Message-
From: Nithin Raju [mailto:nit...@vmware.com]
Sent: Tuesday, 18 November, 2014 09:10
To: Sorin Vinturis
Cc: dev@openvswitch.or
38 matches
Mail list logo
