Hi Pravin
I can't see this on master, and I don't see the changes can you point me to the
commit.
Thanks
Maryam
> -Original Message-
> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Pravin
> Shelar
> Sent: Thursday, October 16, 2014 11:32 PM
> To: Verbeiren, David
> Cc: dev@
“flow_seq” field in NetFlow v5 header should represent a number of NetFlow
flow records exported while it is representing the number of NetFlow
packets exported in the current code. This patch fixes this problem.
Signed-off-by: Motonori Shindo
---
ofproto/netflow.c | 2 +-
1 file changed, 1 ins
On Tue, Nov 04, 2014 at 03:13:21PM +0900, Simon Horman wrote:
> If usable_protocols_bitwise and usable_protocols_cidr are equal
> then it does not matter which one is returned. This leads to
> a slight simplification of the selection logic.
>
> Signed-off-by: Simon Horman
The current logic is th
On Tue, Nov 04, 2014 at 03:13:45PM +0900, Simon Horman wrote:
> Slightly simplify match_format() by using ds_chomp()
> rather than open-coding its logic.
>
> Signed-off-by: Simon Horman
Good catch. Applied, thanks!
___
dev mailing list
dev@openvswitch
On Tue, Nov 04, 2014 at 03:14:04PM +0900, Simon Horman wrote:
> Slightly simplify ofp10_match_to_string() by using ds_chomp()
> rather than open-coding its logic.
>
> Signed-off-by: Simon Horman
Thanks again, applied!
___
dev mailing list
dev@openvswit
Fixes following warning:
../lib/ovs-router.c:162:11: warning: incorrect type in assignment
(different base types)
../lib/ovs-router.c:162:11:expected restricted ovs_be32
[usertype]
../lib/ovs-router.c:162:11:got restricted ovs_be16
Reported-by: Ben Pfaff
Signed-off-by: Pravin B Shelar
-
The last hunk seems to belong to the next patch, otherwise:
Acked-by: Jarno Rajahalme
On Nov 3, 2014, at 5:14 PM, Ben Pfaff wrote:
> It will be used in an upcoming commit.
>
> Signed-off-by: Ben Pfaff
> ---
> ofproto/ofproto-dpif-xlate.c | 11 +--
> ofproto/ofproto-dpif-xlate.h |
Actually I forgot to push it to master back then. So I did it now.
Thanks for pointing it out.
On Tue, Nov 4, 2014 at 7:34 AM, Tahhan, Maryam wrote:
> Hi Pravin
> I can't see this on master, and I don't see the changes can you point me to
> the commit.
>
> Thanks
> Maryam
>
>> -Original Mes
With small nits below:
Acked-by: Jarno Rajahalme
On Nov 3, 2014, at 5:14 PM, Ben Pfaff wrote:
> Until now, ofproto/trace has looked up the flow itself. xlate_actions()
> can do the flow lookup internally and, since that is what happens when a
> packet arrives, having it do its own packet look
LGTM,
Acked-by: Jarno Rajahalme
On Nov 3, 2014, at 2:16 PM, Pravin B Shelar wrote:
> Fixes following warning:
> ../lib/ovs-router.c:162:11: warning: incorrect type in assignment
> (different base types)
> ../lib/ovs-router.c:162:11:expected restricted ovs_be32
> [usertype]
> ../lib/ovs-ro
I pushed it to master.
Thanks.
On Tue, Nov 4, 2014 at 9:45 AM, Jarno Rajahalme wrote:
> LGTM,
>
> Acked-by: Jarno Rajahalme
>
> On Nov 3, 2014, at 2:16 PM, Pravin B Shelar wrote:
>
>> Fixes following warning:
>> ../lib/ovs-router.c:162:11: warning: incorrect type in assignment
>> (different bas
On Wed, Nov 05, 2014 at 01:12:18AM +0900, Motonori Shindo wrote:
> ???flow_seq??? field in NetFlow v5 header should represent a number of NetFlow
> flow records exported while it is representing the number of NetFlow
> packets exported in the current code. This patch fixes this problem.
>
> Signe
We get these questions from time to time and it would be nice to just be
able to cut and paste the answer. (And possibly some people might actually
read the answer straight from the FAQ.)
Signed-off-by: Ben Pfaff
---
FAQ.md | 23 +++
1 file changed, 23 insertions(+)
diff
Thanks for noticing the out-of-place hunk. I applied this.
On Tue, Nov 04, 2014 at 09:36:25AM -0800, Jarno Rajahalme wrote:
> The last hunk seems to belong to the next patch, otherwise:
>
> Acked-by: Jarno Rajahalme
>
>
> On Nov 3, 2014, at 5:14 PM, Ben Pfaff wrote:
>
> > It will be used in
Thanks for pointing out the nits. I fixed them and I'll apply this in
a minute.
On Tue, Nov 04, 2014 at 09:41:38AM -0800, Jarno Rajahalme wrote:
> With small nits below:
>
> Acked-by: Jarno Rajahalme
>
> On Nov 3, 2014, at 5:14 PM, Ben Pfaff wrote:
>
> > Until now, ofproto/trace has looked u
On Mon, Nov 03, 2014 at 05:21:24PM -0800, Jean Tourrilhes wrote:
> On Mon, Nov 03, 2014 at 05:14:05PM -0800, Ben Pfaff wrote:
> > From: Jean Tourrilhes
> >
> > Signed-off-by: Jean Tourrilhes
>
> Actually, you don't need this testcase if you modify your own
> testcase as such :
>
> https:
I've pointed out two misuses of these macros in review in the last week,
by different authors. It's time to make it difficult to screw this up.
Signed-off-by: Ben Pfaff
---
Makefile.am | 17 +
1 file changed, 17 insertions(+)
diff --git a/Makefile.am b/Makefile.am
index 343df
On Mon, Nov 03, 2014 at 02:38:23PM -0800, Jarno Rajahalme wrote:
>
> On Nov 3, 2014, at 2:03 PM, Ben Pfaff wrote:
>
> > On Wed, Oct 29, 2014 at 03:12:02PM -0700, Jarno Rajahalme wrote:
> >> 1. Flows with an explicit match on nw_frag, where the LATER bit is 1:
> >> Prohibit setting transport he
Looks good. Acked-by: Andy Zhou
It would be to nice add more details to the commit message. The actual
problem occurs when ovs_dp_name() is called.
In the long run, it would be nice to add lock depends to
lookup_datapath. It seems all the use cases requires mutex to be held
to prevent related d
On Thu, Oct 23, 2014 at 03:52:33PM -0700, Andy Zhou wrote:
> OVS userspace are backward compatible with older Linux kernel modules.
> However, not having the most up-to-date datapath kernel modules can
> some times lead to user confusion. Storing the datapath version in
> OVSDB allows management so
On Fri, Oct 24, 2014 at 01:36:41PM -0700, Jarno Rajahalme wrote:
> Some struct cls_subtable fields were documented of being const. Make
> them const and use CONST_CAST where appropriate to initialize them.
>
> This will help catch future errors modifying those fields after
> initialization.
>
>
On Tue, Nov 4, 2014 at 12:39 PM, Andy Zhou wrote:
> Looks good. Acked-by: Andy Zhou
>
> It would be to nice add more details to the commit message. The actual
> problem occurs when ovs_dp_name() is called.
>
I pushed this fix to master.
> In the long run, it would be nice to add lock depends to
On Mon, Nov 3, 2014 at 1:36 PM, Lorand Jakab wrote:
> Implementation of the pop_eth and push_eth actions in the kernel, and
> layer 3 flow support.
>
> Signed-off-by: Lorand Jakab
> ---
> datapath/actions.c| 85
> ---
> datapath/flow.c
Package: openvswitch-datapath-dkms
Version: 1.4.2+git20120612-9.1~deb7u1
Severity: important
Dear Maintainer,
"apt-get install openvswitch-datapath-dkms" fails with the following error in
/var/lib/dkms/openvswitch/1.4.2+git20120612/build/make.log :
/var/lib/dkms/openvswitch/1.4.2+git20120612/bu
On Nov 3, 2014, at 2:33 PM, Eitan Eliahu wrote:
> Thank for the review.
> " Since you have declared $vmName as mandatory, is this check required?"
> As I understand the "mandatory" parameter definition of PS means that the
> parameter must be provided by the caller. If the parameter is not provi
Hi Nithin,
Actually the function does throw an exception in both cases when the parameter
is not specified and in the case an empty string is sent as the VM name:
S C:\script> import-module .\OVS.psm1
S C:\script> $vnic = Get-VMNetworkAdapter WinVM1
S C:\script> $vnic | Set-VMNetworkAdapterOVS
On Wed, Oct 29, 2014 at 02:55:39PM -0600, Scott Mann wrote:
> These changes cause shared libraries to be built by default.
> In particular, lib/libopenvwitch.so, lib/libsflow.so, ofproto/libofproto.so,
> and ovsdb/libovsdb.so will be built. Original behavior of building static
> objects excusively
On Tue, Nov 04, 2014 at 08:42:23AM -0800, Ben Pfaff wrote:
> On Tue, Nov 04, 2014 at 03:13:21PM +0900, Simon Horman wrote:
> > If usable_protocols_bitwise and usable_protocols_cidr are equal
> > then it does not matter which one is returned. This leads to
> > a slight simplification of the selectio
Thanks for v2.
I often hear of LLDP used in connection with OpenFlow controllers and
switches. Until now, Open vSwitch has had no built-in support for
LLDP, although support could be implemented through an OpenFlow
controller. This patch series does start adding built-in LLDP
support. I am not
hi Eitan,
I applied your patch, and ran some tests on how validation is performed:
1)
If "" is provided for vmName argument, then powershell throws an exception, esp
since it is declared as mandatory. So, having the if ($vmName) check is not
necessary, and if so, setting $vnic to 0, is also not
Ben,
Yes, I will. But it will likely be this weekend before I am able to do that
(in traveling).
Scott
On Nov 4, 2014 3:51 PM, "Ben Pfaff" wrote:
>
> On Wed, Oct 29, 2014 at 02:55:39PM -0600, Scott Mann wrote:
> > These changes cause shared libraries to be built by default.
> > In particular, lib
Signed-off-by: Eitan Eliahu
---
lib/route-table-stub.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/route-table-stub.c b/lib/route-table-stub.c
index 85c2583..cd50002 100644
--- a/lib/route-table-stub.c
+++ b/lib/route-table-stub.c
@@ -18,10 +18,10 @@
#include "com
parse_ofp_group_mod_str() may limit the usable protocols according
to the group and in particular its actions. However, without this
change ovs-ofctl ignores this calculation.
Signed-off-by: Simon Horman
---
utilities/ovs-ofctl.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-
On Nov 5, 2014, at 10:39 AM, Eitan Eliahu
wrote:
> Signed-off-by: Eitan Eliahu
> ---
> lib/route-table-stub.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/route-table-stub.c b/lib/route-table-stub.c
> index 85c2583..cd50002 100644
> --- a/lib/route-table-stub
34 matches
Mail list logo
