-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
I have made some additional testing on a new server that have the same
hardware/setup than other I have uncounter the same issue.
but in fact, the issue occurs with I use fake-bridge with a vlan.
root@stri:~# ovs-vsctl show
b7c26499-2586-4dac-
Our initial goal is to make OVS an auto attach client.
We are watching with great interest the progress of the recently submitted
802.1ah (PBB) patch.
PBB is the datapath on top of which the SPB control plane is layered and thus
could lay the groundwork for adding auto attach server support to O
Hi Ben,
Thank you for the thorough review of the auto attach patches!
We will address all your comments/concerns and be back in touch.
Thanks again,
Dennis
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Ben Pfaff
Sent: Monday, October 13, 2014 6:49 PM
To
Hi Ankur,
The event lock should protect only the event queue. It should not be confused
with the other lock which protect the user mode interface (CtrlLock).
I would suggest to use a specific lock to protect the event queue rather using
the CtrlLock.
-static __inline VOID
-OvsAcquireEventQueueL
Does support for PBB make support for AAC unnecessary? The cited
Internet draft says that it is for devices that "typically do not
support SPBM, MAC-in-MAC (802.1ah), nor I-SID usage".
On Tue, Oct 14, 2014 at 12:41:53PM +, Flynn, Dennis R (Dennis) wrote:
> Our initial goal is to make OVS an a
Greetings All,
We have compiled the most recent and comprehensive contact base of
technology users 2014 - 2015. The contact base includes users of over 11,000
technologies, with key decision makers and designated executives.
Technologies: Microsoft, Oracle, SAP, SalesLogix, Netsuite, Sugar
In the ingress datapath the creation of a missed packet doesn't
need to be guarded by the dispatchLock. Same for the NBL context
initialization.
In the OvsInjectPacketThroughActions function extracting flow
parameters (OvsExtractFlow) from the current packet doesn't need to
be guarded. Nor by the
Hi Sorin,
Sounds fair. I will introduce a new lock in v2.
Thanks.
Regards,
Ankur
From: Sorin Vinturis
Sent: Monday, October 13, 2014 11:26 PM
To: Ankur Sharma; dev@openvswitch.org
Subject: RE: [ovs-dev] [PATCH v1 1/2] datapath-windows: Fix CtrlLock acqui
Hi Eitan,
Sure, i will take care of this.
I thought that CtrlLock is used for all the global resources.
Thanks.
Regards,
Ankur
From: Eitan Eliahu
Sent: Tuesday, October 14, 2014 5:56 AM
To: Ankur Sharma; dev@openvswitch.org
Subject: RE: [ovs-dev] [PATCH v
On Tue, Oct 07, 2014 at 12:23:37AM +1300, Joe Stringer wrote:
> This patch modifies the dpif interface to allow flows to be manipulated
> using a 128-bit identifier. This allows revalidator threads to perform
> datapath operations faster, as they do not need to serialise the entire
> flow key for o
Hi,
I have been validating the userspace tunneling patches for DPDK and have
encountered some problems.
My set-up is as follows:
192.168.1.1/24 192.168.1.2/24
++++
| br1
DPDK rings don't need one queue per PMD thread and don't support multiple
queues (set_multiq function is undefined). To fix operation with DPDK rings,
this patch ignores EOPNOTSUPP error on netdev_set_multiq() and provides, for
DPDK rings, a netdev send() function that ignores the provided queue id
My changes for trasacation error handling for not needed for dump commands.
Fixed the same.
Signed-off-by: Ankur Sharma
---
datapath-windows/ovsext/Flow.c | 50 +++---
1 file changed, 13 insertions(+), 37 deletions(-)
diff --git a/datapath-windows/ovsext/Flow
OvsReadEventCmdHandler was calling OvsRemoveEventEntry after acquiring
CtrlLock. OvsRemoveEventEntry in turn also tries to acquire the same lock.
Added a new lock in Event.c for the eventQueue.
Signed-off-by: Ankur Sharma
---
datapath-windows/ovsext/Event.c | 9 +
1 file changed, 5 inse
Acked-by: Eitan Eliahu
Thanks Ankur,
Eitan
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Ankur Sharma
Sent: Tuesday, October 14, 2014 10:16 AM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH v2 1/2] datapath-windows: Fix CtrlLock acquire issue
in OvsRe
On Tue, Oct 07, 2014 at 12:23:38AM +1300, Joe Stringer wrote:
> One of the limiting factors on the number of flows that can be supported
> in the datapath is the overhead of assembling flow dump messages in the
> datapath. This patch modifies the flow_dump interface to allow
> revalidators to skip
Hi,
I find that upcalls from datapath are handled by handle_upcalls() in
ofproto/ofproto-dpif-upcall.c. What should I do if I want to know from
which datapath the upcalls come from in handle_upcalls()? I am using
mininet to run multiple datapaths, and I want to record the upcalls and
where they co
Looks good Ankur. Thanks!
Acked-by: Sorin Vinturis
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Eitan Eliahu
Sent: Tuesday, October 14, 2014 8:17 PM
To: Ankur Sharma; dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH v2 1/2] datapath-windows: Fix CtrlLoc
On Tue, Oct 14, 2014 at 9:57 AM, Loftus, Ciara wrote:
> Hi,
>
> I have been validating the userspace tunneling patches for DPDK and have
> encountered some problems.
>
> My set-up is as follows:
>
>
>192.168.1.1/24 192.168.1.2/24
>++
On Tue, Oct 14, 2014 at 10:16:00AM -0700, Ankur Sharma wrote:
> OvsReadEventCmdHandler was calling OvsRemoveEventEntry after acquiring
> CtrlLock. OvsRemoveEventEntry in turn also tries to acquire the same lock.
>
> Added a new lock in Event.c for the eventQueue.
>
> Signed-off-by: Ankur Sharma
Auto Attach is about automatically attaching network devices to SPB capable
networks so that the services that a SPB network provides are available on less
complex and lighter weight devices on which SPB capability is not desired or
needed. SPB requires full IS-IS and other software.
>From th
Eitan,
Looks good but for the following comments.
> +UINT32
> +static __inline NlAttrSize(UINT32 payload)
Can we call this: NlAttrSizeForPayload() or NlAttrSizeForData? The reason is,
there are existing APIs such as NlAttrLen() which operate on a nlattr. These
functions that you are adding don'
Hi Nithin,
I don't have a strong opinion on the names, but I thought we want to keep NL
utilities names as the Linux datapath.
Thank you,
Eitan
-Original Message-
From: Nithin Raju
Sent: Tuesday, October 14, 2014 1:00 PM
To: Eitan Eliahu
Cc:
Subject: Re: [ovs-dev] [PATCH 1/4] Upcall NL
ovs-docker is a helper script to add network interfaces to
docker containers and to attach them as ports to OVS bridge.
This script can be further enhanced as we understand different
use cases.
Signed-off-by: Gurucharan Shetty
---
NEWS | 2 +
debian/openvswitch-co
Open vSwitch does not have native integration with Docker.
INSTALL.Docker explains how Open vSwitch can be integrated
with docker non-natively.
Signed-off-by: Gurucharan Shetty
---
INSTALL.Docker | 82 ++
Makefile.am| 1 +
2 files chan
On Oct 14, 2014, at 1:03 PM, Eitan Eliahu
wrote:
> Hi Nithin,
> I don't have a strong opinion on the names, but I thought we want to keep NL
> utilities names as the Linux datapath.
Now that I am looked at patch 2 of 4, the names you had given are fine. Pls.
rename the input parameter 'payloa
Pushed,
Thanks for the review!
Jarno
On Oct 13, 2014, at 1:59 PM, Ben Pfaff wrote:
> On Fri, Oct 10, 2014 at 04:18:45PM -0700, Jarno Rajahalme wrote:
>> classifier_find_rule_exactly() only needs the mutex to protect the
>> list traversal. Subtables are already RCU protected.
>>
>> Locking
The change include the Packet Read handler.
The current implementation reads once packet at a time. This should be updated
once user mode code is in place. Also, the packet offset should be updated
to reflect the new NL format.
signed-off-by: Eitan Eliahu
---
datapath-windows/include/OvsDpInterf
On Mon, Oct 13, 2014 at 6:51 PM, Alex Wang wrote:
> Hey Jarno,
>
> I have some high-level comments/questions as follow:
>
> On Tue, Oct 7, 2014 at 2:43 PM, Jarno Rajahalme
> wrote:
>
>> flow inserts and removals are simplified:
>>
>> - No need for classifier internal mutex, as dpif-netdev alread
hi Eitan,
Looks good but for some comments I had, mostly minor though.
Acked-by: Nithin Raju
> diff --git a/datapath-windows/ovsext/User.c b/datapath-windows/ovsext/User.c
> index 26cd431..5037b42 100644
> --- a/datapath-windows/ovsext/User.c
> +++ b/datapath-windows/ovsext/User.c
> @@ -873,3 +8
On Oct 10, 2014, at 11:08 AM, Eitan Eliahu wrote:
> Remove hard coded queue is, pass the key rather the tunnel key,
> remove the none NL implementation
LG.
Acked-by: Nithin Raju
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman
> /*
> *
> - * _MapFlowTunKeyToNlKey --
> - *Maps OvsIPv4TunnelKey to OVS_TUNNEL_KEY_ATTR_ID attribute.
> + * MapFlowTunKeyToNlKey --
> + * Maps OvsIPv4TunnelKey to OVS_TUNNEL_KEY_ATTR_ID attribute.
> *---
> -NL_BUFFER nlBuf;
> -
> -if (!(usrParamsCtx->outputBuffer)) {
> -/* No output buffer */
> -rc = STATUS_INVALID_BUFFER_SIZE;
> -goto done;
> -}
We can retain this code as:
if (usrParamsCtx->devOp == OVS_TRANSACTION_DEV_OP &&
!(usrParamsCtx->outputBuffer))
LG, minor comment.
Thanks,
Eitan
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Ankur Sharma
Sent: Tuesday, October 14, 2014 10:16 AM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH v2 2/2] datapath-windows: Transactional error fix for
flow dump.
My cha
>
> static inline struct netdev_flow_key *
> -miniflow_to_netdev_flow_key(const struct miniflow *mf)
> +miniflow_to_netdev_flow_key(const struct miniflow *miniflow)
> {
> -return (struct netdev_flow_key *) CONST_CAST(struct miniflow *, mf);
> +struct netdev_flow_key *key;
> +
> +INIT_C
Thanks Nithin. Ankur caught it too :-)
-Original Message-
From: Nithin Raju
Sent: Tuesday, October 14, 2014 2:36 PM
To: Eitan Eliahu
Cc:
Subject: Re: [ovs-dev] [PATCH 2/4] Upcall NL packet format: NL Flow utilities,
parametrized Key to NL conversion
> /*
> *---
My changes for trasacation error handling for not needed for dump commands.
Fixed the same.
Signed-off-by: Ankur Sharma
Acked-by: Nithin Raju
Acked-by: Eitan Eliahu
---
datapath-windows/ovsext/Flow.c | 61 +-
1 file changed, 18 insertions(+), 43 deletio
>
> @ -2697,19 +2845,28 @@ fast_path_processing(struct dp_netdev_pmd_thread
>> *pmd,
>> ? &put_actions
>> : &actions;
>>
>> -ovs_mutex_lock(&dp->flow_mutex);
>> -/* XXX: There's a brief race where this flow could have
>> already
>> -
Add NlAttrSize and NlAttrTotalSize
Signed-off-by: Eitan Eliahu
Acked-by: Ankur Sharma
Acked-by: Nithin Raju
---
datapath-windows/ovsext/Netlink/Netlink.h | 22 ++
1 file changed, 22 insertions(+)
diff --git a/datapath-windows/ovsext/Netlink/Netlink.h
b/datapath-windows/o
Extend the key and tunnel key conversion to nested NL format functions use the
NL attribute as a parameter so we can use them for missed packet formatting.
Add functions for calculating the space needed for storing the key and the
tunnel key in NL format
Signed-off-by: Eitan Eliahu
---
datapath
Add NlAttrSize and NlAttrTotalSize
Signed-off-by: Eitan Eliahu
Acked-by: Ankur Sharma
Acked-by: Nithin Raju
---
datapath-windows/ovsext/Netlink/Netlink.h | 22 ++
1 file changed, 22 insertions(+)
diff --git a/datapath-windows/ovsext/Netlink/Netlink.h
b/datapath-windows/o
Extend the key and tunnel key conversion to nested NL format functions use the
NL attribute as a parameter so we can use them for missed packet formatting.
Add functions for calculating the space needed for storing the key and the
tunnel key in NL format
Signed-off-by: Eitan Eliahu
Acked-by: Ank
[1] Allocate a queue element and space to hold the packet, key, tunnel key
and user data in NL format.
[2] Format the NL header
[3] Store packet, key, tunnel key and user data in NL format
[4] Calculates and insert checksum if offloaded.
signed-off-by: Eitan Eliahu
Acked-by: Ankur Sharma
Acked-b
Remove hard coded queue is, pass the key rather the tunnel key,
Remove the none NL implementation
Signed-off-by: Eitan Eliahu
Acked-by: Ankur Sharma
Acked-by: Nithin Raju
---
datapath-windows/ovsext/Actions.c | 29 ++---
datapath-windows/ovsext/PacketIO.c | 7 +-
datapath-windows/ovsext/Tu
From: Chunhe Li
In rethat OS, the service name is "openvswitch", providers also should
be change to "openvswitch"
Signed-off-by: Chunhe Li
Signed-off-by: Dongdong
---
rhel/etc_init.d_openvswitch | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/rhel/etc_init.d_openvswitch b/
From: liuyongqiang
this patch work for the ovs serporting the IEEE 802.1ah
protocol(Mac in Mac or PBB)
IEEE 802.1ah (PBB or MAC-in-MAC):
PBB (also known as MAC-in-MAC) is used by SPs to resolve these problems.
PBB introduces a hierarchical network architecture with associated new
frame formats w
I could not find any place to define the enum OVS_ACTION_ATTR_PUSH_PBB and
OVS_ACTION_ATTR_POP_PBB,
I compare the code of openvswitch-2.0.0, I find that the openvswitch.h under
the include/linux/,
but the openvswitch-master is under the datapath/linux/compat/include/linux/.
On 2014/10/10 23:24,
47 matches
Mail list logo
