Signed-off-by: Tom Gundersen
Cc: Pravin Shelar
Cc: dev@openvswitch.org
---
v9: set NET_NAME_USER directly in internal_dev_create as requested by Pravin
Shelar
net/openvswitch/vport-internal_dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/openvswitch/vport-interna
Thanks for the review.
I have removed the incorrect whitespaces.
About XXX_get_out_tun_info(), I keep the caluclation of saddr, including route
look up process, tp_src and tp_dst in ops for each vport, due to that the
process are a little different for each vport. And I think that the potent
Dear *Sir/Madam*
The *Asian Economic and Social Society and Pak Publishing Group* are
organizing a 2nd International Conference on Economics, Finance and
Management Outlooks
20-21 December, 2014,* Pearl International Hotel, Kuala Lumpur, Malaysia.*
Website: http://www.pakrdw.com/?ic=details&id
On Thu, Jul 17, 2014 at 08:35:04AM +0200, Eric Sesterhenn wrote:
> On 07/16/2014 08:04 PM, Ben Pfaff wrote:
> > On Wed, Jul 16, 2014 at 02:53:37PM -0300, Flavio Leitner wrote:
> >> On Wed, Jul 16, 2014 at 09:56:20AM -0700, Ben Pfaff wrote:
> >>> On Wed, Jul 16, 2014 at 10:39:17AM -0300, Flavio Leit
On Jul 15, 2014, at 10:18 PM, YAMAMOTO Takashi wrote:
>> /* A flow classifier. */
>> struct classifier {
>> -struct cls_classifier *cls;
>> +struct ovs_mutex mutex;
>> +int n_rules OVS_GUARDED;/* Total number of rules. */
>> +uint8_t n_flow_segments;
>> +uint8_t flow_
On Jul 15, 2014, at 2:24 PM, Ben Pfaff wrote:
> On Fri, Jul 11, 2014 at 04:55:56AM -0700, Jarno Rajahalme wrote:
>> Previously we only returned the last matching prefix length
>> encountered during a trie lookup, and skipped subtables that had
>> prefixes longer than that. This patch changes th
On Jul 15, 2014, at 1:55 PM, Ben Pfaff wrote:
> On Fri, Jul 11, 2014 at 04:55:55AM -0700, Jarno Rajahalme wrote:
>> This stylistic change makes the following patch a bit simpler.
>>
>> Signed-off-by: Jarno Rajahalme
>
> It's hard for me to see the difference between m_bits and n_bits in
> som
On Wed, Jul 16, 2014 at 3:05 PM, Ben Pfaff wrote:
> An upcoming commit will add a caller that needs to format both the key and
> the value. That isn't cleanly possible with the current interface.
>
> Signed-off-by: Ben Pfaff
Acked-by: Gurucharan Shetty
> ---
> lib/smap.c | 11 ++-
>
On Thu, Jul 17, 2014 at 08:35:04AM +0200, Eric Sesterhenn wrote:
> On 07/16/2014 08:04 PM, Ben Pfaff wrote:
> > A thought I've had about hardening ovs-vswitchd is to adopt an
> > OpenSSH-like privilege separation model, where a simple, separate
> > process with high privilege doles out restricted a
On Wed, Jul 16, 2014 at 3:05 PM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
I did not test it, but looks correct.
Acked-by: Gurucharan Shetty
> ---
> NEWS |1 +
> ofproto/connmgr.c| 26 +++-
> ofproto/pinsched.c | 17 +---
> ofproto/pinsched.h | 11
On Thu, Jul 17, 2014 at 11:04:55AM +1200, Joe Stringer wrote:
> On 17 July 2014 04:48, Ben Pfaff wrote:
>
> > On Wed, Jul 16, 2014 at 02:50:12PM +1200, Joe Stringer wrote:
> > > Converting the flow key and mask back into netlink format during flow
> > > dump is fairly expensive. By caching the us
On Thu, Jul 17, 2014 at 3:05 AM, Wenyu Zhang wrote:
> Thanks for the review.
>
> I have removed the incorrect whitespaces.
>
> About XXX_get_out_tun_info(), I keep the caluclation of saddr, including
> route look up process, tp_src and tp_dst in ops for each vport, due to that
> the process are
On Wed, Jul 16, 2014 at 03:30:55PM -0700, Gurucharan Shetty wrote:
> On Wed, Jul 16, 2014 at 3:05 PM, Ben Pfaff wrote:
> > Signed-off-by: Ben Pfaff
> Acked-by: Gurucharan Shetty
Thanks, I applied this to master.
___
dev mailing list
dev@openvswitch.or
On Wed, Jul 16, 2014 at 03:57:27PM -0700, Gurucharan Shetty wrote:
> On Wed, Jul 16, 2014 at 3:05 PM, Ben Pfaff wrote:
> > 'n_txq' was initialized to 0 and never modified, so pinsched_count_txqlen()
> > always returned 0. Instead, return the correct number.
> >
> > This only affected the results
On Wed, Jul 16, 2014 at 04:26:04PM -0700, Gurucharan Shetty wrote:
> On Wed, Jul 16, 2014 at 3:05 PM, Ben Pfaff wrote:
> > The only client for ofproto_controller_info was transforming the array of
> > pairs into an smap anyway. It's easy for the code that fills in the array
> > to generate it as
On Thu, Jul 17, 2014 at 10:08:16AM -0700, Gurucharan Shetty wrote:
> On Wed, Jul 16, 2014 at 3:05 PM, Ben Pfaff wrote:
> > Signed-off-by: Ben Pfaff
> I did not test it, but looks correct.
> Acked-by: Gurucharan Shetty
Thank you for the reviews. I applied the remaining patches to master.
__
On Thu, Jul 17, 2014 at 07:15:17AM -0700, Jarno Rajahalme wrote:
>
> On Jul 15, 2014, at 1:55 PM, Ben Pfaff wrote:
>
> > On Fri, Jul 11, 2014 at 04:55:55AM -0700, Jarno Rajahalme wrote:
> >> This stylistic change makes the following patch a bit simpler.
> >>
> >> Signed-off-by: Jarno Rajahalme
On Thu, Jul 17, 2014 at 07:09:15AM -0700, Jarno Rajahalme wrote:
>
> On Jul 15, 2014, at 10:18 PM, YAMAMOTO Takashi wrote:
>
> >> /* A flow classifier. */
> >> struct classifier {
> >> -struct cls_classifier *cls;
> >> +struct ovs_mutex mutex;
> >> +int n_rules OVS_GUARDED;/*
On Thu, Jul 17, 2014 at 07:13:38AM -0700, Jarno Rajahalme wrote:
>
> On Jul 15, 2014, at 2:24 PM, Ben Pfaff wrote:
>
> > On Fri, Jul 11, 2014 at 04:55:56AM -0700, Jarno Rajahalme wrote:
> >> Previously we only returned the last matching prefix length
> >> encountered during a trie lookup, and sk
On Wed, Jul 16, 2014 at 5:10 PM, Daniele Di Proietto
wrote:
> The following changes were made:
>
> - Since we have two dpdk classes, we should split the initial operations
> needed
> by both classes from the initialization needed by each class.
> - The dpdk_ring class does not need an initializ
On Thu, Jul 17, 2014 at 1:06 AM, Tom Gundersen wrote:
> Signed-off-by: Tom Gundersen
> Cc: Pravin Shelar
> Cc: dev@openvswitch.org
Looks good.
Acked-by: Pravin B Shelar
> ---
>
> v9: set NET_NAME_USER directly in internal_dev_create as requested by Pravin
> Shelar
>
> net/openvswitch/vport-
Thanks,
Daniele
On Jul 17, 2014, at 11:20 AM, Pravin Shelar wrote:
> On Wed, Jul 16, 2014 at 5:10 PM, Daniele Di Proietto
> wrote:
>> The following changes were made:
>>
>> - Since we have two dpdk classes, we should split the initial operations
>> needed
>> by both classes from the initial
On Mon, Jul 14, 2014 at 1:55 PM, Daniele Di Proietto
wrote:
> DPDK mempools rely on rte_lcore_id() to implement a thread-local cache.
> Our non pmd threads had rte_lcore_id() == 0. This allowed concurrent access to
> the "thread-local" cache, causing crashes.
>
> This commit resolves the issue wit
Add defines needed to compile netlink-socket.c and netlink.c.
Add wrappers for the functions sendmsg and recvmsg. They can also be added to
another file instead of defining them inlined.
Add a wrapper and the functionality behind it for syconf.
Add the newly created files to the noinst_HEADERS i
For our kernel extension we do not take into consideration the padding
thus remove it.
Add MAX_LINKS define needed for nl_pool.
Add NETLINK_ROUTE needed to compile rtnetlink-link.
Signed-off-by: Alin Gabriel Serdean
---
lib/netlink-protocol.h | 14 ++
lib/netlink.c | 4 ++
Bypass the error compilation when compiling under MSVC.
Signed-off-by: Alin Gabriel Serdean
---
lib/netlink-socket.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/netlink-socket.h b/lib/netlink-socket.h
index d53db4e..2b9ec52 100644
--- a/lib/netlink-socket.h
+++ b/lib/netlink-socket
Add the structure sockaddr_nl to netlink-socket.c when compiling under
MSVC.
Add two functions set_sock_pid_in_kernel and portid_next. This will allow
the channel identification for the kernel extension to send back messages.
Replace send with WriteFile equivalent and ignore nl_sock_drain for the
Add netlink related files to the windows build.
Signed-off-by: Alin Gabriel Serdean
---
lib/automake.mk | 13 +
1 file changed, 13 insertions(+)
diff --git a/lib/automake.mk b/lib/automake.mk
index 0997df5..deaf0fc 100644
--- a/lib/automake.mk
+++ b/lib/automake.mk
@@ -319,6 +319,1
The substitute for epoll would be I/O Completion Ports
http://msdn.microsoft.com/en-us/library/windows/desktop/aa365198%28v=vs.85%29.aspx
.
I will be back later on with a patch with this matter.
I have taken your review in account and sent out a new series of patches which
would go more increm
On Thu, Jul 17, 2014 at 6:57 PM, Ben Pfaff wrote:
>
> It probably wouldn't be too hard to do this in OVS, because we used to
> do something very similar for non-security reasons. It would be a
> matter of resurrecting the "worker" library and adjusting it to better
> suit as a security feature (
Sure, I’ll post v2 in a minute.
Thanks
On Jul 17, 2014, at 11:30 AM, Pravin Shelar wrote:
> On Mon, Jul 14, 2014 at 1:55 PM, Daniele Di Proietto
> wrote:
>> DPDK mempools rely on rte_lcore_id() to implement a thread-local cache.
>> Our non pmd threads had rte_lcore_id() == 0. This allowed conc
DPDK mempools rely on rte_lcore_id() to implement a thread-local cache.
Our non pmd threads had rte_lcore_id() == 0. This allowed concurrent access to
the "thread-local" cache, causing crashes.
This commit resolves the issue with the following changes:
- Every non pmd thread has the same lcore_id
Hi all,
I have ported openvswitch to a mips based device and I am trying to
create a new bridge. When I create a new bridge using the following
command everything seems to be working OK, except that the bridge
interface does not show up under ifconfig.
ovs-vsctl add-br ovs-br0
"ovs-vsctl s
This patch fixes following kernel crash that could happen, if geneve
vport was not added yet, but revalidator thread attempted to dump flows.
To reproduce:
1. switch tunnel type between geneve and gre; and
2. run ping.
BUG: unable to handle kernel NULL pointer dereference at 0048
IP: [
On 18 July 2014 05:19, Ben Pfaff wrote:
>
> > From datapath/README:
> >
> > - If the kernel's flow key includes more fields than the userspace
> > version of the flow key, for example if the kernel decoded IPv6
> > headers but userspace stopped at the Ethernet type (because it
> >
On Thu, Jul 17, 2014 at 3:46 PM, Ansis Atteka wrote:
> diff --git a/datapath/flow_netlink.c b/datapath/flow_netlink.c
> index 5f975a1..a4108c0 100644
> --- a/datapath/flow_netlink.c
> +++ b/datapath/flow_netlink.c
> @@ -1034,7 +1034,7 @@ int ovs_nla_put_flow(struct datapath *dp, const struct
> sw
On 18 July 2014 10:53, Joe Stringer wrote:
> Basically I'd be much more comfortable with the kernel generating its
>> own flow key the first time it dumps a flow, then caching that. How
>> much overhead does that have versus caching the userspace-provided
>> flow key?
>>
>
> By the same metric,
bgColor="turquoise"
width="94%"
bgColor="deeppink"
bgColor="turquoise"
- Важная
инфа пo гл aвным темам бизнеcкoнcалтингa ΡФ:
Милицeйcκме\налοговыe претeнзииопeчатываниe, oбыcκ,
изъятиe, арест имущecтва, οcмoтp,
досмoтp
- реĸοмeндaции противοдeйствия, дeятельнoe
рас
On Thu, Jul 17, 2014 at 11:38:38PM +0200, Justin Pettit wrote:
> On Thu, Jul 17, 2014 at 6:57 PM, Ben Pfaff wrote:
>
> >
> > It probably wouldn't be too hard to do this in OVS, because we used to
> > do something very similar for non-security reasons. It would be a
> > matter of resurrecting the
Thanks Ben the review, and sorry for the delay.
I’m about to drop a v2 with your suggestions.
On Jun 23, 2014, at 2:24 PM, Ben Pfaff wrote:
> On Fri, Jun 13, 2014 at 02:58:32PM -0700, Daniele Di Proietto wrote:
>> This commit intruduces a new appctl command: dpif/dpctl
>
> s/intruduces/introduc
See Attached File
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Without this change, with shared libraries, VLOG
constructor for ovsdb-server would get called twice corrupting
the 'vlog_modules' list causing an infinite loop.
Signed-off-by: Gurucharan Shetty
Reported-by: Gur Stavi
---
AUTHORS |1 +
ovsdb/automake.mk |1 -
2 files changed,
-Original Message-
From: Pravin Shelar [mailto:pshe...@nicira.com]
Sent: Friday, July 18, 2014 1:20 AM
To: Wenyu Zhang
Cc: Romain Lenglet; Ben Pfaff; Jesse Gross; dev@openvswitch.org
Subject: Re: [PATCH v3] Extend OVS IPFIX exporter to export tunnel headers
On Thu, Jul 17, 2014 at 3:05
On Thu, Jul 17, 2014 at 8:20 PM, Wenyu Zhang wrote:
>
>
> -Original Message-
> From: Pravin Shelar [mailto:pshe...@nicira.com]
> Sent: Friday, July 18, 2014 1:20 AM
> To: Wenyu Zhang
> Cc: Romain Lenglet; Ben Pfaff; Jesse Gross; dev@openvswitch.org
> Subject: Re: [PATCH v3] Extend OVS IPFI
44 matches
Mail list logo
