Dear Applicant
Currently we recruit to Laval Quebec Canada with work permit for various
department/positions.*Accounts/Engineering/Waiters/Waitress/Office
Assistants/Customer Care Officers/Nurses/Drivers and more.
How to apply:Send Application Letter with Cv attached to:
quebecemployment@hotm
On Fri, May 16, 2014 at 08:07:07AM +0900, Simon Horman wrote:
> Allow datapath to recognize and extract MPLS labels into flow keys
> and execute actions which push, pop, and set labels on packets.
[snip]
> diff --git a/datapath/linux/compat/gso.h b/datapath/linux/compat/gso.h
> index b83a4c3..98b
On Thu, May 15, 2014 at 03:01:19AM -0700, Ryan Wilson wrote:
> When the user changes port type (i.e. changing p0 from type 'internal' to
> 'gre'), the netdev must first be deleted, then re-created with the new type.
> Deleting the netdev requires there exist no more references to the netdev.
> Howe
2014-05-16, Jesse Gross:
> On Thu, May 15, 2014 at 1:28 AM, wrote:
>> Hi Jesse,
>>
>> (below)
>>
>> 2014-05-09, Jesse Gross:
>>> On Fri, Apr 25, 2014 at 4:56 AM, wrote:
Hi Jesse,
(inlined below)
Jesse Gross :
>>
>> In general, I think it would be
In netdev_remove, the netdev is unreffed after being removed from the global
shash. If the ref count is 0, the netdev is destroyed.
I'll re-submit with a more accurate comment for netdev_remove (it unrefs rather
than destroys the netdev) and also adding a comment with netdev_remove in
iface_des
Perfect. Thanks!
On May 16, 2014 8:16 AM, "Ryan Wilson 76511" wrote:
> In netdev_remove, the netdev is unreffed after being removed from the
> global shash. If the ref count is 0, the netdev is destroyed.
>
> I'll re-submit with a more accurate comment for netdev_remove (it unrefs
> rather than d
On Fri, May 16, 2014 at 11:30:23AM +0900, Simon Horman wrote:
> In some cases an pop MPLS action changes a packet to be a non-mpls packet.
> In this case subsequent any L3+ actions require access to portions
> of the packet which were not decoded as they were opaque when the
> packet was MPLS. Allo
On Fri, May 16, 2014 at 11:30:24AM +0900, Simon Horman wrote:
> With recirculation in place this should be safe.
>
> Signed-off-by: Simon Horman
Nice.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Fri, May 16, 2014 at 11:30:26AM +0900, Simon Horman wrote:
> Co-Authored-by: Joe Stringer
> Signed-off-by: Simon Horman
Thanks, this makes sense.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Fri, May 16, 2014 at 11:30:25AM +0900, Simon Horman wrote:
> This makes maintaining the controller test slightly easier
> by splitting it in two.
>
> Based on a similar patch by Joe Stringer.
>
> Cc: Joe Stringer
> Signed-off-by: Simon Horman
Applied, thanks!
___
On Tue, May 13, 2014 at 04:15:18PM -0700, Daniele Di Proietto wrote:
> As suggested by others, we can use the classifier, instead of the
> hash table, as the only flow container in dpif-netdev
>
> Signed-off-by: Daniele Di Proietto
This needs {}:
> +if (!netdev_flow)
> +return NULL;
On Wed, May 14, 2014 at 04:19:33PM +0900, Simon Horman wrote:
> Some concern has been raised by Ben Pfaff that atomic_uint64_t may not
> be portable. In particular on 32bit platforms that do not have atomic
> 64bit integers.
>
> This series removes the users of atomic_uint64_t.
> It then removes a
When the user changes port type (i.e. changing p0 from type 'internal' to
'gre'), the netdev must first be deleted, then re-created with the new type.
Deleting the netdev requires there exist no more references to the netdev.
However, the xlate cache holds references to netdevs and the cache is onl
It appears this patch will be pushed, so I'll send out v3 of the xlate RCU
locking patch.
Cheers,
Ryan Wilson
Member of Technical Staff
wr...@vmware.com
3401 Hillview Avenue, Palo Alto, CA
650.427.1511 Office
916.588.7783 Mobile
On May 15, 2014, at 11:16 AM, Ryan Wilson wrote:
> Here's my new
---
lib/ovs-rcu.h |2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/ovs-rcu.h b/lib/ovs-rcu.h
index 4b451b2..8327517 100644
--- a/lib/ovs-rcu.h
+++ b/lib/ovs-rcu.h
@@ -129,6 +129,7 @@
*/
#if __GNUC__
#define OVSRCU_TYPE(TYPE) struct { ATOMIC(TYPE) p; }
+#define OVSRCU_TYPE_INITIALIZ
Before, a global read-write lock protected the ofproto-dpif / ofproto-dpif-xlate
interface. Handler and revalidator threads had to wait while configuration was
being changed. This patch implements RCU locking which allows handlers and
revalidators to operate while configuration is being updated.
S
On Fri, May 16, 2014 at 02:17:58AM -0700, Ryan Wilson wrote:
> When the user changes port type (i.e. changing p0 from type 'internal' to
> 'gre'), the netdev must first be deleted, then re-created with the new type.
> Deleting the netdev requires there exist no more references to the netdev.
> Howe
Acked-by: Alex Wang
On Fri, May 16, 2014 at 2:34 AM, Ryan Wilson wrote:
> ---
> lib/ovs-rcu.h |2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/lib/ovs-rcu.h b/lib/ovs-rcu.h
> index 4b451b2..8327517 100644
> --- a/lib/ovs-rcu.h
> +++ b/lib/ovs-rcu.h
> @@ -129,6 +129,7 @@
> */
>
Pushed to master,
Jarno
On May 7, 2014, at 11:11 AM, Ethan Jackson wrote:
> Acked-by: Ethan Jackson
>
>
> On Fri, May 2, 2014 at 8:44 AM, Jarno Rajahalme wrote:
>> Unless otherwise configured, the prefix trie lookup is enabled for
>> IPv4 destination and source address fields. A new keyw
Thanks for the review. applied to master, branch 2.2 and branch 2.3
On Thu, May 15, 2014 at 9:03 PM, Ben Pfaff wrote:
> On Mon, May 12, 2014 at 10:30:04AM -0700, Andy Zhou wrote:
>> Without this patch, the match passed into to
>> ofproto_dpif_add_internal_flow() are modified. The mask of dl_type
From: Daniele Di Proietto
This is necessary, since u64 is not unsigned long long
in all architectures: u64 could be also uint64_t.
Signed-off-by: Daniele Di Proietto
Signed-off-by: Jesse Gross
---
net/openvswitch/flow_netlink.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff -
From: Joe Perches
Each use of pr__once has a per-site flag.
Some of the OVS_NLERR messages look as if seeing them
multiple times could be useful, so use net_ratelimit()
instead of pr_info_once.
Signed-off-by: Joe Perches
Signed-off-by: Jesse Gross
---
net/openvswitch/datapath.h | 8 +---
From: Daniele Di Proietto
In few functions, const formal parameters are assigned or cast to
non-const.
These changes suppress warnings if compiled with -Wcast-qual.
Signed-off-by: Daniele Di Proietto
Signed-off-by: Jesse Gross
---
net/openvswitch/flow_netlink.c | 6 --
net/openvswitch/fl
A set of OVS changes for net-next/3.16.
The major change here is a switch from per-CPU to per-NUMA flow
statistics. This improves scalability by reducing kernel overhead
in flow setup and maintenance.
The following changes since commit a188a54d11629bef2169052297e61f3767ca8ce5:
macvlan: simplif
From: Joe Perches
Add "openvswitch: " prefix to OVS_NLERR output
to match the other OVS_NLERR output of datapath.c
Signed-off-by: Joe Perches
Signed-off-by: Jesse Gross
---
net/openvswitch/flow_netlink.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/openvswitch/flow_netlink.c b/ne
From: Daniele Di Proietto
This function must cast a const value to a non const value.
By adding an uintptr_t cast the warning is suppressed.
To avoid the cast (proper solution) several function signatures
must be changed.
Signed-off-by: Daniele Di Proietto
Signed-off-by: Jesse Gross
---
net/o
From: Monam Agarwal
This patch replaces rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, NULL)
The rcu_assign_pointer() ensures that the initialization of a structure
is carried out before storing a pointer to that structure.
And in the case of the NULL pointer, there is no structure to init
From: Jarno Rajahalme
We already extract the TCP flags for the key, might as well use that
for stats.
Signed-off-by: Jarno Rajahalme
Acked-by: Pravin B Shelar
Signed-off-by: Jesse Gross
---
net/openvswitch/flow.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git
From: Joe Perches
It's slightly smaller/faster for some architectures.
Signed-off-by: Joe Perches
Signed-off-by: Jesse Gross
---
net/openvswitch/actions.c | 4 ++--
net/openvswitch/flow.c | 16
net/openvswitch/flow_netlink.c | 12 ++--
3 files changed, 1
From: Jarno Rajahalme
The 5-tuple optimization becomes unnecessary with a later per-NUMA
node stats patch. Remove it first to make the changes easier to
grasp.
Signed-off-by: Jarno Rajahalme
Signed-off-by: Jesse Gross
---
net/openvswitch/datapath.c | 11
net/openvswitch/flow.c
From: Jarno Rajahalme
The 'output' argument of the ovs_nla_put_flow() is the one from which
the bits are written to the netlink attributes. For SCTP we
accidentally used the bits from the 'swkey' instead. This caused the
mask attributes to include the bits from the actual flow key instead
of th
From: Daniele Di Proietto
This change, firstly, avoids declaring the formal parameter const,
since it is treated as non const. (to avoid -Wcast-qual)
Secondly, it cast the pointer from void* to u8*, since it is used
in arithmetic (to avoid -Wpointer-arith)
Signed-off-by: Daniele Di Proietto
Sig
From: Jarno Rajahalme
Keep kernel flow stats for each NUMA node rather than each (logical)
CPU. This avoids using the per-CPU allocator and removes most of the
kernel-side OVS locking overhead otherwise on the top of perf reports
and allows OVS to scale better with higher number of threads.
Wit
Thanks Ryan, it is pretty close. Please see my comments below:
One high level comment is that, we assume new_xcfg is non-null. Could we
add assertion to the
external functions? e.g. xlate_ofport_remove()
>
@@ -324,10 +332,76 @@ static bool dscp_from_skb_priority(const struct xport
> *, uint
From: Jesse Gross
Date: Fri, 16 May 2014 14:07:27 -0700
> A set of OVS changes for net-next/3.16.
>
> The major change here is a switch from per-CPU to per-NUMA flow
> statistics. This improves scalability by reducing kernel overhead
> in flow setup and maintenance.
Pulled, thanks Jesse.
__
On Fri, May 16, 2014 at 1:48 AM, Simon Horman wrote:
> On Fri, May 16, 2014 at 08:07:07AM +0900, Simon Horman wrote:
>> Allow datapath to recognize and extract MPLS labels into flow keys
>> and execute actions which push, pop, and set labels on packets.
>
> [snip]
>
>> diff --git a/datapath/linux/
'cache' gives an inexact connotation, as the list is always expected
to be in order and contain pointers to all the subtables.
The struct cls_subtables fields are are also renamed to be more readable.
struct cls_classifier fields 'subtables' is remamed to 'subtables_map' and
'subtables_priority'
When, during a classifier lookup, we narrow down to a single potential
rule, it is enough to match on ("unwildcard") one bit that differs
between the packet and the rule.
This is a special case of the more general algorithm, where it is
sufficient to match on enough bits that separates the packet
Do not cache the 'tag' and 'max_priority' in the subtable array. This
makes later changes to classifier easier.
Also makes the 'cls_subtables*' functions to always leave the
subtables array in a consistent state. This includes the new
cls_subtables_insert() function and removal of the old
cls_su
On 05/16/14 at 02:29pm, Jesse Gross wrote:
> On Fri, May 16, 2014 at 1:48 AM, Simon Horman wrote:
> > On Fri, May 16, 2014 at 08:07:07AM +0900, Simon Horman wrote:
> >> Allow datapath to recognize and extract MPLS labels into flow keys
> >> and execute actions which push, pop, and set labels on pa
Before, a global read-write lock protected the ofproto-dpif / ofproto-dpif-xlate
interface. Handler and revalidator threads had to wait while configuration was
being changed. This patch implements RCU locking which allows handlers and
revalidators to operate while configuration is being updated.
S
On Fri, May 16, 2014 at 2:48 PM, Thomas Graf wrote:
> On 05/16/14 at 02:29pm, Jesse Gross wrote:
>> On Fri, May 16, 2014 at 1:48 AM, Simon Horman wrote:
>> > On Fri, May 16, 2014 at 08:07:07AM +0900, Simon Horman wrote:
>> >> Allow datapath to recognize and extract MPLS labels into flow keys
>> >
Pravin will be maintaining Open vSwitch going forward.
CC: Pravin Shelar
Signed-off-by: Jesse Gross
---
I'll continue to be very much involved (especially with the outstanding
patchsets). However, Pravin has been doing a significant amount of the
work involved in maintaining OVS already in addit
On May 16, 2014, at 9:26 AM, Ben Pfaff wrote:
> This needs {}:
>> +if (!netdev_flow)
>> +return NULL;
>
Sure, i’ll fix it
> VLOG_ERR is pretty strong. ovs-appctl(8) says that it means that "A
> high-level operation or a subsystem failed. Attention is warranted."
> That is, it ge
On Fri, May 16, 2014 at 04:17:34PM -0700, Daniele Di Proietto wrote:
> On May 16, 2014, at 9:26 AM, Ben Pfaff wrote:
> > I don't think that it is safe to use a cls_cursor to iterate flows in
> > the flow dump path. The classifier isn't locked from one
> > dpif_netdev_flow_dump_next() to the next,
Commit a6ce4b9d251 (ofproto-dpif-upcall: Avoid use-after-free in
revalidate() corner case.) showed that it is somewhat tricky to correctly
use the existing dpif flow dumping interface to obtain batches of flows.
One has to be careful about calling dpif_flow_dump_next_may_destroy_keys()
before going
Acked-by: Jarno Rajahalme
Some comments below, though,
Jarno
On May 8, 2014, at 4:50 PM, Ben Pfaff wrote:
> This implements an "optimistic concurrent cuckoo hash", a single-writer,
> multiple-reader hash table data structure. The point of this data
> structure is performance, so this comm
When deleting a mask from the mask array, we always move the last entry
into its current location. Another approach can be NULL in its current
place, and periodically compact it.
The approach taken by this patch is more efficient during run time.
During look up, fast path packet don't have to skip
On Fri, May 16, 2014 at 08:55:12AM -0700, Ben Pfaff wrote:
> On Fri, May 16, 2014 at 11:30:23AM +0900, Simon Horman wrote:
> > In some cases an pop MPLS action changes a packet to be a non-mpls packet.
> > In this case subsequent any L3+ actions require access to portions
> > of the packet which we
On Fri, May 16, 2014 at 03:17:18PM -0700, Jesse Gross wrote:
> On Fri, May 16, 2014 at 2:48 PM, Thomas Graf wrote:
> > On 05/16/14 at 02:29pm, Jesse Gross wrote:
> >> On Fri, May 16, 2014 at 1:48 AM, Simon Horman wrote:
> >> > On Fri, May 16, 2014 at 08:07:07AM +0900, Simon Horman wrote:
> >> >>
50 matches
Mail list logo
