The sample action is rather generic, allowing arbitrary actions to be
executed based on a probability. However its use, within the Open vSwitch
code-base is limited: only a single user-space action is ever nested.
A consequence of the current implementation of sample actions is that
depending on w
Hi Jessee,
as discussed elsewhere this series alters the sample action
so that nested-actions do not have side effects. The motivation
for this is to potentially simplify verification of new actions.
And in particular to simplify the verification of MPLS actions
(not included in this patchset).
S
On Wed, May 07, 2014 at 04:58:59PM +1200, Simon Horman wrote:
> Hi Ben,
>
> On Fri, May 02, 2014 at 07:34:58AM -0700, Ben Pfaff wrote:
> > On Fri, May 02, 2014 at 05:41:35PM +0900, Simon Horman wrote:
> > > This is to allow a recirculation id to be associated with a rule
> > > in the case that its
It is my understanding that on error execute_recirc() does not free the
skb passed to it.
Assuming this is true then on error skb should always be freed
if an error occurs in execute_recirc().
And if recirc_skb differs from skb, because it is a clone of skb,
then it should also be freed.
Signed-
On Thu, May 01, 2014 at 09:45:12AM -0700, Jesse Gross wrote:
> On Thu, May 1, 2014 at 1:54 AM, Simon Horman wrote:
> > On Wed, Apr 30, 2014 at 03:56:44PM -0700, Jesse Gross wrote:
> >> On Tue, Apr 29, 2014 at 10:58 PM, Simon Horman wrote:
> >> > On Tue, Apr 29, 2014 at 11:41:57AM -0700, Jesse Gro
Am Sun, May 11, 2014 at 01:13:47PM +0530 schrieb Anish Khurana:
> SET_ETHTOOL_OPS is equivalent to :
> #define SET_ETHTOOL_OPS(netdev,ops) \
> ( (netdev)->ethtool_ops = (ops) )
>
> how it makes difference removing this code and replacing with the
> code mentioned ?
It doesn't change anything
On Sat, May 10, 2014 at 5:40 AM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
>
> diff --git a/lib/ofp-msgs.h b/lib/ofp-msgs.h
> index df7569e..b548f6b 100644
> --- a/lib/ofp-msgs.h
> +++ b/lib/ofp-msgs.h
> @@ -162,8 +162,10 @@ enum ofpraw {
>
> /* OFPT 1.0 (12): struct ofp_port_status, stru
This trivial patch fixes a typo in lib/vconn-provider.h.
Signed-off-by: Rami Rosen
---
lib/vconn-provider.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/vconn-provider.h b/lib/vconn-provider.h
index b05bb45..0225a58 100644
--- a/lib/vconn-provider.h
+++ b/lib/vconn-pro
Add per-table counters. This resolves some short-comings
in the data provided in a table stats reply message.
* Lookups and matches are calculated based on table
accesses rather than datapath flow hits and misses.
* Lookups and matches are credited to the table where they
occurred rather than
Some concern has been raised by Ben Pfaff that atomic_uint64_t may not
be portable. In particular on 32bit platforms that do not have atomic
64bit integers.
Now that there are no longer any users of atomic_uint64_t remove it
entirely. Also remove atomic_int64_t which has no users.
Cc: YAMAMOTO Ta
Some concern has been raised by Ben Pfaff that atomic_uint64_t may not
be portable. Accordingly, use atomic_ulong instead of atomic_uint64_t
in struct ofproto.
This is in preparation for removing atomic_uint64_t entirely.
Cc: YAMAMOTO Takashi
Signed-off-by: Simon Horman
---
ofproto/ofproto-dpi
Some concern has been raised by Ben Pfaff that atomic_uint64_t may not
be portable. In particular on 32bit platforms that do not have atomic
64bit integers.
This series removes the users of atomic_uint64_t.
It then removes atomic_uint64_t and atomic_int64_t themselves.
Simon Horman (2):
ofproto
On 10 May 2014 03:14, Ben Pfaff wrote:
> On Fri, May 09, 2014 at 02:35:44PM +1200, Joe Stringer wrote:
>
> This was causing a mismatch between the odp flow key in an upcall
> > compared to the odp flow key that is serialised upon flow_dump.
> >
> > Signed-off-by: Joe Stringer
>
> I agree that t
Assert failures that should not happen have been reported on some
(non-OVS) test cases. This patch adds diagnostics to analyze what
goes wrong.
None of the OVS unit tests trigger these, so there is no performance
penalty.
This could be moved to test-classifier once it has served it's
purpose.
S
I assume that's the only change. If so, it sounds good. I hope we can catch
the bug quickly.
On May 11, 2014 8:34 PM, "Jarno Rajahalme" wrote:
> Assert failures that should not happen have been reported on some
> (non-OVS) test cases. This patch adds diagnostics to analyze what
> goes wrong.
>
>
Array splicing was broken when multiple elements were being moved,
resulting in the priority order being mixed. This came up when the
highest priority rule from a subtable was removed and the subtable
needed to be moved down the priority list by more than one position.
Signed-off-by: Jarno Rajaha
16 matches
Mail list logo
