On Mon, Mar 31, 2014 at 2:24 PM, YAMAMOTO Takashi
wrote:
> Bump timeout differences, because timeouts different by 1s might end up
> to have the same position in the heap as rule_eviction_priority() uses
> 1024ms as a unit.
>
> Also, use time/stop to avoid relying on how long an add-flow would tak
these fleeting phenomenal discor
, and partly to the more prominent actors in the war. The contrast between the
American colonies of Great Britain throwing off their allegiance to the Old
Country because they saw fit to do so for their own interests, and the
government of the Federation of the
My dear I sent you an important information that required urgent your
action but until now you have not reply the message why?
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
This is the diff between RSTP patch v3 and v2 (the one sent on February 24th).
---
diff --git a/v1/lib/rstp.c b/v2/lib/rstp.c
index 2725707..d226967 100644
--- a/v1/lib/rstp.c
+++ b/v2/lib/rstp.c
@@ -1076,6 +1076,20 @@ rstp_port_get_aux(struct rstp_port *p)
return aux;
}
+/* Returns true i
6674570558665051175975807744913939379765982978793377940695601954545212831445384076376468553050251523Shenzhen
Technology
Co.,Ltd is a high-tech company specializing in the development,
production and sale of hydraulic reinforced concrete cutting machine.Main
products are fully hydraulic wall
On Mon, Mar 31, 2014 at 03:24:28PM +0900, YAMAMOTO Takashi wrote:
> Signed-off-by: YAMAMOTO Takashi
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Mon, Mar 31, 2014 at 03:24:29PM +0900, YAMAMOTO Takashi wrote:
> Depending on how output buffers are flushed, there might
> be still races. But this at least makes the race windows smaller.
>
> Signed-off-by: YAMAMOTO Takashi
Acked-by: Ben Pfaff
_
On Mon, Mar 31, 2014 at 03:24:27PM +0900, YAMAMOTO Takashi wrote:
> Signed-off-by: YAMAMOTO Takashi
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Mon, Mar 31, 2014 at 03:24:30PM +0900, YAMAMOTO Takashi wrote:
> Bump timeout differences, because timeouts different by 1s might end up
> to have the same position in the heap as rule_eviction_priority() uses
> 1024ms as a unit.
>
> Also, use time/stop to avoid relying on how long an add-flow
On Mon, Mar 31, 2014 at 03:24:31PM +0900, YAMAMOTO Takashi wrote:
> These tests invokes ovs-ofctl monitor twice or more.
> Because "ovs-appctl -t ofctl exit" does not wait for the target
> process exit, there are chances to see the pid file from the previous
> incarnation.
>
> Signed-off-by: YAMAM
severity 740983 normal
thanks
This bug was submitted with:
Severity: grave
Justification: renders package unusable
because the DKMS module does not build with Linux kernel 3.13. While
this is true, it does not render the package unusable by any stretch of
the imagination, because Linux
Processing commands for cont...@bugs.debian.org:
> severity 740983 normal
Bug #740983 [openvswitch-datapath-dkms] openvswitch-datapath-dkms: fails to
build dkms module
Severity set to 'normal' from 'grave'
> thanks
Stopping processing here.
Please contact me if you need assistance.
--
740983: h
When openvswitch stops before libvirt shuts down VMs, it makes it hard for
libvirt to remove virtual network interfaces (ovs-vsctl cannot access the
database socket, which has been removed). This commit should ensure that
the VMs get shut down before openvswitch.
CC: 701...@bugs.debian.org
Report
Processing commands for cont...@bugs.debian.org:
> # 740983, for Linux 3.13, is against openvswitch-datapath-dkms
> # 732260, for Linux 3.11, is against openvswitch
> #
> # They are essentially the same bug, so make them both against
> # the same package.
> #
> # For now, not merging them: 732260
CC: 733...@bugs.debian.org
Reported-by: m...@linux.it (Marco d'Itri)
Signed-off-by: Ben Pfaff
---
AUTHORS| 1 +
debian/control | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/AUTHORS b/AUTHORS
index b189957..e853887 100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -209,6 +209,7
On Sun, Mar 30, 2014 at 06:45:09PM -0700, Andy Zhou wrote:
> Changing one of the files in the Open vSwitch ``lib'' directory
> causes 43 binaries to be relinked, which takes a lot of time even with
> parallel ``make''. 31 of those binaries are in the ``tests''
> directory. ovs-test attemps to com
On Sun, Mar 30, 2014 at 06:45:10PM -0700, Andy Zhou wrote:
> Modify test-heap.c to use ovstest framework.
>
> Signed-off-by: Andy Zhou
Looking at this, I think it would be better to require the test name to
be passed in as a string, that is, "test-heap" instead of test-heap. It
looks less odd t
On Sun, Mar 30, 2014 at 07:15:47PM -0700, Andy Zhou wrote:
> Modify test-heap.c to use ovstest framework.
>
> Signed-off-by: Andy Zhou
>
> ---
> v1-v2: Coding style fixes
I inadvertently reviewed v1. I guess v1->v2 isn't a big deal so feel
free to use my original reviews.
_
openvswitch_2.1.0+git20140325-1_i386.changes uploaded successfully to localhost
along with the files:
openvswitch_2.1.0+git20140325-1.dsc
openvswitch_2.1.0+git20140325.orig.tar.xz
openvswitch_2.1.0+git20140325-1.debian.tar.xz
openvswitch-common_2.1.0+git20140325-1_i386.deb
openvswitch-swi
binary:openvswitch-vtep is NEW.
Your package contains new components which requires manual editing of
the override file. It is ok otherwise, so please be patient. New
packages are usually added to the override file about once a week.
___
dev mailing li
ovs_flow_cmd_del() now allocates reply (if needed) after the flow has
already been removed from the flow table. If the reply allocation
fails, a netlink error is signaled with netlink_set_err(), as is
already done in ovs_flow_cmd_new_or_set() in the similar situation.
Signed-off-by: Jarno Rajahal
For ovs_flow_stats_get() using ovsl_dereference() was wrong, since
flow dumps call this with RCU read lock.
ovs_flow_stats_clear() is always called with ovs_mutex, so can use
ovsl_dereference().
Also, make the ovs_flow_stats_get() 'flow' argument const to make
later patches cleaner.
Signed-off-b
Incorrect struct name was confusing, even though otherwise
inconsequental.
Signed-off-by: Jarno Rajahalme
---
datapath/flow_table.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/datapath/flow_table.c b/datapath/flow_table.c
index a680895..159572b 100644
--- a/datapath/fl
Following patch will be easier to reason about with separate
ovs_flow_cmd_new() and ovs_flow_cmd_set() functions.
Signed-off-by: Jarno Rajahalme
---
datapath/datapath.c | 161 +--
1 file changed, 117 insertions(+), 44 deletions(-)
diff --git a/da
Reduce and clarify locking requirements for ovs_flow_cmd_alloc_info(),
ovs_flow_cmd_fill_info() and ovs_flow_cmd_build_info().
A datapath pointer is available only when holding a lock. Change
ovs_flow_cmd_fill_info() and ovs_flow_cmd_build_info() to take a
dp_ifindex directly, rather than a datap
Signed-off-by: Jarno Rajahalme
---
v6: Use key fields of the newly allocated flow directly in ovs_flow_cmd_new().
Correctly handle the case of no acts in ovs_flow_cmd_set().
datapath/datapath.c | 193 ++-
1 file changed, 115 insertions(+), 78
Every other table has an external_ids column, which can be useful to
controller writers for integration purposes, so add one to Flow_Table also.
Reported-by: Ariel Tubaltsev
Signed-off-by: Ben Pfaff
---
AUTHORS|1 +
vswitchd/vswitch.ovsschema |9 ++---
vswitchd/v
On Sat, Mar 29, 2014 at 05:47:18PM -0700, Jarno Rajahalme wrote:
> Thanks for the review! Pushed to master with the proposed changes. See a
> small comment below, though.
>
> Jarno
>
> On Mar 25, 2014, at 5:16 PM, Ben Pfaff wrote:
>
> > On Mon, Mar 24, 2014 at 10:59:06AM -0700, Jarno Rajahalm
Done. Sorry it took me a few days.
On Tue, Mar 25, 2014 at 05:48:15PM -0300, Flavio Leitner wrote:
>
> Ben,
>
> Could you cherry-pick the commit below to branch-2.1 as well?
>
> commit 490db96efaf89c63656b192d5ca287b0908a6c77
> Author: Flavio Leitner
> Date: Tue Jan 14 00:22:07 2014 -0200
>
On Tue, Mar 25, 2014 at 02:50:17PM -0300, Flavio Leitner wrote:
> It should be an administrator task to bring up devices as they
> are configured properly.
>
> Currently, Fedora is deleting the bridges when the interface is
> brought down. Therefore, there is no bridge on the next boot and
> the i
Acked-by: Justin Pettit
--Justin
Ben Pfaff wrote:
Every other table has an external_ids column, which can be useful to
controller writers for integration purposes, so add one to Flow_Table also.
Reported-by: Ariel Tubaltsev
Signed-off-by: Ben Pfaff
---
AUTHORS|1 +
Acked-by: Justin Pettit
--Justin
Ben Pfaff wrote:
CC: 733...@bugs.debian.org
Reported-by: m...@linux.it (Marco d'Itri)
Signed-off-by: Ben Pfaff
---
AUTHORS| 1 +
debian/control | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/AUTHORS b/AUTHORS
index b189957..e
> diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
> index 03db95a..0100c2f 100644
> --- a/include/linux/skbuff.h
> +++ b/include/linux/skbuff.h
> @@ -567,6 +567,7 @@ struct sk_buff {
>* headers if needed
>*/
> __u8encapsulation:1;
> + __u8
Thanks, applied to master and branch-2.1.
On Mon, Mar 31, 2014 at 01:29:06PM -0700, Justin Pettit wrote:
> Acked-by: Justin Pettit
>
> --Justin
>
>
> Ben Pfaff wrote:
> >CC: 733...@bugs.debian.org
> >Reported-by: m...@linux.it (Marco d'Itri)
> >Signed-off-by: Ben Pfaff
> >---
> > AUTHORS
Thanks, applied to master.
On Mon, Mar 31, 2014 at 01:25:18PM -0700, Justin Pettit wrote:
> Acked-by: Justin Pettit
>
> --Justin
>
>
> Ben Pfaff wrote:
> >Every other table has an external_ids column, which can be useful to
> >controller writers for integration purposes, so add one to Flow_Tab
> diff --git a/net/Kconfig b/net/Kconfig
> index e411046..e02ab8d 100644
> --- a/net/Kconfig
> +++ b/net/Kconfig
> @@ -285,6 +285,16 @@ config NET_FLOW_LIMIT
> with many clients some protection against DoS by a single (spoofed)
> flow that greatly exceeds average workload.
>
> +con
Hi Jiri,
Apologies for possibly newbie questions here, but:
> +bool swdev_dev_check(const struct net_device *dev)
> +{
> + return dev->priv_flags & IFF_SWITCH;
> +}
> +EXPORT_SYMBOL(swdev_dev_check);
[...]
> + BUG_ON(!swdev_dev_check(dev));
[...]
> +int __swdev_register(struct net_device
On Mon, Mar 31, 2014 at 01:04:53PM -0700, Ben Pfaff wrote:
> Done. Sorry it took me a few days.
No worries,
thanks!
fbl
> On Tue, Mar 25, 2014 at 05:48:15PM -0300, Flavio Leitner wrote:
> >
> > Ben,
> >
> > Could you cherry-pick the commit below to branch-2.1 as well?
> >
> > commit 490db96ef
Allows setting up type=patch ports through sysconfig ifcfg-* files.
Signed-off-by: Jason Kölker
---
rhel/README.RHEL | 25 +
rhel/etc_sysconfig_network-scripts_ifdown-ovs | 3 +++
rhel/etc_sysconfig_network-scripts_ifup-ovs | 4
3 fil
On Sat, Mar 29, 2014 at 7:33 PM, Jarno Rajahalme wrote:
>
> On Mar 28, 2014, at 2:52 PM, Jesse Gross wrote:
>
>> On Fri, Mar 28, 2014 at 8:50 AM, Jarno Rajahalme
>> wrote:
>>>
On Mar 27, 2014, at 3:59 PM, Jesse Gross wrote:
> On Fri, Feb 21, 2014 at 11:41 AM, Jarno Rajahalme
>>
On Sun, Mar 30, 2014 at 5:12 AM, wei zhang wrote:
> At 2014-03-29 06:02:25,"Jesse Gross" wrote:
>
>>I'm not sure that rejecting all ICMP packets is the correct thing do
>>here since it means that we could pass them onto a later caller even
>>though they are intended for us. We should probably use
Thanks Ben for the review.
I will push with following incremental changes.
The first two issues, argument check and --help took a bit more code
which I don't feel comfortable check-in without review. I will
incorporate them into the follow on patch series.
i
On Mon, Mar 31, 2014 at 11:34:14PM +, Jason Kölker wrote:
> Allows setting up type=patch ports through sysconfig ifcfg-* files.
>
> Signed-off-by: Jason Kölker
> ---
Looks good, works here.
Acked-by: Flavio Leitner
___
dev mailing list
dev@openv
From: Pravin Shelar
netdev-dpdk uses this pointer to store dpdk mbuf. This patch fixes
compilation error in dpdk.
Signed-off-by: Pravin B Shelar
---
lib/ofpbuf.h |4
1 file changed, 4 insertions(+)
diff --git a/lib/ofpbuf.h b/lib/ofpbuf.h
index 8d1cb11..9becedd 100644
--- a/lib/ofpbu
From: Pravin Shelar
Define data, base and size access APIs for DPDK.
Signed-off-by: Pravin B Shelar
---
lib/ofpbuf.h | 47 ++-
1 file changed, 42 insertions(+), 5 deletions(-)
diff --git a/lib/ofpbuf.h b/lib/ofpbuf.h
index df7f189..94651e4 100644
From: Pravin Shelar
On DPDK packet recv, ovs is given pointer to mbuf which has
information about a packet, for example pointer to data and size.
By moving mbuf to ofpbuf we can let dpdk allocate ofpbuf and
pass that to ovs for processing the packet.
Signed-off-by: Pravin B Shelar
---
lib/netd
From: Pravin Shelar
Signed-off-by: Pravin B Shelar
---
lib/ofpbuf.c | 27 ++-
lib/ofpbuf.h |2 ++
2 files changed, 24 insertions(+), 5 deletions(-)
diff --git a/lib/ofpbuf.c b/lib/ofpbuf.c
index 8763e49..f616b1c 100644
--- a/lib/ofpbuf.c
+++ b/lib/ofpbuf.c
@@ -23,
> On Mon, Mar 31, 2014 at 03:24:31PM +0900, YAMAMOTO Takashi wrote:
>> These tests invokes ovs-ofctl monitor twice or more.
>> Because "ovs-appctl -t ofctl exit" does not wait for the target
>> process exit, there are chances to see the pid file from the previous
>> incarnation.
>>
>> Signed-off-b
>> # Sleep and modify the one that expires soonest
>> -sleep 2
>> +ovs-appctl time/warp 2
>
> I think we should warp as small as possible to verify precision.
> What do you think about warp 12000?
i agree smaller is better.
how about the following?
YAMAMOTO Takashi
commit b4a624761fe90aa0
Hi Jesse, Hi Pravin, Hi All,
This patchset makes use of a whitelist to only allow mpls_push actions to
be applied to packets with an ethertype where the tag order is well defined
and implemented. This avoids the problem of where an MPLS LSE should be
added in relation to a VLAN or similar tag.
Th
On Thu, Mar 20, 2014 at 10:05:44AM -0700, Ben Pfaff wrote:
> On Fri, Mar 14, 2014 at 04:19:52PM +0900, Simon Horman wrote:
> > When creating a flow in the datapath as the result of an upcall
> > the match itself is the match supplied in the upcall while
> > the mask of the match, if supplied, is ge
Allow datapath to recognize and extract MPLS labels into flow keys
and execute actions which push, pop, and set labels on packets.
Based heavily on work by Leo Alterman, Ravi K, Isaku Yamahata and Joe Stringer.
Cc: Ravi K
Cc: Leo Alterman
Cc: Isaku Yamahata
Cc: Joe Stringer
Signed-off-by: Sim
On Tue, Mar 25, 2014 at 01:48:39PM -0700, Andy Zhou wrote:
> Infrastructure to enable megaflow support for bond ports using
> recirculation. This patch adds the following features:
> * Generate RECIRC action when bond can benefit from recirculation.
> * Populate post recirculation rules in a hidden
On Tue, Apr 1, 2014 at 1:12 PM, YAMAMOTO Takashi wrote:
>>> # Sleep and modify the one that expires soonest
>>> -sleep 2
>>> +ovs-appctl time/warp 2
>>
>> I think we should warp as small as possible to verify precision.
>> What do you think about warp 12000?
>
> i agree smaller is better.
> h
54 matches
Mail list logo
