Re: [ovs-dev] [PATCH/RFC 4/8] ofproto-dpif: Add recirc_id field to struct rule_dpif

2014-03-26 Thread Simon Horman
On Tue, Mar 25, 2014 at 09:18:19PM -0700, Andy Zhou wrote: > On Tue, Mar 25, 2014 at 7:19 PM, Simon Horman wrote: > > Hi Andy, > > > > to date, the implementation of MPLS has not provided any entity other > > than the rules themselves. > > I see. I need to step back to understand the bigger pictu

Re: [ovs-dev] hackathon idea list

2014-03-26 Thread Flavio Leitner
On Tue, Mar 25, 2014 at 10:11:23PM -0700, Ben Pfaff wrote: > Bash Command Completion > --- > > ovs-vsctl and other programs would be easier to use if bash command > completion (with ``tab'', etc.) were supported. Alex Wang > is planning to lead a team for this project. Feel f

Re: [ovs-dev] hackathon idea list

2014-03-26 Thread Alex Wang
Thanks Flavio, In fact, I have learned a lot from your post about how to write compgen functions. ;D Will keep using your script as reference ~ I'm thinking of writing a script that parses the manpage and generates the script of compgen functions. I have some initial implementation here for app

Re: [ovs-dev] hackathon idea list

2014-03-26 Thread Flavio Leitner
On Wed, Mar 26, 2014 at 07:25:34AM -0700, Alex Wang wrote: > Thanks Flavio, > > In fact, I have learned a lot from your post about how to write compgen > functions. ;D Same here, it was my first attempt to write bash completion scripts. :) > Will keep using your script as reference ~ > > I'm

[ovs-dev] [patch net-next RFC v2 0/6] introduce infrastructure for support of switch chip datapath

2014-03-26 Thread Jiri Pirko
This is second version of RFC. Here are the main differences from the first one: -There is no special swdev of swport structure. The switch and its ports are now represented only by net_device structures. There are couple of switch-specific ndos added (inserting and removing flows). -Regarding

[ovs-dev] [patch net-next RFC v2 6/6] net: introduce dummy switch

2014-03-26 Thread Jiri Pirko
Dummy switch implementation using switchdev API Signed-off-by: Jiri Pirko --- drivers/net/Kconfig | 7 ++ drivers/net/Makefile | 1 + drivers/net/dummyswitch.c| 235 +++ include/uapi/linux/if_link.h | 9 ++ 4 files changed, 252 i

[ovs-dev] [patch net-next RFC v2 4/6] net: introduce switchdev API

2014-03-26 Thread Jiri Pirko
switchdev API is designed to allow kernel support for various switch chips. It is the responsibility of a driver to create netdevice instances which represents every port and for the switch master itself. Driver uses swdev_register and swportdev_register functions to make the core aware of the fac

[ovs-dev] [patch net-next RFC v2 2/6] skbuff: add "missed_flow" flag

2014-03-26 Thread Jiri Pirko
This flag sets incoming switch device in order to let know that the flow which the skb is part of is missed. Listener may react to it appropriately, Signed-off-by: Jiri Pirko --- include/linux/filter.h | 1 + include/linux/skbuff.h | 13 + net/core/filter.c | 3 +++ 3 files ch

[ovs-dev] [patch net-next RFC v2 5/6] openvswitch: Introduce support for switchdev based datapath

2014-03-26 Thread Jiri Pirko
Signed-off-by: Jiri Pirko --- include/uapi/linux/openvswitch.h | 4 + net/openvswitch/Makefile | 4 + net/openvswitch/datapath.c | 45 ++- net/openvswitch/datapath.h | 8 ++ net/openvswitch/dp_notify.c| 3 +-

[ovs-dev] [patch net-next RFC v2 3/6] openvswitch: split flow structures into ovs specific and generic ones

2014-03-26 Thread Jiri Pirko
After this, flow related structures can be used in other code. Signed-off-by: Jiri Pirko --- include/linux/sw_flow.h| 105 +++ net/openvswitch/datapath.c | 45 +++ net/openvswitch/datapath.h | 4 +- net/openvswitch/flow.c |

Re: [ovs-dev] [PATCH] netdev-bsd: compilation fixes

2014-03-26 Thread Ben Pfaff
On Wed, Mar 26, 2014 at 02:26:15PM +0900, YAMAMOTO Takashi wrote: > > On Wed, Mar 26, 2014 at 10:29:03AM +0900, YAMAMOTO Takashi wrote: > >> > On Wed, Mar 26, 2014 at 05:13:43AM +0900, YAMAMOTO Takashi wrote: > >> >> This fixes regressions from commit f7791740 > >> >> ("netdev: Rename netdev_rx to

Re: [ovs-dev] [patch net-next RFC v2 2/6] skbuff: add "missed_flow" flag

2014-03-26 Thread Alexei Starovoitov
On Wed, Mar 26, 2014 at 9:31 AM, Jiri Pirko wrote: > This flag sets incoming switch device in order to let know that the flow > which the skb is part of is missed. Listener may react to it > appropriately, > > Signed-off-by: Jiri Pirko > --- > include/linux/filter.h | 1 + > include/linux/skbuf

Re: [ovs-dev] [patch net-next RFC v2 2/6] skbuff: add "missed_flow" flag

2014-03-26 Thread Jiri Pirko
Wed, Mar 26, 2014 at 05:59:12PM CET, alexei.starovoi...@gmail.com wrote: >On Wed, Mar 26, 2014 at 9:31 AM, Jiri Pirko wrote: >> This flag sets incoming switch device in order to let know that the flow >> which the skb is part of is missed. Listener may react to it >> appropriately, >> >> Signed-of

Re: [ovs-dev] [PATCH] datapath: Add support for kernel 3.13

2014-03-26 Thread Kyle Mestery
On Tue, Mar 25, 2014 at 3:36 PM, Pravin Shelar wrote: > On Fri, Mar 21, 2014 at 10:41 AM, Kyle Mestery > wrote: > > Add support for building the in-tree kernel datapath for Linux kernel > 3.13. > > There were some changes in the netlink area which required adding new > > compatibility code for t

Re: [ovs-dev] [PATCH V2 09/10] dpif-netdev: Add DPDK netdev.

2014-03-26 Thread Ed Maste
On 21 March 2014 14:03, Pravin wrote: > Following patch adds DPDK netdev-class to userspace datapath. Now > OVS can use DPDK port for IO by just configuring DPDK port and then > adding dpdk type port to userspace datapath. Intel recently released DPDK also for FreeBSD, so it may be worth referrin

Re: [ovs-dev] [PATCH v4] core, nfqueue, openvswitch: Orphan frags in skb_zerocopy and handle errors

2014-03-26 Thread David Miller
From: Zoltan Kiss Date: Fri, 21 Mar 2014 10:31:34 + > skb_zerocopy can copy elements of the frags array between skbs, but it doesn't > orphan them. Also, it doesn't handle errors, so this patch takes care of that > as well, and modify the callers accordingly. skb_tx_error() is also added to >

Re: [ovs-dev] [PATCH v4] core, nfqueue, openvswitch: Orphan frags in skb_zerocopy and handle errors

2014-03-26 Thread David Miller
From: David Miller Date: Wed, 26 Mar 2014 15:59:58 -0400 (EDT) > From: Zoltan Kiss > Date: Fri, 21 Mar 2014 10:31:34 + > >> skb_zerocopy can copy elements of the frags array between skbs, but it >> doesn't >> orphan them. Also, it doesn't handle errors, so this patch takes care of that >>

Re: [ovs-dev] hackathon idea list

2014-03-26 Thread Ansis Atteka
Here is another idea: Use strongSwan to negotiate IPsec_* tunnels Currently ovs-monitor-ipsec uses racoon to negotiate IPsec flavored tunnels. Besides racoon, there are also some other IPsec keying daemons (e.g. strongSwan, racoon2, open

Re: [ovs-dev] [patch net-next RFC v2 0/6] introduce infrastructure for support of switch chip datapath

2014-03-26 Thread Jamal Hadi Salim
Jiri, The flow extensions may be distracting - note there are many tables (L3, L2, etc) in such chips not just ACLs. And there's likely no OneWay(tm) to add a flow. My view is probably to solve or reach an agreement on the ports. Then resolve the different tables control/data exposure. On the swi

Re: [ovs-dev] [patch net-next RFC v2 0/6] introduce infrastructure for support of switch chip datapath

2014-03-26 Thread Florian Fainelli
2014-03-26 14:44 GMT-07:00 Jamal Hadi Salim : > Jiri, > > The flow extensions may be distracting - note there are many > tables (L3, L2, etc) in such chips not just ACLs. And there's likely no > OneWay(tm) to add a flow. My view is probably to solve or reach an > agreement on the ports. Then resolv

Re: [ovs-dev] [BUG]: kernel crash when use gre vport of openvswitch!

2014-03-26 Thread Jesse Gross
On Tue, Mar 25, 2014 at 7:28 PM, wei zhang wrote: > Hi > > When I use gre vport of openvswitch on the Centos6.4, kernel crashed! > the crash log is attached at the last. > > I found out that openvswitch register a gre_cisco_protocol but > does not supply a err_handler with it. The gre_cisco_err()

Re: [ovs-dev] Null Pointer / Kernel Panic

2014-03-26 Thread Jesse Gross
On Tue, Feb 25, 2014 at 12:56 PM, Sean Swehla wrote: > Hello, > > I'm currently hitting a null pointer dereference and kernel panic that seems > to be in ovs. The problem is sporadic. I have one production machine that's > hit it four times in the past 24hrs, and one lab machine that I can't get t

[ovs-dev] [PATCH v5] core, nfqueue, openvswitch: Orphan frags in skb_zerocopy and handle errors

2014-03-26 Thread Zoltan Kiss
skb_zerocopy can copy elements of the frags array between skbs, but it doesn't orphan them. Also, it doesn't handle errors, so this patch takes care of that as well, and modify the callers accordingly. skb_tx_error() is also added to the callers so they will signal the failed delivery towards the c

Re: [ovs-dev] [PATCH v4] core, nfqueue, openvswitch: Orphan frags in skb_zerocopy and handle errors

2014-03-26 Thread Zoltan Kiss
On 26/03/14 20:12, David Miller wrote: From: David Miller Date: Wed, 26 Mar 2014 15:59:58 -0400 (EDT) From: Zoltan Kiss Date: Fri, 21 Mar 2014 10:31:34 + skb_zerocopy can copy elements of the frags array between skbs, but it doesn't orphan them. Also, it doesn't handle errors, so this p

Re: [ovs-dev] [PATCH] ofproto-dpif: Remove the flow_dumper thread.

2014-03-26 Thread Joe Stringer
Hey Ethan, On 6 March 2014 13:33, Joe Stringer wrote: > static void > -revalidate_udumps(struct revalidator *revalidator, struct list *udumps) > +revalidate(struct revalidator *revalidator) > { > struct udpif *udpif = revalidator->udpif; > > struct dump_op ops[REVALIDATE_MAX_BATCH];

Re: [ovs-dev] boot.sh is failing on latest master -- need help

2014-03-26 Thread Ben Pfaff
On Tue, Mar 25, 2014 at 11:39 AM, Sabyasachi Sengupta wrote: > > I'm getting the following error while trying to build openvswitch. Can > anyone suggest what may be missing? I have autoconf-2.65, m4 and libtool > installed. The failure does not occur when using master from last week. > > [sabyasse

Re: [ovs-dev] [PATCH] datapath: Add support for kernel 3.13

2014-03-26 Thread Kyle Mestery
On Tue, Mar 25, 2014 at 3:36 PM, Pravin Shelar wrote: > On Fri, Mar 21, 2014 at 10:41 AM, Kyle Mestery > wrote: > > Add support for building the in-tree kernel datapath for Linux kernel > 3.13. > > There were some changes in the netlink area which required adding new > > compatibility code for t

[ovs-dev] [PATCH net] openvswitch: fix a possible deadlock and lockdep warning

2014-03-26 Thread Flavio Leitner
There are two problematic situations. A deadlock can happen when is_percpu is false because it can get interrupted while holding the spinlock. Then it executes ovs_flow_stats_update() in softirq context which tries to get the same lock. The second sitation is that when is_percpu is true, the code

[ovs-dev] [PATCH] recirculation: Some cosmetic fixes

2014-03-26 Thread YAMAMOTO Takashi
Wrap long lines, fix whitespaces, and fix a typo in a comment. No functional changes are intended. Cc: Andy Zhou Signed-off-by: YAMAMOTO Takashi --- include/linux/openvswitch.h | 3 ++- lib/dpif-netdev.c | 3 ++- ofproto/ofproto-dpif.h | 50 -