[ovs-dev] provide mould and finished parts

2014-02-19 Thread sili
Dear Sirs, We specialize in Plastic injection Mold, Die Casting Mold, Metal Stamping Mold. We can produce the top quality molds according to your requirements with our independent development team, optimized operating procedures, updated facilities,strictly quality control system… If you h

[ovs-dev] [PATCH 2/2] vswitchd: Limit fake bridge MAC selection to ports in the same VLAN

2014-02-19 Thread Helmut Schaa
Limit fake bridge MAC address selection to only consider ports that use the same VLAN as the fake bridge itself. This prevents OVS from selecting a MAC address that was not really present in the VLAN of the fake bridge before. Signed-off-by: Helmut Schaa --- I'm running this patchset on top of

[ovs-dev] [PATCH 1/2] vswitchd: Split pick_local_hw_addr

2014-02-19 Thread Helmut Schaa
This allows to reuse find_local_hw_addr for fake bridges. Preparation for upcoming MAC address inheritance for fake bridges. Signed-off-by: Helmut Schaa --- vswitchd/bridge.c | 44 ++-- 1 file changed, 26 insertions(+), 18 deletions(-) diff --git a/vswitc

Re: [ovs-dev] [PATCH] ofp-actions: Consider pop MPLS to non-MPLS ethtype as consistent

2014-02-19 Thread Simon Horman
On Tue, Feb 18, 2014 at 10:43:27AM -0800, Jarno Rajahalme wrote: > > On Feb 16, 2014, at 5:11 PM, Simon Horman wrote: > > > On Mon, Feb 17, 2014 at 10:06:55AM +0900, Simon Horman wrote: > >> Remove the restriction that pop MPLS to an ethtype is > >> considered inconsistent. > >> > >> As it happ

[ovs-dev] Working on ONF Extensions for OF1.3.X

2014-02-19 Thread Shivanker Goel
Hi guys, I am a CS Major, Undergraduate student at IIT Delhi. I was looking for a roughly 6-7 week project on the lines of extending OVS with OF 1.3+ specs. So I had a look at the OPENFLOW-1.1+ document in OVS and think that I could work on some topics in ONF 1.3.X Extensions required for OF1.4. I

[ovs-dev] [PATCH] ofp-actions: Correct pop MPLS ethtype as consistency test

2014-02-19 Thread Simon Horman
Correct pop MPLS ethtype consistency check to verify that the packet has an MPLS ethtype before the pop action rather than after: an MPLS ethtype is a pre-condition but not a post-condition of pop MPLS. With this change the consistency check in ofpact_check__() becomes consistent with that in ofpa

[ovs-dev] [PATCH] ofp-util: Fix a typo in ofputil_decode_ofp11_port

2014-02-19 Thread kmindg
Signed-off-by: kmindg --- lib/ofp-util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ofp-util.c b/lib/ofp-util.c index 7de82c6..aa25e67 100644 --- a/lib/ofp-util.c +++ b/lib/ofp-util.c @@ -3640,7 +3640,7 @@ ofputil_decode_ofp11_port(struct ofputil_phy_port *pp, ov

[ovs-dev] Is there a way to get port status directly on kernel module?

2014-02-19 Thread Rafael Duarte Vencioneck
Digging a little in ovs kernel module code, I can't find a way to verify if a given port is up or down before execute an output. Is there a way to do that? OVS version 1.9.3 Thanks, Rafael Duarte Vencioneck ___ dev mailing list dev@openvswitch.org http:/

[ovs-dev] OVS Netlink zerocopy vs Xen netback zerocopy

2014-02-19 Thread Zoltan Kiss
Hi, Currently I'm working on a patchset which reintroduces grant mapping into netback. We used it before Linux Xen bits were upstreamed, but we had to change to grant copy as the original solution were fundamentally not upstreamable. But the advantage would be huge, as we could replace copy g

Re: [ovs-dev] [ovs-discuss] Working on ONF Extensions for OF1.3.X

2014-02-19 Thread Ben Pfaff
On Wed, Feb 19, 2014 at 05:32:19PM +0530, Shivanker Goel wrote: > I am a CS Major, Undergraduate student at IIT Delhi. I was looking for a > roughly 6-7 week project on the lines of extending OVS with OF 1.3+ specs. > So I had a look at the OPENFLOW-1.1+ document in OVS and think that I could > wor

Re: [ovs-dev] [ovs-discuss] Working on ONF Extensions for OF1.3.X

2014-02-19 Thread Shivanker Goel
On Wed, Feb 19, 2014 at 9:40 PM, Ben Pfaff wrote: > I don't know of anyone working on these features. > > I would pick one small project to start and then later take on more if > you have time. Bundles are a huge project, table synchronization is > pretty pointless for a software switch, and so

[ovs-dev] [PATCH] OPENFLOW-1.1+: Remove "rework tag order" from OF1.3.

2014-02-19 Thread Ben Pfaff
OpenFlow 1.3.4 is going to revert this change that OpenFlow 1.3 made. Signed-off-by: Ben Pfaff --- OPENFLOW-1.1+ | 4 1 file changed, 4 deletions(-) diff --git a/OPENFLOW-1.1+ b/OPENFLOW-1.1+ index eaf2ee9..8c5811b 100644 --- a/OPENFLOW-1.1+ +++ b/OPENFLOW-1.1+ @@ -129,10 +129,6 @@ didn't

[ovs-dev] [PATCH] OPENFLOW-1.1+: Update status of a few items.

2014-02-19 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- OPENFLOW-1.1+ | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/OPENFLOW-1.1+ b/OPENFLOW-1.1+ index 8c5811b..388f5fd 100644 --- a/OPENFLOW-1.1+ +++ b/OPENFLOW-1.1+ @@ -56,7 +56,7 @@ probably incomplete. * OFPT_TABLE_MOD message. This is

Re: [ovs-dev] [PATCH] sFlow LAG and Tunnel export

2014-02-19 Thread Neil McKee
Finally getting back to this. Can we do it one piece at a time? For example, attached is a patch that just adds counters to the LACP module and a call to retrieve them. Neil -- Neil McKee InMon Corp. http://www.inmon.com On Mon, Jan 13, 2014 at 8:29 AM, Neil McKee wrote: > Thanks for the

Re: [ovs-dev] [PATCH] ovs-vsctl: reconnect to the database if connection was dropped

2014-02-19 Thread Ben Pfaff
On Tue, Feb 18, 2014 at 02:34:58PM -0800, Ansis Atteka wrote: > If ovs-vsctl has to wait for ovs-vswitchd to reconfigure itself > according to the new database, then sometimes ovs-vsctl could > end up stuck in the event loop if OVSDB connection was dropped > while ovs-vsctl was still running. > >

[ovs-dev] [PATCH] ofproto: Remove 'force-miss-model' configuration.

2014-02-19 Thread Joe Stringer
This configuration item was introduced to assist testing of upcall handling behaviour with and without facets. Facets were removed in commit e79a6c833e0d7237, so this patch removes the configuration item. Signed-off-by: Joe Stringer --- ofproto/ofproto-provider.h |4 ofproto/ofproto.c

[ovs-dev] [PATCH v2] OPENFLOW-1.1+: Remove "rework tag order" and MPLS BoS matching from OF1.3.

2014-02-19 Thread Ben Pfaff
OpenFlow 1.3.4 is going to revert the tag order change made by OpenFlow 1.3. MPLS BoS matching is implemented. Signed-off-by: Ben Pfaff --- v1->v2: Also remove MPLS BoS matching since that's been implemented. OPENFLOW-1.1+ |8 1 file changed, 8 deletions(-) diff --git a/OPENFLOW-

Re: [ovs-dev] [PATCH v2] OPENFLOW-1.1+: Remove "rework tag order" and MPLS BoS matching from OF1.3.

2014-02-19 Thread Joe Stringer
Acked-by: Joe Stringer On 19 February 2014 10:30, Ben Pfaff wrote: > OpenFlow 1.3.4 is going to revert the tag order change made by OpenFlow > 1.3. > > MPLS BoS matching is implemented. > > Signed-off-by: Ben Pfaff > --- > v1->v2: Also remove MPLS BoS matching since that's been implemented. >

Re: [ovs-dev] [PATCH] OPENFLOW-1.1+: Update status of a few items.

2014-02-19 Thread Joe Stringer
Acked-by: Joe Stringer On 19 February 2014 08:29, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > OPENFLOW-1.1+ | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/OPENFLOW-1.1+ b/OPENFLOW-1.1+ > index 8c5811b..388f5fd 100644 > --- a/OPENFLOW-1.1+ > +++ b/OPENF

Re: [ovs-dev] [PATCH] OPENFLOW-1.1+: Update status of a few items.

2014-02-19 Thread Ben Pfaff
Thanks, I'll apply this soon. On Wed, Feb 19, 2014 at 10:33:42AM -0800, Joe Stringer wrote: > Acked-by: Joe Stringer > > > On 19 February 2014 08:29, Ben Pfaff wrote: > > > Signed-off-by: Ben Pfaff > > --- > > OPENFLOW-1.1+ | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > >

Re: [ovs-dev] [PATCH v2] OPENFLOW-1.1+: Remove "rework tag order" and MPLS BoS matching from OF1.3.

2014-02-19 Thread Ben Pfaff
Thanks, I'll apply this soon. On Wed, Feb 19, 2014 at 10:33:01AM -0800, Joe Stringer wrote: > Acked-by: Joe Stringer > > > On 19 February 2014 10:30, Ben Pfaff wrote: > > > OpenFlow 1.3.4 is going to revert the tag order change made by OpenFlow > > 1.3. > > > > MPLS BoS matching is implemente

Re: [ovs-dev] [PATCH] configure: Fix bug report email address.

2014-02-19 Thread Joe Stringer
Acked-by: Joe Stringer On 17 January 2014 17:50, Ben Pfaff wrote: > Reported-by: Arun Sharma > Signed-off-by: Ben Pfaff > --- > configure.ac |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure.ac b/configure.ac > index 9b6c69e..2c04729 100644 > --- a/config

[ovs-dev] [PATCH] ofproto: Send port status message for port-mods, right away.

2014-02-19 Thread Ben Pfaff
Until now, when it processes OFPT_PORT_MOD message, Open vSwitch has waited for ports to notify it that their status has changed before it sends a port status update to controllers. Also, Open vSwitch never sent port config updates at all for port modifications other than OFPPC_PORT_DOWN. I guess

Re: [ovs-dev] [PATCH] ipfix: add SCTP, ICMP, and ICMPv6 flow reporting

2014-02-19 Thread Ben Pfaff
On Wed, Feb 12, 2014 at 07:06:12PM -0800, Romain Lenglet wrote: > Signed-off-by: Romain Lenglet Seems fine, can I have a NEWS entry? ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH net-next] openvswitch: Use ether_addr_copy

2014-02-19 Thread Pravin Shelar
Jesse is on vacation. So I applied it to ovs master. Thanks. On Tue, Feb 18, 2014 at 3:15 PM, David Miller wrote: > From: Joe Perches > Date: Tue, 18 Feb 2014 11:15:45 -0800 > >> It's slightly smaller/faster for some architectures. >> >> Signed-off-by: Joe Perches > > I'll let Jesse take this

Re: [ovs-dev] [PATCH] ofp-util: Fix a typo in ofputil_decode_ofp11_port

2014-02-19 Thread Ben Pfaff
On Wed, Feb 19, 2014 at 09:45:46PM +0800, kmindg wrote: > Signed-off-by: kmindg Applied, thanks! ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] Is there a way to get port status directly on kernel module?

2014-02-19 Thread Ben Pfaff
On Wed, Feb 19, 2014 at 11:34:25AM -0300, Rafael Duarte Vencioneck wrote: > Digging a little in ovs kernel module code, I can't find a way to verify if > a given port is up or down before execute an output. Is there a way to do > that? The kernel is pretty far down in the stack for OVS to be makin

Re: [ovs-dev] Is there a way to get port status directly on kernel module?

2014-02-19 Thread Rafael Duarte Vencioneck
I'm thinking about the possibility of fast forwarding without upcalls. If the link is down, maybe the module could know someway for what port to forward. It's really impossible to do that? Rafael Duarte Vencioneck 2014-02-19 16:39 GMT-03:00 Ben Pfaff : > On Wed, Feb 19, 2014 at 11:34:25AM -030

Re: [ovs-dev] Is there a way to get port status directly on kernel module?

2014-02-19 Thread Ben Pfaff
On Wed, Feb 19, 2014 at 05:12:22PM -0300, Rafael Duarte Vencioneck wrote: > I'm thinking about the possibility of fast forwarding without upcalls. If > the link is down, maybe the module could know someway for what port to > forward. > It's really impossible to do that? It might be possible. With

Re: [ovs-dev] [PATCH v2 1/2] ovs-vswitchd: Get rid of call to process_init().

2014-02-19 Thread Ben Pfaff
On Fri, Feb 14, 2014 at 03:15:47PM -0800, Gurucharan Shetty wrote: > It is not needed as we don't use any other process_* calls. > > Signed-off-by: Gurucharan Shetty Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/m

Re: [ovs-dev] [PATCH v2 2/2] process: Make changes for Windows.

2014-02-19 Thread Ben Pfaff
On Fri, Feb 14, 2014 at 03:15:48PM -0800, Gurucharan Shetty wrote: > As of now, we are using the process subsystem in > ovsdb-server to handle the "--run" command line > option. That particular option is not used often > and till deemed necessary, make it unsupported on > Windows platform. > > Sig

Re: [ovs-dev] [PATCH 2/2] tests/run-ryu: Fix setup for Ryu tests

2014-02-19 Thread Ben Pfaff
On Mon, Feb 17, 2014 at 05:14:17PM +0900, YAMAMOTO Takashi wrote: > Tweak our configuration to match with Ryu tests' single-bridge assumption. > > Signed-off-by: YAMAMOTO Takashi Both patches applied, thanks Yamamoto-san. ___ dev mailing list dev@openv

Re: [ovs-dev] [PATCH] ofp-actions: Correct pop MPLS ethtype as consistency test

2014-02-19 Thread Ben Pfaff
On Wed, Feb 19, 2014 at 09:27:16PM +0900, Simon Horman wrote: > Correct pop MPLS ethtype consistency check to verify that > the packet has an MPLS ethtype before the pop action rather than after: > an MPLS ethtype is a pre-condition but not a post-condition of pop MPLS. > > With this change the co

Re: [ovs-dev] [PATCH] ofproto: Remove 'force-miss-model' configuration.

2014-02-19 Thread Ben Pfaff
On Wed, Feb 19, 2014 at 10:26:31AM -0800, Joe Stringer wrote: > This configuration item was introduced to assist testing of upcall > handling behaviour with and without facets. Facets were removed in > commit e79a6c833e0d7237, so this patch removes the configuration item. > > Signed-off-by: Joe St

Re: [ovs-dev] [PATCHv3] upcall: Allow max_idle be configured through ovs-vsctl.

2014-02-19 Thread Ben Pfaff
On Tue, Feb 18, 2014 at 11:01:39AM -0800, Joe Stringer wrote: > Signed-off-by: Joe Stringer This patch adds a new "max_idle" column to the Flow_Table table, and documents it, but doesn't appear to use it anywhere in actual code. ___ dev mailing list dev

Re: [ovs-dev] [PATCH] packet: Make set_ethertype() static

2014-02-19 Thread Ben Pfaff
On Wed, Feb 12, 2014 at 04:31:03PM +0900, Simon Horman wrote: > Make set_ethertype() static as it is not used outside of packet.c > > Signed-off-by: Simon Horman Applied, thanks. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/l

Re: [ovs-dev] [PATCH] configure: Fix bug report email address.

2014-02-19 Thread Ben Pfaff
Applied, thanks! On Wed, Feb 19, 2014 at 10:54:31AM -0800, Joe Stringer wrote: > Acked-by: Joe Stringer > > > On 17 January 2014 17:50, Ben Pfaff wrote: > > > Reported-by: Arun Sharma > > Signed-off-by: Ben Pfaff > > --- > > configure.ac |2 +- > > 1 file changed, 1 insertion(+), 1 del

Re: [ovs-dev] [PATCHv3] upcall: Allow max_idle be configured through ovs-vsctl.

2014-02-19 Thread Joe Stringer
Hmm. The way I follow it is that bridge_reconfigure() will read it from the table, and call ofproto_set_max_idle() to set the ofproto_flow_idle variable. Later, in revalidate_udumps(), we take a local copy of ofproto_flow_idle, and this is used later in the function (by code that already exists).

Re: [ovs-dev] [PATCH] FAQ: Describe how to add new OpenFlow messages.

2014-02-19 Thread Ben Pfaff
On Tue, Jan 21, 2014 at 09:34:45AM -0800, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff Anyone want to review this? ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v2 2/2] process: Make changes for Windows.

2014-02-19 Thread Gurucharan Shetty
On Wed, Feb 19, 2014 at 1:08 PM, Ben Pfaff wrote: > On Fri, Feb 14, 2014 at 03:15:48PM -0800, Gurucharan Shetty wrote: >> As of now, we are using the process subsystem in >> ovsdb-server to handle the "--run" command line >> option. That particular option is not used often >> and till deemed neces

Re: [ovs-dev] [PATCH v2 2/2] packets: Always set ethertype in push_mpls()

2014-02-19 Thread Ben Pfaff
On Wed, Feb 12, 2014 at 10:13:02AM +0900, Simon Horman wrote: > There are two different MPLS ethertypes, 0x8847 and 0x8848 and a push MPLS > action applied to an MPLS packet may cause the ethertype to change from one > to the other. To ensure that this happens update the ethertype in > push_mpls()

Re: [ovs-dev] [PATCH] ipfix: fix upcall cookie size checks to support 8 byte cookies

2014-02-19 Thread Ben Pfaff
On Tue, Feb 11, 2014 at 03:21:08PM -0800, Romain Lenglet wrote: > Commit 96ed775f resizes all userspace metadata to be 8 bytes minimum. > Fix the upcall size checks accordingly. > > Signed-off-by: Romain Lenglet Thanks, applied to master, branch-2.1, branch-2.0, and I'm working on branch-1.11. _

Re: [ovs-dev] [PATCH v2 2/2] process: Make changes for Windows.

2014-02-19 Thread Ben Pfaff
On Wed, Feb 19, 2014 at 02:02:33PM -0800, Gurucharan Shetty wrote: > On Wed, Feb 19, 2014 at 1:08 PM, Ben Pfaff wrote: > > On Fri, Feb 14, 2014 at 03:15:48PM -0800, Gurucharan Shetty wrote: > >> As of now, we are using the process subsystem in > >> ovsdb-server to handle the "--run" command line >

Re: [ovs-dev] [PATCHv3] upcall: Allow max_idle be configured through ovs-vsctl.

2014-02-19 Thread Ben Pfaff
bridge_reconfigure() reads other-config:max-idle from the Open_vSwitch table. That part is fine. I'm complaining about max_idle in the Flow_Table table. Why do both exist? On Wed, Feb 19, 2014 at 02:00:44PM -0800, Joe Stringer wrote: > Hmm. The way I follow it is that bridge_reconfigure() will

[ovs-dev] [PATCH] ipfix: add SCTP, ICMP, and ICMPv6 flow reporting

2014-02-19 Thread Romain Lenglet
Signed-off-by: Romain Lenglet --- NEWS |1 + ofproto/ofproto-dpif-ipfix.c | 120 ++ 2 files changed, 88 insertions(+), 33 deletions(-) diff --git a/NEWS b/NEWS index 34dde6b..7c6ae70 100644 --- a/NEWS +++ b/NEWS @@ -67,6 +67,7

Re: [ovs-dev] [PATCH] ipfix: add SCTP, ICMP, and ICMPv6 flow reporting

2014-02-19 Thread Ben Pfaff
On Wed, Feb 19, 2014 at 02:23:39PM -0800, Romain Lenglet wrote: > Signed-off-by: Romain Lenglet Thanks, applied. I moved the NEWS item from v2.1.0 to post-v2.1.0, because it is too late (we branched for 2.1 a long time ago). ___ dev mailing list dev@op

[ovs-dev] [PATCH] datapath: Fix build failure.

2014-02-19 Thread Pravin
Defines RCU_INIT_POINTER() for compatibility. Signed-off-by: Pravin B Shelar --- datapath/linux/compat/include/linux/rcupdate.h | 12 1 file changed, 12 insertions(+) diff --git a/datapath/linux/compat/include/linux/rcupdate.h b/datapath/linux/compat/include/linux/rcupdate.h ind

Re: [ovs-dev] [PATCHv3] upcall: Allow max_idle be configured through ovs-vsctl.

2014-02-19 Thread Joe Stringer
Ah, I see now. That would be my misunderstanding, from following the "flow-limit" and "flow_limit" configuration options and equating them with each other. I plan to send a fresh version. On 19 February 2014 14:20, Ben Pfaff wrote: > bridge_reconfigure() reads other-config:max-idle from the Ope

Re: [ovs-dev] [rwlock 2/5] netdev: Change netdev_class_rwlock to recursive mutex, for POSIX safety.

2014-02-19 Thread Joe Stringer
Acked-by: Joe Stringer On 16 January 2014 10:07, Ben Pfaff wrote: > With glibc, rwlocks by default allow recursive read-locking even if a > thread is blocked waiting for the write-lock. POSIX allows such attempts > to deadlock, and it appears that the libc used in NetBSD, at least, does > dea

Re: [ovs-dev] [PATCH] datapath: Fix build failure.

2014-02-19 Thread Jarno Rajahalme
Thanks Pravin, Acked-by: Jarno Rajahalme On Feb 19, 2014, at 2:29 PM, Pravin wrote: > Defines RCU_INIT_POINTER() for compatibility. > > Signed-off-by: Pravin B Shelar > --- > datapath/linux/compat/include/linux/rcupdate.h | 12 > 1 file changed, 12 insertions(+) > > diff --git

Re: [ovs-dev] [PATCH] datapath: Fix build failure.

2014-02-19 Thread Pravin Shelar
Thanks. Pushed to master. On Wed, Feb 19, 2014 at 2:44 PM, Jarno Rajahalme wrote: > Thanks Pravin, > > Acked-by: Jarno Rajahalme > > On Feb 19, 2014, at 2:29 PM, Pravin wrote: > >> Defines RCU_INIT_POINTER() for compatibility. >> >> Signed-off-by: Pravin B Shelar >> --- >> datapath/linux/compa

Re: [ovs-dev] [PATCHv3] upcall: Allow max_idle be configured through ovs-vsctl.

2014-02-19 Thread Ben Pfaff
Thanks. On Wed, Feb 19, 2014 at 02:34:40PM -0800, Joe Stringer wrote: > Ah, I see now. That would be my misunderstanding, from following the > "flow-limit" and "flow_limit" configuration options and equating them with > each other. I plan to send a fresh version. > > > On 19 February 2014 14:20,

Re: [ovs-dev] [PATCH] FAQ: Mention hairpinning under actions=in_port.

2014-02-19 Thread Ben Pfaff
On Wed, Feb 12, 2014 at 11:20:29AM -0800, Joe Stringer wrote: > Signed-off-by: Joe Stringer > --- > I've heard term in the context of using a switch to "bless" traffic. > Adding this wording makes it easier to search for the relevant FAQ > entry. Applied, thanks. _

Re: [ovs-dev] [PATCH] ofproto-provider: Update documentation.

2014-02-19 Thread Ben Pfaff
On Tue, Feb 18, 2014 at 09:39:12AM -0800, Joe Stringer wrote: > This wording was in ofproto.c, but missing from ofproto-provider.h. > > Signed-off-by: Joe Stringer Applied, thanks. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman

Re: [ovs-dev] [rwlock 3/5] ofproto-dpif-xlate: Avoid recursively taking read side of ofgroup rwlock.

2014-02-19 Thread Joe Stringer
This looks good to me, although aren't we meant to report something at the OpenFlow layer? Is this equivalent to the OpenFlow "chaining" description? So if we don't support chaining groups together, we should return an error message with reason OFPGMFC_CHAINING_UNSUPPORTED, rather than accepting t

Re: [ovs-dev] [PATCH] ovs-vsctl: reconnect to the database if connection was dropped

2014-02-19 Thread Ansis Atteka
Thanks for review. I pushed this to branches where issue was observed - master and 2.1. On Wed, Feb 19, 2014 at 10:22 AM, Ben Pfaff wrote: > On Tue, Feb 18, 2014 at 02:34:58PM -0800, Ansis Atteka wrote: >> If ovs-vsctl has to wait for ovs-vswitchd to reconfigure itself >> according to the new dat

Re: [ovs-dev] [rwlock 2/5] netdev: Change netdev_class_rwlock to recursive mutex, for POSIX safety.

2014-02-19 Thread Ben Pfaff
Applied, thanks. On Wed, Feb 19, 2014 at 02:39:06PM -0800, Joe Stringer wrote: > Acked-by: Joe Stringer > > > On 16 January 2014 10:07, Ben Pfaff wrote: > > > With glibc, rwlocks by default allow recursive read-locking even if a > > thread is blocked waiting for the write-lock. POSIX allows

Re: [ovs-dev] [rwlock 4/5] ovs-thread: Get rid of obsolete sparse wrappers.

2014-02-19 Thread Joe Stringer
Acked-by: Joe Stringer On 16 January 2014 10:07, Ben Pfaff wrote: > These were useful back when we were trying to use the sparse lock balance > annotations, but we removed those in commit 47b52c71232c0 (sparse: Remove > support for thread-safety annotations.) and so they serve no purpose any >

Re: [ovs-dev] [rwlock 5/5] ovs-thread: Use fair (but nonrecursive) rwlocks on glibc.

2014-02-19 Thread Joe Stringer
On 16 January 2014 10:07, Ben Pfaff wrote: > > + * An ovs_rwlock does not support recursive readers, because POSIX allows > + * taking the reader lock recursively to deadlock when a thread is > waiting on > + * the write-lock. (NetBSD does deadlock.) glibc does not deadlock in > this > + * situa

[ovs-dev] [PATCHv4] upcall: Configure datapath max-idle through ovs-vsctl.

2014-02-19 Thread Joe Stringer
This patch adds a new configuration option, "max-idle" to the Open_vSwitch "other-config" column. This sets how long datapath flows are cached in the datapath before revalidators expire them. Signed-off-by: Joe Stringer --- v4: Remove extra "max_idle" from Flow_Table table. v3: Use 'unsigned' in

[ovs-dev] [PATCH 03/14] socket-util: Maximum file descriptors for windows.

2014-02-19 Thread Gurucharan Shetty
Windows does not have a getrlimit() function. As such, there is no limit to number of file descriptors that can be opened. So, set an aritificial limit of 1024. This may be increased in the future if the limit is too low. Co-authored-by: Linda Sun Signed-off-by: Linda Sun Signed-off-by: Guruchar

[ovs-dev] [PATCH 01/14] socket-util: Move sock_errno() to socket-util.

2014-02-19 Thread Gurucharan Shetty
And add more users. Signed-off-by: Gurucharan Shetty --- lib/socket-util.c | 49 +++-- lib/socket-util.h | 12 lib/stream-ssl.c | 12 3 files changed, 39 insertions(+), 34 deletions(-) diff --git a/lib/socket-util.c b/

[ovs-dev] [PATCH 02/14] socket-util: set_nonblocking for Windows.

2014-02-19 Thread Gurucharan Shetty
Co-authored-by: Linda Sun Signed-off-by: Linda Sun Signed-off-by: Gurucharan Shetty --- lib/socket-util.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/lib/socket-util.c b/lib/socket-util.c index 0195093..bfa2ce8 100644 --- a/lib/socket-util.c +++ b/lib/socket-util.c @@ -73,

[ovs-dev] [PATCH 10/14] socket-util: Windows does not have /dev/null.

2014-02-19 Thread Gurucharan Shetty
Signed-off-by: Gurucharan Shetty --- lib/socket-util.c |2 ++ lib/socket-util.h |2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/socket-util.c b/lib/socket-util.c index 9095418..d3b580d 100644 --- a/lib/socket-util.c +++ b/lib/socket-util.c @@ -1022,6 +1022,7 @@ er

[ovs-dev] [PATCH 07/14] socket-util: drain_rcvbuf() for Windows.

2014-02-19 Thread Gurucharan Shetty
drain_rcvbuf() is currenlty called from netlink-socket.c and netdev-linux.c. As of now, I don't see it being used for Windows. Signed-off-by: Gurucharan Shetty --- lib/socket-util.c |2 ++ lib/socket-util.h |2 ++ 2 files changed, 4 insertions(+) diff --git a/lib/socket-util.c b/lib/soc

[ovs-dev] [PATCH 11/14] socket-util: fsync directory for Windows.

2014-02-19 Thread Gurucharan Shetty
There is no corresponding function for Windows. open() does not work on directories. There is a function _commit(fd), but that is only meant for files. Signed-off-by: Gurucharan Shetty --- lib/socket-util.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/socket-util.c b/lib/socket-u

[ovs-dev] [PATCH 13/14] socket-util: Describe fd for Windows.

2014-02-19 Thread Gurucharan Shetty
In windows there is no clear way to distinguish between a socket fd and a file fd. We use the function, describe_fd() mostly for debugging. For now, return a generic statement. Co-authored-by: Linda Sun Signed-off-by: Linda Sun Signed-off-by: Gurucharan Shetty --- lib/socket-util.c |4 +++

[ovs-dev] [PATCH 08/14] socket-util: Unix socket related calls for non-windows platform.

2014-02-19 Thread Gurucharan Shetty
Don't try to compile Unix socket related functions for Windows. Signed-off-by: Gurucharan Shetty --- lib/automake.mk |4 ++-- lib/socket-util.c |4 lib/socket-util.h |4 ++-- lib/stream.c |4 4 files changed, 12 insertions(+), 4 deletions(-) diff --git a/lib/aut

[ovs-dev] [PATCH 09/14] socket-util: closesocket() for Windows.

2014-02-19 Thread Gurucharan Shetty
For Windows sockets, one has to call closesocket() to close the sockets. Signed-off-by: Gurucharan Shetty --- lib/socket-util.c |4 ++-- lib/socket-util.h |4 lib/stream-ssl.c |2 -- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/lib/socket-util.c b/lib/socket-u

[ovs-dev] [PATCH 05/14] socket-util: getaddrinfo return values for Windows.

2014-02-19 Thread Gurucharan Shetty
Couple of return values need changes. * EAI_NODATA is the same as EAI_NONAME. So we prevent duplicate cases. * Windows does not have a EAI_SYSTEM. Signed-off-by: Gurucharan Shetty --- lib/socket-util.c |4 1 file changed, 4 insertions(+) diff --git a/lib/socket-util.c b/lib/socket-util

[ovs-dev] [PATCH 04/14] socket-util: inet_aton for Windows.

2014-02-19 Thread Gurucharan Shetty
Windows does not have a inet_aton(). But does have a inet_pton(). Signed-off-by: Gurucharan Shetty --- lib/socket-util.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/lib/socket-util.c b/lib/socket-util.c index cde4d71..b3b1ae5 100644 --- a/lib/socket-util.c +++ b/lib/soc

[ovs-dev] [PATCH 14/14] socket-util: af_inet_ioctl() for Windows.

2014-02-19 Thread Gurucharan Shetty
There is no direct mapping for the ioctl function in Windows. As of now, af_inet_ioctl() is being used for Linux and BSD. So, don't try to compile it for Windows. Signed-off-by: Gurucharan Shetty --- lib/socket-util.c |2 ++ lib/socket-util.h |2 ++ 2 files changed, 4 insertions(+) dif

[ovs-dev] [PATCH 12/14] socket-util: getsockopt for Windows.

2014-02-19 Thread Gurucharan Shetty
Windows defines the 'optval' argument as char * instead of void *. Signed-off-by: Gurucharan Shetty --- lib/socket-util.h |8 1 file changed, 8 insertions(+) diff --git a/lib/socket-util.h b/lib/socket-util.h index 5c32033..2257759 100644 --- a/lib/socket-util.h +++ b/lib/socket-ut

[ovs-dev] [PATCH 06/14] socket-util: poll() for Windows.

2014-02-19 Thread Gurucharan Shetty
Windows send() does not have a MSG_DONTWAIT. So, use the get_socket_error() function. Co-authored-by: Linda Sun Signed-off-by: Linda Sun Signed-off-by: Gurucharan Shetty --- lib/socket-util.c | 34 +- 1 file changed, 33 insertions(+), 1 deletion(-) diff --git

Re: [ovs-dev] [PATCH v2 00/13] datapath: Reduce lock contention.

2014-02-19 Thread Pravin Shelar
Hi Jarno, Can you send updated patches for current master? Thanks, Pravin. On Tue, Feb 11, 2014 at 4:07 PM, Jarno Rajahalme wrote: > This series reduces kernel datapath lock contention. I have included > the NUMA stats patches, as the rest do not apply cleanly without them. > I have added netpe

Re: [ovs-dev] [PATCH v2 00/13] datapath: Reduce lock contention.

2014-02-19 Thread Jarno Rajahalme
I’m working on it… Jarno On Feb 19, 2014, at 4:47 PM, Pravin Shelar wrote: > Hi Jarno, > Can you send updated patches for current master? > > Thanks, > Pravin. > > On Tue, Feb 11, 2014 at 4:07 PM, Jarno Rajahalme > wrote: >> This series reduces kernel datapath lock contention. I have inc

[ovs-dev] [PATCH] ofp-util: Avoid gcc warning on NetBSD

2014-02-19 Thread YAMAMOTO Takashi
Avoid the following warning caused by the combination of NetBSD's htons implementation and gcc bug. Now --enable-Werror build succeeds on NetBSD-6. lib/ofp-util.c: In function 'ofputil_match_from_ofp10_match': lib/ofp-util.c:174:15: error: integer overflow in expression Signed-off-by: YAM

[ovs-dev] [PATCH v8] ofproto: Honour Table Mod settings for table-miss handling

2014-02-19 Thread Simon Horman
This reworks lookup of rules for both table 0 and table action translation. The result is that Table Mod settings, which can alter the miss-behaviour of tables, including table 0, on a per-table basis may be honoured. Previous patches proposed by myself which build on earlier merged patches by And

[ovs-dev] [PATCH v8] ofproto: Honour Table Mod settings for table-miss handling

2014-02-19 Thread Simon Horman
This reworks lookup of rules for both table 0 and table action translation. The result is that Table Mod settings, which can alter the miss-behaviour of tables, including table 0, on a per-table basis may be honoured. Previous patches proposed by myself which build on earlier merged patches by And

Re: [ovs-dev] [PATCH v8] ofproto: Honour Table Mod settings for table-miss handling

2014-02-19 Thread Simon Horman
Apologies for sending this twice, both posts contain the same patch, so please ignore one of them. On Thu, Feb 20, 2014 at 11:17:41AM +0900, Simon Horman wrote: > This reworks lookup of rules for both table 0 and table action translation. > The result is that Table Mod settings, which can alter th

Re: [ovs-dev] [PATCH V3] ofproto-dpif-upcall: Remove the dispatcher thread.

2014-02-19 Thread YAMAMOTO Takashi
> This commit removes the 'dispatcher' thread by allowing 'handler' > threads to read upcalls directly from dpif. vport in dpif will > open netlink sockets for each handler and will use the 5-tuple > hash from the missed packet to choose which socket (handler) to > send the upcall. > > This patch

Re: [ovs-dev] [PATCH V3] ofproto-dpif-upcall: Remove the dispatcher thread.

2014-02-19 Thread Alex Wang
Thanks a lot for pointing it out, Yamamoto, I failed to cover this. will work on solving it. Alex Wang, On Wed, Feb 19, 2014 at 6:36 PM, YAMAMOTO Takashi wrote: > > This commit removes the 'dispatcher' thread by allowing 'handler' > > threads to read upcalls directly from dpif. vport in dpif

Re: [ovs-dev] [PATCH] ofproto: Send port status message for port-mods, right away.

2014-02-19 Thread Kmindg G
On Thu, Feb 20, 2014 at 3:20 AM, Ben Pfaff wrote: > Until now, when it processes OFPT_PORT_MOD message, Open vSwitch has waited > for ports to notify it that their status has changed before it sends a > port status update to controllers. > > Also, Open vSwitch never sent port config updates at all

[ovs-dev] [PATCH] tests/run-ryu: Correct logfile reporting

2014-02-19 Thread Simon Horman
$logfile is already prefixed by "$sandbox/" and suffixed by ".log" so do not duplicate this prefix and suffix combination when appending $logfile to $logs. Cc: YAMAMOTO Takashi Signed-off-by: Simon Horman --- tests/run-ryu | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test