[ovs-dev] Question about miniflow_hash in lib/flow.c

2014-02-08 Thread Kmindg G
Hi all, I have a little question about miniflow_hash(). At the end of miniflow_hash, "p - flow->values" is used as the second paramter of mhash_finish. But "p - flow->valuse" is not the number of bytes which has been added to hash in miniflow_hash. The second parameter should be "sizeof hash_map +

[ovs-dev] make check failing on 2.x

2014-02-08 Thread Andrey Korolyov
Hello, 'ofproto - flow monitoring pause and resume' test failing continuously during make check on all 2.x major branches. The problem is in 'ovs-ofctl add-flows br0 flows.txt' execution which actually hangs a test switch because set count is insanely high and test execution actually hitting the t

Re: [ovs-dev] [PATCH] tests: Don't rely on strace for IPv6 IDL testcases.

2014-02-08 Thread Ben Pfaff
On Fri, Feb 07, 2014 at 03:38:07PM -0800, Joe Stringer wrote: > This would cause testsuite failures if someone runs the testsuite > without strace installed. > > Signed-off-by: Joe Stringer Oops, I was using that for local debugging and did not mean for it to be checked in. Applied, thanks! ___

[ovs-dev] Question about VLOG

2014-02-08 Thread Junguk Cho
I add code in lib and ofproto direcotry. I wonder how to use VLOG? I include "vlog.h" and decalare VLOG_DEFINE_THIS_MODULE(FILENAME); Do I need more? Thanks ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] Question about miniflow_hash in lib/flow.c

2014-02-08 Thread Jarno Rajahalme
> On Feb 8, 2014, at 12:49 AM, Kmindg G wrote: > > Hi all, > I have a little question about miniflow_hash(). > At the end of miniflow_hash, "p - flow->values" is used as the second > paramter of mhash_finish. But "p - flow->valuse" is not the number of > bytes which has been added to hash in min

Re: [ovs-dev] [PATCH v5 2/2] datapath: Per NUMA node flow stats.

2014-02-08 Thread Jesse Gross
On Thu, Feb 6, 2014 at 3:13 PM, Jarno Rajahalme wrote: > diff --git a/datapath/flow.c b/datapath/flow.c > index abe6789..e86034e 100644 > --- a/datapath/flow.c > +++ b/datapath/flow.c > @@ -80,96 +76,126 @@ void ovs_flow_stats_update(struct sw_flow *flow, struct > sk_buff *skb) >

Re: [ovs-dev] [PATCH 1/2] datapath: Do not read tcp flags from a later fragment.

2014-02-08 Thread Jesse Gross
On Thu, Feb 6, 2014 at 3:13 PM, Jarno Rajahalme wrote: > Only the first IP fragment can have a TCP header, check for this. > > Signed-off-by: Jarno Rajahalme Acked-by: Jesse Gross ___ dev mailing list dev@openvswitch.org http://openvswitch.org

Re: [ovs-dev] Question about VLOG

2014-02-08 Thread Ben Pfaff
On Sat, Feb 08, 2014 at 06:32:56PM -0700, Junguk Cho wrote: > I add code in lib and ofproto direcotry. > > I wonder how to use VLOG? > I include "vlog.h" and decalare VLOG_DEFINE_THIS_MODULE(FILENAME); > Do I need more? That's all you need to do. ___ de

Re: [ovs-dev] Question about VLOG

2014-02-08 Thread Junguk Cho
However, I recompiled ovs. I showed this message. "ofproto/libofproto.a(debug.o): In function `show_tnl_port': /home/ubuntu2/ovs/ofproto/debug.c:23: undefined reference to `VLM_debug'" Does anyone know reason? Thanks, 2014-02-08 21:58 GMT-07:00 Ben Pfaff : > On Sat, Feb 08, 2014 at 06:32:56PM