[ovs-dev] [PATCH] coverage: Fix build when linker sections not supported.

2013-12-07 Thread Ben Pfaff
With this change, OVS builds and runs fine without linker section support. CC: Linda Sun CC: Saurabh Shah Signed-off-by: Ben Pfaff --- lib/coverage.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/coverage.c b/lib/coverage.c index aae9937..c7a0028 100644 --- a/lib/c

Re: [ovs-dev] [PATCH] Use WaitForMultipleObjects for polling on windows. This works on all kinds of objects, e.g. sockets, files, especially ioctl calls to the kernel. One additional paramater is pass

2013-12-07 Thread Ben Pfaff
On Fri, Dec 06, 2013 at 04:41:52PM -0800, Linda Sun wrote: > Can you elaborate which cases have duplicate fds? It seems pretty likely for vconn-stream, since waiting to receive data and waiting for space to become available in the send buffer are independent. > I've already used closesocket inste

Re: [ovs-dev] [PATCH] Use WaitForMultipleObjects for polling on windows. This works on all kinds of objects, e.g. sockets, files, especially ioctl calls to the kernel. One additional paramater is pass

2013-12-07 Thread Ben Pfaff
On Fri, Dec 06, 2013 at 05:01:23PM -0800, Ethan Jackson wrote: > I'm not planning to review this patch, but could you please reformat > the commit message in a more standard way? I.E. something like: > > poll-loop: \n > \n > > > The current formatting doesn't play nicely with git send email. R

Re: [ovs-dev] [PATCH] vswitchd: Inherit parents mac address for fake bridges

2013-12-07 Thread Ben Pfaff
On Fri, Dec 06, 2013 at 04:18:42PM +0100, Helmut Schaa wrote: > When adding a physical port to the main bridge the mac address > of the bridge is updated. We can do the same for fake bridges by > copying the mac address of the parent bridge. > > There exists only one fake bridge per vlan, hence it

Re: [ovs-dev] [PATCH] Use WaitForMultipleObjects for polling on windows. This works on all kinds of objects, e.g. sockets, files, especially ioctl calls to the kernel. One additional paramater is pass

2013-12-07 Thread Linda Sun
Since all we do is to be waken up to go back to the main loop I can sort the fds and or the events for the duplicates. Does that sound ok? I used null events for the cases not used by windows. So it's currently not added to the array. I can always create event so no chance to pass a null event

Re: [ovs-dev] [PATCH] Use WaitForMultipleObjects for polling on windows. This works on all kinds of objects, e.g. sockets, files, especially ioctl calls to the kernel. One additional paramater is pass

2013-12-07 Thread Ben Pfaff
On Sat, Dec 07, 2013 at 10:43:44AM -0800, Linda Sun wrote: > Since all we do is to be waken up to go back to the main loop I can > sort the fds and or the events for the duplicates. Does that sound ok? I'd be inclined to use a hash table. > I used null events for the cases not used by windows. So

[ovs-dev] new "sparse" warning

2013-12-07 Thread Ben Pfaff
Building with GCC 4.7 without __corei7: ../lib/util.c:921:15: warning: symbol 'count_1bits_8' was not declared. Should it be static? Here is one possible fix, but perhaps you prefer a different one. diff --git a/lib/util.h b/lib/util.h index 7c5eacb..8d810c2 100644 --- a/lib/util.h +++ b/li

Re: [ovs-dev] [PATCH] Use WaitForMultipleObjects for polling on windows. This works on all kinds of objects, e.g. sockets, files, especially ioctl calls to the kernel. One additional paramater is pass

2013-12-07 Thread Linda Sun
Currently we have very minimal testing. I wanted to send the patch to get feedback and I got it. ;-) I can hold off the push till we are ready for the make check and other unit testing efforts. You have some other suggestions? Thanks, Linda Sent from my iPad > On Dec 6, 2013, at 11:10 PM,

Re: [ovs-dev] [PATCH v5 4/4] Classifier: Track address prefixes.

2013-12-07 Thread Ben Pfaff
On Thu, Dec 05, 2013 at 04:27:26PM -0800, Jarno Rajahalme wrote: > Add a prefix tree (trie) structure for tracking the used address > space, enabling skipping classifier tables containing longer masks > than necessary for an address field value in a packet header being > classified. This enables l