On 21 September 2013 00:28, Jesse Gross wrote:
> On Mon, Sep 16, 2013 at 2:13 AM, Viresh Kumar wrote:
>> Is this piece of code reentrant? I don't think so, otherwise there would
>> have been races to update loop_counters..
> It certainly can be accessed simultaneously on multiple CPUs.
> Obviou
From: Wei Yongjun
Remove duplicated include.
Signed-off-by: Wei Yongjun
---
net/openvswitch/vport-vxlan.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/openvswitch/vport-vxlan.c b/net/openvswitch/vport-vxlan.c
index 36848bd..8515c66 100644
--- a/net/openvswitch/vport-vxlan.c
+++ b/net
From: Wei Yongjun
Remove duplicated include.
Signed-off-by: Wei Yongjun
---
net/openvswitch/vport-gre.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/net/openvswitch/vport-gre.c b/net/openvswitch/vport-gre.c
index 21d5073..c03a964c 100644
--- a/net/openvswitch/vport-gre.c
+++ b/net/open
This commit fixes a memory leak in ofproto-dpif-upcall module.
The memory leak is caused by not freeing the 'struct upcall's.
Signed-off-by: Alex Wang
---
ofproto/ofproto-dpif-upcall.c |6 ++
1 file changed, 6 insertions(+)
diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dp
This support is added through the userspace slow path, because we don't
judge that this is important enough to require permanent support in the
Linux kernel ABI.
CC: Teemu Koponen
CC: Pankaj Thakkar "
Signed-off-by: Ben Pfaff
---
lib/meta-flow.c | 10
lib/odp-execute.c |
time_poll() calls log_poll_interval(), which in some circumstances calls
coverage_log(). Before this commit, time_poll() also called
coverage_clear() after log_poll_interval(). This made sense before commit
857165b5fd26 (coverage: Make thread-safe.), because coverage_log() would
log the most rece
Signed-off-by: Ben Pfaff
---
lib/dpif-netdev.c | 10 +++---
lib/odp-execute.c | 18 --
lib/odp-execute.h |6 --
3 files changed, 19 insertions(+), 15 deletions(-)
diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index 0d489ba..0f6a71c 100644
--- a/lib/dpif-netde
Signed-off-by: Ben Pfaff
---
ofproto/ofproto-dpif.c | 108 ++--
1 file changed, 41 insertions(+), 67 deletions(-)
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
index 93db491..1c82318 100644
--- a/ofproto/ofproto-dpif.c
+++ b/ofproto/ofp
Alex,
The "key" member in struct flow_miss refers to memory held by the "struct
upcall", hence the upcalls should be freed only after the flow misses are
processed by the main thread. How about this instead:
Free upcalls after they are used.
Signed-off-by: Jarno Rajahalme
---
ofproto/ofp
Signed-off-by: Ben Pfaff
---
utilities/ovs-ofctl.c | 32
1 file changed, 32 insertions(+)
diff --git a/utilities/ovs-ofctl.c b/utilities/ovs-ofctl.c
index c2cc1f6..1cd23e6 100644
--- a/utilities/ovs-ofctl.c
+++ b/utilities/ovs-ofctl.c
@@ -50,6 +50,7 @@
#includ
The miss handler threads do not call poll_block(), which calls
coverage_clear() indirectly. This meant that coverage counters incremented
by miss handler threads never got integrated into the global coverage
counters and therefore did not show up in coverage logging or
"ovs-appctl coverage/show" o
Signed-off-by: Ben Pfaff
---
lib/pcap-file.c | 38 +++---
1 file changed, 31 insertions(+), 7 deletions(-)
diff --git a/lib/pcap-file.c b/lib/pcap-file.c
index d181a3e..700cdea 100644
--- a/lib/pcap-file.c
+++ b/lib/pcap-file.c
@@ -1,5 +1,5 @@
/*
- * Copyright
Signed-off-by: Ben Pfaff
---
ofproto/ofproto-dpif.c | 27 ---
1 file changed, 8 insertions(+), 19 deletions(-)
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
index 80874b8..93db491 100644
--- a/ofproto/ofproto-dpif.c
+++ b/ofproto/ofproto-dpif.c
@@ -4950,9
There is no reason to log end of file as an error, but that's what this
code was doing.
Signed-off-by: Ben Pfaff
---
lib/pcap-file.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/lib/pcap-file.c b/lib/pcap-file.c
index d137be8..d181a3e 100644
--- a/lib/pcap-f
The reason for [RFC] this series of patches is that I'm adding an
ofproto-dpif-monitor.at for testing all monitor thread and bfd/cfm
related features. But meanwhile, it would be really helpful if
someone can give this series a review since the implementation
is complete.
Thanks!
Alex Wang (3):
This commit adds a new module ofproto-dpif-monitor in ofproto
directory. This module is in charge of all monitoring logics,
including bfd and cfm. Accordingly, the bfd and cfm references
are removed from ofproto-dpif and ofproto-dpif-xlate modules.
And they will invoke the corresponding functions
This commit makes the ofproto-dpif-monitor module thread-safe.
Also, to guarantee thread-safety, the ofproto_dpif_send_packet()
function is moved to ofproto-dpif-xlate module.
Signed-off-by: Alex Wang
---
ofproto/ofproto-dpif-monitor.c | 106 ++--
ofproto/ofp
This commit moves the ofproto-dpif-monitor module into a
dedicated thread.
Signed-off-by: Alex Wang
---
lib/timeval.c | 56 +
lib/timeval.h |3 +
ofproto/ofproto-dpif-monitor.c | 221 --
ofproto/ofproto-dpif-monitor.h | 11 +-
ofprot
Until now, OVS has expected that the datapath supports all the actions
required by any flow to be installed. There are at least two reasons why
a datapath might not support a given action:
- The datapath version is older than the userspace version, and the
action was introduced after th
It will soon be possible for a single flow to be slow pathed for multiple
reasons. This commit makes it possible to indicate more than one reason
to slow path a flow.
This commit is logically a revert of commit 98f0520fb2 (odp-util: Make
slow_path_reasons mutually exclusive.) but details have cha
Signed-off-by: Ben Pfaff
---
lib/netdev-dummy.c | 45 -
1 file changed, 44 insertions(+), 1 deletion(-)
diff --git a/lib/netdev-dummy.c b/lib/netdev-dummy.c
index 8f3deb2..e40c099 100644
--- a/lib/netdev-dummy.c
+++ b/lib/netdev-dummy.c
@@ -28,11 +28
The new name better reflects what this function does.
Signed-off-by: Ben Pfaff
---
lib/coverage.c|2 +-
lib/coverage.h|2 +-
lib/timeval.c |2 +-
ofproto/ofproto-dpif-upcall.c |2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
Until now, Open vSwitch has support matching on ARP headers, but not
modifying them. This series adds support for modifying them. Jesse
doesn't think that this is worth doing in the kernel, so this series
implements it entirely in userspace.
Ben Pfaff (13):
timeval: Call coverage_clear() befor
Acked-by: Justin Pettit
On Sep 17, 2013, at 4:02 PM, Ben Pfaff wrote:
> Found by valgrind.
>
> Signed-off-by: Ben Pfaff
> ---
> ofproto/ofproto.c |1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c
> index 0ceb85f..bd85104 100644
> --- a/ofproto/
On Sat, Sep 21, 2013 at 10:38 PM, Simon Horman wrote:
> On Thu, Sep 19, 2013 at 12:31:51PM -0500, Jesse Gross wrote:
>> On Wed, Sep 18, 2013 at 5:07 PM, Simon Horman wrote:
>> > On Tue, Sep 17, 2013 at 11:38:18AM -0700, Pravin Shelar wrote:
>> >> On Mon, Sep 9, 2013 at 12:20 AM, Simon Horman wro
www.zettabyte-gadgets.com
Take a quick look at below offers
Logitech BoomBox Portable rechargable bluetooth speaker @ 39% Discount!
Transcend Mp350 with fitness tracker & Shockproof built now @ 16% Discount
King Dazzle portable rechargable finger touch light @ 50% Discount!
i) ASUS O Play Mini F
Thanks for your review, I wasn't aware of that. I'd very much like to
review this patch.
Still i have few questions, could you ping me when you are available?
Thanks,
Alex Wang,
On Mon, Sep 23, 2013 at 10:57 AM, Jarno Rajahalme wrote:
> Alex,
>
> The "key" member in struct flow_miss refers to
On Mon, Sep 23, 2013 at 10:57:22AM -0700, Jarno Rajahalme wrote:
> The "key" member in struct flow_miss refers to memory held by the "struct
> upcall", hence the upcalls should be freed only after the flow misses are
> processed by the main thread. How about this instead:
>
> Free upcalls af
On Mon, Sep 23, 2013 at 3:51 AM, Viresh Kumar wrote:
> On 21 September 2013 00:28, Jesse Gross wrote:
>> OVS is in the upstream kernel as well. This loop checker is just
>> compatibility code since the exact same logic exists in net/core/dev.c
>> on newer kernels. The same transformations should
On Mon, Sep 23, 2013 at 6:55 AM, Wei Yongjun wrote:
> From: Wei Yongjun
>
> Remove duplicated include.
>
> Signed-off-by: Wei Yongjun
Applied.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Mon, Sep 23, 2013 at 6:56 AM, Wei Yongjun wrote:
> From: Wei Yongjun
>
> Remove duplicated include.
>
> Signed-off-by: Wei Yongjun
Also applied.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Sat, Sep 21, 2013 at 10:34 PM, Simon Horman wrote:
> On Thu, Sep 19, 2013 at 12:21:33PM -0500, Jesse Gross wrote:
>> On Thu, Sep 19, 2013 at 10:57 AM, Simon Horman wrote:
>> > On Mon, Sep 16, 2013 at 03:38:21PM -0500, Jesse Gross wrote:
>> >> On Mon, Sep 9, 2013 at 12:20 AM, Simon Horman wrot
On Mon, Sep 23, 2013 at 12:47 PM, Pravin Shelar wrote:
> This patch does not work since vport-netdev does not include compat
> gso header. after including gso.h it gives me compiler error.
> Can you post combined patch with fixes?
I think it's probably because of this:
+#if 1 // LINUX_VERSION_CO
Signed-off-by: Justin Pettit
---
lib/jsonrpc.c |4 ++--
lib/jsonrpc.h | 11 +++
ovsdb/SPECS |4 +++-
vswitchd/bridge.c |2 +-
4 files changed, 13 insertions(+), 8 deletions(-)
diff --git a/lib/jsonrpc.c b/lib/jsonrpc.c
index b43b044..cef96a9 100644
--- a/lib/j
Signed-off-by: Justin Pettit
---
include/openflow/openflow-common.h |3 ++-
lib/stream-ssl.c |6 +++---
lib/vconn-stream.c |4 ++--
lib/vconn.c|8
ofproto/connmgr.c |2 +-
third-party/ofp-tcpdu
The OVS code has always made a distinction between the unencrypted (TCP)
and SSL port numbers for the OpenFlow and OVSDB protocols. The default
port numbers for both protocols has changed, and there continues to be
no distinction between the unencrypted and SSL versions. This
commit removes the d
Both OpenFlow and OVSDB have new IANA-assigned port numbers. We still
default to the original values (6633 and 6632, respectively), but this
commit logs a warning. In the future, we will switch to the official
values (6653 and 6640, respectively).
Signed-off-by: Justin Pettit
---
NEWS
The '-m' option is documented in the manpage.
Signed-off-by: Gurucharan Shetty
---
utilities/ovs-dpctl.c |5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/utilities/ovs-dpctl.c b/utilities/ovs-dpctl.c
index 0516d1b..dad4eed 100644
--- a/utilities/ovs-dpctl.c
+++ b/utilit
Inside dpctl_del_flow() argv[0] is 'del-flow' and argv[1] can
be the flow in the absence of the optional datapath argument.
Signed-off-by: Gurucharan Shetty
---
utilities/ovs-dpctl.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/utilities/ovs-dpctl.c b/utilities/ovs-dpct
Signed-off-by: Gurucharan Shetty
---
utilities/ovs-dpctl.c |1 +
1 file changed, 1 insertion(+)
diff --git a/utilities/ovs-dpctl.c b/utilities/ovs-dpctl.c
index dad4eed..6e214ab 100644
--- a/utilities/ovs-dpctl.c
+++ b/utilities/ovs-dpctl.c
@@ -1047,6 +1047,7 @@ dpctl_normalize_actions(int a
Signed-off-by: Gurucharan Shetty
---
lib/odp-util.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/odp-util.c b/lib/odp-util.c
index 5ca8baf..aec4196 100644
--- a/lib/odp-util.c
+++ b/lib/odp-util.c
@@ -1665,7 +1665,7 @@ parse_odp_key_mask_attr(const char *s, const str
Signed-off-by: Gurucharan Shetty
---
utilities/ovs-dpctl.c |1 +
1 file changed, 1 insertion(+)
diff --git a/utilities/ovs-dpctl.c b/utilities/ovs-dpctl.c
index dad4eed..be94f0b 100644
--- a/utilities/ovs-dpctl.c
+++ b/utilities/ovs-dpctl.c
@@ -1060,6 +1060,7 @@ dpctl_normalize_actions(int a
On Mon, Sep 23, 2013 at 02:17:50PM -0700, Jesse Gross wrote:
> On Sat, Sep 21, 2013 at 10:34 PM, Simon Horman wrote:
> > On Thu, Sep 19, 2013 at 12:21:33PM -0500, Jesse Gross wrote:
> >> On Thu, Sep 19, 2013 at 10:57 AM, Simon Horman wrote:
> >> > On Mon, Sep 16, 2013 at 03:38:21PM -0500, Jesse G
On Mon, Sep 23, 2013 at 02:24:31PM -0700, Jesse Gross wrote:
> On Mon, Sep 23, 2013 at 12:47 PM, Pravin Shelar wrote:
> > This patch does not work since vport-netdev does not include compat
> > gso header. after including gso.h it gives me compiler error.
> > Can you post combined patch with fixes
On Mon, Sep 23, 2013 at 6:32 PM, Simon Horman wrote:
> On Mon, Sep 23, 2013 at 02:17:50PM -0700, Jesse Gross wrote:
>> On Sat, Sep 21, 2013 at 10:34 PM, Simon Horman wrote:
>> > On Thu, Sep 19, 2013 at 12:21:33PM -0500, Jesse Gross wrote:
>> >> On Thu, Sep 19, 2013 at 10:57 AM, Simon Horman wrot
> @@ -1788,26 +1815,21 @@ ofproto_delete_flow(struct ofproto *ofproto,
> struct classifier *cls = &ofproto->tables[0].cls;
> struct rule *rule;
>
> +/* First do a cheap check whether the rule we're looking for has already
> + * been deleted. If so, then we're done. */
> ov
On Mon, Sep 23, 2013 at 06:38:23PM -0700, Jesse Gross wrote:
> On Mon, Sep 23, 2013 at 6:32 PM, Simon Horman wrote:
> > On Mon, Sep 23, 2013 at 02:17:50PM -0700, Jesse Gross wrote:
> >> On Sat, Sep 21, 2013 at 10:34 PM, Simon Horman wrote:
> >> > On Thu, Sep 19, 2013 at 12:21:33PM -0500, Jesse Gr
On Tue, Sep 24, 2013 at 11:41:23AM +0900, YAMAMOTO Takashi wrote:
> > @@ -1788,26 +1815,21 @@ ofproto_delete_flow(struct ofproto *ofproto,
> > struct classifier *cls = &ofproto->tables[0].cls;
> > struct rule *rule;
> >
> > +/* First do a cheap check whether the rule we're looking f
Commit 97f63e57a8 (ofproto: Remove soon-to-be-invalid optimizations.)
changed ofproto_delete_flow() to use the general-purpose flow_mod
implementation. However, the general-purpose flow_mod never matches hidden
flows, which are exactly the flows that ofproto_delete_flow()'s callers
want to delete.
On Mon, Sep 23, 2013 at 08:09:24PM -0700, Ben Pfaff wrote:
> On Tue, Sep 24, 2013 at 11:41:23AM +0900, YAMAMOTO Takashi wrote:
> > > @@ -1788,26 +1815,21 @@ ofproto_delete_flow(struct ofproto *ofproto,
> > > struct classifier *cls = &ofproto->tables[0].cls;
> > > struct rule *rule;
> > >
[resend with Luca's email address fixed]
On Mon, Sep 23, 2013 at 08:35:05PM -0700, Ben Pfaff wrote:
> Commit 97f63e57a8 (ofproto: Remove soon-to-be-invalid optimizations.)
> changed ofproto_delete_flow() to use the general-purpose flow_mod
> implementation. However, the general-purpose flow_mod n
On Sep 23, 2013, at 8:39 PM, Ben Pfaff wrote:
> [resend with Luca's email address fixed]
>
> On Mon, Sep 23, 2013 at 08:35:05PM -0700, Ben Pfaff wrote:
>> Commit 97f63e57a8 (ofproto: Remove soon-to-be-invalid optimizations.)
>> changed ofproto_delete_flow() to use the general-purpose flow_mod
>
On Mon, Sep 23, 2013 at 09:17:32PM -0700, Justin Pettit wrote:
>
> On Sep 23, 2013, at 8:39 PM, Ben Pfaff wrote:
>
> > [resend with Luca's email address fixed]
> >
> > On Mon, Sep 23, 2013 at 08:35:05PM -0700, Ben Pfaff wrote:
> >> Commit 97f63e57a8 (ofproto: Remove soon-to-be-invalid optimizat
On 24 September 2013 02:00, Jesse Gross wrote:
> Search net/core/dev.c for RECURSION_LIMIT.
Ahh, thanks for the pointers..
This stuff was added in 2.6.37 And you said this earlier:
"This loop checker is just compatibility code since the exact same
logic exists in net/core/dev.c on newer kernels
54 matches
Mail list logo
