[Reviving and older thread...]
On Jun 21, 2013, at 2:50 AM, Jesse Gross wrote:
On Mon, Jun 17, 2013 at 11:19 AM, Lori Jakab wrote:
On 6/11/13 1:09 AM, Jesse Gross wrote:
On Wed, Jun 5, 2013 at 2:56 PM, Lori Jakab wrote:
At a high level, we would introduce layer 3 (tunnel) vports, and LIS
When there is no incoming data traffic at the interface for a period,
BFD decay allows the bfd session to increase the min_rx. This is
helpful in that some interfaces may be idle for long a time. And cpu
consumption can be reduced by processing fewer bfd control packets.
Signed-off-by: Alex Wang
On Mon, Jul 29, 2013 at 3:48 PM, Pravin B Shelar wrote:
> diff --git a/datapath/vport-lisp.c b/datapath/vport-lisp.c
> index 847cb39..9ffa74f 100644
> --- a/datapath/vport-lisp.c
> +++ b/datapath/vport-lisp.c
> +static void handle_offloads(struct sk_buff *skb)
> {
> - int err;
> + if
Signed-off-by: Gurucharan Shetty
---
ovsdb/ovsdbmonitor/.gitignore |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ovsdb/ovsdbmonitor/.gitignore b/ovsdb/ovsdbmonitor/.gitignore
index d6f433b..e02ced0 100644
--- a/ovsdb/ovsdbmonitor/.gitignore
+++ b/ovsdb/ovsdbmonitor/.gitig
Package: openvswitch
Version: 1.9.2+git20130813
Severity: grave
I'm filing this bug to track the various "make check" failures that
caused the 1.9.2+git20130813 build to fail on most archs. I need to
spend some time tracking down the exact causes, and this bug report
seems to be a reasonable plac
On Sat, Jun 22, 2013 at 5:32 AM, Andy Zhou wrote:
> For architectures can load and store unaligned long efficiently, use 4
> or 8 bytes operations. This improves the efficiency compare to byte wise
> operations.
>
> This patch is uses ideas and code from a patch submitted by Peter Klausler
> title
On Wed, Aug 14, 2013 at 09:13:13AM +, Gurucharan Shetty wrote:
> Signed-off-by: Gurucharan Shetty
> ---
> ovsdb/ovsdbmonitor/.gitignore |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ovsdb/ovsdbmonitor/.gitignore b/ovsdb/ovsdbmonitor/.gitignore
> index d6f433b..e
Using inner-id for tunnel id is not safe in some rare cases.
E.g. packets coming from multiple sources entering same tunnel
can have same id. Therefore on tunnel packet receive we
could have packets from two different stream but with same
source and dst IP with same ip-id which could confuse ip pac
On Wed, Aug 14, 2013 at 11:29 AM, Jesse Gross wrote:
> On Sat, Jun 22, 2013 at 5:32 AM, Andy Zhou wrote:
> > For architectures can load and store unaligned long efficiently, use 4
> > or 8 bytes operations. This improves the efficiency compare to byte wise
> > operations.
> >
> > This patch is u
This commit fixes the bug introduced by commit fab52e16f7d8 (BFD: Add
check_tnl_key feature to BFD code.). The bug caused the opposite of
the intended behaviour.
Unit test is added for the 'check_tnl_key' feature.
Signed-off-by: Alex Wang
---
lib/bfd.c|2 +-
tests/bfd.at | 34
On Wed, Aug 14, 2013 at 11:46 AM, Pravin B Shelar wrote:
> Using inner-id for tunnel id is not safe in some rare cases.
> E.g. packets coming from multiple sources entering same tunnel
> can have same id. Therefore on tunnel packet receive we
> could have packets from two different stream but with
On Wed, Aug 14, 2013 at 01:12:33PM -0700, Alex Wang wrote:
> This commit fixes the bug introduced by commit fab52e16f7d8 (BFD: Add
> check_tnl_key feature to BFD code.). The bug caused the opposite of
> the intended behaviour.
>
> Unit test is added for the 'check_tnl_key' feature.
>
> Signed-off
I don't understand bfd well enough to understand this comment. Do you
mean that this patch fixes such a bug or that it introduces such a
bug?
Thanks,
Ben.
On Tue, Aug 13, 2013 at 04:33:42PM -0700, Alex Wang wrote:
> This can be a bug, when we configure bfd:min_rx and bfd:decay_min_rx
> together
Exactly, sorry, I didn't check the exact command line. Do I need to send
another patch?
On Wed, Aug 14, 2013 at 1:45 PM, Ben Pfaff wrote:
> On Wed, Aug 14, 2013 at 01:12:33PM -0700, Alex Wang wrote:
> > This commit fixes the bug introduced by commit fab52e16f7d8 (BFD: Add
> > check_tnl_key feat
On Wed, Aug 14, 2013 at 11:50 AM, Andy Zhou wrote:
>
>
>
> On Wed, Aug 14, 2013 at 11:29 AM, Jesse Gross wrote:
>>
>> On Sat, Jun 22, 2013 at 5:32 AM, Andy Zhou wrote:
>> > For architectures can load and store unaligned long efficiently, use 4
>> > or 8 bytes operations. This improves the effici
No. I updated the commit message and applied this to master. Thanks.
On Wed, Aug 14, 2013 at 01:49:00PM -0700, Alex Wang wrote:
> Exactly, sorry, I didn't check the exact command line. Do I need to send
> another patch?
>
>
> On Wed, Aug 14, 2013 at 1:45 PM, Ben Pfaff wrote:
>
> > On Wed, Au
Thanks,
On Wed, Aug 14, 2013 at 1:50 PM, Ben Pfaff wrote:
> No. I updated the commit message and applied this to master. Thanks.
>
> On Wed, Aug 14, 2013 at 01:49:00PM -0700, Alex Wang wrote:
> > Exactly, sorry, I didn't check the exact command line. Do I need to send
> > another patch?
> >
>
Sorry forget to reply all,
On Wed, Aug 14, 2013 at 1:57 PM, Alex Wang wrote:
>
>
> On Wed, Aug 14, 2013 at 1:49 PM, Ben Pfaff wrote:
>
>> I don't understand bfd well enough to understand this comment. Do you
>> mean that this patch fixes such a bug or that it introduces such a
>> bug?
>>
>
> I
On Wed, Aug 14, 2013 at 02:03:37PM -0700, Alex Wang wrote:
> On Wed, Aug 14, 2013 at 1:57 PM, Alex Wang wrote:
>
> >
> >
> > On Wed, Aug 14, 2013 at 1:49 PM, Ben Pfaff wrote:
> >
> >> I don't understand bfd well enough to understand this comment. Do you
> >> mean that this patch fixes such a bu
Signed-off-by: Ben Pfaff
---
lib/ovsdb-idl.c |2 --
python/ovs/db/idl.py |1 -
2 files changed, 3 deletions(-)
diff --git a/lib/ovsdb-idl.c b/lib/ovsdb-idl.c
index 116aa86..4631291 100644
--- a/lib/ovsdb-idl.c
+++ b/lib/ovsdb-idl.c
@@ -91,7 +91,6 @@ struct ovsdb_idl_txn {
char
Hey Ethan, after checking the code, I have following thoughts,
>From my understanding, we the upcall dispatcher-handler for each type of
datapath. So, we may require user to specify the type of datapath (or not
when there is only one datapath).
So, it is not appropriate to use a vsctl command. In
You may want to combine the two patches into one.
It is not good to have is_zero mask check scattered over. This will hard to
maintain.
On Tue, Aug 13, 2013 at 2:50 PM, wrote:
> From: gyang
>
> With megaflow support, there is API to convert mask to nlattr key based
> format. This change intro
On Wed, Aug 14, 2013 at 03:27:07PM -0700, Ben Pfaff wrote:
> On Wed, Aug 14, 2013 at 02:03:37PM -0700, Alex Wang wrote:
> > On Wed, Aug 14, 2013 at 1:57 PM, Alex Wang wrote:
> >
> > >
> > >
> > > On Wed, Aug 14, 2013 at 1:49 PM, Ben Pfaff wrote:
> > >
> > >> I don't understand bfd well enough to
On Wed, Aug 14, 2013 at 05:57:41AM +0900, y...@mwd.biglobe.ne.jp wrote:
> From: YAMAMOTO Takashi
>
> Signed-off-by: YAMAMOTO Takashi
Thanks, applied to master.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
I applied this (yesterday).
On Tue, Aug 13, 2013 at 02:04:49PM -0700, Justin Pettit wrote:
> Looks good.
>
> --Justin
>
>
> On Aug 13, 2013, at 12:54 PM, Ben Pfaff wrote:
>
> > dpkg-buildflags has not always supported --export=configure, but commit
> > 6c2d4c8780 (debian: Apply hardening opti
Thanks a lot Ben,
I should be more careful about commenting.
Kind Regards,
Alex Wang,
On Wed, Aug 14, 2013 at 3:39 PM, Ben Pfaff wrote:
> On Wed, Aug 14, 2013 at 03:27:07PM -0700, Ben Pfaff wrote:
> > On Wed, Aug 14, 2013 at 02:03:37PM -0700, Alex Wang wrote:
> > > On Wed, Aug 14, 2013 at 1:5
No problem. Misunderstandings are inevitable.
Thanks,
Ben.
On Wed, Aug 14, 2013 at 03:47:44PM -0700, Alex Wang wrote:
> Thanks a lot Ben,
>
> I should be more careful about commenting.
>
> Kind Regards,
> Alex Wang,
>
>
> On Wed, Aug 14, 2013 at 3:39 PM, Ben Pfaff wrote:
>
> > On Wed, Aug
git silently included an extra hunk in vport_cmd_set() during
automatic merging. This code is unreachable so it does not actually
introduce a problem but it is clearly incorrect.
Signed-off-by: Jesse Gross
---
net/openvswitch/datapath.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/net/o
From: Pravin B Shelar
Flex array is used to allocate hash buckets which is type struct
hlist_head, but we use `struct hlist_head *` to calculate
array size. Since hlist_head is of size pointer it works fine.
Following patch use correct type.
Signed-off-by: Pravin B Shelar
Signed-off-by: Jesse
Three bug fixes that are fairly small either way but resolve obviously
incorrect code. For net/3.11.
The following changes since commit ad81f0545ef01ea651886dddac4bef6cec930092:
Linux 3.11-rc1 (2013-07-14 15:18:27 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/l
It doesn't make sense to output a tunnel packet using the same
parameters that it was received with since that will generally
just result in the packet going back to us. As a result, userspace
assumes that the tunnel key is cleared when transitioning through
the switch. In the majority of cases thi
This commit changes the "ovs-appclt coverage/show" command to show the
per-second, per-minute and per-hour rates of function invocation. More
importantly, this makes using coverage counter an easy way to monitor
the execution of specific functions.
Signed-off-by: Alex Wang
---
v2 -> v3:
- rebas
User is allowed to create tunnel without any keys. In this
case userspace set tunnel action does not set tun-key flag
which was confusing gre64 vport header calculations. Following
patch fixes it by always assuming TUNNEL_KEY parameter as we
do it with tun-seq.
Signed-off-by: Pravin B Shelar
Bu
On Wed, Aug 14, 2013 at 5:31 PM, Pravin B Shelar wrote:
> User is allowed to create tunnel without any keys. In this
> case userspace set tunnel action does not set tun-key flag
> which was confusing gre64 vport header calculations. Following
> patch fixes it by always assuming TUNNEL_KEY parame
On Wed, Aug 14, 2013 at 7:01 AM, Lori Jakab wrote:
> [Reviving and older thread...]
>
>
> On Jun 21, 2013, at 2:50 AM, Jesse Gross wrote:
>
>> On Mon, Jun 17, 2013 at 11:19 AM, Lori Jakab wrote:
>>>
>>> On 6/11/13 1:09 AM, Jesse Gross wrote:
On Wed, Jun 5, 2013 at 2:56 PM, Lori Jak
> - do not allow bfd to call bfd_may_decay when decay_min_rx
> is less than rmt_min_tx.
Why? I don't think we should need this. If the rmt_min_tx is greater
than our min_rx, according to the bfd protocol we'll simply use the
rmt_min_tx as our rx interval (see bfd_rx_interval()). In other
word
> From my understanding, we the upcall dispatcher-handler for each type of
> datapath. So, we may require user to specify the type of datapath (or not
> when there is only one datapath).
In practice users effectively run only one type of datapath. You
aren't going to have production switches whic
This commit adds a new appctl command "dpif/set-n-handler-threads"
in "ofproto-dpif.c". It is used to set the number of upcall handler
threads created by ofproto-dpif-upcall module.
Signed-off-by: Alex Wang
---
ofproto/ofproto-dpif-unixctl.man | 18 ++
ofproto/ofproto-dpif.c
Sorry Ethan, I saw this right after I posted the patch... ;(
On Wed, Aug 14, 2013 at 7:26 PM, Ethan Jackson wrote:
> In practice users effectively run only one type of datapath. You
> aren't going to have production switches which are running both the
> linux kernel and the linux userspace dat
> I agree with your point about persistence. But it seems to me,
> ofproto-dpif-upcall
> is not a generic feature. is it reasonable to define a function in
> ofproto_class?
That's fine with me. Or you could do what we did for the
flow_eviction_threshold and make it a global in ofproto-provider.
Thanks,
I pushed it to master
On Wed, Aug 14, 2013 at 5:39 PM, Jesse Gross wrote:
> On Wed, Aug 14, 2013 at 5:31 PM, Pravin B Shelar
> wrote:
> > User is allowed to create tunnel without any keys. In this
> > case userspace set tunnel action does not set tun-key flag
> > which was confusing g
Thanks.
I pushed it to master.
On Wed, Aug 14, 2013 at 1:34 PM, Jesse Gross wrote:
> On Wed, Aug 14, 2013 at 11:46 AM, Pravin B Shelar
> wrote:
> > Using inner-id for tunnel id is not safe in some rare cases.
> > E.g. packets coming from multiple sources entering same tunnel
> > can have same
Thanks.
I pushed first three patches to master.
On Tue, Aug 13, 2013 at 5:44 PM, Jesse Gross wrote:
> On Mon, Jul 29, 2013 at 3:47 PM, Pravin B Shelar
> wrote:
> > diff --git a/datapath/vport-lisp.c b/datapath/vport-lisp.c
> > index 6027a16..6e37b2f 100644
> > --- a/datapath/vport-lisp.c
> > +
This patch is not applicable.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
44 matches
Mail list logo
