On Wed, Jul 3, 2013 at 7:50 AM, Jesse Gross wrote:
> On Tue, Jun 11, 2013 at 10:35 PM, Joe Stringer wrote:
>> diff --git a/datapath/actions.c b/datapath/actions.c
>> index 0dac658..d4fdd65 100644
>> --- a/datapath/actions.c
>> +++ b/datapath/actions.c
>> +static int set_sctp(struct sk_buff *skb,
On Jul 3, 2013, at 1:58 , ext Andy Zhou wrote:
> diff --git a/datapath/tunnel.c b/datapath/tunnel.c
> index 9102786..18c3622 100644
> --- a/datapath/tunnel.c
> +++ b/datapath/tunnel.c
> @@ -186,7 +186,9 @@ u16 ovs_tnl_get_src_port(struct sk_buff *skb)
> int low;
> int high;
> uns
Le 03/07/2013 01:00, David Miller a écrit :
From: Isaku Yamahata
Date: Tue, 2 Jul 2013 20:30:10 +0900
The dev_forward_skb() assignment of pkt_type should be done
after the call to eth_type_trans().
ip-encapsulated packets can be handled by localhost. But skb->pkt_type
can be PACKET_OTHERHOST
Good point. I agree. This patch is only to fix a bug at hand. My
understanding is that we will change to use skb_get_rxhash() after Pravin's
tunnel patches are upstreamed.
On Wed, Jul 3, 2013 at 4:34 AM, Rajahalme, Jarno (NSN - FI/Espoo) <
jarno.rajaha...@nsn.com> wrote:
>
> On Jul 3, 2013, at
Reported-by: Justin Pettit
Signed-off-by: Andy Zhou
---
datapath/flow.c |7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/datapath/flow.c b/datapath/flow.c
index 2ac36b6..c598641 100644
--- a/datapath/flow.c
+++ b/datapath/flow.c
@@ -1251,15 +1251,14 @@ int ipv4_tun_t
When kernel rejects a netlink message, it usually returns EINVAL
error code to the userspace. The actual reason for rejecting the
netlinke message is not available, making it harder to debug netlink
issues. This patch adds kernel log messages whenever a netlink message
is rejected with reasons. Th
On Wed, Jul 3, 2013 at 1:49 AM, Daniel Borkmann wrote:
> The return value of nla_nest_start() is not checked, and can be NULL,
> which is then being dereferenced in nla_nest_end(). Add a check to
> prevent such situations.
>
> Signed-off-by: Daniel Borkmann
> ---
> On top of "net-next" tree.
>
>
Both patches look good.
acked-by: Andy Zhou
On Tue, Jul 2, 2013 at 6:43 PM, Justin Pettit wrote:
> For non-Ethernet II packets, we don't set an EtherType netlink attribute
> and set the Ethertype mask attribute to 0x. The code was encoding
> whatever mask was passed in, which could lead
Thanks, Andy. I pushed to all affected branches.
--Justin
On Jul 3, 2013, at 9:33 AM, Andy Zhou wrote:
> Both patches look good.
> acked-by: Andy Zhou
>
>
>
> On Tue, Jul 2, 2013 at 6:43 PM, Justin Pettit wrote:
> For non-Ethernet II packets, we don't set an EtherType netlink attribute
On 07/03/2013 06:32 PM, Jesse Gross wrote:
On Wed, Jul 3, 2013 at 1:49 AM, Daniel Borkmann wrote:
The return value of nla_nest_start() is not checked, and can be NULL,
which is then being dereferenced in nla_nest_end(). Add a check to
prevent such situations.
Signed-off-by: Daniel Borkmann
--
Oh - it fails some tests now - such as the LACP ones. Looks like
ovsrec_interface_set_ifindex() is triggering this error in
lib/ovsdb-idl.c:ovsdb_idl_txn_write__()
if (row->table->idl->verify_write_only && !write_only) {
VLOG_ERR("Bug: Attempt to write to a read/write column (%s:%s
On Tue, Jul 2, 2013 at 3:58 PM, Jesse Gross wrote:
> On Tue, Jul 2, 2013 at 3:44 PM, Pravin B Shelar wrote:
>> Flow dump operation is read-only operation. There is no need to
>> take ovs-lock. Following patch use rcu-lock for dumping flows.
>>
>> Signed-off-by: Pravin B Shelar
>
> Acked-by: Je
On Wed, Jul 3, 2013 at 9:11 AM, Andy Zhou wrote:
> Reported-by: Justin Pettit
> Signed-off-by: Andy Zhou
> ---
> datapath/flow.c |7 +++
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/datapath/flow.c b/datapath/flow.c
> index 2ac36b6..c598641 100644
> --- a/datapath/
On Wed, Jul 3, 2013 at 9:18 AM, Andy Zhou wrote:
> When kernel rejects a netlink message, it usually returns EINVAL
> error code to the userspace. The actual reason for rejecting the
> netlinke message is not available, making it harder to debug netlink
> issues. This patch adds kernel log messag
Good point. I will take a look and send out V2.
On Wed, Jul 3, 2013 at 4:23 PM, Jesse Gross wrote:
> On Wed, Jul 3, 2013 at 9:11 AM, Andy Zhou wrote:
> > Reported-by: Justin Pettit
> > Signed-off-by: Andy Zhou
> > ---
> > datapath/flow.c |7 +++
> > 1 file changed, 3 insertions(+),
Looks pretty good overall, one query---are they meant to be complete,
or only the changes?
It seems that the OF1.2 matrix does not have "match on table_id" and
"controller chooses table_id" rows.
On Sat, Jun 29, 2013 at 8:27 AM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
> ---
> DESIGN | 120
Looks good.
On Sat, Jun 29, 2013 at 2:34 AM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
> ---
> I first sent out this patch on May 8.
>
> DESIGN |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/DESIGN b/DESIGN
> index f3e9309..0037eea 100644
> --- a/DESIGN
> +++ b
This looks like it retains the same behaviour as before, so looks good
to me. I assume this is to prepare for the final patch in the series.
On Sat, Jun 29, 2013 at 8:27 AM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
> ---
> lib/learn.c|3 ++-
> lib/ofp-parse.c|2 ++
Looks good.
On Sat, Jun 29, 2013 at 8:27 AM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
> ---
> tests/ofproto.at | 22 --
> 1 files changed, 20 insertions(+), 2 deletions(-)
>
> diff --git a/tests/ofproto.at b/tests/ofproto.at
> index 53d5cad..5fc33d6 100644
> --- a/tests
On Sat, Jun 29, 2013 at 8:27 AM, Ben Pfaff wrote:
> @@ -1514,7 +1593,17 @@ ofputil_decode_flow_mod(struct ofputil_flow_mod *fm,
>
> /* Translate the message. */
> fm->priority = ntohs(ofm->priority);
> -if (ofm->command == OFPFC_ADD) {
> +if (oh->version == OFP11_
No sweat. I've sent a couple of minor bits of feedback on the remaining patches.
On Sat, Jun 29, 2013 at 1:08 PM, Ben Pfaff wrote:
> Thank you for the reviews. I applied patches 1, 2, and 4 to master.
>
> On Sat, Jun 29, 2013 at 11:25:01AM +0900, Joe Stringer wrote:
>> Looks good.
>>
>> On Sat,
21 matches
Mail list logo
