Re: [ovs-dev] [PATCH] datapath: Add basic MPLS support to kernel

2013-06-12 Thread Pravin Shelar
On Tue, Jun 11, 2013 at 2:26 PM, Jesse Gross wrote: > On Mon, Jun 10, 2013 at 1:07 AM, Simon Horman wrote: >> diff --git a/datapath/actions.c b/datapath/actions.c >> index 0dac658..197811a 100644 >> --- a/datapath/actions.c >> +++ b/datapath/actions.c >> +static int push_mpls(struct sk_buff *skb,

Re: [ovs-dev] [PATCH] datapath: Add basic MPLS support to kernel

2013-06-12 Thread Simon Horman
On Wed, Jun 12, 2013 at 06:14:07PM -0700, Pravin Shelar wrote: > On Tue, Jun 11, 2013 at 2:26 PM, Jesse Gross wrote: > > On Mon, Jun 10, 2013 at 1:07 AM, Simon Horman wrote: > >> diff --git a/datapath/actions.c b/datapath/actions.c > >> index 0dac658..197811a 100644 > >> --- a/datapath/actions.c

Re: [ovs-dev] Resubmit after Normal output action

2013-06-12 Thread Baohua Yang
Thanks ben. I re-do the experiments, the order does NOT care. Sorry for my mistake due to the input port match. Thanks! On Tue, Jun 11, 2013 at 12:55 AM, Ben Pfaff wrote: > On Sun, Jun 09, 2013 at 05:20:27PM +0800, Baohua Yang wrote: > > I want one packet do two processes in ovs: > >

Re: [ovs-dev] [megaflow v4 1/2] datapath: Mega flow implementation

2013-06-12 Thread Jesse Gross
On Wed, Jun 12, 2013 at 10:00 AM, Andy Zhou wrote: > Add mega flow support in kernel datapath. > > Pravin has made significant contributions to this patch. Including > the mega flow id look up scheme, API clean ups, and bug fixes. > > Co-authored-by: Pravin B Shelar > Signed-off-by: Pravin B Shel

Re: [ovs-dev] [PATCH net-next 1/4] openvswitch: Unify vport error stats handling.

2013-06-12 Thread Jesse Gross
On Wed, Jun 12, 2013 at 3:56 PM, Pravin B Shelar wrote: > Following patch changes vport->send return type so that vport > layer can do error accounting. > > Signed-off-by: Pravin B Shelar There's already a version of this patch in my tree on kernel.org. __

[ovs-dev] [PATCH] lib/netdev-linux.c: Prevent receiving of sent packets

2013-06-12 Thread Murphy McCauley
Commit 796223f5 (netdev: Add new "struct netdev_rx" for capturing packets from a netdev) refactored send and receive into separate netdevs. As a result, send and receive now use different socket descriptors (except for tap interfaces which are treated specially). An unintended side effect was tha

Re: [ovs-dev] Possible Regression in 'netdev: Add new "struct netdev_rx" for capturing packets from a netdev.'

2013-06-12 Thread Murphy McCauley
On Jun 12, 2013, at 5:34 PM, Simon Horman wrote: > On Wed, Jun 12, 2013 at 08:08:50AM -0700, Ben Pfaff wrote: >> On Wed, Jun 12, 2013 at 07:11:50AM -0700, Murphy McCauley wrote: >>> >>> On Jun 12, 2013, at 6:28 AM, Ed Maste wrote: >>> On 12 June 2013 07:04, Murphy McCauley wrote: > (S

Re: [ovs-dev] [PATCH net-next 2/4] openvswitch: Simplify interface ovs_flow_metadata_from_nlattrs()

2013-06-12 Thread Jesse Gross
On Wed, Jun 12, 2013 at 3:57 PM, Pravin B Shelar wrote: > diff --git a/net/openvswitch/flow.c b/net/openvswitch/flow.c > index b15321a..150f181 100644 > --- a/net/openvswitch/flow.c > +++ b/net/openvswitch/flow.c > @@ -1122,10 +1122,9 @@ int ovs_flow_from_nlattrs(struct sw_flow_key *swkey, > int

Re: [ovs-dev] [PATCH net-next 4/4] openvswitch: make skb->csum consistent with rest of networking stack.

2013-06-12 Thread Jesse Gross
On Wed, Jun 12, 2013 at 3:57 PM, Pravin B Shelar wrote: > diff --git a/net/openvswitch/datapath.c b/net/openvswitch/datapath.c > index 39cd821..e6ffb82 100644 > --- a/net/openvswitch/datapath.c > +++ b/net/openvswitch/datapath.c > @@ -406,6 +406,7 @@ static int queue_userspace_packet(struct net *n

Re: [ovs-dev] [PATCH net-next 3/4] openvswitch: Fix struct comment.

2013-06-12 Thread Jesse Gross
On Wed, Jun 12, 2013 at 3:57 PM, Pravin B Shelar wrote: > Signed-off-by: Pravin B Shelar > --- > include/uapi/linux/openvswitch.h |1 - > 1 files changed, 0 insertions(+), 1 deletions(-) Applied, thanks. ___ dev mailing list dev@openvswitch.org ht

Re: [ovs-dev] [PATCH] datapath: Add basic MPLS support to kernel

2013-06-12 Thread Pravin Shelar
On Wed, Jun 12, 2013 at 6:19 PM, Simon Horman wrote: > On Wed, Jun 12, 2013 at 06:14:07PM -0700, Pravin Shelar wrote: >> On Tue, Jun 11, 2013 at 2:26 PM, Jesse Gross wrote: >> > On Mon, Jun 10, 2013 at 1:07 AM, Simon Horman wrote: >> >> @@ -341,10 +376,14 @@ static int netdev_send(struct vport

Re: [ovs-dev] [PATCH] datapath: Add basic MPLS support to kernel

2013-06-12 Thread Simon Horman
On Wed, Jun 12, 2013 at 11:00:56PM -0700, Pravin Shelar wrote: > On Wed, Jun 12, 2013 at 6:19 PM, Simon Horman wrote: > > On Wed, Jun 12, 2013 at 06:14:07PM -0700, Pravin Shelar wrote: > >> On Tue, Jun 11, 2013 at 2:26 PM, Jesse Gross wrote: > >> > On Mon, Jun 10, 2013 at 1:07 AM, Simon Horman w

<    1   2