On Jun 11, 2013, at 5:02 PM, Ben Pfaff wrote:
> On Tue, Jun 11, 2013 at 03:17:17PM -0700, Justin Pettit wrote:
>> This is a backport of the facet wildcarding code to 1.11. The patch that
>> should be the most closely looked at is "ofproto-dpif: Consolidate facet
>> stat logic.", since I had to m
This patchset applies against David Miller's net-next tree.
This is my first patch, so please let me know if I've done something
wrong or could do something better (e.g. splitting the patch in a
different way).
I think there is a problem with memory accounting in pskb_expand_head.
Some call sites
Some call sites to pskb_expand_head subsequently update the skb truesize
and others don't (even with non-zero arguments). This is likely a memory
audit leak. Fixed this up by moving the memory accounting to the
skbuff.c file and removing it from the calling sites.
Signed-off-by: Dave Wiltshire
--
On Wed, 2013-06-12 at 19:05 +1000, Dave Wiltshire wrote:
> Some call sites to pskb_expand_head subsequently update the skb truesize
> and others don't (even with non-zero arguments). This is likely a memory
> audit leak. Fixed this up by moving the memory accounting to the
> skbuff.c file and remov
Hi,
I am trying to determine how actions are stored and applied in OVS for each
flow. When I use the ovs-ofctl add-flow command (specifying only the source
& destination IP and protocol with actions=output:1), I see that 8
"ofpact" structures are created inside the ofproto_add_flow function.
The
On Jun 10, 2013, at 20:04 , ext Jesse Gross wrote:
>
+static bool __flow_cmp_key_mask(struct sw_flow *flow, u32 hash, u8
*key,
+ int key_start, int key_len,
+ struct sw_flow_mask *mfm)
+{
+ return (flo
(Sorry this isn't an actual reply and is missing context -- I wasn't on the
list when it was originally posted.)
Simon and I have been in touch about this, and I thought I'd share my findings
for what they're worth.
The problem is from the commit Simon mentioned
(796223f5bc3a4896e6398733c79839
In a few different drivers there is a check of (skb_cloned &&
!skb_clone_writable) before then using pskb_expand_head to copy the skb
if that is required. There are already some skb_cow_* functions for
other conditions, so added this one and changed the call sites.
Signed-off-by: Dave Wiltshire
-
There is a helper function skb_cow_head which checks if a skb needs to
be expanded. This was unused in some drivers. Fixing that leads to
cleaner code in the drivers.
Signed-off-by: Dave Wiltshire
---
drivers/net/ethernet/atheros/atl1c/atl1c_main.c |8 ++--
drivers/net/ethernet/atheros
On 12 June 2013 07:04, Murphy McCauley wrote:
> (Sorry this isn't an actual reply and is missing context -- I wasn't on the
> list when it was originally posted.)
>
> Simon and I have been in touch about this, and I thought I'd share my
> findings for what they're worth.
>
> The problem is from
On Jun 12, 2013, at 6:28 AM, Ed Maste wrote:
> On 12 June 2013 07:04, Murphy McCauley wrote:
>> (Sorry this isn't an actual reply and is missing context -- I wasn't on the
>> list when it was originally posted.)
>>
>> Simon and I have been in touch about this, and I thought I'd share my
>> fi
On Wed, Jun 12, 2013 at 07:11:50AM -0700, Murphy McCauley wrote:
>
> On Jun 12, 2013, at 6:28 AM, Ed Maste wrote:
>
> > On 12 June 2013 07:04, Murphy McCauley wrote:
> >> (Sorry this isn't an actual reply and is missing context -- I wasn't on
> >> the list when it was originally posted.)
> >>
On Tue, Jun 11, 2013 at 06:24:54PM -0700, Ethan Jackson wrote:
> Ideally, this patch would move xlate_actions() into it's own module
> with a clearly defined regular interface which is minimally
> dependent on ofproto-dpif. While, I've done this in a prototype,
> moving large amounts of code into
On Wed, Jun 12, 2013 at 03:36:02PM +0500, Sohaib Ayub wrote:
> I am trying to determine how actions are stored and applied in OVS for each
> flow. When I use the ovs-ofctl add-flow command (specifying only the source
> & destination IP and protocol with actions=output:1), I see that 8
> "ofpact" s
On Thu, Jun 06, 2013 at 03:59:59PM -0500, Gurkan, Deniz wrote:
> Our OFConfig code and initial development efforts are posted here:
> https://github.com/UH-SDN/softconf.d This is a collaboration with
> Infoblox.
>
> We included a configuration description under /doc. All YANG modules
> from OFConf
The user space logic ensures no key will overlap (in the kernel), so the
order of masks are not important for correctness.
Ordering masks to improve efficiency is an interesting idea. However, it is
not clear ordering by mask specificity will gain efficiency -- there is no
guarantee that the frequ
On Tue, Jun 11, 2013 at 6:59 PM, Pravin B Shelar wrote:
> As suggested by Jesse in the comment for patch "gre: Restructure
> tunneling", following patch keeps skb->csum correct across ovs.
>
> Signed-off-by: Pravin B Shelar
Acked-by: Jesse Gross
___
d
On Tue, Jun 11, 2013 at 8:49 PM, Andy Zhou wrote:
> Did not realize that the __CHECK_ENDIAN__ flags has to be passed by hand to
> enable those checks. This is what I use to verify the fix. Any better way
> to enable this check?
>
> make C=2 CF="-D__CHECK_ENDIAN__"
That's how run it (actually I
Sure, will send out v4 of the patch soon.
On Wed, Jun 12, 2013 at 9:42 AM, Jesse Gross wrote:
> On Tue, Jun 11, 2013 at 8:49 PM, Andy Zhou wrote:
> > Did not realize that the __CHECK_ENDIAN__ flags has to be passed by hand
> to
> > enable those checks. This is what I use to verify the fix. A
Since we have implemented the prototype on OVS, it had to be layered on OVSDB.
Otherwise, OVS does not have any other way to be configured other than OVSDB
interface when applicable - we would also have to use vsctl commands for some
configuration data.
Other OpenFlow-capable virtual switch im
On Wed, Jun 12, 2013 at 10:00:03AM -0700, Andy Zhou wrote:
> Added --mega option to ovs-dpctl command to allow mega flow to be
> specified and displayed. ovs-dpctl tool is mainly used as debugging
> tool.
>
> This patch also implements the low level user space routines to send
> and receive mega
On Tue, Jun 11, 2013 at 04:45:10PM -0700, Andy Zhou wrote:
> Added --mega option to ovs-dpctl command to allow mega flow to be
> specified and displayed. ovs-dpctl tool is mainly used as debugging
> tool.
>
> This patch also implements the low level user space routines to send
> and receive mega
This commit changes the "ovs-appclt coverage/show" command to show the
per-second, per-minute and per-hour rates of function invocation. More
importantly, this makes using coverage counter an easy way to monitor
the execution of specific functions.
Signed-off-by: Alex Wang
---
Possible Issue:
Th
This commit adds an unit test for the "ovs-appctl coverage/show".
Signed-off-by: Alex Wang
---
tests/ofproto-dpif.at | 26 ++
1 file changed, 26 insertions(+)
diff --git a/tests/ofproto-dpif.at b/tests/ofproto-dpif.at
index 9231221..823b07a 100644
--- a/tests/ofproto-d
The subfacet rates (e.g. add rate, del rate) were computed by exponential
moving averaging function in ofproto-dpif.c. This patch replaces that
logic with coverage counters. And the rates can be checked by running
"ovs-appctl coverage/show" command.
Signed-off-by: Alex Wang
---
ofproto/ofproto-d
On Wed, Jun 12, 2013 at 11:17 AM, Ben Pfaff wrote:
> I don't see anything anywhere that says that a datapath may ignore a
> field's wildcards, instead fixing the field's values. That's
> important but not at all obvious from the interface, so I would think
> that we should document this in the dp
On Wed, Jun 12, 2013 at 11:22:09AM -0700, Jesse Gross wrote:
> On Wed, Jun 12, 2013 at 11:17 AM, Ben Pfaff wrote:
> > I don't see anything anywhere that says that a datapath may ignore a
> > field's wildcards, instead fixing the field's values. That's
> > important but not at all obvious from the
Sorry, something wrong with the header, should be V1.
On Wed, Jun 12, 2013 at 11:38 AM, Alex Wang wrote:
> This commit adds an unit test for the "ovs-appctl coverage/show".
>
> Signed-off-by: Alex Wang
> ---
> tests/ofproto-dpif.at | 26 ++
> 1 file changed, 26 inser
Sorry, something wrong with the header, should be V1.
On Wed, Jun 12, 2013 at 11:38 AM, Alex Wang wrote:
> The subfacet rates (e.g. add rate, del rate) were computed by exponential
> moving averaging function in ofproto-dpif.c. This patch replaces that
> logic with coverage counters. And the ra
On Wed, Jun 12, 2013 at 11:28:22AM -0700, Alex Wang wrote:
> Sorry, something wrong with the header, should be V1.
For a v1 you can just omit a version number.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Thanks Ben, for the tip.
This will not happen again.
On Wed, Jun 12, 2013 at 11:29 AM, Ben Pfaff wrote:
> On Wed, Jun 12, 2013 at 11:28:22AM -0700, Alex Wang wrote:
> > Sorry, something wrong with the header, should be V1.
>
> For a v1 you can just omit a version number.
>
It had no users outside of ofp-errors.c.
Signed-off-by: Ben Pfaff
---
lib/ofp-errors.c |2 +-
lib/ofp-errors.h |1 -
2 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/lib/ofp-errors.c b/lib/ofp-errors.c
index 74a3358..a141f3f 100644
--- a/lib/ofp-errors.c
+++ b/lib/ofp-error
OpenFlow 1.2 standardized experimenter error codes in a way different from
the Nicira extension. This commit implements the OpenFlow 1.2+ version.
This commit also makes it easy to add error codes for new experimenter IDs
by adding new *_VENDOR_ID definitions to openflow-common.h.
Signed-off-by:
This series adds support for OF1.2+ experimenter error codes.
v1->v2: Make it much easier to add new experimenter IDs and updates the
error code used to the one used in the latest version of the EXT-260
proposal, using an ONF experimenter ID.
v2->v3: Rebase against current master, repost to get i
Signed-off-by: Ben Pfaff
---
lib/ofp-errors.h |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/ofp-errors.h b/lib/ofp-errors.h
index 593241d..aa3ba50 100644
--- a/lib/ofp-errors.h
+++ b/lib/ofp-errors.h
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2008, 2009, 2010, 2011,
This is a prototype of OpenFlow enhancement proposal EXT-260 "Add error
code for duplicate instruction." It uses the error code proposed there.
Signed-off-by: Ben Pfaff
---
lib/ofp-actions.c|4 +---
lib/ofp-errors.h |3 +++
tests/ofp-actions.at |4 ++--
3 files changed, 6 in
This feature wasn't used and removing it slightly simplifies the code.
Signed-off-by: Ben Pfaff
---
build-aux/extract-ofp-errors | 10 +++---
1 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/build-aux/extract-ofp-errors b/build-aux/extract-ofp-errors
index 965e322..32d0913 10
On Wed, Jun 12, 2013 at 11:32:00AM -0700, Alex Wang wrote:
> Thanks Ben, for the tip.
>
> This will not happen again.
Don't worry about it, it's not a big deal.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
This function is more convenient than ofputil_format_port() when a "struct
ds" is not already in use. This commit converts one caller for which this
was already true, and the following commit will add another.
Signed-off-by: Ben Pfaff
---
lib/ofp-util.c | 32 ++--
Users are more likely to be able to reasonably interpret OpenFlow port
numbers than datapath port numbers.
This issue has existed since at least 2011 but only recently has it been
possible for OpenFlow and datapath port numbers to differ (except for the
"local" port).
Reported-by: Christopher Pag
v1->v2: Rebase against current master, re-send to get into patchwork.
Ben Pfaff (2):
ofp-util: New function ofputil_port_to_string().
ofproto-dpif: Make "fdb/show" report OpenFlow port numbers.
AUTHORS|1 +
lib/ofp-util.c | 32 ++--
l
Signed-off-by: Ethan Jackson
---
ofproto/ofproto-dpif-xlate.c | 39 +--
ofproto/ofproto-dpif-xlate.h | 46 +++---
ofproto/ofproto-dpif.c | 18 -
3 files changed, 53 insertions(+), 50 deletions(-)
diff
This patch neglected to delete the struct xlate_ctx; prototype from
ofproto-dpif-xlate.h. Assuming there are no comments, I'll delete
that before merging.
Ethan
On Wed, Jun 12, 2013 at 1:02 PM, Ethan Jackson wrote:
> Signed-off-by: Ethan Jackson
> ---
> ofproto/ofproto-dpif-xlate.c | 39 +++
Signed-off-by: Ethan Jackson
---
Thsi version fixes a bug I found in the original.
---
ofproto/ofproto-dpif-xlate.c | 39 --
ofproto/ofproto-dpif-xlate.h | 48 ++
ofproto/ofproto-dpif.c | 25 +++-
Thanks for the contribution! I have some comments.
"git am" reported some trailing whitespace:
Applying: ofctl: Initial attempt for multiple tables in replace-flows
/home/blp/ovs/.git/rebase-apply/patch:50: trailing whitespace.
table_classifiers_find_classifier(struct table_classifie
Looks good to me, tested.
On Wed, Jun 12, 2013 at 11:35 AM, Ben Pfaff wrote:
> This feature wasn't used and removing it slightly simplifies the code.
>
> Signed-off-by: Ben Pfaff
> ---
> build-aux/extract-ofp-errors | 10 +++---
> 1 files changed, 3 insertions(+), 7 deletions(-)
>
> dif
Thanks, applied to master.
On Wed, Jun 12, 2013 at 01:21:30PM -0700, Reid Price wrote:
> Looks good to me, tested.
>
>
> On Wed, Jun 12, 2013 at 11:35 AM, Ben Pfaff wrote:
>
> > This feature wasn't used and removing it slightly simplifies the code.
> >
> > Signed-off-by: Ben Pfaff
> > ---
> >
On Wed, Jun 12, 2013 at 01:12:06PM -0700, Ethan Jackson wrote:
> Signed-off-by: Ethan Jackson
> ---
>
> Thsi version fixes a bug I found in the original.
Looks good.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Jun 5, 2013, at 1:05 PM, Ben Pfaff wrote:
> +enum { OFP_FLOW_REMOVED_REASON_BUFSIZE = INT_STRLEN(int) + 1 };
The use of an enum to define these surprised me. I don't think it's wrong.
Just a convention I don't remember seeing elsewhere.
> static const char *
> -ofp_flow_removed_reason_to
On Fri, May 31, 2013 at 02:35:11PM +0300, Jarno Rajahalme wrote:
> The earlier check on base_flow.mpls_depth seemed wrong, as multiple
> MPLS push actions would have resulted in the flow.mpls_depth being
> set to 1 each time.
>
> Signed-off-by: Jarno Rajahalme
Applied, thanks.
__
'ctx->xin->flow' and 'ctx->xout->wc' are both pretty long. Where it gets
in the way of code readability, this patch replaces them by 'xin' and
'xout' using local variables.
Also, replace an explicit comparison against IP and IPv6 Ethertypes by
a call to is_ip_any().
Co-authored-by: Jarno Rajahal
This patch removes the last reference to dpif_backer from
ofproto-dpif-xlate, and moves it's definition into ofproto-dpif.c
Signed-off-by: Ethan Jackson
---
ofproto/ofproto-dpif-xlate.c |7 +++---
ofproto/ofproto-dpif.c | 54 ++
ofproto/ofproto
With this patch, the mac_learning module takes responsibility for
remembering tags which need revalidation after a
mac_learning_changed() call. This removes one of
ofproto-dpif-xlate's dpif_backer uses.
Signed-off-by: Ethan Jackson
---
lib/mac-learning.c | 15 +--
lib/ma
On Fri, May 31, 2013 at 02:35:12PM +0300, Jarno Rajahalme wrote:
> With the recent change in xlate_ctx some of the code became repetitive
> in accessing the ctx->xin->flow. This replaces the *ctx argument with
> *flow argument for action execution functions that only need to access
> ctx->xin->flo
This marginally simplifies the code, and removes a reference to
dpif_backer from ofproto-dpif-xlate.
Signed-off-by: Ethan Jackson
---
ofproto/ofproto-dpif-xlate.c |7 ---
ofproto/ofproto-dpif.c |8 +++-
2 files changed, 7 insertions(+), 8 deletions(-)
diff --git a/ofproto/
Acked-by: Ethan Jackson
On Wed, Jun 12, 2013 at 2:23 PM, Ben Pfaff wrote:
> 'ctx->xin->flow' and 'ctx->xout->wc' are both pretty long. Where it gets
> in the way of code readability, this patch replaces them by 'xin' and
> 'xout' using local variables.
>
> Also, replace an explicit comparison a
On Fri, May 31, 2013 at 02:35:13PM +0300, Jarno Rajahalme wrote:
> It would be good to be able to harminize the use of "xlate", "execute",
> "compose", etc. "xlate" clearly relates to the use of the various translation
> context structures, but the distinction between "execute" and "compose" is
>
On Fri, May 31, 2013 at 02:35:14PM +0300, Jarno Rajahalme wrote:
> This will make later patches easier to follow.
>
> Signed-off-by: Jarno Rajahalme
I caught many of these in my rewrite of patch 2 as reposted at:
http://openvswitch.org/pipermail/dev/2013-June/028383.html
I see that I mis
Thanks, I'll apply this in a minute.
On Wed, Jun 12, 2013 at 02:34:14PM -0700, Ethan Jackson wrote:
> Acked-by: Ethan Jackson
>
> On Wed, Jun 12, 2013 at 2:23 PM, Ben Pfaff wrote:
> > 'ctx->xin->flow' and 'ctx->xout->wc' are both pretty long. Where it gets
> > in the way of code readability, t
This patch removes the last reference to dpif_backer from
ofproto-dpif-xlate, and moves it's definition into ofproto-dpif.c.
Signed-off-by: Ethan Jackson
---
In this version, I moved revalidate_reason out of ofproto-dpif.h as well.
---
ofproto/ofproto-dpif-xlate.c |7 ++---
ofproto/ofproto
On Wed, Jun 12, 2013 at 02:18:43PM -0700, Justin Pettit wrote:
>
> On Jun 5, 2013, at 1:05 PM, Ben Pfaff wrote:
>
> > +enum { OFP_FLOW_REMOVED_REASON_BUFSIZE = INT_STRLEN(int) + 1 };
>
> The use of an enum to define these surprised me. I don't think it's
> wrong. Just a convention I don't rem
This marginally simplifies the code, and removes a reference to
dpif_backer from ofproto-dpif-xlate.
Signed-off-by: Ethan Jackson
---
ofproto/ofproto-dpif-xlate.c |7 ---
ofproto/ofproto-dpif.c |8 +++-
2 files changed, 7 insertions(+), 8 deletions(-)
diff --git a/ofproto/
Returning a static data buffer makes code more brittle and definitely
not thread-safe, so this commit switches to using a caller-provided
buffer instead.
Signed-off-by: Ben Pfaff
---
lib/ofp-print.c | 47 ---
1 files changed, 32 insertions(+), 15 del
With this patch, the mac_learning module takes responsibility for
remembering tags which need revalidation after a
mac_learning_changed() call. This removes one of
ofproto-dpif-xlate's dpif_backer uses.
Signed-off-by: Ethan Jackson
---
lib/mac-learning.c | 15 +--
lib/ma
This patch removes the last reference to dpif_backer from
ofproto-dpif-xlate, and moves it's definition into ofproto-dpif.c.
Signed-off-by: Ethan Jackson
---
ofproto/ofproto-dpif-xlate.c |7 ++--
ofproto/ofproto-dpif.c | 74 ++
ofproto/ofproto-
On Jun 12, 2013, at 2:44 PM, Ben Pfaff wrote:
> I added:
> /* Returns a string form of 'reason'. The return value is either a statically
> * allocated constant string or the 'bufsize'-byte buffer 'reasonbuf'.
> * 'bufsize' should be at least OFP_FLOW_REMOVED_REASON_BUFSIZE. */
>
> How's that?
Looks good, but I think similar changes should be made to
ofp_port_reason_to_string() and OFP_PORT_REASON_BUFSIZE.
--Justin
On Jun 12, 2013, at 2:45 PM, Ben Pfaff wrote:
> Returning a static data buffer makes code more brittle and definitely
> not thread-safe, so this commit switches to using
On Wed, Jun 12, 2013 at 02:46:57PM -0700, Justin Pettit wrote:
> On Jun 12, 2013, at 2:44 PM, Ben Pfaff wrote:
>
> > I added:
> > /* Returns a string form of 'reason'. The return value is either a
> > statically
> > * allocated constant string or the 'bufsize'-byte buffer 'reasonbuf'.
> > * 'bu
Done, and pushed.
On Wed, Jun 12, 2013 at 02:48:41PM -0700, Justin Pettit wrote:
> Looks good, but I think similar changes should be made to
> ofp_port_reason_to_string() and OFP_PORT_REASON_BUFSIZE.
>
> --Justin
>
>
> On Jun 12, 2013, at 2:45 PM, Ben Pfaff wrote:
>
> > Returning a static dat
On Wed, Jun 12, 2013 at 02:45:47PM -0700, Ethan Jackson wrote:
> With this patch, the mac_learning module takes responsibility for
> remembering tags which need revalidation after a
> mac_learning_changed() call. This removes one of
> ofproto-dpif-xlate's dpif_backer uses.
>
> Signed-off-by: Etha
On Wed, Jun 12, 2013 at 02:45:48PM -0700, Ethan Jackson wrote:
> This marginally simplifies the code, and removes a reference to
> dpif_backer from ofproto-dpif-xlate.
>
> Signed-off-by: Ethan Jackson
Looks good, thanks.
___
dev mailing list
dev@openvs
On Wed, Jun 12, 2013 at 02:45:49PM -0700, Ethan Jackson wrote:
> This patch removes the last reference to dpif_backer from
> ofproto-dpif-xlate, and moves it's definition into ofproto-dpif.c.
"its"
> Signed-off-by: Ethan Jackson
Looks good, thanks.
__
On Fri, May 31, 2013 at 02:35:10PM +0300, Jarno Rajahalme wrote:
> The code in ofproto-dpif.c became harder on the eye after the reorg of
> struct xlate. This series tries cleaning that up a bit, and while at it,
> identifying and reducing unnecessary copying of struct flow. The main
> enabler for
On Wed, Jun 12, 2013 at 02:35:54PM +0900, Joe Stringer wrote:
> This implementation was derived from FreeBSD:
> http://code.google.com/p/freebsd-head/source/browse/sys/libkern/crc32.c
>
> Reviewed-by: Simon Horman
> Signed-off-by: Joe Stringer
Looks good, but is there any reason not to fold pat
On Wed, Jun 12, 2013 at 02:35:55PM +0900, Joe Stringer wrote:
> Reviewed-by: Simon Horman
> Signed-off-by: Joe Stringer
I'm happy with the userspace portions of this. It changes kernel
headers so it needs approval from Jesse.
___
dev mailing list
dev@
On Wed, Jun 12, 2013 at 02:35:57PM +0900, Joe Stringer wrote:
> Reviewed-by: Simon Horman
> Signed-off-by: Joe Stringer
This looks good, once Jesse is happy with patches 2 and 3.
Thanks,
Ben.
___
dev mailing list
dev@openvswitch.org
http://openvswitc
Thanks for the review. Here's an incremental.
---
lib/mac-learning.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/lib/mac-learning.c b/lib/mac-learning.c
index d66f331..f9b3171 100644
--- a/lib/mac-learning.c
+++ b/lib/mac-learning.c
@@ -246,7 +246,10 @@ mac
On Wed, Jun 12, 2013 at 03:27:13PM -0700, Ethan Jackson wrote:
> Thanks for the review. Here's an incremental.
That's what I had in mind, thanks.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Thanks, I'll merge this series shortly.
Ethan
On Wed, Jun 12, 2013 at 3:27 PM, Ben Pfaff wrote:
> On Wed, Jun 12, 2013 at 03:27:13PM -0700, Ethan Jackson wrote:
>> Thanks for the review. Here's an incremental.
>
> That's what I had in mind, thanks.
__
Signed-off-by: Ethan Jackson
---
ofproto/ofproto-dpif-xlate.c |7 +++
ofproto/ofproto-dpif.c | 21 -
ofproto/ofproto-dpif.h | 14 ++
3 files changed, 25 insertions(+), 17 deletions(-)
diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofpr
On Wed, Jun 12, 2013 at 03:33:45PM -0700, Ethan Jackson wrote:
> Signed-off-by: Ethan Jackson
Looks good, thanks.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Following patches are required but not directly related to ovs tunneling.
So I am sending them as separate series. These cleanups are already
there in out of tree ovs module.
Pravin B Shelar (4):
openvswitch: Unify vport error stats handling.
openvswitch: Simplify interface ovs_flow_metadata_f
Following patch changes vport->send return type so that vport
layer can do error accounting.
Signed-off-by: Pravin B Shelar
---
net/openvswitch/vport-netdev.c |1 -
net/openvswitch/vport.c|9 +++--
net/openvswitch/vport.h|3 ++-
3 files changed, 9 insertions(+), 4
This is not functional change, this is just code cleanup.
Signed-off-by: Pravin B Shelar
---
net/openvswitch/datapath.c |5 +
net/openvswitch/flow.c | 23 +++
net/openvswitch/flow.h |4 ++--
3 files changed, 14 insertions(+), 18 deletions(-)
diff --git
Following patch keeps skb->csum correct across ovs.
Signed-off-by: Pravin B Shelar
---
net/openvswitch/actions.c|4
net/openvswitch/datapath.c |1 +
net/openvswitch/flow.c |3 +++
net/openvswitch/vport-internal_dev.c |1 +
net/openvswitch/
Signed-off-by: Pravin B Shelar
---
include/uapi/linux/openvswitch.h |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/include/uapi/linux/openvswitch.h b/include/uapi/linux/openvswitch.h
index 405918d..424672d 100644
--- a/include/uapi/linux/openvswitch.h
+++ b/include/uapi/
On Wed, Jun 12, 2013 at 11:38:41AM -0700, Alex Wang wrote:
> This commit changes the "ovs-appclt coverage/show" command to show the
> per-second, per-minute and per-hour rates of function invocation. More
> importantly, this makes using coverage counter an easy way to monitor
> the execution of spe
On Wed, Jun 12, 2013 at 11:38:42AM -0700, Alex Wang wrote:
> The subfacet rates (e.g. add rate, del rate) were computed by exponential
> moving averaging function in ofproto-dpif.c. This patch replaces that
> logic with coverage counters. And the rates can be checked by running
> "ovs-appctl covera
On Wed, Jun 12, 2013 at 11:38:43AM -0700, Alex Wang wrote:
> This commit adds an unit test for the "ovs-appctl coverage/show".
>
> Signed-off-by: Alex Wang
Seems reasonable, thanks.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailma
On Mon, Jun 10, 2013 at 01:10:28AM -0700, Gurucharan Shetty wrote:
> Till now, rxbuf was only used by the worker. An upcoming
> commit will have another client. So carve out rxbuf from
> the worker files.
>
> Signed-off-by: Gurucharan Shetty
Thanks for doing this. We need a fix.
I don't see a
On Wed, Jun 12, 2013 at 4:38 PM, Ben Pfaff wrote:
> On Mon, Jun 10, 2013 at 01:10:28AM -0700, Gurucharan Shetty wrote:
> > Till now, rxbuf was only used by the worker. An upcoming
> > commit will have another client. So carve out rxbuf from
> > the worker files.
> >
> > Signed-off-by: Gurucharan
On Wed, Jun 12, 2013 at 04:43:18PM -0700, Gurucharan Shetty wrote:
> On Wed, Jun 12, 2013 at 4:38 PM, Ben Pfaff wrote:
>
> > On Mon, Jun 10, 2013 at 01:10:28AM -0700, Gurucharan Shetty wrote:
> > > Till now, rxbuf was only used by the worker. An upcoming
> > > commit will have another client. So
No reason. I wasn't sure whether there were Debian-specific policies on
this or something.
On Thu, Jun 13, 2013 at 7:22 AM, Ben Pfaff wrote:
> On Wed, Jun 12, 2013 at 02:35:54PM +0900, Joe Stringer wrote:
> > This implementation was derived from FreeBSD:
> > http://code.google.com/p/freebsd-hea
Nope.
On Thu, Jun 13, 2013 at 08:58:31AM +0900, Joe Stringer wrote:
> No reason. I wasn't sure whether there were Debian-specific policies on
> this or something.
>
>
> On Thu, Jun 13, 2013 at 7:22 AM, Ben Pfaff wrote:
>
> > On Wed, Jun 12, 2013 at 02:35:54PM +0900, Joe Stringer wrote:
> > > T
---
This is unpolished but it shows the approach I have in mind.
Sending out for comments on the approach.
diff --git a/ovsdb/ovsdb-server.c b/ovsdb/ovsdb-server.c
index 20e1964..d87360a 100644
--- a/ovsdb/ovsdb-server.c
+++ b/ovsdb/ovsdb-server.c
@@ -81,8 +81,14 @@ struct add_remote_aux {
st
On Wed, Jun 12, 2013 at 04:48:28PM -0700, Ben Pfaff wrote:
> On Wed, Jun 12, 2013 at 04:43:18PM -0700, Gurucharan Shetty wrote:
> > On Wed, Jun 12, 2013 at 4:38 PM, Ben Pfaff wrote:
> >
> > > On Mon, Jun 10, 2013 at 01:10:28AM -0700, Gurucharan Shetty wrote:
> > > > Till now, rxbuf was only used
ovs-vsctl hang for bridge related operations usually indicates that
ovs-vswitchd daemon is not running. Can you check it?
Also, ovs-vsctl show cmd works since it only interacts with ovsdb &
ovsdb-server.
Best,
Jing
On Wed, Jun 12, 2013 at 4:26 PM, muddin wrote:
> Hello,
>
>
> We have compi
On Wed, Jun 12, 2013 at 08:08:50AM -0700, Ben Pfaff wrote:
> On Wed, Jun 12, 2013 at 07:11:50AM -0700, Murphy McCauley wrote:
> >
> > On Jun 12, 2013, at 6:28 AM, Ed Maste wrote:
> >
> > > On 12 June 2013 07:04, Murphy McCauley wrote:
> > >> (Sorry this isn't an actual reply and is missing conte
Thanks,
I pushed it to master.
On Wed, Jun 12, 2013 at 9:46 AM, Jesse Gross wrote:
> On Tue, Jun 11, 2013 at 6:59 PM, Pravin B Shelar wrote:
>> As suggested by Jesse in the comment for patch "gre: Restructure
>> tunneling", following patch keeps skb->csum correct across ovs.
>>
>> Signed-off-by
Following patch restructures ovs tunneling and gre vport
implementation to make ovs tunneling more in sync with
upstream kernel tunneling. Doing this tunneling code is
simplified as most of protocol processing on send and
recv is pushed to kernel tunneling. For external ovs
module the code is mov
1 - 100 of 112 matches
Mail list logo
