[ovs-dev] [PATCH v2.29] datapath: Add basic MPLS support to kernel

2013-05-17 Thread Simon Horman
Allow datapath to recognize and extract MPLS labels into flow keys and execute actions which push, pop, and set labels on packets. Based heavily on work by Leo Alterman and Ravi K. Cc: Ravi K Cc: Leo Alterman Reviewed-by: Isaku Yamahata Signed-off-by: Simon Horman --- This is the remaining

Re: [ovs-dev] [PATCH net-next v2] net: Loosen constraints for recalculating checksum in skb_segment()

2013-05-17 Thread Eric Dumazet
On Fri, 2013-05-17 at 15:49 +0900, Simon Horman wrote: > In the case where the ability to offload checksums changes > then it may be necessary for software checksumming of an skb to occur. > > An example of such a case is where a non-GRE packet is received but > is to be encapsulated and transmitt

Re: [ovs-dev] [PATCH net-next v3] MPLS: Add limited GSO support

2013-05-17 Thread Eric Dumazet
On Fri, 2013-05-17 at 15:50 +0900, Simon Horman wrote: > @@ -509,6 +511,8 @@ struct sk_buff { > __u32 reserved_tailroom; > }; > > + __be16 inner_protocol; > + /* 16/48 bit hole */ > sk_buff_data_t inner_transport_header; >

Re: [ovs-dev] [xlate 2/4] ofproto-dpif: Move odp_actions from subfacet to facet.

2013-05-17 Thread Ben Pfaff
On Tue, May 14, 2013 at 07:29:34PM -0700, Ethan Jackson wrote: > Upon close inspection, it appears that it's not possible for > actions to differ between subfacets belonging to a given facet. > Given this fact, it makes sense to move datapath actions from > subfacets to their parent facets. It's b

Re: [ovs-dev] [xlate 3/4] ofproto-dpif: Rename action_xlate_ctx.

2013-05-17 Thread Ben Pfaff
On Tue, May 14, 2013 at 07:29:35PM -0700, Ethan Jackson wrote: > This patch changes the name of action_xlate_ctx to xlate_ctx. Aside > from being a bit snappier, it fits more cleanly with structures > added in future patches. > > Signed-off-by: Ethan Jackson Sure, fine with me. _

Re: [ovs-dev] [xlate 4/4] ofproto-dpif: Revamp xlate_actions() interface.

2013-05-17 Thread Ben Pfaff
On Tue, May 14, 2013 at 07:29:36PM -0700, Ethan Jackson wrote: > This patch implements a new interface to xlate_actions which, aside > from being simpler and more intuitive, achieves several goals. It > pulls all of xlate_actions() results into a single structure which > will be easier to cache an

Re: [ovs-dev] [PATCH v8 1/5] Add execute_actions

2013-05-17 Thread Jesse Gross
On Wed, May 15, 2013 at 1:31 AM, Simon Horman wrote: > This moves generic action execution code out of lib/dpif-netedev.c > and into a new file, lib/execute-actions.c. > > This is in preparation for using execute_set_action() > in lib/odp-util.c to handle recirculation/ > > Signed-off-by: Simon Ho

Re: [ovs-dev] [PATCH net-next v3] MPLS: Add limited GSO support

2013-05-17 Thread Jesse Gross
On Thu, May 16, 2013 at 11:50 PM, Simon Horman wrote: > * Set skb->mac_len and skb->network_header to correspond to the > end of the L3 header, including the MPLS label stack. I believe that the treatment of skb->mac_len is different from what you are proposing in the OVS patch. I think this is

[ovs-dev] [oftest v3 1/5] netdev-dummy: Limit receive queue length to 100 packets.

2013-05-17 Thread Ben Pfaff
It doesn't seem like a good idea to allow the queue length to grow without bound, even for a test-only device. Signed-off-by: Ben Pfaff --- lib/netdev-dummy.c | 15 +-- 1 files changed, 13 insertions(+), 2 deletions(-) diff --git a/lib/netdev-dummy.c b/lib/netdev-dummy.c index 908

[ovs-dev] [oftest v3 3/5] netdev-dummy: Drop "nobody listened" reply from netdev-dummy/receive.

2013-05-17 Thread Ben Pfaff
Ethan pointed out that this wasn't very useful. Signed-off-by: Ben Pfaff --- lib/netdev-dummy.c| 16 +++- tests/ofproto-dpif.at | 24 2 files changed, 11 insertions(+), 29 deletions(-) diff --git a/lib/netdev-dummy.c b/lib/netdev-dummy.c index ce84a0

[ovs-dev] [oftest v3 2/5] netdev-dummy: Factor some netdev_dummy_receive() code out into new function.

2013-05-17 Thread Ben Pfaff
An upcoming patch will add another user. Signed-off-by: Ben Pfaff --- lib/netdev-dummy.c | 32 ++-- 1 files changed, 22 insertions(+), 10 deletions(-) diff --git a/lib/netdev-dummy.c b/lib/netdev-dummy.c index 62d8a1b..ce84a0c 100644 --- a/lib/netdev-dummy.c +++ b/

[ovs-dev] [oftest v3 0/5] add support for OFTest

2013-05-17 Thread Ben Pfaff
This is the latest version of the oftest series. The first version was posted Oct. 25, 2012. The second version was posted Feb. 1, 2013. The only difference between v2 and v3 is considerable work rebasing due to the restructuring of the netdev library interface. Ben Pfaff (5): netdev-dummy: Li

[ovs-dev] [oftest v3 4/5] netdev-dummy: Add "pstream" option for connecting a dummy to a process.

2013-05-17 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- lib/netdev-dummy.c | 244 +--- 1 files changed, 232 insertions(+), 12 deletions(-) diff --git a/lib/netdev-dummy.c b/lib/netdev-dummy.c index 8c182a3..a617218 100644 --- a/lib/netdev-dummy.c +++ b/lib/netdev-dummy.c @@

[ovs-dev] [oftest v3 5/5] tests: Add support for running OFTest.

2013-05-17 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- Makefile.am |1 + NEWS |2 + README-OFTest | 77 +++ tests/automake.mk |6 +++ tests/run-oftest | 94 + 5 files changed, 180 insertions(

[ovs-dev] [PATCH] netdev-dummy: Remove FreeBSD dependency.

2013-05-17 Thread Ben Pfaff
There's no particular reason that netdev_dummy_register() has to care about the particular OS, except that the tests like to use the special Linux-only tunnel vport types. But that can be done better, I think, by just always registering them from netdev_dummy_register() and making that function id

Re: [ovs-dev] [PATCH v2.29] datapath: Add basic MPLS support to kernel

2013-05-17 Thread Jesse Gross
On Fri, May 17, 2013 at 12:06 AM, Simon Horman wrote: > diff --git a/datapath/actions.c b/datapath/actions.c > index 0dac658..ac4423a 100644 > --- a/datapath/actions.c > +++ b/datapath/actions.c > +/* The end of the mac header. > + * > + * For non-MPLS skbs this will correspond to the network head

Re: [ovs-dev] [PATCH] netdev-dummy: Remove FreeBSD dependency.

2013-05-17 Thread Ed Maste
On 17 May 2013 18:57, Ben Pfaff wrote: > There's no particular reason that netdev_dummy_register() has to care about > the particular OS, except that the tests like to use the special Linux-only > tunnel vport types. But that can be done better, I think, by just always > registering them from net