On May 2, 2013, at 21:21 , ext Ben Pfaff wrote:
> There has been a lot of discussion on patch 4. Do you plan to update
> and re-send the series, or do you expect further discussion or review
> of the rest of the series before we go on?
I have the rest of the series done, I was waiting for some
On May 2, 2013, at 21:19 , ext Ben Pfaff wrote:
> On Tue, Apr 30, 2013 at 05:21:28AM +, Rajahalme, Jarno (NSN - FI/Espoo)
> wrote:
>>
>> On Apr 29, 2013, at 20:49 , ext Jesse Gross wrote:
>>
>>> On Sun, Apr 28, 2013 at 11:29 AM, Rajahalme, Jarno (NSN - FI/Espoo)
>>> wrote:
Anot
Adds tun_src and tun_dst match and set capabilities via new NXM fields
NXM_NX_TUN_IPV4_SRC and NXM_NX_TUN_IPV4_DST. This allows management of
large number of tunnels via flow tables, without requiring the tunnels
to be pre-configured.
Flow-based tunnels can be configured with options remote_ip=fl
Do not clear tunnel metadata on tunnel input. This is used by a later patch.
Signed-off-by: Jarno Rajahalme
---
v2:
- Keep ctx->base_flow.tunnel zeroed to reflect datapath view of the flow
ofproto/ofproto-dpif.c | 17 +++--
ofproto/tunnel.c |3 +--
2 files changed, 8 ins
As tunnel metadata is no longer cleared on input, and the input
values are retained in 'ctx->flow' accross tunnel output actions,
there is no need to store the tunnel.ip_tos to initial_vals.
Signed-off-by: Jarno Rajahalme
---
v2: no change
ofproto/ofproto-dpif.c | 15 ++-
1 file c
As the flow is no longer modified (apart from the in_port) on tunnel
input, the perfect fitness can be retained.
Signed-off-by: Jarno Rajahalme
---
v2: no change
ofproto/ofproto-dpif.c |3 ---
1 file changed, 3 deletions(-)
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
index
Adds tun_src and tun_dst match and set capabilities via new NXM fields
NXM_NX_TUN_IPV4_SRC and NXM_NX_TUN_IPV4_DST. This allows management of
large number of tunnels via the flow tables, without requiring the tunnels
to be pre-configured.
Flow-based tunnels can be configured with options remote_i
On May 3, 2013, at 7:52 PM, Jesse Gross wrote:
> The get_config vport op is left over from old compatibility code,
> it is neither used nor implemented any more.
>
> Signed-off-by: Jesse Gross
Looks good Jesse.
___
dev mailing list
dev@openvswitch.or
On Mon, May 6, 2013 at 8:04 AM, Kyle Mestery (kmestery)
wrote:
> On May 3, 2013, at 7:52 PM, Jesse Gross wrote:
>> The get_config vport op is left over from old compatibility code,
>> it is neither used nor implemented any more.
>>
>> Signed-off-by: Jesse Gross
>
>
> Looks good Jesse.
Applied,
From: Alex Wang
Since the use of single datapath, all bridges belonging to the same type of
datapath will use the same (single) datapath. This causes confusion in the
current 'ofproto/trace' command. Especially, when given the unrelated
'bridge' and 'in_port' combination, the current implementati
From: Alex Wang
The following three tests are affected by the re-implemented ofproto/trace
command.
tests/learn.at
tests/ofproto-dpif.at
tests/tunnel.at
This patch fixes these affected tests.
Signed-off-by: Alex Wang
---
tests/learn.at| 16 +--
tests/ofproto-dpif.at | 76
From: Alex Wang
Three testcases are added to the testsuite, which test the three command
formats and the corresponding corner cases.
Signed-off-by: Alex Wang
---
tests/ofproto-dpif.at | 209 +
1 file changed, 209 insertions(+)
diff --git a/test
From: Alex Wang
This patch Modifies the man page for the ofproto/trace command in
accordance with the new implementation.
Signed-off-by: Alex Wang
---
ofproto/ofproto-unixctl.man | 62 ++-
1 file changed, 38 insertions(+), 24 deletions(-)
diff --git a
The recent threading changes have broken the build on Fedora,
and presumably other Red Hat based distributions. This adds an explicit
"-lpthread" to the linker command line and allows the latest master to build
on Fedora. I've also tested this on Ubuntu and it builds fine there.
Signed-off-by: Kyl
On 6 May 2013 13:47, Kyle Mestery wrote:
> The recent threading changes have broken the build on Fedora,
> and presumably other Red Hat based distributions. This adds an explicit
> "-lpthread" to the linker command line and allows the latest master to build
> on Fedora. I've also tested this on Ub
On Fri, May 3, 2013 at 10:46 AM, Jesse Gross wrote:
> On Fri, May 3, 2013 at 10:35 AM, Pravin B Shelar wrote:
>> VPORT_F_TUN_ID is last remaining flag, once we remove it, flags
>> field from vport-ops can be removed. Since it does not complicate
>> much code, we decided to remove this flag.
>>
>
Sorry to not have responded in so long on this. It's become important
again, so I'm going to try to get it merged soon. Seems pretty close.
> No, that's fine, but I found it hard to infer the units other than
> from the type. Could some comments mention that they are msecs?
I added a comment i
Traditionally, Open vSwitch has used a variant of 802.1ag "CFM" for
interface liveness detection. This has served us well until now,
but has several serious drawbacks which have steadily become more
inconvenient. First, the 802.1ag standard does not implement
several useful features forcing us to
When using ovsdb-client with an ovsdb-server with multiple databases, an
assertion could trigger due to them being returned in non-sorted order.
This commit changes the fetch_dbs() function to always return databases
in sorted order, since both callers are expecting that behavior.
Signed-off-by: J
Looks good. Thanks for addressing it cleanly.
On Thu, May 2, 2013 at 4:16 PM, Ben Pfaff wrote:
> strftime() returns 0 and leaves the contents of the output buffer
> unspecified if the output buffer is not big enough. Thus, one should
> check strftime()'s return value. Until now, OVS has had a
Hi Eagle,
I set up a Facebook profile where I can post my pictures, videos and events and
I want to add you as a friend so you can see it. First, you need to join
Facebook! Once you join, you can also create your own profile.
--
hi can we be friends?thanks
--
Thanks,
Eagle
Not only is it easier to re-use the actions we already have, this avoids
potential problems due to the state that add_sflow_action() and
add_ipfix_action() look at having possibly been changed by
do_xlate_actions(). Currently those functions appear to look only at
the flow's 'in_port', which curre
OpenFlow says that an "output" action to a flow's input port is ordinarily
dropped, unless the flow explicitly outputs to OFPP_IN_PORT. We've
occasionally been asked to implement some way to avoid this behavior in
cases where it is not easily known in advance whether a given port is the
input port
The formatting of the "enqueue" action uses a "q" to separate the port
number from the queue number, as in "enqueue:123q456". This is different
from every other action. This commit improves the situation by:
* Switching the formatting to use a colon (e.g. "enqueue:123:456"),
which is a
The "output" and "enqueue" actions did not accept port names. The
ovs-ofctl manpage claimed that "enqueue" did accept them. This fixes
the problem.
As a side effect, this change begins validating numeric port numbers used
in "output" and "enqueue" actions. We are trying to get users to use
keyw
Fixes misspelling of "OpenFlow".
Fixes the indentation of the paragraph beginning "Any \fIreason\fR...".
Changes "target" to "action" in the introduction of actions, which seems
like a better name.
Reorders action descriptions to group all the simple forms of output
together.
Consistently menti
On Mon, May 06, 2013 at 02:37:37PM -0400, Ed Maste wrote:
> On 6 May 2013 13:47, Kyle Mestery wrote:
> > The recent threading changes have broken the build on Fedora,
> > and presumably other Red Hat based distributions. This adds an explicit
> > "-lpthread" to the linker command line and allows t
Looks good to me.
--
Romain Lenglet
- Original Message -
> From: "Ben Pfaff"
> To: dev@openvswitch.org
> Cc: "Ben Pfaff"
> Sent: Monday, May 6, 2013 3:38:58 PM
> Subject: [ovs-dev] [PATCH 1/2] ofproto-dpif: Avoid figuring out sFlow and
> IPFIX actions twice.
>
> Not only is it easi
On Mon, May 06, 2013 at 10:11:14AM -0700, Alex Wang wrote:
> From: Alex Wang
>
> Since the use of single datapath, all bridges belonging to the same type of
> datapath will use the same (single) datapath. This causes confusion in the
> current 'ofproto/trace' command. Especially, when given the
On Mon, May 06, 2013 at 12:50:52PM -0700, Justin Pettit wrote:
> When using ovsdb-client with an ovsdb-server with multiple databases, an
> assertion could trigger due to them being returned in non-sorted order.
> This commit changes the fetch_dbs() function to always return databases
> in sorted o
On Mon, May 06, 2013 at 12:10:29PM -0700, Ethan Jackson wrote:
> Since it's been so long, I'll go ahead and resend the latest version
> of the patch. I think it's pretty much reviewed and ready to go, so
> don't feel obligated to comb over it as nothings changed. Feel free
> to make additional co
From: Alex Wang
Three testcases are added to the testsuite, which test the three command
formats and the corresponding corner cases.
Signed-off-by: Alex Wang
---
tests/ofproto-dpif.at | 209 +
1 file changed, 209 insertions(+)
diff --git a/test
From: Alex Wang
Three testcases are added to the testsuite, which test the three command
formats and the corresponding corner cases.
Signed-off-by: Alex Wang
---
tests/ofproto-dpif.at | 209 +
1 file changed, 209 insertions(+)
diff --git a/test
On May 6, 2013, at 3:43 PM, Ben Pfaff wrote:
> On Mon, May 06, 2013 at 12:50:52PM -0700, Justin Pettit wrote:
>> When using ovsdb-client with an ovsdb-server with multiple databases, an
>> assertion could trigger due to them being returned in non-sorted order.
>> This commit changes the fetch_dbs
Commit 66980be9 (ovsdb-client: Avoid assertion with multiple databases.)
passed in a pointer to an svec pointer, when it should have just been an
svec pointer. This corrects the bug.
Signed-off-by: Justin Pettit
---
ovsdb/ovsdb-client.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-
On Mon, May 06, 2013 at 09:33:26PM -0700, Justin Pettit wrote:
> Commit 66980be9 (ovsdb-client: Avoid assertion with multiple databases.)
> passed in a pointer to an svec pointer, when it should have just been an
> svec pointer. This corrects the bug.
>
> Signed-off-by: Justin Pettit
Thanks, "m
On May 6, 2013, at 9:42 PM, Ben Pfaff wrote:
> On Mon, May 06, 2013 at 09:33:26PM -0700, Justin Pettit wrote:
>> Commit 66980be9 (ovsdb-client: Avoid assertion with multiple databases.)
>> passed in a pointer to an svec pointer, when it should have just been an
>> svec pointer. This corrects the
37 matches
Mail list logo
