Re: [ovs-dev] [PATCH] datapath: Fix compatibility with older kernel (<2.6.26).

2013-03-06 Thread Palo Andi
Hi all, the patches solved the compilation errors. But when I insert the kernel module (insmod openvswitch.ko) the module doesn't load. In dmesg I get: *openvswitch: Unknown symbol ksize* Thanks, Andi On 6 March 2013 01:34, Jesse Gross wrote: > On Tue, Mar 5, 2013 at 3:44 PM, Pravin B Shelar

Re: [ovs-dev] [PATCH] datapath: Fix compatibility with older kernel (<2.6.26).

2013-03-06 Thread Palo Andi
Hi, I solved even this error. That particular version of linux kernel did not export ksize symbol. I re-build the kernel with the patch to mm/slab.c. Practically I added EXPORT_SYMBOL(ksize); after the function definition in mm/slab.c. Andi On 6 March 2013 12:51, Palo Andi wrote: > Hi all, > the

Re: [ovs-dev] [RFC PATCH 1/2] add igmp snooping support

2013-03-06 Thread Cong Wang
On Tue, 2013-03-05 at 09:34 -0800, Ben Pfaff wrote: > On Fri, Mar 01, 2013 at 09:03:44PM +0800, Cong Wang wrote: > > WARNING: This patch *only* compiles! NOT tested yet! > > > > This patch adds the initial IGMP snooping support. > > I sent out this patch early to get some early reviews, > > especi

[ovs-dev] OVS-VSWITCHD crashes when packet received from datapath

2013-03-06 Thread Palo Andi
Hi all, I managed to cross-compile OVS 1.10 and install it on the mipsel router running dd-wrt kernel 2.6.23. After the patches OVS side and kernel side([1] [2]) it runs. But the error from [3] remains. This time it manifest as a Bus error. Gdb connected to gdbserver in target machine segfaults als

Re: [ovs-dev] OpenVSwitch and libvirt integration problem at shutdown/reboot

2013-03-06 Thread Ernesto Domato
Sorry for the late response. On Mon, Mar 4, 2013 at 7:06 PM, Ansis Atteka wrote: > On Mon, Mar 4, 2013 at 12:08 PM, Ernesto Domato wrote: > > If you do not block on interface creation and libvirt/Open vSwitch > init.d dependencies are not right, then I think you might end up with > another race

Re: [ovs-dev] OVS-VSWITCHD crashes when packet received from datapath

2013-03-06 Thread Ben Pfaff
On Wed, Mar 06, 2013 at 04:05:01PM +0100, Palo Andi wrote: > I managed to cross-compile OVS 1.10 and install it on the mipsel router > running dd-wrt kernel 2.6.23. > After the patches OVS side and kernel side([1] [2]) it runs. > But the error from [3] remains. This time it manifest as a Bus error.

Re: [ovs-dev] [PATCH 1/3] Add support for dec_mpls_ttl action

2013-03-06 Thread Jesse Gross
On Tue, Mar 5, 2013 at 11:08 PM, Simon Horman wrote: > [ Cc Pravin B Shelar ] > > On Tue, Mar 05, 2013 at 06:11:27PM -0800, Ben Pfaff wrote: >> On Wed, Mar 06, 2013 at 10:42:02AM +0900, Simon Horman wrote: >> > On Tue, Mar 05, 2013 at 10:14:44AM -0800, Ben Pfaff wrote: >> > > On Thu, Feb 28, 2013

Re: [ovs-dev] [PATCH 1/3] Add support for dec_mpls_ttl action

2013-03-06 Thread Ben Pfaff
On Wed, Mar 06, 2013 at 07:46:16AM -0800, Jesse Gross wrote: > On Tue, Mar 5, 2013 at 11:08 PM, Simon Horman wrote: > > [ Cc Pravin B Shelar ] > > > > On Tue, Mar 05, 2013 at 06:11:27PM -0800, Ben Pfaff wrote: > >> On Wed, Mar 06, 2013 at 10:42:02AM +0900, Simon Horman wrote: > >> > On Tue, Mar 05

Re: [ovs-dev] [PATCH 1/3] Add support for dec_mpls_ttl action

2013-03-06 Thread Jesse Gross
On Wed, Mar 6, 2013 at 8:21 AM, Ben Pfaff wrote: > On Wed, Mar 06, 2013 at 07:46:16AM -0800, Jesse Gross wrote: >> On Tue, Mar 5, 2013 at 11:08 PM, Simon Horman wrote: >> > [ Cc Pravin B Shelar ] >> > >> > On Tue, Mar 05, 2013 at 06:11:27PM -0800, Ben Pfaff wrote: >> >> On Wed, Mar 06, 2013 at 10

Re: [ovs-dev] [PATCH 1/3] Add support for dec_mpls_ttl action

2013-03-06 Thread Ben Pfaff
On Wed, Mar 06, 2013 at 08:29:13AM -0800, Jesse Gross wrote: > On Wed, Mar 6, 2013 at 8:21 AM, Ben Pfaff wrote: > > On Wed, Mar 06, 2013 at 07:46:16AM -0800, Jesse Gross wrote: > >> On Tue, Mar 5, 2013 at 11:08 PM, Simon Horman wrote: > >> > [ Cc Pravin B Shelar ] > >> > > >> > On Tue, Mar 05, 20

Re: [ovs-dev] [PATCH 1/3] Add support for dec_mpls_ttl action

2013-03-06 Thread Ben Pfaff
On Wed, Mar 06, 2013 at 08:40:38AM -0800, Ben Pfaff wrote: > On Wed, Mar 06, 2013 at 08:29:13AM -0800, Jesse Gross wrote: > > On Wed, Mar 6, 2013 at 8:21 AM, Ben Pfaff wrote: > > > On Wed, Mar 06, 2013 at 07:46:16AM -0800, Jesse Gross wrote: > > >> On Tue, Mar 5, 2013 at 11:08 PM, Simon Horman wr

Re: [ovs-dev] [PATCH 2/3] Add support for set_mpls_ttl action

2013-03-06 Thread Ben Pfaff
On Wed, Mar 06, 2013 at 04:08:12PM +0900, Simon Horman wrote: > On Wed, Mar 06, 2013 at 10:43:45AM +0900, Simon Horman wrote: > > On Tue, Mar 05, 2013 at 10:23:10AM -0800, Ben Pfaff wrote: > > > On Thu, Feb 28, 2013 at 06:15:08PM +0900, Simon Horman wrote: > > > > This adds support for the OpenFlow

Re: [ovs-dev] [PATCH 3/3] datapath: Add basic MPLS support to kernel

2013-03-06 Thread Jesse Gross
On Tue, Mar 5, 2013 at 10:03 PM, Simon Horman wrote: > On Tue, Mar 05, 2013 at 11:35:41AM -0800, Jesse Gross wrote: >> On Tue, Mar 5, 2013 at 10:23 AM, Ben Pfaff wrote: >> > On Thu, Feb 28, 2013 at 06:15:09PM +0900, Simon Horman wrote: >> >> Allow datapath to recognize and extract MPLS labels int

[ovs-dev] [PATCH] Add table_id to NXM flow_removed messages.

2013-03-06 Thread Ben Pfaff
Feature #15466. Requested-by: Ronghua Zhang Signed-off-by: Ben Pfaff --- NEWS |2 ++ include/openflow/nicira-ext.h | 10 -- lib/ofp-util.c|3 ++- tests/ofp-print.at|4 ++-- 4 files changed, 14 insertions(+), 5 deletions(-

Re: [ovs-dev] [PATCH 1/3] Add support for dec_mpls_ttl action

2013-03-06 Thread Bruce Davie
The processing for MPLS TTL is somewhat complex compared to IP, because there are a few different options for what is acceptable when pushing and popping labels. However, one thing that DOES carry forward straightforwardly from IP is that if the TTL reaches zero, the packet MUST be discarded. Th

Re: [ovs-dev] [bug15171 1/4] ovsdb-idlc: Make no-op writes to write-only columns cheaper.

2013-03-06 Thread Ben Pfaff
On Tue, Mar 05, 2013 at 10:44:48PM -0800, Ethan Jackson wrote: > > The underscores style is what we've adopted for new code in the python > > directory. I think I would rather go back and change the old code to > > conform, than to write new code to fit in with whatever code it is near. > > Fine w

Re: [ovs-dev] [bug15171 4/4] ofproto: Merge all the CFM query functions into one.

2013-03-06 Thread Ben Pfaff
On Tue, Mar 05, 2013 at 09:40:18PM -0800, Ben Pfaff wrote: > On Tue, Mar 05, 2013 at 05:02:25PM -0800, Ethan Jackson wrote: > > I think cfm_get_status() deserves a comment in ofproto-provider.h and > > ofproto.c, more out of convention than anything else. > > Oops. I overlooked that. I'll take c

Re: [ovs-dev] OVS-VSWITCHD crashes when packet received from datapath

2013-03-06 Thread Palo Andi
Anyway, I have tested OVS version 1.4.0 and 1.4.1 and they work like a charm :) Thanks, Andi On 6 March 2013 16:45, Ben Pfaff wrote: > On Wed, Mar 06, 2013 at 04:05:01PM +0100, Palo Andi wrote: > > I managed to cross-compile OVS 1.10 and install it on the mipsel router > > running dd-wrt kernel

[ovs-dev] [PATCH] nicira-ext: Add Nicira actions NXAST_STACK_PUSH and NXAST_STACK_POP.

2013-03-06 Thread Andy Zhou
The Push action takes a single parameter. Any source allowed by NXAST_REG_MOVE is allowed to be pushed onto the stack. When the source is a bit field, its value will be right shifted to bit zero before being pushed onto the stack. The remaining bits will be set to zero. The Pop action also takes a

Re: [ovs-dev] [PATCH v7] Tunnel: Cleanup old tunnel infrastructure.

2013-03-06 Thread Pravin Shelar
On Mon, Mar 4, 2013 at 1:35 PM, Pravin Shelar wrote: > On Thu, Feb 28, 2013 at 3:58 PM, Jesse Gross wrote: >> On Thu, Feb 28, 2013 at 10:27 AM, Pravin B Shelar wrote: >>> Since userspace flow based tunneling code is checked in, the kernel >>> port based tunneling code can be removed. >>> >>> Pat

Re: [ovs-dev] OpenVSwitch and libvirt integration problem at shutdown/reboot

2013-03-06 Thread Ansis Atteka
On Wed, Mar 6, 2013 at 7:41 AM, Ernesto Domato wrote: > Sorry for the late response. > > On Mon, Mar 4, 2013 at 7:06 PM, Ansis Atteka wrote: >> On Mon, Mar 4, 2013 at 12:08 PM, Ernesto Domato wrote: >> >> If you do not block on interface creation and libvirt/Open vSwitch >> init.d dependencies a

Re: [ovs-dev] [PATCH] nicira-ext: Add Nicira actions NXAST_STACK_PUSH and NXAST_STACK_POP.

2013-03-06 Thread Ben Pfaff
On Tue, Mar 05, 2013 at 04:27:55PM -0800, Andy Zhou wrote: > The Push action takes a single parameter. Any source allowed by NXAST_REG_MOVE > is allowed to be pushed onto the stack. When the source is a bit field, > its value will be right shifted to bit zero before being pushed onto the > stack. T

Re: [ovs-dev] [ECNv2 5/5] tunnel: Mark ECN status on decapsulated tunnel packets.

2013-03-06 Thread Justin Pettit
On Mar 5, 2013, at 3:49 PM, Ben Pfaff wrote: >> Thanks for the reviews! I'll just wait for your feedback on the >> incremental I sent for part 2 before pushing the series. > > Let me know if you need anything else. Thanks again for the reviews. I pushed this to master and branch-1.10. --Jus

[ovs-dev] [PATCH 1/2] bridge: Fix remote_opstate bug recently introduced.

2013-03-06 Thread Ben Pfaff
Commit 9a9e3786b3a8 (ofproto: Merge all the CFM query functions into one.) mistakenly transformed a tristate variable into a Boolean one. This commit fixes the problem. Signed-off-by: Ben Pfaff --- ofproto/ofproto.h |7 ++- vswitchd/bridge.c |9 +++-- 2 files changed, 13 inserti

[ovs-dev] [PATCH 2/2] bridge: Fix interpretation of 'health' member of struct ofproto_cfm_status.

2013-03-06 Thread Ben Pfaff
Commit 9a9e3786b3a8 (ofproto: Merge all the CFM query functions into one.) mistakenly interpreted struct ofproto_cfm_status as always being in the range [0,100]. It can in fact take the value -1 if the health status is not currently well-defined. Signed-off-by: Ben Pfaff --- ofproto/ofproto.h |

[ovs-dev] [PATCH] ofproto-dpif: Treat zero MPLS post-decrement TTL as invalid.

2013-03-06 Thread Ben Pfaff
RFC 3443 says that an outgoing MPLS TTL of zero is invalid, so we must send packets that have such a TTL post-decrement to the controller rather than allowing them to continue through the OpenFlow tables. Here is the text from RFC 3443 that implies this behavior: oTTL: This is the TTL value us

Re: [ovs-dev] [PATCH 1/3] Add support for dec_mpls_ttl action

2013-03-06 Thread Ben Pfaff
On Wed, Mar 06, 2013 at 09:26:19AM -0800, Bruce Davie wrote: > The processing for MPLS TTL is somewhat complex compared to IP, > because there are a few different options for what is acceptable > when pushing and popping labels. However, one thing that DOES carry > forward straightforwardly from IP

Re: [ovs-dev] [PATCH 1/2] bridge: Fix remote_opstate bug recently introduced.

2013-03-06 Thread Ethan Jackson
Acked-by: Ethan Jackson On Wed, Mar 6, 2013 at 2:53 PM, Ben Pfaff wrote: > Commit 9a9e3786b3a8 (ofproto: Merge all the CFM query functions into one.) > mistakenly transformed a tristate variable into a Boolean one. This commit > fixes the problem. > > Signed-off-by: Ben Pfaff > --- > ofpro

Re: [ovs-dev] [PATCH 2/2] bridge: Fix interpretation of 'health' member of struct ofproto_cfm_status.

2013-03-06 Thread Ethan Jackson
Acked-by: Ethan Jackson On Wed, Mar 6, 2013 at 2:53 PM, Ben Pfaff wrote: > Commit 9a9e3786b3a8 (ofproto: Merge all the CFM query functions into one.) > mistakenly interpreted struct ofproto_cfm_status as always being in the > range [0,100]. It can in fact take the value -1 if the health stat

Re: [ovs-dev] [PATCH 2/2] bridge: Fix interpretation of 'health' member of struct ofproto_cfm_status.

2013-03-06 Thread Ben Pfaff
Thanks, I applied these to master. On Wed, Mar 06, 2013 at 04:16:30PM -0800, Ethan Jackson wrote: > Acked-by: Ethan Jackson > > > > On Wed, Mar 6, 2013 at 2:53 PM, Ben Pfaff wrote: > > > Commit 9a9e3786b3a8 (ofproto: Merge all the CFM query functions into one.) > > mistakenly interpreted str

[ovs-dev] [PATCH] ofproto-dpif: Print slow-path actions instead of "drop" in dump-flows.

2013-03-06 Thread Justin Pettit
The command "ovs-appctl dpif/dump-flows" would print slow-path actions as "drop", which could be confusing to users. This is different from "ovs-dpctl dump-flows", which prints a descriptive reason. This commit replaces "drop" with the reason. Bug #14840 Signed-off-by: Justin Pettit --- ofpro

[ovs-dev] [PATCH 1/2] ofproto-dpif: Clarify that 'one_subfacet' may not always be valid.

2013-03-06 Thread Justin Pettit
Signed-off-by: Justin Pettit --- ofproto/ofproto-dpif.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c index 89f5bf4..c95daa2 100644 --- a/ofproto/ofproto-dpif.c +++ b/ofproto/ofproto-dpif.c @@ -487,7 +487,9 @@ struct fa

[ovs-dev] [PATCH 2/2] ofproto-dpif: Add helper function to retrieve a subfacet from a facet.

2013-03-06 Thread Justin Pettit
Signed-off-by: Justin Pettit --- ofproto/ofproto-dpif.c | 17 - 1 files changed, 12 insertions(+), 5 deletions(-) diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c index c95daa2..f230e90 100644 --- a/ofproto/ofproto-dpif.c +++ b/ofproto/ofproto-dpif.c @@ -513,6 +513,