[ovs-dev] [RFC PATCH 1/2] add igmp snooping support

2013-03-01 Thread Cong Wang
WARNING: This patch *only* compiles! NOT tested yet! This patch adds the initial IGMP snooping support. I sent out this patch early to get some early reviews, especially the design of the code. Any comments are welcome! Cc: Ben Pfaff Cc: Jesse Gross Not-Yet-Signed-off-by: Cong Wang --- incl

[ovs-dev] [RFC PATCH 2/2] add igmp6 snooping support

2013-03-01 Thread Cong Wang
WARNING: This patch *only* compiles! NOT tested yet! Based on patch 1/2, this patch adds IPv6 support. Any comments are welcome! Cc: Ben Pfaff Cc: Jesse Gross Not-Yet-Signed-off-by: Cong Wang --- lib/flow.c | 18 +--- lib/flow.h | 12 +++- lib/igmp-sn

[ovs-dev] [PATCH branch-1.7] meta-flow: Fix mf_set_wild() on ip_frag field.

2013-03-01 Thread Ben Pfaff
Fixes behavior of utilities/ovs-ofctl parse-flow 'ip,ip_frag=any,actions=drop' and other cases that invoke this function on the ip_frag field. Reported-by: love you Signed-off-by: Ben Pfaff --- AUTHORS |1 + lib/meta-flow.c |6 +++--- 2 files changed, 4 insertions(+), 3 dele

[ovs-dev] openvswitch: cannot register gre protocol handler

2013-03-01 Thread Palo Andi
Hi everybody, I am having this error message in dmesg when I: insmod openvswitch_mod.ko openvswitch: cannot register gre protocol handler Then when ovs-vswitchd goes in segmentation fault at the first received packet. I am deploying openvswitch in a custom build linux kernel for DD-WRT( http://ww

[ovs-dev] openvswitch: cannot register gre protocol handler

2013-03-01 Thread Palo Andi
Hi everybody, I am having this error message in dmesg when I: insmod openvswitch_mod.ko openvswitch: cannot register gre protocol handler Then when ovs-vswitchd goes in segmentation fault at the first received packet. I am deploying openvswitch in a custom build linux kernel for DD-WRT( http://ww

[ovs-dev] openvswitch: cannot register gre protocol handler

2013-03-01 Thread Raffaele
Hi everybody, I am having this error message in dmesg when I: insmod openvswitch_mod.ko openvswitch: cannot register gre protocol handler Then when ovs-vswitchd goes in segmentation fault at the first received packet. I am deploying openvswitch in a custom build linux kernel for DD-WRT(http://ww

Re: [ovs-dev] [PATCH] ofpbuf: Remove OFPBUF_STACK_BUFFER.

2013-03-01 Thread Andy Zhou
This looks good. On Wed, Feb 27, 2013 at 5:03 PM, Ben Pfaff wrote: > Its alleged convenience just doesn't outweigh the syntactical ugliness, and > so it didn't have any users. > > Signed-off-by: Ben Pfaff > --- > lib/ofpbuf.c |6 +++--- > lib/ofpbuf.h |6 +- > 2 files changed, 4 i

Re: [ovs-dev] openvswitch: cannot register gre protocol handler

2013-03-01 Thread Pravin Shelar
On Fri, Mar 1, 2013 at 10:13 AM, Raffaele wrote: > Hi everybody, > I am having this error message in dmesg when I: insmod openvswitch_mod.ko > openvswitch: cannot register gre protocol handler > You need to unload ip_gre and gre module, openvswitch gre does not work along with kernel gre module fo

Re: [ovs-dev] [PATCH] ovs-ofctl: Better ovs-ofctl add-flows error reporting

2013-03-01 Thread Ben Pfaff
On Thu, Feb 28, 2013 at 07:36:47PM -0800, Andy Zhou wrote: > When error is encountered with add-flows command, this patch > adds file name and line number in addition to the parser > error message to the output. > > The file name and line number will not be added to > the output of "ovs-ofctl add-

[ovs-dev] [PATCH] CodingStyle: Mention our common return value conventions.

2013-03-01 Thread Ben Pfaff
CC: Andy Zhou Signed-off-by: Ben Pfaff --- CodingStyle | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/CodingStyle b/CodingStyle index ee7a0e6..22f0f45 100644 --- a/CodingStyle +++ b/CodingStyle @@ -249,6 +249,18 @@ details. (Some compilers also assume that

Re: [ovs-dev] [PATCH] ofpbuf: Remove OFPBUF_STACK_BUFFER.

2013-03-01 Thread Ethan Jackson
Acked-by: Ethan Jackson On Fri, Mar 1, 2013 at 10:26 AM, Andy Zhou wrote: > This looks good. > > > On Wed, Feb 27, 2013 at 5:03 PM, Ben Pfaff wrote: > >> Its alleged convenience just doesn't outweigh the syntactical ugliness, >> and >> so it didn't have any users. >> >> Signed-off-by: Ben Pf

Re: [ovs-dev] openvswitch: cannot register gre protocol handler

2013-03-01 Thread Ben Pfaff
On Fri, Mar 01, 2013 at 11:00:10AM -0800, Pravin Shelar wrote: > On Fri, Mar 1, 2013 at 10:13 AM, Raffaele wrote: > > Hi everybody, > > I am having this error message in dmesg when I: insmod openvswitch_mod.ko > > openvswitch: cannot register gre protocol handler > > > You need to unload ip_gre an

Re: [ovs-dev] [PATCH] ofpbuf: Remove OFPBUF_STACK_BUFFER.

2013-03-01 Thread Ben Pfaff
Thanks, I applied it to master. On Fri, Mar 01, 2013 at 10:26:56AM -0800, Andy Zhou wrote: > This looks good. > > > On Wed, Feb 27, 2013 at 5:03 PM, Ben Pfaff wrote: > > > Its alleged convenience just doesn't outweigh the syntactical ugliness, and > > so it didn't have any users. > > > > Signe

[ovs-dev] [PATCH] ovsdb: Allow recovery from transient write errors in log implementation.

2013-03-01 Thread Ben Pfaff
Until now, the OVSDB data journaling implementation has made write errors "sticky", so that a single write error persists as long as ovsdb-server is alive. However, some kinds of write errors (such as ENOSPC) can be transient in practice. I don't know of a good reason to make such errors sticky,

Re: [ovs-dev] openvswitch: cannot register gre protocol handler

2013-03-01 Thread Raffaele
Thank for the answers, @Pravin I'don't have that compiled as module so i have to make a new image with gre "stuff" compiled as module and try. The version is 1.6.1. This is a run [1]. @Ben This is the dmesg [0] bu i don't have OOPSes in dmesg. Raffaele [0] http://pastebin.com/uSFszmCs [1] htt

Re: [ovs-dev] openvswitch: cannot register gre protocol handler

2013-03-01 Thread Ben Pfaff
On Fri, Mar 01, 2013 at 08:19:44PM +0100, Raffaele wrote: > @Ben > This is the dmesg [0] bu i don't have OOPSes in dmesg. OK, in that case can you get a backtrace from the segmentation fault? Thanks, Ben. ___ dev mailing list dev@openvswitch.org http:/

Re: [ovs-dev] openvswitch: cannot register gre protocol handler

2013-03-01 Thread Raffaele
Il giorno 01/mar/2013, alle ore 20:23, Ben Pfaff ha scritto: > On Fri, Mar 01, 2013 at 08:19:44PM +0100, Raffaele wrote: >> @Ben >> This is the dmesg [0] bu i don't have OOPSes in dmesg. > > OK, in that case can you get a backtrace from the segmentation fault? > > Thanks, > > Ben. No backtra

Re: [ovs-dev] [PATCH] CodingStyle: Mention our common return value conventions.

2013-03-01 Thread Justin Pettit
Looks good. --Justin On Mar 1, 2013, at 11:02 AM, Ben Pfaff wrote: > CC: Andy Zhou > Signed-off-by: Ben Pfaff > --- > CodingStyle | 12 > 1 files changed, 12 insertions(+), 0 deletions(-) > > diff --git a/CodingStyle b/CodingStyle > index ee7a0e6..22f0f45 100644 > --- a/Coding

Re: [ovs-dev] [PATCH] Add Nicira vendor extension actions NXAST_STACK_PUSH/POP

2013-03-01 Thread Andy Zhou
Thanks for the comments. I will post the reworked patch based on the feedbacks to this thread soon. On Wed, Feb 27, 2013 at 8:44 PM, Ben Pfaff wrote: > On Wed, Feb 27, 2013 at 05:12:16PM -0800, Ethan Jackson wrote: > > +static union mf_value* > > > +nx_stack_pop(struct ofpbuf* stack) > > > +{

Re: [ovs-dev] [PATCH] nicira-ext: Add Nicira actions NXAST_STACK_PUSH and NXAST_STACK_POP.

2013-03-01 Thread Andy Zhou
The Push action takes a single parameter. Any source allowed by NXAST_REG_MOVE is allowed to be pushed onto the stack. When the source is a bit field, its value will be right shifted to bit zero before being pushed onto the stack. The remaining bits will be set to zero. The Pop action also takes