Gesch�ftsvorschlag...

2013-02-13 Thread Nana-Addo Duffour
Guten Tag, Ich kontaktiere Sie, weil ich auf der Suche nach einem Partner bei der Realisierung eines Projekts bin. Zunaechst moechte ich mich vorstellen; ich bin Barr. Nana-Addo Duffour, ich lebe in Accra, Ghana und praktiziere als Rechtsanwalt und ich habe ein ungewoehnliches aber lukratives A

Re: [ovs-dev] [PATCH 04/16] actions: Allow secondary decoding of a flow

2013-02-13 Thread Simon Horman
On Tue, Feb 12, 2013 at 09:42:52AM -0800, Ben Pfaff wrote: > On Wed, Feb 06, 2013 at 10:53:55PM +0900, Simon Horman wrote: > > Actions may provide information to allow further decoding of > > a flow. > > > > For example: > > > > In the case of MPLS, L3 and L4 information may not initially be deco

Re: [ovs-dev] [PATCH 04/16] actions: Allow secondary decoding of a flow

2013-02-13 Thread Ben Pfaff
On Wed, Feb 13, 2013 at 11:47:46PM +0900, Simon Horman wrote: > On Tue, Feb 12, 2013 at 09:42:52AM -0800, Ben Pfaff wrote: > > On Wed, Feb 06, 2013 at 10:53:55PM +0900, Simon Horman wrote: > > > Actions may provide information to allow further decoding of > > > a flow. > > > > > > For example: > >

[ovs-dev] [PATCH] FAQ: Add troubleshooting procedure and example.

2013-02-13 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- FAQ | 86 +++ 1 file changed, 86 insertions(+) diff --git a/FAQ b/FAQ index e253b16..0f1fe78 100644 --- a/FAQ +++ b/FAQ @@ -1008,6 +1008,92 @@ A: Yes, Open vSwitch makes individual bond interfaces vis

Re: [ovs-dev] [ext-272 0/4] Implement EXT-272 (role reply generation_ids)

2013-02-13 Thread Ben Pfaff
On Wed, Feb 13, 2013 at 07:47:38AM +, Rajahalme, Jarno (NSN - FI/Espoo) wrote: > On Feb 12, 2013, at 18:52 , ext Ben Pfaff wrote: > > > On Tue, Feb 12, 2013 at 03:31:16PM +, Rajahalme, Jarno (NSN - FI/Espoo) > > wrote: > >> The patches look good, but as I haven't seen the EXT-272, I don'

Re: [ovs-dev] [PATCH 2/3] tests: Make long name more readable by introducing a shell variable.

2013-02-13 Thread Ben Pfaff
seq isn't in POSIX so I'm not sure we can rely on it. For now, I left it as-is. Thanks for the review. On Tue, Feb 12, 2013 at 05:59:42PM -0800, Ethan Jackson wrote: > You may consider simply generating the name using seq i.e. > > seq -s "" 200 > > Acked-by: Ethan Jackson > > On Fri, Feb 1,

Re: [ovs-dev] [PATCH 3/3] tests: Add test for Python version of long socket name workaround.

2013-02-13 Thread Ben Pfaff
Thanks for the reviews. I applied these to master. On Tue, Feb 12, 2013 at 06:04:01PM -0800, Ethan Jackson wrote: > There's a bit of trailing whitespace in test-unix-socket.py (at least > in the version I cloned from your repo). > > Acked-by: Ethan Jackson > > On Fri, Feb 1, 2013 at 2:46 PM, B

[ovs-dev] [PATCHv2] Add support for LISP tunneling

2013-02-13 Thread Lorand Jakab
LISP is an experimental layer 3 tunneling protocol, described in RFC 6830. This patch adds support for LISP tunneling. Since LISP encapsulated packets do not carry an Ethernet header, it is removed before encapsulation, and added with hardcoded source and destination MAC addresses after decapsula

[ovs-dev] [ext-260 v2 1/6] ofp-errors: Fix typos in comment.

2013-02-13 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- lib/ofp-errors.h |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/ofp-errors.h b/lib/ofp-errors.h index 593241d..aa3ba50 100644 --- a/lib/ofp-errors.h +++ b/lib/ofp-errors.h @@ -1,5 +1,5 @@ /* - * Copyright (c) 2008, 2009, 2010, 2011,

[ovs-dev] [ext-260 v2 2/6] ofp-errors: Make ofperr_decode() static.

2013-02-13 Thread Ben Pfaff
It had no users outside of ofp-errors.c. Signed-off-by: Ben Pfaff --- lib/ofp-errors.c |2 +- lib/ofp-errors.h |1 - 2 files changed, 1 insertions(+), 2 deletions(-) diff --git a/lib/ofp-errors.c b/lib/ofp-errors.c index f2a9e8c..e2449b3 100644 --- a/lib/ofp-errors.c +++ b/lib/ofp-error

[ovs-dev] [ext-260 v2 6/6] Implement EXT-237 "Add error messages for OFPT_SET_ASYNC".

2013-02-13 Thread Ben Pfaff
I don't see any need to actually report any of these errors, so this commit just adds the error codes. Since these are the first non-Nicira extension error codes in Open vSwitch, also add a test to make sure that they get correctly encoded and decoded. Signed-off-by: Ben Pfaff --- lib/ofp-error

[ovs-dev] [ext-260 v2 3/6] extract-ofp-errors: Remove support for hexadecimal error types.

2013-02-13 Thread Ben Pfaff
This feature wasn't used and removing it slightly simplifies the code. Signed-off-by: Ben Pfaff --- build-aux/extract-ofp-errors | 10 +++--- 1 files changed, 3 insertions(+), 7 deletions(-) diff --git a/build-aux/extract-ofp-errors b/build-aux/extract-ofp-errors index fd53001..aa1f4b7 10

[ovs-dev] [ext-260 v2 4/6] ofp-errors: Implement OpenFlow 1.2+ experimenter error codes.

2013-02-13 Thread Ben Pfaff
OpenFlow 1.2 standardized experimenter error codes in a way different from the Nicira extension. This commit implements the OpenFlow 1.2+ version. Signed-off-by: Ben Pfaff --- build-aux/extract-ofp-errors| 149 +++ include/openflow/openflow-1.2.h |5

[ovs-dev] [ext-260 v2 0/6] Implement EXT-260 and EXT-237

2013-02-13 Thread Ben Pfaff
This version significantly revises the ofp-errors implementation from the first version, and adds a (pathologically trivial) implementation of EXT-237 as well. Ben Pfaff (6): ofp-errors: Fix typos in comment. ofp-errors: Make ofperr_decode() static. extract-ofp-errors: Remove support for hex

Re: [ovs-dev] [ext-260 v2 4/6] ofp-errors: Implement OpenFlow 1.2+ experimenter error codes.

2013-02-13 Thread Reid Price
Python seems good, nice use of int(X, 0) One question on > +print "{ -1, -1, -1 }, /* %s */" % enum If you moved the print outside this and used the same print (below) for both > +print "{ %#8x, %2d, %3d }, /* %s */" % (vendor, > type_, co

Re: [ovs-dev] [ext-260 v2 4/6] ofp-errors: Implement OpenFlow 1.2+ experimenter error codes.

2013-02-13 Thread Ben Pfaff
On Wed, Feb 13, 2013 at 03:23:39PM -0800, Reid Price wrote: > Python seems good, nice use of int(X, 0) Thanks. > One question on > > > +print "{ -1, -1, -1 }, /* %s */" % enum > > If you moved the print outside this and used the same print (below) for both > > >

[ovs-dev] [PATCH 1/4] ofproto-dpif: Make initial packet value handling generic.

2013-02-13 Thread Justin Pettit
For VLAN splinters, an "initial_tci" value was introduced that is passed around during flow processing to be used later for action translation. This commit switches to passing around a struct so that additional values beyond TCI can be used. A future commit will use this. Signed-off-by: Justin Pe

[ovs-dev] [PATCH 4/4] tunnel: Mark ECN status on decapsulated tunnel packets.

2013-02-13 Thread Justin Pettit
In the kernel tunnel implementation, if a packet was marked as ECN CE on the outer packet then we would carry this over to the inner packet on decapsulation. With the switch to flow based tunneling, this stopped happening. This commit reintroduces that behavior by using the set IP header action.

[ovs-dev] [PATCH 2/4] ofproto-dpif: Store the initial tunnel IP TOS values for later use.

2013-02-13 Thread Justin Pettit
When a packet arrives on an IP tunnel, store the TOS value for later use. This value will be used in a couple of future commits. Signed-off-by: Justin Pettit --- ofproto/ofproto-dpif.c | 23 ++- 1 files changed, 18 insertions(+), 5 deletions(-) diff --git a/ofproto/ofprot

[ovs-dev] [PATCH 3/4] tunnel: Generate datapath flows for tunneled packets dropped due to ECN.

2013-02-13 Thread Justin Pettit
Move the check for whether tunneled packets should be dropped due to congestion encountered (CE) when the encapsulated packet is not ECN capable (non-ECT). This also adds some additional tests for ECN handling on tunnel decapsulation. Signed-off-by: Justin Pettit --- ofproto/ofproto-dpif.c |

[ovs-dev] [ext-260 v2 5/6] ofp-errors: New error code NXBIC_DUP_INSTRUCTION.

2013-02-13 Thread Ben Pfaff
This is a prototype of OpenFlow enhancement proposal EXT-260 "Add error code for duplicate instruction." It uses the error code proposed there. Signed-off-by: Ben Pfaff --- lib/ofp-actions.c|4 +--- lib/ofp-errors.h |6 ++ tests/ofp-actions.at |4 ++-- 3 files changed, 9

[ovs-dev] [PATCH] ofproto-dpif: Move 'orig_flow' from action_xlate_ctx to local variable.

2013-02-13 Thread Ben Pfaff
A comment said that this was necessary to silence a false-positive warning from GCC 4.4. However, it no longer triggers a warning for me, so enough must have changed in the meantime to make GCC happy. Signed-off-by: Ben Pfaff --- ofproto/ofproto-dpif.c | 14 +- 1 files changed, 5

Re: [ovs-dev] [PATCH] ofproto-dpif: Move 'orig_flow' from action_xlate_ctx to local variable.

2013-02-13 Thread Justin Pettit
Looks good. --Justin On Feb 13, 2013, at 3:50 PM, Ben Pfaff wrote: > A comment said that this was necessary to silence a false-positive warning > from GCC 4.4. However, it no longer triggers a warning for me, so enough > must have changed in the meantime to make GCC happy. > > Signed-off-by:

Re: [ovs-dev] [PATCH] FAQ: Add troubleshooting procedure and example.

2013-02-13 Thread Justin Pettit
On Feb 13, 2013, at 9:36 AM, Ben Pfaff wrote: > + - "ovs-appctl ofproto/trace" to observe the logic behind how > + ovs-vswitchd treats packets. See ovs-vswitchd(8) for > + documentation. The ofproto/trace input format makes it easy > + to cut and paste flows output

Re: [ovs-dev] [PATCH 04/16] actions: Allow secondary decoding of a flow

2013-02-13 Thread Simon Horman
On Wed, Feb 13, 2013 at 08:42:53AM -0800, Ben Pfaff wrote: > On Wed, Feb 13, 2013 at 11:47:46PM +0900, Simon Horman wrote: > > On Tue, Feb 12, 2013 at 09:42:52AM -0800, Ben Pfaff wrote: > > > On Wed, Feb 06, 2013 at 10:53:55PM +0900, Simon Horman wrote: > > > > Actions may provide information to al

Re: [ovs-dev] [PATCH] ofproto-dpif: Move 'orig_flow' from action_xlate_ctx to local variable.

2013-02-13 Thread Ben Pfaff
Thanks, I pushed this. On Wed, Feb 13, 2013 at 04:22:07PM -0800, Justin Pettit wrote: > Looks good. > > --Justin > > > On Feb 13, 2013, at 3:50 PM, Ben Pfaff wrote: > > > A comment said that this was necessary to silence a false-positive warning > > from GCC 4.4. However, it no longer trigge

Re: [ovs-dev] [PATCH] FAQ: Add troubleshooting procedure and example.

2013-02-13 Thread Ben Pfaff
On Wed, Feb 13, 2013 at 04:31:42PM -0800, Justin Pettit wrote: > On Feb 13, 2013, at 9:36 AM, Ben Pfaff wrote: > > > + - "ovs-appctl ofproto/trace" to observe the logic behind how > > + ovs-vswitchd treats packets. See ovs-vswitchd(8) for > > + documentation. The ofproto/t

[ovs-dev] [PATCH 1/2] ofp-util: Fix type of 'port' param to ofputil_encode_dump_ports_request().

2013-02-13 Thread Ben Pfaff
We always use unsigned types for port numbers elsewhere, so use one here too. Signed-off-by: Ben Pfaff --- lib/ofp-util.c |2 +- lib/ofp-util.h |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/ofp-util.c b/lib/ofp-util.c index dd6eed8..2716f82 100644 --- a/lib/of

[ovs-dev] [PATCH 2/2] ofp-util: Remove prototype for unimplemented, misspelled function.

2013-02-13 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- lib/ofp-util.h |2 -- 1 file changed, 2 deletions(-) diff --git a/lib/ofp-util.h b/lib/ofp-util.h index 5698491..4d0d8ad 100644 --- a/lib/ofp-util.h +++ b/lib/ofp-util.h @@ -686,8 +686,6 @@ union ofp_action *ofputil_actions_clone(const union ofp_action *, size_t