On Fri, Feb 08, 2013 at 11:18:07AM +0800, ?? wrote:
>Thanks your reply. Yes, I read that manual several times before i sent
> the previous post here. This manual tell me that ovs-vsctl is a db client
> to configure Open vSwitch configuration database maintained by
> ovsdb-server. So when
On Thu, Feb 07, 2013 at 07:04:21PM -0800, Ethan Jackson wrote:
> These log messages occur infrequently, and are quite useful when
> debugging problems after the fact. So they should be logged at
> info level which makes them more readily available.
>
> Signed-off-by: Ethan Jackson
Looks good, t
On Thu, Feb 07, 2013 at 07:04:22PM -0800, Ethan Jackson wrote:
> The documented behavior of ovs is that a missing key is the
> same as a zero key. However, the tunneling code actually treated
> them differently. This could cause problems with tunneling modes
> such as vxlan which always have a ke
On Wed, Feb 06, 2013 at 08:44:36AM -0800, Ben Pfaff wrote:
> On Wed, Feb 06, 2013 at 03:54:14PM +0800, Cong Wang wrote:
> > On 02/06/2013 03:14 AM, Ben Pfaff wrote:
> > >Reported-by: Cong Wang
> > >Signed-off-by: Ben Pfaff
> > >---
> > >Cong, will you verify that this makes the init script work O
If the pointer does not represent an error then the PTR_ERR macro may still
return a nonzero value. The fix is the same as in ovs_vport_cmd_set.
Signed-off-by: Rich Lane
---
datapath/datapath.c |1 +
1 file changed, 1 insertion(+)
diff --git a/datapath/datapath.c b/datapath/datapath.c
index
On Thu, Feb 07, 2013 at 03:48:14PM -0800, Pavithra Ramesh wrote:
> If socket path specified is relative to ovs_rundir(),
> append the directory name to in unix_open and punix_open.
> Freed the new newly allocated strings.
> Also included the change in bridge.c to relax the whitelist
> check, only i
On Fri, Feb 8, 2013 at 9:11 AM, Rich Lane wrote:
> If the pointer does not represent an error then the PTR_ERR macro may still
> return a nonzero value. The fix is the same as in ovs_vport_cmd_set.
>
> Signed-off-by: Rich Lane
Applied, thank you.
___
d
Thanks Ben. The patch looks good.
Do we also want to change the python stream implementation
to behave the same way?
-Pavithra
- Original Message -
From: "Ben Pfaff"
To: "Pavithra Ramesh"
Cc: dev@openvswitch.org
Sent: Friday, February 8, 2013 9:14:13 AM
Subject: Re: [ovs-dev] [PATCH] s
Yes, would you mind taking a first shot?
On Fri, Feb 08, 2013 at 09:51:33AM -0800, Pavithra Ramesh wrote:
> Thanks Ben. The patch looks good.
> Do we also want to change the python stream implementation
> to behave the same way?
>
> -Pavithra
>
> - Original Message -
> From: "Ben Pfaff"
Sure, I've made the change and will send out a new patch.
Can you push this one?
Thanks,
Pavithra
- Original Message -
From: "Ben Pfaff"
To: "Pavithra Ramesh"
Cc: dev@openvswitch.org
Sent: Friday, February 8, 2013 11:18:38 AM
Subject: Re: [ovs-dev] [PATCH] stream-unix: append ovs_rundir
This bug was introduced in 1fc7083d (datapath: Remove vport MAC address
configuration.)
Signed-off-by: Rich Lane
---
datapath/datapath.c |1 +
1 file changed, 1 insertion(+)
diff --git a/datapath/datapath.c b/datapath/datapath.c
index f78c232..87c96ae 100644
--- a/datapath/datapath.c
+++ b/
Hi,
On 30/01/13 14:44, Markus Schuster wrote:
Hi,
looks like I'm currently in SLB bonding bug hunting mood :) - I think I found
an additional bug / strange behaviour with balance-slb bonding: Two VMs
suffered from short term (a few minutes) connectivity issues every now and
then, so I started
Usually we put both the C and Python versions into one patch, if we
remember to change both versions at the same time.
On Fri, Feb 08, 2013 at 11:24:45AM -0800, Pavithra Ramesh wrote:
> Sure, I've made the change and will send out a new patch.
> Can you push this one?
>
> Thanks,
> Pavithra
>
>
If socket path specified is relative to ovs_rundir(),
append the directory name to in unix_open and punix_open.
Made the change in the stream-unix implementation of C and
Python.
Also modified bridge.c to relax the whitelist check,
only if there is no '/' in socket name.
---
lib/stream-unix.c
On Fri, Feb 08, 2013 at 12:06:22AM +0200, Jarno Rajahalme wrote:
>
> Signed-off-by: Jarno Rajahalme
Well done. I applied this to master. I only added {} around a
statement where it was missing and ending punctuation to a few
comments.
Thanks a lot.
Ben
___
On Fri, Feb 8, 2013 at 12:09 PM, Rich Lane wrote:
> This bug was introduced in 1fc7083d (datapath: Remove vport MAC address
> configuration.)
>
> Signed-off-by: Rich Lane
Also applied, thanks.
___
dev mailing list
dev@openvswitch.org
http://openvswitch
The patch pretty much looks good to me. I still don't think we have
the patch port code exactly correct though. Suppose we're neither in
the forwarding state, nor the learning state. It looks to me like
we'll still run through the learning code when sending through the
patch port, though we don't
Thanks for the reviews. I've pushed this to master and 1.10
Ethan
On Fri, Feb 8, 2013 at 8:45 AM, Ben Pfaff wrote:
> On Thu, Feb 07, 2013 at 07:04:22PM -0800, Ethan Jackson wrote:
>> The documented behavior of ovs is that a missing key is the
>> same as a zero key. However, the tunneling code
This patch increases the certificate validity to 100 years
for certificate authorities, the certificates that they certify
and for self signed certificates.
Signed-off-by: Gurucharan Shetty
---
utilities/ovs-pki.in |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/util
Without genlmsg_end the upcall message ends (according to nlmsg_len) after the
struct ovs_header.
Signed-off-by: Rich Lane
---
datapath/datapath.c |1 +
1 file changed, 1 insertion(+)
diff --git a/datapath/datapath.c b/datapath/datapath.c
index 87c96ae..5d18def 100644
--- a/datapath/datapat
Before this patch, if an LLC/SNAP packet with OUI 00:00:00 had an ethertype
less than 1536 the flow key given to userspace in the upcall would contain the
invalid ethertype (for example, 3). If userspace attempted to insert a kernel
flow for this key it would be rejected by ovs_flow_from_nlattrs.
On Fri, Feb 08, 2013 at 02:49:12PM -0800, Gurucharan Shetty wrote:
> This patch increases the certificate validity to 100 years
> for certificate authorities, the certificates that they certify
> and for self signed certificates.
>
> Signed-off-by: Gurucharan Shetty
Thanks, this seems reasonable
HI
Thanks, so, to do kernel configuration, how does ovs-vswitchd do? by
direct function call or some other mechanism?
2013/2/9 Ben Pfaff
> On Fri, Feb 08, 2013 at 11:18:07AM +0800, ?? wrote:
> >Thanks your reply. Yes, I read that manual several times before i sent
> > the previous
On Sat, Feb 9, 2013 at 12:46 AM, Ben Pfaff wrote:
> On Wed, Feb 06, 2013 at 08:44:36AM -0800, Ben Pfaff wrote:
>> On Wed, Feb 06, 2013 at 03:54:14PM +0800, Cong Wang wrote:
>> > On 02/06/2013 03:14 AM, Ben Pfaff wrote:
>> > >Reported-by: Cong Wang
>> > >Signed-off-by: Ben Pfaff
>> > >---
>> > >C
24 matches
Mail list logo
