On Sun, Jan 20, 2013 at 11:28:24PM -0800, Pravin Shelar wrote:
> On Sun, Jan 20, 2013 at 9:02 PM, Ben Pfaff wrote:
> > On Sat, Jan 19, 2013 at 08:15:56PM -0800, Pravin B Shelar wrote:
> >> Following patch adds null check while inserting new netlink attribute.
> >> This was introduced by commit 9b4
On Sun, Jan 20, 2013 at 05:36:59PM +0530, Paraneetharan Chandrasekaran wrote:
> This is a cosmetic change. Remove the redundant call to ofconn_get_ofproto
> in handle_flow_mod.
>
> Signed-off-by: Paraneetharan C
Thanks. Applied to master.
If you submit more patches, please ensure that the name
skb_gso_segment() has the following comment:
*It may return NULL if the skb requires no segmentation. This is
*only possible when GSO is used for verifying header integrity.
Somehow queue_gso_packets() has never hit this case before, but some
failures have suddenly been reported. This
On Mon, Jan 21, 2013 at 10:11 AM, Ben Pfaff wrote:
> skb_gso_segment() has the following comment:
>
> *It may return NULL if the skb requires no segmentation. This is
> *only possible when GSO is used for verifying header integrity.
>
> Somehow queue_gso_packets() has never hit this cas
On Sat, Jan 19, 2013 at 8:15 PM, Pravin B Shelar wrote:
> Following patch adds null check while inserting new netlink attribute.
> This was introduced by commit 9b405f1aa8d175d (datapath: More
> flexible kernel/userspace tunneling attribute.)
>
> Signed-off-by: Pravin B Shelar
> Bug #14767
> ---
On Sun, Jan 20, 2013 at 9:05 PM, Ben Pfaff wrote:
> On Sat, Jan 19, 2013 at 08:16:06PM -0800, Pravin B Shelar wrote:
>> Following patch fixes flow buffer size calculation to allocate
>> sufficient memory for all nested attributes in new tunnel
>> attribute.
>>
>> Signed-off-by: Pravin B Shelar
>>
On Mon, Jan 21, 2013 at 02:25:34PM -0800, Jesse Gross wrote:
> On Mon, Jan 21, 2013 at 10:11 AM, Ben Pfaff wrote:
> > skb_gso_segment() has the following comment:
> >
> > *It may return NULL if the skb requires no segmentation. This is
> > *only possible when GSO is used for verifying h
Currently, if there isn't enough space to store the actions in a
flow during a dump we return -ENOMEM. However, the standard error
in this situation is -EMSGSIZE so this changes the behavior to match.
This issue was introduced in 354d4c98a8cdaae3525848f564e58a9016bcd3af
(datapath: Fix nelink attr
From: Ben Pfaff
After commit 9b405f1aa8d175dc63ad3ffe5d0fe05d5ee09162 (datapath: More
flexible kernel/userspace tunneling attribute.), it was possible for a
flow dump to return a partial action list. It's better to return no
action list at all in this situation since then userspace will know
tha
On Mon, Jan 21, 2013 at 2:48 PM, Ben Pfaff wrote:
> On Mon, Jan 21, 2013 at 02:25:34PM -0800, Jesse Gross wrote:
>> On Mon, Jan 21, 2013 at 10:11 AM, Ben Pfaff wrote:
>> > skb_gso_segment() has the following comment:
>> >
>> > *It may return NULL if the skb requires no segmentation. This is
On Mon, Jan 21, 2013 at 2:25 PM, Jesse Gross wrote:
> On Mon, Jan 21, 2013 at 10:11 AM, Ben Pfaff wrote:
>> skb_gso_segment() has the following comment:
>>
>> *It may return NULL if the skb requires no segmentation. This is
>> *only possible when GSO is used for verifying header integr
On Mon, Jan 21, 2013 at 03:59:16AM -0800, Jesse Gross wrote:
> From: Ben Pfaff
>
> After commit 9b405f1aa8d175dc63ad3ffe5d0fe05d5ee09162 (datapath: More
> flexible kernel/userspace tunneling attribute.), it was possible for a
> flow dump to return a partial action list. It's better to return no
On Mon, Jan 21, 2013 at 04:04:22PM -0800, Jesse Gross wrote:
> On Mon, Jan 21, 2013 at 2:25 PM, Jesse Gross wrote:
> > On Mon, Jan 21, 2013 at 10:11 AM, Ben Pfaff wrote:
> >> skb_gso_segment() has the following comment:
> >>
> >> *It may return NULL if the skb requires no segmentation. This
On Mon, Jan 21, 2013 at 4:09 PM, Ben Pfaff wrote:
> On Mon, Jan 21, 2013 at 04:04:22PM -0800, Jesse Gross wrote:
>> On Mon, Jan 21, 2013 at 2:25 PM, Jesse Gross wrote:
>> > On Mon, Jan 21, 2013 at 10:11 AM, Ben Pfaff wrote:
>> >> skb_gso_segment() has the following comment:
>> >>
>> >> *It
On Thu, Jan 17, 2013 at 02:26:06PM +0900, Simon Horman wrote:
> On Wed, Jan 16, 2013 at 05:38:08PM +0900, Simon Horman wrote:
> > On Tue, Jan 15, 2013 at 11:05:45PM -0800, Ben Pfaff wrote:
[snip]
> > > parse_l3_onward() could use flow_innermost_dl_type() since that's what
> > > it's effectively c
Commit 24b019f808211a95078efd916064af0975ca5733 (datapath: Disable
LRO from userspace instead of the kernel.) accidentally moved the
check for LRO packets from the receive path to transmit. Since
this check is supposed to protect OVS (and other parts of the system)
from packets that it cannot hand
On Thu, Jan 17, 2013 at 09:42:29AM +0900, Simon Horman wrote:
> On Wed, Jan 16, 2013 at 01:59:21PM -0800, Ben Pfaff wrote:
> > On Tue, Jan 15, 2013 at 01:20:57PM +0900, Simon Horman wrote:
> > > Optimise OpenFlow flow expiry by placing expirable flows on a list.
> > > This optimises scanning of flo
On Mon, Jan 21, 2013 at 05:21:19AM -0800, Jesse Gross wrote:
> Commit 24b019f808211a95078efd916064af0975ca5733 (datapath: Disable
> LRO from userspace instead of the kernel.) accidentally moved the
> check for LRO packets from the receive path to transmit. Since
> this check is supposed to protect
On Mon, Jan 21, 2013 at 5:11 PM, Ben Pfaff wrote:
> On Mon, Jan 21, 2013 at 05:21:19AM -0800, Jesse Gross wrote:
>> Commit 24b019f808211a95078efd916064af0975ca5733 (datapath: Disable
>> LRO from userspace instead of the kernel.) accidentally moved the
>> check for LRO packets from the receive path
On Mon, Jan 21, 2013 at 03:59:17AM -0800, Jesse Gross wrote:
> Currently, if there isn't enough space to store the actions in a
> flow during a dump we return -ENOMEM. However, the standard error
> in this situation is -EMSGSIZE so this changes the behavior to match.
> This issue was introduced in
On Mon, Jan 21, 2013 at 5:16 PM, Ben Pfaff wrote:
> On Mon, Jan 21, 2013 at 03:59:17AM -0800, Jesse Gross wrote:
>> Currently, if there isn't enough space to store the actions in a
>> flow during a dump we return -ENOMEM. However, the standard error
>> in this situation is -EMSGSIZE so this chang
21 matches
Mail list logo
