Re: [ovs-dev] [PATCH] v2: Add ODP level handling of OVS_KEY_ATTR_IPV4_TUNNEL.

2012-12-19 Thread Jarno Rajahalme
On Dec 19, 2012, at 9:48 , ext Jarno Rajahalme wrote: > On Dec 18, 2012, at 19:37 , ext Jesse Gross wrote: >> On Tue, Dec 18, 2012 at 5:57 AM, Jarno Rajahalme >> wrote: >>> diff --git a/lib/odp-util.c b/lib/odp-util.c >>> index f1075e3..1ba241d 100644 >>> --- a/lib/odp-util.c >>> +++ b/lib/odp-uti

[ovs-dev] [PATCH v2 2/2] datapath: linux2.7 s/pid/portid/g

2012-12-19 Thread Isaku Yamahata
the following up of 15e473046cb6e5d18a4d0057e61d76315230382b This patch replaces pid with portid under datapath/linux/compat Signed-off-by: Isaku Yamahata --- datapath/linux/compat/genetlink.inc | 18 +- datapath/linux/compat/include/linux/rtnetlink.h | 10 +--

[ovs-dev] [PATCH v2 1/2] datapath: support Linux 3.7

2012-12-19 Thread Isaku Yamahata
datapath: backport 15e473046cb6e5d18a4d0057e61d76315230382b Signed-off-by: Isaku Yamahata --- Changes v1 -> v2: - more replace to align with 15e473046cb6e5d18a4d0057e61d76315230382b - NEWS, README --- FAQ |2 +- NEWS

[ovs-dev] (no subject)

2012-12-19 Thread SAUDAÇÕES
MEU NOME É Nero e eu moro no Canadá, meu marido me deixou com a criança após seis anos de casamento, ele foi tão devastador até que encontrei um homem na PROFETA INTERNET IKPEFUA, ele é um lançador de magias Eu nunca acreditei em magias, mas eu não tinha outra escolha QUE apenas tentar ele me

[ovs-dev] testing openvswitch ports

2012-12-19 Thread Gray, Mark D
Hi, I have a question about porting openvswitch. After developing a dpif or ofproto implementation, how can I test it? Do you have any automated tests. The ./tests folder has some unit-tests but I don't know if that is sufficient. Or should I write my own test code as I develop the port? Thank

[ovs-dev] [PATCH 01/10] ofproto: Remove trailing whitespace.

2012-12-19 Thread Ethan Jackson
Signed-off-by: Ethan Jackson --- ofproto/ofproto.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c index a85a681..42a5baf 100644 --- a/ofproto/ofproto.c +++ b/ofproto/ofproto.c @@ -3547,7 +3547,7 @@ handle_flow_mod(struct ofconn *ofconn

[ovs-dev] [PATCH 02/10] xenserver: Downgrade not on XenServer warning to DBG.

2012-12-19 Thread Ethan Jackson
This log message is annoying and of questionable usefulness. Signed-off-by: Ethan Jackson --- vswitchd/xenserver.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vswitchd/xenserver.c b/vswitchd/xenserver.c index 1f29daf..7427e4c 100644 --- a/vswitchd/xenserver.c +++ b/vsw

[ovs-dev] [PATCH 03/10] ovs: Replace TODO:XXX with XXX.

2012-12-19 Thread Ethan Jackson
According to the coding style, XXX is the appropriate tag for code that needs work. Signed-off-by: Ethan Jackson --- lib/jsonrpc.c |2 +- lib/ofp-actions.c | 14 +++--- lib/ofp-actions.h |4 ++-- lib/ofp-parse.c|4 ++-- ofproto/ofproto-dpif.c |

[ovs-dev] [PATCH 04/10] ofproto-dpif: User proper type for odp_port when outputting.

2012-12-19 Thread Ethan Jackson
Found by inspection. Signed-off-by: Ethan Jackson --- ofproto/ofproto-dpif.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c index d5d22d3..d1064bc 100644 --- a/ofproto/ofproto-dpif.c +++ b/ofproto/ofproto-dpif.c @@ -5384,7 +

[ovs-dev] [PATCH 05/10] ofproto-dpif: Don't output to nonexistent ports.

2012-12-19 Thread Ethan Jackson
In older versions of Open vSwitch, one could reasonably predict that the datapath port number would be the same as the OpenFlow port number even for ports which may not exist yet. With the single datapath model, it's no possible longer to make this prediction. Therefore, instead of attempting to,

[ovs-dev] [PATCH 06/10] ofproto-dpif: New function ofproto_receive().

2012-12-19 Thread Ethan Jackson
Before translating a datapath flow key into actions, ofproto-dpif must parse it, tweak it, and figure out what ofproto_dpif it belongs to. This patch brings all this logic into one place where it will be easier to extend in the future. Signed-off-by: Ethan Jackson --- ofproto/ofproto-dpif.c |

[ovs-dev] [PATCH 08/10] netdev-vport: Remove set_stats() implementation.

2012-12-19 Thread Ethan Jackson
The only user of netdev_set_stats() is bonding (for updating the fake interface). This interface is never a vport, so it seems quite a bit cleaner to keep the relevant code in the netdev-linux library where it's needed, instead of in netdev-vport, where it adds needless complexity. Signed-off-by:

[ovs-dev] [PATCH 07/10] netdev-vport: Remove the ability to send packets.

2012-12-19 Thread Ethan Jackson
The only user of netdev_send() is dpif-netdev which doesn't support vports. Signed-off-by: Ethan Jackson --- lib/dpif-linux.c | 27 --- lib/dpif-linux.h |3 --- lib/netdev-vport.c | 34 +- 3 files changed, 1 insertion(+), 63 del

[ovs-dev] [PATCH 09/10] netdev-vport: Manage ethernet addresses in userspace.

2012-12-19 Thread Ethan Jackson
Letting netdev-vport manage ethernet addresses itself instead of relying on the datapath has several advantages. It simplifies the code, is significantly more efficient, and will work when there is no longer a one to one mapping from netdev-vports to datapath vports. Signed-off-by: Ethan Jackson

[ovs-dev] [PATCH 10/10] netdev: Rename get_drv_info() to get_status().

2012-12-19 Thread Ethan Jackson
get_status() is a much more intuitive name since "status" is what the database column is called. Signed-off-by: Ethan Jackson --- lib/netdev-provider.h |6 +++--- lib/netdev-vport.c| 53 ++--- lib/netdev.c |6 +++--- lib/netdev.h

Re: [ovs-dev] testing openvswitch ports

2012-12-19 Thread Ben Pfaff
On Wed, Dec 19, 2012 at 10:49:25AM +, Gray, Mark D wrote: > I have a question about porting openvswitch. After developing a dpif > or ofproto implementation, how can I test it? Do you have any > automated tests. The ./tests folder has some unit-tests but I don't > know if that is sufficient. Or