Signed-off-by: Isaku Yamahata
---
datapath/datapath.c | 54 -
datapath/linux/Modules.mk |1 +
datapath/linux/compat/include/net/genetlink.h | 15 ++-
datapath/linux/compat/include/net/inet_frag.h | 16
da
On 12/18/12 10:40, Isaku Yamahata wrote:
> Signed-off-by: Isaku Yamahata
> ---
> datapath/datapath.c | 54
> -
> datapath/linux/Modules.mk |1 +
> datapath/linux/compat/include/net/genetlink.h | 15 ++-
> datapath/
This patchset introduces matching support for sctp src,dst ports. Round two
addresses feedback from the previous posting and adds many more tests. In
particular, there are now tests to check that set-field behaviour for SCTP
src/dst port is correct when re-calculating checksums. The checksum tests
Signed-off-by: Joe Stringer
---
v2: Remove SCTP checksum recalculation when changing IP address
Calculate checksums as delta from incoming checksum
---
datapath/actions.c | 37 +
datapath/checksum.c|3 +
datapath/datapath.c
This implementation was derived from FreeBSD:
http://code.google.com/p/freebsd-head/source/browse/sys/libkern/crc32.c
Signed-off-by: Joe Stringer
---
v2: Update copyright notice
Use network byte-order
Include config.h (Fix sparse error)
---
lib/automake.mk |2 +
lib/crc32c.c| 14
Signed-off-by: Joe Stringer
---
v2: Rebase against master
Add flowmod parse tests
Add set-field tests
Add NEWS item
Add sctp to ovs-ofctl.8
---
NEWS |1 +
OPENFLOW-1.1+|4 --
lib/match.c |4 ++
lib/meta-flow.c | 4
Signed-off-by: Joe Stringer
---
v2: Fix broken test
Use the correct packet pointer
Calculate checksums as delta from incoming checksum
---
include/linux/openvswitch.h |6 +
include/sparse/netinet/in.h |1 +
lib/dpif-netdev.c |6 +
lib/flow.c
v2 adds struct ofputil_role_request and
encode/decode functions for role request/reply.
Signed-off-by: Jarno Rajahalme
---
lib/ofp-msgs.h | 24 ++-
lib/ofp-print.c| 43 +--
lib/ofp-util.c | 83
Signed-off-by: SUGYO Kazushi
diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c
index f95d6ef..cbabae9 100644
--- a/ofproto/ofproto.c
+++ b/ofproto/ofproto.c
@@ -2245,8 +2245,11 @@ handle_features_request(struct ofconn *ofconn, const stru
features.auxiliary_id = 0;
b = ofputil_encode_sw
On Dec 18, 2012, at 14:51 , ext SUGYO Kazushi wrote:
> Signed-off-by: SUGYO Kazushi
>
> diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c
> index f95d6ef..cbabae9 100644
> --- a/ofproto/ofproto.c
> +++ b/ofproto/ofproto.c
> @@ -2245,8 +2245,11 @@ handle_features_request(struct ofconn *ofconn, co
v2 addresses comments by Jesse.
Signed-off-by: Jarno Rajahalme
---
lib/odp-util.c | 85 +++-
tests/odp.at | 15 ++
2 files changed, 93 insertions(+), 7 deletions(-)
diff --git a/lib/odp-util.c b/lib/odp-util.c
index f1075e3..1ba2
Signed-off-by: Felician Nemeth
---
ofproto/ofproto.c| 12
ofproto/ofproto.h|2 ++
vswitchd/bridge.c| 14 ++
vswitchd/vswitch.xml |6 ++
4 files changed, 34 insertions(+)
diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c
index f95d6ef..db68a1
On Mon, Dec 17, 2012 at 9:08 PM, Ansis Atteka wrote:
> This patch adds logging support for skb_mark and skb_priority.
>
> Signed-off-by: Ansis Atteka
Looks good to me, thanks.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listi
On Tue, Dec 18, 2012 at 5:57 AM, Jarno Rajahalme
wrote:
> v2 addresses comments by Jesse.
>
> Signed-off-by: Jarno Rajahalme
It's helpful if you add comments about changes between patches below a
separator of --- so git will automatically trim them out when the
patch is applied.
> diff --git a/
This function can be implemented as a trivial wrapper around
mf_get_value(), which I hadn't noticed before, so it's better to do it
that way. Also, examining the code that is removed, it had some bugs in
it (for example, all MFF_TUN_* fields were treated as if they were
MFF_TUN_ID) which mf_get_va
On Tue, Dec 18, 2012 at 9:45 AM, Ben Pfaff wrote:
> This function can be implemented as a trivial wrapper around
> mf_get_value(), which I hadn't noticed before, so it's better to do it
> that way. Also, examining the code that is removed, it had some bugs in
> it (for example, all MFF_TUN_* fiel
On Tue, Dec 18, 2012 at 10:02:27AM -0800, Jesse Gross wrote:
> On Tue, Dec 18, 2012 at 9:45 AM, Ben Pfaff wrote:
> > This function can be implemented as a trivial wrapper around
> > mf_get_value(), which I hadn't noticed before, so it's better to do it
> > that way. Also, examining the code that
On Tue, Dec 18, 2012 at 12:40 AM, Isaku Yamahata wrote:
> Signed-off-by: Isaku Yamahata
> ---
> datapath/datapath.c | 54
> -
> datapath/linux/Modules.mk |1 +
> datapath/linux/compat/include/net/genetlink.h | 15
On Tue, Dec 18, 2012 at 9:10 AM, Jesse Gross wrote:
> On Mon, Dec 17, 2012 at 9:08 PM, Ansis Atteka wrote:
>> This patch adds logging support for skb_mark and skb_priority.
>>
>> Signed-off-by: Ansis Atteka
>
> Looks good to me, thanks.
Thanks for the review. I pushed this to master and branch-1
Signed-off-by: Romain Lenglet
---
ofproto/automake.mk | 2 +
ofproto/ofproto-dpif-ipfix.c | 125 +++
ofproto/ofproto-dpif-ipfix.h | 28 ++
ofproto/ofproto-dpif.c | 25 +
ofproto/ofproto-provider.h | 8 +++
ofproto/ofpr
This is the complete patch series to add a SAMPLE_IPFIX vendor action
to do statistical sampling of packets and send one IPFIX message for
every sample.
I have updated the first two patches (1/4 and 2/4) to use only 16 bits
for the probability in the OpenFlow action, making it 8 bytes shorter,
and
Define NXAST_SAMPLE_IPFIX OpenFlow vendor action and the corresponding
OFPACT_SAMPLE_IPFIX OVS action.
Signed-off-by: Romain Lenglet
---
NEWS | 1 +
include/openflow/nicira-ext.h | 22 +
lib/ofp-actions.c | 45
Signed-off-by: Romain Lenglet
---
lib/odp-util.c | 19
lib/odp-util.h | 9 +-
ofproto/ofproto-dpif.c | 81 +-
tests/odp.at | 1 +
4 files changed, 95 insertions(+), 15 deletions(-)
diff --git a/lib/odp-u
On Thu, Nov 22, 2012 at 7:57 AM, Pravin B Shelar wrote:
> diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
> index 585aca7..a23df86 100644
> --- a/include/linux/skbuff.h
> +++ b/include/linux/skbuff.h
> @@ -422,6 +424,7 @@ struct sk_buff {
> __u16 csum_offset;
On Thu, Nov 22, 2012 at 7:57 AM, Pravin B Shelar wrote:
> From: Pravin Shelar
>
> Signed-off-by: Pravin B Shelar
> ---
> drivers/net/vxlan.c | 27 ++-
> 1 files changed, 22 insertions(+), 5 deletions(-)
Looks good, modulo changes related to earlier comments and upstre
When HMAP_FOR_EACH completes, the value in the loop control variable is not
necessarily NULL. It is NULL minus the offset of the hmap_node struct
member, which is nonnull if that offset is nonzero. Currently,
'all_ofproto_dpifs_node' is the first member in struct ofproto_dpif, so
there is no real
'devname' needs to be destroyed whether it's the datapath device or not.
Signed-off-by: Ben Pfaff
---
ofproto/ofproto-dpif.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
index b78d6cf..6ce9a07 100644
--- a/ofproto/ofpr
The dpif_port_destroy() call was in the dpif_port_query_by_name() error
path, when there's nothing to destroy, rather than in the "success" path,
where there is data to destroy.
Signed-off-by: Ben Pfaff
---
ofproto/ofproto-dpif.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff
Signed-off-by: Ben Pfaff
---
ofproto/ofproto-dpif.c |3 ++-
ofproto/ofproto.c |3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
index 6ce9a07..578e6d7 100644
--- a/ofproto/ofproto-dpif.c
+++ b/ofproto/ofproto-dpif.c
Looks good. Thanks.
--Justin
On Dec 18, 2012, at 1:51 PM, Ben Pfaff wrote:
> When HMAP_FOR_EACH completes, the value in the loop control variable is not
> necessarily NULL. It is NULL minus the offset of the hmap_node struct
> member, which is nonnull if that offset is nonzero. Currently,
>
D'oh. Thanks.
--Justin
On Dec 18, 2012, at 1:51 PM, Ben Pfaff wrote:
> The dpif_port_destroy() call was in the dpif_port_query_by_name() error
> path, when there's nothing to destroy, rather than in the "success" path,
> where there is data to destroy.
>
> Signed-off-by: Ben Pfaff
> ---
> o
Looks good.
--Justin
On Dec 18, 2012, at 1:51 PM, Ben Pfaff wrote:
> 'devname' needs to be destroyed whether it's the datapath device or not.
>
> Signed-off-by: Ben Pfaff
> ---
> ofproto/ofproto-dpif.c |3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/ofproto/of
Looks good. Thanks!
--Justin
On Dec 18, 2012, at 1:51 PM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
> ---
> ofproto/ofproto-dpif.c |3 ++-
> ofproto/ofproto.c |3 ++-
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dp
Fixes the following sparse warnings:
meta-flow.c:947:21: warning: incorrect type in assignment (different base types)
meta-flow.c:947:21:expected restricted __be32 [usertype] be32
meta-flow.c:947:21:got unsigned int const [unsigned] [usertype] skb_priority
meta-flow.c:951:21: warning: inco
On Tue, Dec 18, 2012 at 3:54 PM, Ben Pfaff wrote:
> Fixes the following sparse warnings:
>
> meta-flow.c:947:21: warning: incorrect type in assignment (different base
> types)
> meta-flow.c:947:21:expected restricted __be32 [usertype] be32
> meta-flow.c:947:21:got unsigned int const [unsi
On Tue, Dec 18, 2012 at 04:06:54PM -0800, Jesse Gross wrote:
> On Tue, Dec 18, 2012 at 3:54 PM, Ben Pfaff wrote:
> > Fixes the following sparse warnings:
> >
> > meta-flow.c:947:21: warning: incorrect type in assignment (different base
> > types)
> > meta-flow.c:947:21:expected restricted __b
Thanks for all the reviews. I pushed these to master.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Tue, Dec 18, 2012 at 4:09 PM, Ben Pfaff wrote:
> On Tue, Dec 18, 2012 at 04:06:54PM -0800, Jesse Gross wrote:
>> On Tue, Dec 18, 2012 at 3:54 PM, Ben Pfaff wrote:
>> > Fixes the following sparse warnings:
>> >
>> > meta-flow.c:947:21: warning: incorrect type in assignment (different base
>> >
On Tue, Dec 18, 2012 at 04:38:44PM -0800, Jesse Gross wrote:
> On Tue, Dec 18, 2012 at 4:09 PM, Ben Pfaff wrote:
> > On Tue, Dec 18, 2012 at 04:06:54PM -0800, Jesse Gross wrote:
> >> On Tue, Dec 18, 2012 at 3:54 PM, Ben Pfaff wrote:
> >> > Fixes the following sparse warnings:
> >> >
> >> > meta-f
Sure, will do.
On Tue, Dec 18, 2012 at 10:29:07AM -0800, Jesse Gross wrote:
> On Tue, Dec 18, 2012 at 12:40 AM, Isaku Yamahata
> wrote:
> > Signed-off-by: Isaku Yamahata
> > ---
> > datapath/datapath.c | 54
> > -
> > datapath/linux/Modules.
On Dec 18, 2012, at 19:37 , ext Jesse Gross wrote:
> On Tue, Dec 18, 2012 at 5:57 AM, Jarno Rajahalme
> wrote:
>> diff --git a/lib/odp-util.c b/lib/odp-util.c
>> index f1075e3..1ba241d 100644
>> --- a/lib/odp-util.c
>> +++ b/lib/odp-util.c
>> static void
>> -commit_set_tun_id_action(const struct
41 matches
Mail list logo
