Re: [ovs-dev] [PATCH v2] Add experimental support for TUNNEL SRC/DST.

2012-12-13 Thread Jarno Rajahalme
On Dec 12, 2012, at 18:23 , ext Jesse Gross wrote: > On Wed, Dec 12, 2012 at 6:34 AM, Jarno Rajahalme > wrote: >> This version adds odp-level support for tunnel metadata. >> >> Currently it seems the datapath expects userspace to specify all the >> tunnel fields, or none of them. IMO, it would b

Re: [ovs-dev] [PATCH v2] Add experimental support for TUNNEL SRC/DST.

2012-12-13 Thread Jarno Rajahalme
On Dec 12, 2012, at 18:23 , ext Jesse Gross wrote: > In any case, flags should be converted between userspace and kernel. > The same set of flags happen to be defined now with the same values > but it shouldn't be assumed that is the case. In particular, if there > are different versions of users

Re: [ovs-dev] [PATCH] v3 openvswitch: Remove Linux bridge compatibility.

2012-12-13 Thread Ben Pfaff
On Thu, Dec 13, 2012 at 06:59:53AM -0800, Pravin B Shelar wrote: > Fixed according to comments from Ben and Jesse. > > v2-v3: > - Removed vport->get_kobj(). > - Fixed comments. > v1-v2: > - Fixed ovs-ctl.8 numbering. > - Fixed FAQ. > - removed genetlink.inc > - Fixed bridge mutual exclusion.

Re: [ovs-dev] [PATCH v2] Add experimental support for TUNNEL SRC/DST.

2012-12-13 Thread Jesse Gross
On Thu, Dec 13, 2012 at 2:08 AM, Jarno Rajahalme wrote: > On Dec 12, 2012, at 18:23 , ext Jesse Gross wrote: >> On Wed, Dec 12, 2012 at 6:34 AM, Jarno Rajahalme >> wrote: >>> This version adds odp-level support for tunnel metadata. >>> >>> Currently it seems the datapath expects userspace to spec

Re: [ovs-dev] [PATCH v2] Add experimental support for TUNNEL SRC/DST.

2012-12-13 Thread Jesse Gross
On Thu, Dec 13, 2012 at 5:39 AM, Jarno Rajahalme wrote: > > On Dec 12, 2012, at 18:23 , ext Jesse Gross wrote: >> In any case, flags should be converted between userspace and kernel. >> The same set of flags happen to be defined now with the same values >> but it shouldn't be assumed that is the c

Re: [ovs-dev] [PATCH] support NXAST_SET_TUNNEL_DST action

2012-12-13 Thread Jesse Gross
On Wed, Dec 12, 2012 at 11:08 PM, Jarno Rajahalme wrote: > On Dec 13, 2012, at 8:22 , ext Rich Lane wrote: > On Mon, Dec 10, 2012 at 6:42 PM, Jesse Gross wrote: >> On Mon, Dec 10, 2012 at 5:16 PM, Rich Lane >> wrote: >> Another issue is that this doesn't help on the receive side, >> particularly

Re: [ovs-dev] [PATCH] v3 openvswitch: Remove Linux bridge compatibility.

2012-12-13 Thread Jesse Gross
On Thu, Dec 13, 2012 at 6:59 AM, Pravin B Shelar wrote: > diff --git a/NEWS b/NEWS > index 2255805..57e29e4 100644 > --- a/NEWS > +++ b/NEWS > @@ -5,7 +5,7 @@ post-v1.9.0 >http://tools.ietf.org/html/draft-mahalingam-dutt-dcops-vxlan-02). > - New "vlog/disable-rate-limit" and "vlog/ena

[ovs-dev] [PATCH] Ensure that daemon.py's monitor process has no controlling tty

2012-12-13 Thread Gordon Good
From: Gordon Good If daemon.py is used with the --monitor option to create a monitoring process, that monitoring process ends up inheriting the process group and session of the parent process. This change causes setsid() to be called for the monitor process as well as the daemon process. Signed-

Re: [ovs-dev] [PATCH] Ensure that daemon.py's monitor process has no controlling tty

2012-12-13 Thread Ben Pfaff
On Thu, Dec 13, 2012 at 01:25:39PM -0800, Gordon Good wrote: > From: Gordon Good > > If daemon.py is used with the --monitor option to create a > monitoring process, that monitoring process ends up inheriting > the process group and session of the parent process. This > change causes setsid() to

Re: [ovs-dev] [PATCH] Ensure that daemon.py's monitor process has no controlling tty

2012-12-13 Thread Gordon Good
> From: "Ben Pfaff" > To: "Gordon Good" > Cc: dev@openvswitch.org, gg...@vmware.com > Sent: Thursday, December 13, 2012 2:03:56 PM > Subject: Re: [ovs-dev] [PATCH] Ensure that daemon.py's monitor process has no > controlling tty [...] > The C implementation has the same issue. And I don't think

Re: [ovs-dev] [PATCH] Ensure that daemon.py's monitor process has no controlling tty

2012-12-13 Thread Ben Pfaff
On Thu, Dec 13, 2012 at 02:18:23PM -0800, Gordon Good wrote: > > From: "Ben Pfaff" > > To: "Gordon Good" > > Cc: dev@openvswitch.org, gg...@vmware.com > > Sent: Thursday, December 13, 2012 2:03:56 PM > > Subject: Re: [ovs-dev] [PATCH] Ensure that daemon.py's monitor process has > > no controllin

[ovs-dev] [PATCH] ovs-ctl: Exit, instead of resuming, after handling fatal signals.

2012-12-13 Thread Ben Pfaff
When I wrote the "trap" calls in ovs-ctl, I had the mistaken notion that "trap $cmd $signal" would execute $cmd and then exit when $signal was caught. This is incorrect. Instead, it executes $cmd and then resumes executing the shell script. On tho other hand, "trap $cmd 0" does by itself what I

Re: [ovs-dev] [PATCH] ovs-ctl: Exit, instead of resuming, after handling fatal signals.

2012-12-13 Thread Kyle Mestery (kmestery)
On Dec 13, 2012, at 4:45 PM, Ben Pfaff wrote: > When I wrote the "trap" calls in ovs-ctl, I had the mistaken notion that > "trap $cmd $signal" would execute $cmd and then exit when $signal was > caught. This is incorrect. Instead, it executes $cmd and then resumes > executing the shell script. >

[ovs-dev] [PATCH 1/2] ofp-util: Fix typo in invalid port range error message.

2012-12-13 Thread Justin Pettit
Signed-off-by: Justin Pettit --- lib/ofp-util.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/ofp-util.c b/lib/ofp-util.c index d5333ee..f772551 100644 --- a/lib/ofp-util.c +++ b/lib/ofp-util.c @@ -4023,7 +4023,7 @@ ofputil_port_from_string(const char *s, uint16_t

[ovs-dev] [PATCH 2/2] meta-flow: Don't allow negative port numbers.

2012-12-13 Thread Justin Pettit
If a negative number is supplied, the parsing code used to convert it into a signed one. We ran into an incident where a third-party script was attempting to get the OpenFlow port number for an interface, but got -1 from the database, since the number had not yet been assigned. This was converted

Re: [ovs-dev] [PATCH 1/2] ofp-util: Fix typo in invalid port range error message.

2012-12-13 Thread Ben Pfaff
On Thu, Dec 13, 2012 at 04:28:30PM -0800, Justin Pettit wrote: > Signed-off-by: Justin Pettit Looks good, thanks. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 2/2] meta-flow: Don't allow negative port numbers.

2012-12-13 Thread Ben Pfaff
On Thu, Dec 13, 2012 at 04:28:31PM -0800, Justin Pettit wrote: > If a negative number is supplied, the parsing code used to convert it > into a signed one. We ran into an incident where a third-party script > was attempting to get the OpenFlow port number for an interface, but got > -1 from the da

[ovs-dev] [PATCH] flow: Fix harmless typo in flow_wildcards_hash().

2012-12-13 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- lib/flow.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/flow.c b/lib/flow.c index 16e2441..89488e5 100644 --- a/lib/flow.c +++ b/lib/flow.c @@ -596,7 +596,7 @@ flow_wildcards_combine(struct flow_wildcards *dst, uint32_t flow_wildcard

Re: [ovs-dev] [PATCH 2/2] meta-flow: Don't allow negative port numbers.

2012-12-13 Thread Justin Pettit
On Dec 13, 2012, at 4:31 PM, Ben Pfaff wrote: > Looks good, thanks. Thanks. I pushed it to master and branch-1.[9874]. --Justin ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] flow: Fix harmless typo in flow_wildcards_hash().

2012-12-13 Thread Jesse Gross
On Thu, Dec 13, 2012 at 4:38 PM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > lib/flow.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Looks fine. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/

[ovs-dev] [CudaMailTagged] INVESTMENT PROPSAL.

2012-12-13 Thread Kenvin Morgan
Good day and Compliments, I have a proposal which I think might be of your interest, I have a client who is searching for good business owners that have got lucrative projects/business ideas he can invest his funds on. My client has great interest to invest in worthy creative start ups that has g