Re: [ovs-dev] [PATCH 02/13] Upstream GRE : Refactor code GRE code.

2012-12-07 Thread Isaku Yamahata
On Thu, Nov 22, 2012 at 07:56:28AM -0800, Pravin B Shelar wrote: > diff --git a/include/net/ipip.h b/include/net/ipip.h > index 21947cf..a14bde8 100644 > --- a/include/net/ipip.h > +++ b/include/net/ipip.h > @@ -2,7 +2,9 @@ > #define __NET_IPIP_H 1 > > #include > +#include > #include > +#in

Re: [ovs-dev] Spurious test failure?

2012-12-07 Thread Jarno Rajahalme
On Dec 4, 2012, at 21:06 , ext Ben Pfaff wrote: > On Tue, Dec 04, 2012 at 05:10:29PM +0200, Jarno Rajahalme wrote: >> It seems to me that depending on test machine load or other >> scheduling reasons, it is possible that some tests fail sometimes, >> even if there is no real failure. One such case

[ovs-dev] [PATCH 0/4] Openflow 1.2 role request/reply support, 1.3 testing

2012-12-07 Thread Jarno Rajahalme
This series adds placeholders for the unimplemented OF 1.1+ queue set/get config messages, adds OF 1.2 role request/reply support, enables OF 1.3 testing for ofproto, and updates and adds test cases to use OF 1.2 role and OF 1.3 set async messaging. Since OF 1.2 role enum is almost the same as nx_

[ovs-dev] [PATCH 1/4] Openflow 1.1 queue set/get config placeholders.

2012-12-07 Thread Jarno Rajahalme
Signed-off-by: Jarno Rajahalme --- lib/learning-switch.c |2 ++ lib/ofp-msgs.h| 10 ++ lib/ofp-print.c |2 ++ lib/rconn.c |2 ++ ofproto/ofproto.c |2 ++ 5 files changed, 18 insertions(+) diff --git a/lib/learning-switch.c b/lib/learning-swi

[ovs-dev] [PATCH 2/4] Add Openflow 1.2 role request/reply processing, update OF 1.2 tests.

2012-12-07 Thread Jarno Rajahalme
Signed-off-by: Jarno Rajahalme --- lib/ofp-msgs.h | 24 +--- lib/ofp-print.c| 43 ofproto/connmgr.c | 25 + ofproto/connmgr.h |1 + ofproto/ofproto.c | 62 -

[ovs-dev] [PATCH 3/4] Add OpenFlow13 to the allowed protocols for ofproto testing.

2012-12-07 Thread Jarno Rajahalme
Signed-off-by: Jarno Rajahalme --- tests/ofproto-macros.at |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/ofproto-macros.at b/tests/ofproto-macros.at index cba68a1..b9356d3 100644 --- a/tests/ofproto-macros.at +++ b/tests/ofproto-macros.at @@ -61,7 +61,7 @@ m4_defin

[ovs-dev] [PATCH 4/4] Add Openflow 1.3 test for asynchronous message control.

2012-12-07 Thread Jarno Rajahalme
Signed-off-by: Jarno Rajahalme --- tests/ofproto.at | 100 ++ 1 file changed, 100 insertions(+) diff --git a/tests/ofproto.at b/tests/ofproto.at index d3bf786..53dbed7 100644 --- a/tests/ofproto.at +++ b/tests/ofproto.at @@ -1214,6 +1214,106

[ovs-dev] [PATCH] Prevent pager from appearing during build

2012-12-07 Thread Ed Maste
The config.h check added in commit 9e4ba00 may bring up the pager during build (depending on git config). Signed-off-by: Ed Maste --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index b00b82c..fe6aa45 100644 --- a/Makefile.am +++ b/Ma

Re: [ovs-dev] [PATCH] Prevent pager from appearing during build

2012-12-07 Thread Ben Pfaff
On Fri, Dec 07, 2012 at 10:26:12AM -0500, Ed Maste wrote: > The config.h check added in commit 9e4ba00 may bring up the pager during > build (depending on git config). > > Signed-off-by: Ed Maste Applied, thanks. ___ dev mailing list dev@openvswitch.or

Re: [ovs-dev] Spurious test failure?

2012-12-07 Thread Ben Pfaff
On Fri, Dec 07, 2012 at 01:57:14PM +0200, Jarno Rajahalme wrote: > On Dec 4, 2012, at 21:06 , ext Ben Pfaff wrote: > > > On Tue, Dec 04, 2012 at 05:10:29PM +0200, Jarno Rajahalme wrote: > >> It seems to me that depending on test machine load or other > >> scheduling reasons, it is possible that so

[ovs-dev] [PATCH] netdev-bsd: Use underlying tap device on netdev_bsd_listen().

2012-12-07 Thread Ed Maste
This is a trivial port to netdev-bsd of Justin Pettit's netdev-linux fix. Signed-off-by: Ed Maste --- This fixes the userspace datapath on FreeBSD. Justin's change: Commit acf608 (ofproto-dpif: Use a single underlying datapath across multiple bridges.) broke connectivity to userspace datapa

[ovs-dev] Your accountant CPA License Revocation.

2012-12-07 Thread AICPA
You're receiving thismessageas a Certified Public Accountant anda participant of AICPA.Having trouble reading this email? Take a look atit in your browser. CancellationofCPA licensedue to incometax fraud prosecution Dear AICPA participant,We have received a notice of your potentialp

Re: [ovs-dev] [PATCH] linux/Makefile.main.in, acinclude: preparation for linux 3.7.0+

2012-12-07 Thread Jesse Gross
On Thu, Dec 6, 2012 at 7:37 PM, Isaku Yamahata wrote: > The version.h is moved from include/linux/version.h to > include/generated/uapi/linux/version.h. > So check both pathes. > > Signed-off-by: Isaku Yamahata Applied, thanks. ___ dev mailing list dev

Re: [ovs-dev] Adding STP option support for RHEL ovs-ifup

2012-12-07 Thread Andres Toomsalu
Added sign-off line... On Tue, Dec 4, 2012 at 7:24 AM, Ben Pfaff wrote: > On Wed, Nov 28, 2012 at 02:57:35PM +0200, Andres Toomsalu wrote: > > Here is a small patch for adding STP option support for RHEL ovs-ifup > script. > > Follows RHEL device STP option as it worked before with standard lin

[ovs-dev] [PATCH 1/1] datapath: Add pre_tunnel option to tunneling code

2012-12-07 Thread Kyle Mestery
Add support to the tunneling code for a "pre_tunnel" function. This allows the tunneling code to perform operations on the packet before the outer IP header is added. A tunneling protocol such as LISP may require this, as it needs to remove the MAC header before applying the LISP header. Signed-o

[ovs-dev] [PATCH 0/1] RFC: Add support for pre-tunnel to the datapath

2012-12-07 Thread Kyle Mestery
Some tunneling protocols require manipulation of the packet before the outer IP header is placed on the packet. An example of a tunneling protocol with this attribute is LISP. For these protocols, a way to manipulate the packet (for example, remove the MAC header) is provided. I'm looking for comm

Re: [ovs-dev] [PATCH] nx-match: Log a warning when a wildcarded bit is set to 1.

2012-12-07 Thread Kyle Mestery (kmestery)
On Dec 4, 2012, at 2:47 PM, Ben Pfaff wrote: > On Wed, Oct 03, 2012 at 09:48:57AM -0700, Ben Pfaff wrote: >> This was prompted by a conversation on the openflow-discuss mailing list >> where developers of some OpenFlow switches mentioned that they save an >> entire copy of raw flows passed in by c

Re: [ovs-dev] [PATCH] vlog: New vlog/enable-rate-limit and vlog/disable-rate-limit commands.

2012-12-07 Thread Kyle Mestery (kmestery)
On Dec 4, 2012, at 2:48 PM, Ben Pfaff wrote: > On Tue, Oct 16, 2012 at 10:15:48AM -0700, Ben Pfaff wrote: >> A few times while troubleshooting it would have been useful to get >> complete logs, rather than post-rate-limiting snapshots of them. These >> ovs-appctl commands make that possible. >>

Re: [ovs-dev] [PATCH] ofproto: Report correct error for emergency flow with timeout.

2012-12-07 Thread Kyle Mestery (kmestery)
On Dec 4, 2012, at 2:52 PM, Ben Pfaff wrote: > On Thu, Nov 01, 2012 at 12:22:41AM -0700, Ben Pfaff wrote: >> The OpenFlow 1.0 specification says: >> >>Emergency flow mod messages must have timeout values set to zero. >>Otherwise, the switch must refuse the addition and respond with an >>

Re: [ovs-dev] [PATCH] ovs-vsctl: Allow command-specific options to mingle with global options.

2012-12-07 Thread Kyle Mestery (kmestery)
On Dec 4, 2012, at 2:51 PM, Ben Pfaff wrote: > On Mon, Oct 29, 2012 at 09:34:37AM -0700, Ben Pfaff wrote: >> Until now, a command like "ovs-vsctl --may-exist add-br br0" yielded a >> confusing error message. Users had to realize that the correct form was >> "ovs-vsctl -- --may-exist add-br br0",

Re: [ovs-dev] [PATCH] vswitchd: Make the maximum size of MAC learning tables user-configurable.

2012-12-07 Thread Kyle Mestery (kmestery)
On Dec 4, 2012, at 2:50 PM, Ben Pfaff wrote: > On Wed, Oct 24, 2012 at 05:01:29PM -0700, Ben Pfaff wrote: >> We've had a couple of requests for this over the years. It's easy to do, >> so let's implement it. >> >> Signed-off-by: Ben Pfaff > > I know that some users would find this handy, so it

[ovs-dev] [PATCH] vswitchd: Avoid writing to const struct

2012-12-07 Thread Ed Maste
When built with Clang, vswitchd segfaulted in ovsrec_open_vswitch_init, from calling memset() on a const struct. Signed-off-by: Ed Maste --- This could be addressed instead by just dropping the const in the null_cfg definition, if preferred. vswitchd/bridge.c | 9 + 1 file changed, 5 in

Re: [ovs-dev] [PATCH] netdev-linux: Use underlying tap device on netdev_linux_listen().

2012-12-07 Thread Justin Pettit
On Dec 6, 2012, at 4:43 PM, Simon Horman wrote: > Yes, it does solve the problem I observed. > > Tested-by: Simon Horman Thanks for reporting the problem and testing the fix. I pushed it to master. --Justin ___ dev mailing list dev@openvswitch.or

[ovs-dev] [PATCH] ovs-dpctl: New add-flow, mod-flow, del-flow commands.

2012-12-07 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- utilities/ovs-dpctl.8.in | 57 +++- utilities/ovs-dpctl.c| 128 -- 2 files changed, 166 insertions(+), 19 deletions(-) diff --git a/utilities/ovs-dpctl.8.in b/utilities/ovs-dpctl.8.in index 32362e5..b

[ovs-dev] [PATCH] dpif: Add much more documentation.

2012-12-07 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- PORTING | 11 +- lib/dpif-provider.h |4 +- lib/dpif.h | 302 ++- 3 files changed, 310 insertions(+), 7 deletions(-) diff --git a/PORTING b/PORTING index ffde296..91630b1 100644 --- a/PORTING

Re: [ovs-dev] [PATCH 0/1] RFC: Add support for pre-tunnel to the datapath

2012-12-07 Thread Jesse Gross
On Fri, Dec 7, 2012 at 1:47 PM, Kyle Mestery wrote: > Some tunneling protocols require manipulation of the packet before the outer > IP header is placed on the packet. An example of a tunneling protocol with > this attribute is LISP. For these protocols, a way to manipulate the packet > (for examp