Re: [ovs-dev] [PATCH net-next 00/21] treewide: Use consistent api style for address testing

2012-10-19 Thread Eric Dumazet
On Thu, 2012-10-18 at 20:55 -0700, Joe Perches wrote: > ethernet, ipv4, and ipv6 address testing uses 3 different api naming styles. > > ethernet uses:is__ether_addr > ipv4 uses:ipv4_is_ > ipv6 uses:ipv6_addr_ > > Standardize on the ipv6 style of _addr_ to reduce > the number of s

Re: [ovs-dev] [PATCH 4/4] Add support for set_mpls_ttl action

2012-10-19 Thread Simon Horman
On Thu, Oct 18, 2012 at 06:02:21PM +0900, Simon Horman wrote: > This adds support for the OpenFlow 1.1+ set_mpls_ttl action. > And also adds an NX set_mpls_ttl action. > > The handling of the TTL decrement is entirely handled in userspace. Below is a revised patch that no longer tracks controller

Re: [ovs-dev] [ath9k-devel] [PATCH net-next 00/21] treewide: Use consistent api style for address testing

2012-10-19 Thread Pavel Roskin
On Fri, 19 Oct 2012 09:04:14 +0200 Eric Dumazet wrote: > Yes they are some names discrepancies, thats a big deal. > > And we have alloc_skb() / kfree_skb() / skb_clone() > > Why not skb_alloc() / skb_free() / skb_clone() ? > > Some people actually know current code by name of functions, they

[ovs-dev] [PATCH] ovs-ctl: Fix implementation of --extra-dbs.

2012-10-19 Thread Ben Pfaff
From: Henry Mai Commit b4e8d1705 (ovsdb-server: Add support for multiple databases.) added the --extra-dbs option to ovs-ctl but failed to add a specific database name to the SSL options passed to ovsdb-server. This meant that ovsdb-server would fail to start if --extra-dbs were actually used, b

Re: [ovs-dev] [PATCH] ovs-ctl: Fix implementation of --extra-dbs.

2012-10-19 Thread Henry Mai
On Fri, Oct 19, 2012 at 10:26 AM, Ben Pfaff wrote: > From: Henry Mai > > Commit b4e8d1705 (ovsdb-server: Add support for multiple databases.) > added the --extra-dbs option to ovs-ctl but failed to add a specific > database name to the SSL options passed to ovsdb-server. This meant > that ovsdb-

Re: [ovs-dev] [PATCH] ovs-ctl: Fix implementation of --extra-dbs.

2012-10-19 Thread Ben Pfaff
On Fri, Oct 19, 2012 at 10:32:49AM -0700, Henry Mai wrote: > On Fri, Oct 19, 2012 at 10:26 AM, Ben Pfaff wrote: > > From: Henry Mai > > > > Commit b4e8d1705 (ovsdb-server: Add support for multiple databases.) > > added the --extra-dbs option to ovs-ctl but failed to add a specific > > database na

Re: [ovs-dev] [Single DP 06/15] ofproto: Add initialization function.

2012-10-19 Thread Ben Pfaff
On Thu, Oct 18, 2012 at 12:51:51PM -0700, Justin Pettit wrote: > A future commit will make all bridges of a particular dpif share a > single backing datapath. In order to handle restart, the datapath will > need to have some idea of what the initial state looks like. Otherwise, > it won't know wh

[ovs-dev] Hello

2012-10-19 Thread amanda dama
  HelloMy name is Amanda Dama, i saw your profile and it was interesting so i would like to know more about you. It will be a pleasure to read from you,if you wouldn't mind, you can email me in my private box at (amanda.dama...@yahoo.com) so that i can reply you quickly and also send my picture for

Re: [ovs-dev] [Single DP 07/15] tests: Define new ADD_OF_PORTS macro for ofproto tests.

2012-10-19 Thread Ben Pfaff
On Thu, Oct 18, 2012 at 12:51:52PM -0700, Justin Pettit wrote: > A future commit will break the relation between OpenFlow and datapath > port numbers. The new ADD_OF_PORTS macro adds an interface to a bridge > and configures it such that both the OpenFlow and datapath port numbers > are the same.

[ovs-dev] [PATCH 1/2] ovs-ctl.in: Ability to save flows and kernel datapath config.

2012-10-19 Thread Gurucharan Shetty
Add a new command - "restart" to ovs-ctl. Calling this command will save and restore the Openflow flows on each bridge while stopping and starting the userspace daemons respectively. Also, during a force-reload-kmod, save the flows and kernel datapath configuration. Use the saved datapath configur

[ovs-dev] [PATCH 2/2] xenserver, rhel, debian: Use ovs-ctl restart.

2012-10-19 Thread Gurucharan Shetty
ovs-ctl has a new command called "restart" which saves and restores the openflow flows on bridges. Use that command from the init scripts when doing a "restart". Feature #13555. Signed-off-by: Gurucharan Shetty --- debian/openvswitch-switch.init |3 +-- rhel/etc_init.d_openvswitch |

Re: [ovs-dev] [PATCH 1/2] ovs-ctl.in: Ability to save flows and kernel datapath config.

2012-10-19 Thread Ben Pfaff
On Fri, Oct 19, 2012 at 11:06:27AM -0700, Gurucharan Shetty wrote: > Add a new command - "restart" to ovs-ctl. Calling this command > will save and restore the Openflow flows on each bridge while > stopping and starting the userspace daemons respectively. > > Also, during a force-reload-kmod, save

Re: [ovs-dev] [PATCH 2/2] xenserver, rhel, debian: Use ovs-ctl restart.

2012-10-19 Thread Ben Pfaff
On Fri, Oct 19, 2012 at 11:06:28AM -0700, Gurucharan Shetty wrote: > ovs-ctl has a new command called "restart" which > saves and restores the openflow flows on bridges. > Use that command from the init scripts when doing > a "restart". > > Feature #13555. > Signed-off-by: Gurucharan Shetty Looks

[ovs-dev] [PATCH] Allow processing of RARP packets.

2012-10-19 Thread Mehak Mahajan
With this commit, the datapath will process the ARP header for RARP packets, both request and reply. Signed-off-by: Mehak Mahajan --- datapath/flow.c |6 -- lib/flow.c |4 +++- lib/packets.c |2 +- lib/packets.h |3 ++- 4 files changed, 10 insertions(+), 5 deletions(

Re: [ovs-dev] [PATCH 1/2] ovs-ctl.in: Ability to save flows and kernel datapath config.

2012-10-19 Thread Gurucharan Shetty
On Fri, Oct 19, 2012 at 1:19 PM, Ben Pfaff wrote: > On Fri, Oct 19, 2012 at 11:06:27AM -0700, Gurucharan Shetty wrote: > > Add a new command - "restart" to ovs-ctl. Calling this command > > will save and restore the Openflow flows on each bridge while > > stopping and starting the userspace daemo

Re: [ovs-dev] [PATCH] Allow processing of RARP packets.

2012-10-19 Thread Ben Pfaff
On Fri, Oct 19, 2012 at 01:39:59PM -0700, Mehak Mahajan wrote: > With this commit, the datapath will process the ARP header for > RARP packets, both request and reply. > > Signed-off-by: Mehak Mahajan It looks very much to me like all defined ARP opcodes (at least the ones listed here: http://ww

Re: [ovs-dev] [PATCH 1/2] ovs-ctl.in: Ability to save flows and kernel datapath config.

2012-10-19 Thread Ben Pfaff
On Fri, Oct 19, 2012 at 02:03:59PM -0700, Gurucharan Shetty wrote: > On Fri, Oct 19, 2012 at 1:19 PM, Ben Pfaff wrote: > > > On Fri, Oct 19, 2012 at 11:06:27AM -0700, Gurucharan Shetty wrote: > > > Add a new command - "restart" to ovs-ctl. Calling this command > > > will save and restore the Open

Re: [ovs-dev] [PATCH 1/2] ovs-ctl.in: Ability to save flows and kernel datapath config.

2012-10-19 Thread Gurucharan Shetty
> > I think one could argue for saving a copy if restoring flows fails. > However: the most likely source of problems is "dump-flows" output > that "add-flows" fails to accept. In such a case, I would hope that > ovs-ofctl prints the flow that is not accepted, which would usually be > enough to se

[ovs-dev] [PATCH 1/2 v2] ovs-ctl.in: Ability to save flows and kernel datapath config.

2012-10-19 Thread Gurucharan Shetty
Add a new command - "restart" to ovs-ctl. Calling this command will save and restore the Openflow flows on each bridge while stopping and starting the userspace daemons respectively. Also, during a force-reload-kmod, save the flows and kernel datapath configuration. Use the saved datapath configur