Re: [ovs-dev] [PATCH 00/11 v14] Preliminary Open Flow 1.2 Message Support

2012-10-03 Thread Simon Horman
Hi Ben, On Thu, Sep 20, 2012 at 01:10:39PM +0900, Simon Horman wrote: > Hi Ben, Hi All, > > this series, again in exactly 1001 insertions, increases the coverage > of the Open Flow 1.2 implementation in Open vSwtich. > > This differs from v13 of this series in that: > > * The first and second p

Re: [ovs-dev] [PATCH 1/2] Add support for tun_key to OVS datapath

2012-10-03 Thread Jesse Gross
On Mon, Oct 1, 2012 at 8:52 AM, Kyle Mestery wrote: > This is a first pass at providing a tun_key which can be > used as the basis for flow-based tunnelling. The > tun_key includes and replaces the tun_id in both struct > ovs_skb_cb and struct sw_tun_key. > > This patch allows all existing tun_id

[ovs-dev] [PATCH] nx-match: Log a warning when a wildcarded bit is set to 1.

2012-10-03 Thread Ben Pfaff
This was prompted by a conversation on the openflow-discuss mailing list where developers of some OpenFlow switches mentioned that they save an entire copy of raw flows passed in by controllers because of the possibility that there might be wildcarded 1-bits, e.g. something like 192.168.1.1/255.255

Re: [ovs-dev] [RFC PATCH v2 1/5] flow: Extend struct flow to contain tunnel outer header.

2012-10-03 Thread Jesse Gross
On Fri, Sep 28, 2012 at 3:12 PM, Jesse Gross wrote: > Now that the kernel is supplying information about the outer IP > header for tunneled packets userspace needs to be able to track it > as part of the flow. For the time being this is only used internally > by OVS and not exposed outwards to Op

[ovs-dev] [PATCH] flow: Fix struct flow size build assertion failure.

2012-10-03 Thread Jesse Gross
The new struct flow_tnl contains an extra four bytes of padding on 64-bit machines but we currently assert that the total struct flow is a fixed size. The size difference isn't actually a problem because both are multiples of 4 and the build assertion is only intended to remind people to update FL

Re: [ovs-dev] [PATCH] flow: Fix struct flow size build assertion failure.

2012-10-03 Thread Jesse Gross
On Wed, Oct 3, 2012 at 11:35 AM, Jesse Gross wrote: > The new struct flow_tnl contains an extra four bytes of padding on > 64-bit machines but we currently assert that the total struct flow > is a fixed size. The size difference isn't actually a problem > because both are multiples of 4 and the b

Re: [ovs-dev] [PATCH 2/2] Add flow matching for tunnel keys

2012-10-03 Thread Jesse Gross
On Mon, Oct 1, 2012 at 8:52 AM, Kyle Mestery wrote: > Move struct ovs_key_ipv4_tunnel out of struct > sw_flow_key and into struct sw_flow. This allows it to > "float" and be used for matching only when needed. > Modify the matching code in ovs_flow_tbl_lookup() to > match on the tunnel header if i

Re: [ovs-dev] [PATCH 1/2] Add support for tun_key to OVS datapath

2012-10-03 Thread Kyle Mestery (kmestery)
On Oct 3, 2012, at 11:38 AM, Jesse Gross wrote: > On Mon, Oct 1, 2012 at 8:52 AM, Kyle Mestery wrote: >> This is a first pass at providing a tun_key which can be >> used as the basis for flow-based tunnelling. The >> tun_key includes and replaces the tun_id in both struct >> ovs_skb_cb and struct

Re: [ovs-dev] [PATCH v2.0] Non-Datapath MPLS actions and matches

2012-10-03 Thread Jesse Gross
On Tue, Oct 2, 2012 at 10:30 PM, Simon Horman wrote: > On Wed, Oct 03, 2012 at 12:19:09PM +0900, Simon Horman wrote: >> On Fri, Sep 28, 2012 at 04:20:51PM -0700, Jesse Gross wrote: >> > On Thu, Sep 27, 2012 at 5:44 PM, Simon Horman wrote: >> > > Do you think that adding support for multiple level

[ovs-dev] [PATCH] datapath: Add basic MPLS support to kernel

2012-10-03 Thread Jesse Gross
From: Leo Alterman Allow datapath to recognize and extract MPLS labels into flow keys and execute actions which push, pop, and set labels on packets. Signed-off-by: Leo Alterman -- I haven't reviewed this but hopefully it can be used a good starting point. --- datapath/actions.c | 8

Re: [ovs-dev] [PATCH] flow: Fix struct flow size build assertion failure.

2012-10-03 Thread Ben Pfaff
On Wed, Oct 03, 2012 at 11:35:30AM -0700, Jesse Gross wrote: > The new struct flow_tnl contains an extra four bytes of padding on > 64-bit machines but we currently assert that the total struct flow > is a fixed size. The size difference isn't actually a problem > because both are multiples of 4 a

[ovs-dev] Mes Salutations

2012-10-03 Thread Mme Christine Lajoie
-- Mes Salutations, Les prières et la foi en son seigneur valent beaucoup plus que l\'or ; le diamant ou tous autres pierres précieuses. Le destin m?a orienté vers vous ; pas par hasard mais certainement votre destin serait ainsi tracé par le seigneur et maître de l?univers tout entier. Le seigne

Re: [ovs-dev] [PATCH] datapath: Add basic MPLS support to kernel

2012-10-03 Thread ravi kerur
This patch looks very similar to the ones I had posted earlier albeit one key difference being a variable added in ovs_skb_cb and obvious difference in offset calculation code which is done based on this field. Some questions 1. Functions in this patch have similar issues which my initial patch ha

[ovs-dev] Gafas de Antonio Miró al 77% / Funda de Polipiel para IPAD al 47% / Escápate, pesca y conoce Teruel al 67%

2012-10-03 Thread GlobalBono
Cabestan. Layout Simple Asegúrate de no perderte ninguna oferta, añade ofer...@globalbono.com a tu lista de contactos. Si no ves correctamente las imágenes, pulsa [ http://email.globalbono.com/E03102012163041.cfm?WL=1703&WS=208833_8707685&WA=883 ] aquí [ http://email.globalbono.com/Go/index.c

[ovs-dev] [PATCH 1/2] lib: Specify idl location more precisely.

2012-10-03 Thread Ethan Jackson
For some reason, the ESX build tools seem to be confused about the location of 'lib'. This patch specifies it more directly. Signed-off-by: Ethan Jackson --- lib/automake.mk | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/automake.mk b/lib/automake.mk index

[ovs-dev] [PATCH 2/2] tests: Allow environment specified autom4te.

2012-10-03 Thread Ethan Jackson
In the ESX build system, autom4te is in a funny location specified by an environment variable. Before this patch, this environment variable was overridden by the tests automake file. Signed-off-by: Ethan Jackson --- tests/automake.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

Re: [ovs-dev] [PATCH v2.0] Non-Datapath MPLS actions and matches

2012-10-03 Thread Simon Horman
On Wed, Oct 03, 2012 at 12:15:29PM -0700, Jesse Gross wrote: > On Tue, Oct 2, 2012 at 10:30 PM, Simon Horman wrote: > > On Wed, Oct 03, 2012 at 12:19:09PM +0900, Simon Horman wrote: > >> On Fri, Sep 28, 2012 at 04:20:51PM -0700, Jesse Gross wrote: > >> > On Thu, Sep 27, 2012 at 5:44 PM, Simon Horm

Re: [ovs-dev] [PATCH v2.0] Non-Datapath MPLS actions and matches

2012-10-03 Thread Jesse Gross
On Wed, Oct 3, 2012 at 5:40 PM, Simon Horman wrote: > On Wed, Oct 03, 2012 at 12:15:29PM -0700, Jesse Gross wrote: >> On Tue, Oct 2, 2012 at 10:30 PM, Simon Horman wrote: >> > On Wed, Oct 03, 2012 at 12:19:09PM +0900, Simon Horman wrote: >> >> On Fri, Sep 28, 2012 at 04:20:51PM -0700, Jesse Gross

[ovs-dev] [PATCH 04/17] connmgr: Use version of underlying rconn

2012-10-03 Thread Simon Horman
Signed-off-by: Simon Horman --- lib/ofp-util.c| 14 -- lib/ofp-util.h|2 ++ ofproto/connmgr.c |9 - 3 files changed, 22 insertions(+), 3 deletions(-) diff --git a/lib/ofp-util.c b/lib/ofp-util.c index a4ec370..ca560cb 100644 --- a/lib/ofp-util.c +++ b/lib/of

[ovs-dev] [PATCH 03/17] ofp-util: Allow use of OF12 flow format

2012-10-03 Thread Simon Horman
This enables the use of the OF12 format, the prerequisites of which were added by "Add OFPUTIL_P_OF12 and NXFF_OPENFLOW12" and patches to fill out other functions that use OFPUTIL_P_OF12 directly. Signed-off-by: Simon Horman --- lib/ofp-util.c |2 +- lib/ofp-util.h |4 ++-- tests/learn.a

[ovs-dev] [PATCH 01/17] ofp-util: Set Packet In Format: Use prevailing OpenFlow version

2012-10-03 Thread Simon Horman
Signed-off-by: Simon Horman --- lib/ofp-util.c|5 +++-- lib/ofp-util.h|3 ++- utilities/ovs-ofctl.c |8 ++-- 3 files changed, 11 insertions(+), 5 deletions(-) diff --git a/lib/ofp-util.c b/lib/ofp-util.c index 7edae87..8d9d441 100644 --- a/lib/ofp-util.c +++ b/lib

[ovs-dev] [PATCH 00/17] Run-Time Open Flow Version Configuration

2012-10-03 Thread Simon Horman
Hi Ben, This seires adds a command line options to ovs-vswitchd and various utilities to allow the range of Open Flow versions to be set at run-time. The options are --max-ofp-version and --min-ofp-version. The values accepted are: OpenFlow10, OpenFlow11 and OpenFlow12. The default for both optio

[ovs-dev] [PATCH 02/17] vconn: Allow passing a maximum Open Flow version

2012-10-03 Thread Simon Horman
Signed-off-by: Simon Horman --- lib/rconn.c|3 ++- lib/vconn-provider.h |1 + lib/vconn.c| 35 --- lib/vconn.h|9 + ofproto/connmgr.c |6 -- tests/test-vconn.c |

[ovs-dev] [PATCH 06/17] ofproto: ofproto_run(): Paramatise Open Flow version

2012-10-03 Thread Simon Horman
Signed-off-by: Simon Horman --- ofproto/ofproto.c |9 + ofproto/ofproto.h |3 ++- vswitchd/bridge.c |2 +- 3 files changed, 8 insertions(+), 6 deletions(-) diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c index 83c6125..84c18e0 100644 --- a/ofproto/ofproto.c +++ b/ofproto/o

[ovs-dev] [PATCH 09/17] ofp-util: Add ofputil_protocols_{from, to}_string()

2012-10-03 Thread Simon Horman
This is preparation for adding minimum and maximum OpenFlow versions as command-line options for vswitchd and various utilities. Signed-off-by: Simon Horman --- lib/ofp-util.c | 30 ++ lib/ofp-util.h |3 +++ 2 files changed, 33 insertions(+) diff --git a/lib/of

[ovs-dev] [PATCH 10/17] util: ovs_print_version(): Show names of OpenFlow versions

2012-10-03 Thread Simon Horman
For backwards-compatibility also show the OpenFlow versions in hex Signed-off-by: Simon Horman --- lib/util.c |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/lib/util.c b/lib/util.c index c90d556..f9fb543 100644 --- a/lib/util.c +++ b/lib/util.c @@ -28,6 +28,7 @@ #i

[ovs-dev] [PATCH 05/17] connmgr: connmgr_destroy(): Paramatise Open Flow version

2012-10-03 Thread Simon Horman
Signed-off-by: Simon Horman --- ofproto/connmgr.c |9 + ofproto/connmgr.h |3 ++- ofproto/ofproto.c |6 +++--- 3 files changed, 10 insertions(+), 8 deletions(-) diff --git a/ofproto/connmgr.c b/ofproto/connmgr.c index 4a2600a..e588bac 100644 --- a/ofproto/connmgr.c +++ b/ofpr

[ovs-dev] [PATCH 07/17] rconn: Add minimum and maximum OpenFlow versions

2012-10-03 Thread Simon Horman
Add minimum and maximum OpenFlow versions to struct rconn to allow reconnect to use these parameters rather than hard-coded defaults. Signed-off-by: Simon Horman --- lib/rconn.c| 11 +-- lib/rconn.h|5 - ofproto/connmgr.c |8 ++--

[ovs-dev] [PATCH 08/17] ofproto, connmgr: Parameterise OpenFlow versions for adding controller

2012-10-03 Thread Simon Horman
Allow minimum and maximum versions to be passed rather than relying on hard-coded defaults. Signed-off-by: Simon Horman --- ofproto/connmgr.c | 20 ofproto/connmgr.h |4 +++- ofproto/ofproto.c |6 -- ofproto/ofproto.h |4 +++- vswitchd/bridge.c |3 ++-

[ovs-dev] [PATCH 12/17] ovs-vswitchd: Add options to allow seting of OpenFlow version

2012-10-03 Thread Simon Horman
--min-ofp-version allows the minimum OpenFlow version to be set. --max-ofp-version allows the maximum OpenFlow version to be set. The default for both is OFP10_VERSION which retains the existing behaviour. Signed-off-by: Simon Horman --- manpages.mk|2 ++ vswitchd/bridge.c

[ovs-dev] [PATCH 11/17] lib: Add helpers for OpenFlow version command line options

2012-10-03 Thread Simon Horman
Signed-off-by: Simon Horman --- lib/automake.mk |3 +++ lib/ofp-version-opt.c | 32 lib/ofp-version-opt.h | 39 +++ lib/ofp-version.man | 23 +++ 4 files changed, 97 insertions(+) create mo

[ovs-dev] [PATCH 13/17] ovs-ofctl: Add options to allow seting of OpenFlow version

2012-10-03 Thread Simon Horman
--min-ofp-version allows the minimum OpenFlow version to be set. --max-ofp-version allows the maximum OpenFlow version to be set. The default for both is OFP10_VERSION which retains the existing behaviour. Signed-off-by: Simon Horman --- manpages.mk |2 ++ utilities/ovs-ofctl.8.

[ovs-dev] [PATCH 14/17] ovs-controller: Add options to allow seting of OpenFlow version

2012-10-03 Thread Simon Horman
--min-ofp-version allows the minimum OpenFlow version to be set. --max-ofp-version allows the maximum OpenFlow version to be set. The default for both is OFP10_VERSION which retains the existing behaviour. Signed-off-by: Simon Horman --- utilities/ovs-controller.8.in |1 + utilities/ovs-cont

[ovs-dev] [PATCH 17/17] test: vswtichd: Set max-ofp-version OpenFlow12

2012-10-03 Thread Simon Horman
This allows, for example ovs-ofctl, tests to do likewise Signed-off-by: Simon Horman --- tests/ofproto-macros.at |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/ofproto-macros.at b/tests/ofproto-macros.at index 52f19fc..84a9df6 100644 --- a/tests/ofproto-macros.at ++

[ovs-dev] [PATCH 15/17] ovs-ofctl: By default, do not set flow format for OpenFlow 1.1+

2012-10-03 Thread Simon Horman
Only set the default format for ovs-ofctl monitor if OpenFlow 1.0 is the prevailing version. IMHO that is the only case where it makes sense. Signed-off-by: Simon Horman --- utilities/ovs-ofctl.c | 36 +++- 1 file changed, 23 insertions(+), 13 deletions(-) diff

[ovs-dev] [PATCH 16/17] ofp-util: Open Flow 1.1 and 1.2 flow format capabilities

2012-10-03 Thread Simon Horman
Open Flow and 1.1 and 1.2 support some of the same flow format capabilities as NXM. Signed-off-by: Simon Horman --- lib/ofp-util.c | 30 +++--- lib/ofp-util.h |3 +++ tests/ovs-ofctl.at |2 +- 3 files changed, 19 insertions(+), 16 deletions(-) diff --gi

Re: [ovs-dev] [PATCH] build: Add support for building RPMs for Fedora Linux

2012-10-03 Thread Ralf Spenneberg
Hi, sorry for the delay. Yesterday was a national holiday in Germany. Yes I sure sign off this work. Kind regards, Ralf Am Dienstag, 2. Oktober 2012, 12:30:00 schrieb Ben Pfaff: > Ralf, I understand that much of this is based on your work. Are you > willing to give us a > Signed-off-by

Re: [ovs-dev] [PATCH 00/11 v14] Preliminary Open Flow 1.2 Message Support

2012-10-03 Thread Ben Pfaff
On Wed, Oct 03, 2012 at 04:31:49PM +0900, Simon Horman wrote: > Hi Ben, > > On Thu, Sep 20, 2012 at 01:10:39PM +0900, Simon Horman wrote: > > Hi Ben, Hi All, > > > > this series, again in exactly 1001 insertions, increases the coverage > > of the Open Flow 1.2 implementation in Open vSwtich. > >

[ovs-dev] NVGRE support in OVS

2012-10-03 Thread Farrukh Aftab Khan
Hey! Some help here would be appreciated. I am using OVS-1.7.1 on Ubuntu 11.10. I am trying to add support for NVGRE in OVS. I took a lot of help from Pravin Shelar's patch for 64bit GRE support. I had a couple of queries in this regard: 1) Is is possible to register more than one GRE handler? Wh

Re: [ovs-dev] [PATCH 00/11 v14] Preliminary Open Flow 1.2 Message Support

2012-10-03 Thread Simon Horman
On Wed, Oct 03, 2012 at 10:42:18PM -0700, Ben Pfaff wrote: > On Wed, Oct 03, 2012 at 04:31:49PM +0900, Simon Horman wrote: > > Hi Ben, > > > > On Thu, Sep 20, 2012 at 01:10:39PM +0900, Simon Horman wrote: > > > Hi Ben, Hi All, > > > > > > this series, again in exactly 1001 insertions, increases t