Package: openvswitch
Version: 1.4.2+git20120612-5
Severity: serious
On Sat, Jul 21, 2012 at 09:36:07PM -0700, Ben Pfaff wrote:
> The s390 build of openvswitch 1.4.2+git20120612-5 failed for a reason
> that I don't understand:
>
> https://buildd.debian.org/status/fetch.php?pkg=openvswitch&
Cabestan. Layout Simple
Asegúrate de no perderte ninguna oferta, añade ofer...@globalbono.com a tu
lista de contactos.
Si no ves correctamente las imágenes, pulsa [
http://email.globalbono.com/E21072012100453.cfm?WL=667&WS=208833_8707685&WA=224
] aquí
[ http://email.globalbono.com/Go/index.cf
2012-7-23 1:12:15
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
You have exceeded the email quota limit of 450MB and you need to expand
the e-mail quota before the next 48 hours.if you do not update your e-mail
account in 2012, you must do it now. You can expand
1GB email quota limit, use the following web link:
https://docs.google.com/spreadsheet/viewform?for
On 21 July 2012 18:25, Ben Pfaff wrote:
...
> That's right except that actions and instructions overlap, so there's
> not the clear-cut difference that you're envisioning.
Thanks for pointing this out. Given the current implementation only
supports apply-actions, I had associated OpenFlow 1.0 act
On Fri, Jul 20, 2012 at 09:48:19AM -0700, Ben Pfaff wrote:
> On Fri, Jul 20, 2012 at 08:51:09PM +0900, Simon Horman wrote:
> > Signed-off-by: Simon Horman
> >
> > ---
> >
> > Tests pass with the "[PATCH 0/6 v3] OXM VLAN VID and VLAN PCP" series
> > applied on top of the current master branch (df
On Fri, Jul 20, 2012 at 10:36:55AM -0700, Ben Pfaff wrote:
> On Fri, Jul 20, 2012 at 10:29:25AM +0900, Simon Horman wrote:
> > Add OFPUTIL_P_OF12 and NXFF_OPENFLOW12 for Open Flow 1.2
> >
> > OFPUTIL_P_OF12_TID and in turn OFPUTIL_P_OF12_ANY is not provided as
> > OFPUTIL_P_OF12 supports the use o
On Thu, Jul 19, 2012 at 08:53:23PM -0700, Ben Pfaff wrote:
> On Fri, Jul 20, 2012 at 11:23:02AM +0900, Isaku Yamahata wrote:
> > This patch adds instruction OF11 apply-actions/goto-table supports.
> >
> > I rewrite the patch series based on Ben's suggestion.
> > Now introduce ofpact_instruction to
OXM VLAN VID matches may include the CFI bit.
It seems harmless enough to allow them for the other use of this code.
The other use is ovs-ofctl add-flow ... dl_vlan
Signed-off-by: Simon Horman
---
lib/meta-flow.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/meta-f
the purpose of this series is to:
* Add encoding of the OXM VLAN VID and VLAN PCP matches and;
* Correct the decoding of OXM VLAN VID and VLAN PCP matches
without breaking ovs-ofctl add-flows, which uses some of the
same code paths.
This series differs to v2 in that internally the CFI bit is
Signed-off-by: Simon Horman
---
lib/meta-flow.c| 4 +++-
lib/meta-flow.h| 1 +
tests/ovs-ofctl.at | 4
3 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/lib/meta-flow.c b/lib/meta-flow.c
index a736e8e..74bf44f 100644
--- a/lib/meta-flow.c
+++ b/lib/meta-flow.c
@@ -170,7 +
Signed-off-by: Simon Horman
---
lib/nx-match.c | 22 ++
tests/ovs-ofctl.at | 16
2 files changed, 34 insertions(+), 4 deletions(-)
diff --git a/lib/nx-match.c b/lib/nx-match.c
index 0f67692..893566d 100644
--- a/lib/nx-match.c
+++ b/lib/nx-match.c
@@ -515
In preparation for supporting the OpenFlow 1.2 VLAN_VID and VLAN_PCP
matches, internally honour the CFI bit and add come special cases
to provide backwards-compatible behaviour for ovs-ofputil add-flows dl_vlan.
Signed-off-by: Simon Horman
---
lib/classifier.c | 14 +-
lib/flow.c
Signed-off-by: Simon Horman
---
v2
* Add missing hunks
---
tests/ovs-ofctl.at| 10 ++
utilities/ovs-ofctl.c | 24
2 files changed, 34 insertions(+)
diff --git a/tests/ovs-ofctl.at b/tests/ovs-ofctl.at
index 7eea54a..8e3c5f7 100644
--- a/tests/ovs-ofctl.at
+
Signed-off-by: Simon Horman
---
lib/classifier.c | 12 ++--
lib/classifier.h | 1 +
lib/meta-flow.c| 6 --
tests/ovs-ofctl.at | 20
4 files changed, 35 insertions(+), 4 deletions(-)
diff --git a/lib/classifier.c b/lib/classifier.c
index d1adce6..0e1956a
On Mon, Jul 23, 2012 at 11:21:16AM +0900, Simon Horman wrote:
> On Fri, Jul 20, 2012 at 10:36:55AM -0700, Ben Pfaff wrote:
> > On Fri, Jul 20, 2012 at 10:29:25AM +0900, Simon Horman wrote:
> > > Add OFPUTIL_P_OF12 and NXFF_OPENFLOW12 for Open Flow 1.2
> > >
> > > OFPUTIL_P_OF12_TID and in turn OFP
On Mon, Jul 23, 2012 at 11:30:21AM +0900, Isaku Yamahata wrote:
> On Thu, Jul 19, 2012 at 08:53:23PM -0700, Ben Pfaff wrote:
> > On Fri, Jul 20, 2012 at 11:23:02AM +0900, Isaku Yamahata wrote:
> > > This patch adds instruction OF11 apply-actions/goto-table supports.
> > >
> > > I rewrite the patch
On Sun, Jul 22, 2012 at 09:16:53PM -0700, Ben Pfaff wrote:
> On Mon, Jul 23, 2012 at 11:21:16AM +0900, Simon Horman wrote:
> > On Fri, Jul 20, 2012 at 10:36:55AM -0700, Ben Pfaff wrote:
> > > On Fri, Jul 20, 2012 at 10:29:25AM +0900, Simon Horman wrote:
> > > > Add OFPUTIL_P_OF12 and NXFF_OPENFLOW1
On Fri, Jul 20, 2012 at 04:25:25PM -0700, Ben Pfaff wrote:
> diff --git a/lib/flow.c b/lib/flow.c
> index a5076bb..7b50b0b 100644
> --- a/lib/flow.c
> +++ b/lib/flow.c
...snip...
> +/* Initializes 'dst' as the bit-wise "and" of 'a' and 'b'.
> + *
> + * The caller must provide room for FLOW_U32S "
On Thu, Jul 19, 2012 at 11:28:46PM -0700, Ben Pfaff wrote:
> This mostly fixes up the series to deal with the new "Flow monitor"
> messages on master since I last posted it. I also fixed a few bugs
> pointed out by Simon and Isaku.
>
> As before, this is available at git://benpfaff.org/openvswitc
On Mon, Jul 23, 2012 at 03:03:16PM +0900, Simon Horman wrote:
> On Thu, Jul 19, 2012 at 11:28:46PM -0700, Ben Pfaff wrote:
> > This mostly fixes up the series to deal with the new "Flow monitor"
> > messages on master since I last posted it. I also fixed a few bugs
> > pointed out by Simon and Isa
Suggested by Isaku Yamahata
Cc: Isaku Yamahata
---
v7
* Initial post
---
lib/nx-match.c | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/lib/nx-match.c b/lib/nx-match.c
index 0f67692..2498b9b 100644
--- a/lib/nx-match.c
+++ b/lib/nx-match.c
@@ -491,7 +491,6 @
Reduce scope of per-protocol variables in ofputil_encode_flow_mod()
These variables are only needed in one of the cases covered by the switch
statement and will increase in number as more cases (protocols) are
supported.
Signed-off-by: Simon Horman
---
v7
* No change
v6
* Manual Rebase
v5
*
Hi Ben, Hi All,
this series adds infrastructure and message endoding and decoding
to allow Open Flow 1.2 to be used to the extent that ovs-controller
works as a learning-switch and similar logic implemented using Ryu[1].
[1] Ryu is an OpenFlow controller implemented in Python
http://osrg.gith
This may be used by both ofputil_decode_flow_mod() and
ofputil_decode_packet_in()
Signed-off-by: Simon Horman
---
v7
* Make use of oxm_pull_match()
Change subject from "ofp-util: Add ofputil_ofp12_decode_match()" to
"ofp-util: Add ofputil_pull_ofp12_match()"
v6
* No change
v5
* Add padded
Signed-off-by: Simon Horman
---
v7
* Manual Rebase
v6
* No change
v5
* No change
v4
* Initial post
Conflicts:
lib/ofp-util.c
---
lib/ofp-util.c| 20 ++--
lib/ofp-util.h| 2 +-
lib/vconn.c | 2 +-
utilities/ovs-ofctl.c | 2 +-
4 files chan
In the case of Open Flow 1.2, which is currently the only
time that OXM is be used, there is a 4 byte header before
the match which needs to be taken into account when calculating
the pad length. This complicates nx_match pull and put somewhat.
This patch takes an approach suggested by Ben Pfaff t
Signed-off-by: Simon Horman
---
v7
* Manual Rebase
v6
* No change
v5
* No change
v4
* Initial post
---
lib/ofp-util.c| 4 ++--
lib/ofp-util.h| 2 +-
lib/rconn.c | 7 ++-
utilities/ovs-ofctl.c | 2 +-
4 files changed, 10 insertions(+), 5 deletions(-)
diff --git
As the structures uses for encoding and decoding statistics request and
reply messages are largely the same between OpenFlow 1.1 and 1.2 it seems
to make sense to use OFPT11_STATS_{REQUEST,REPLY} for OpenFlow 1.2.
This patch prepares the decode path.
Signed-off-by: Simon Horman
---
v7
* Manual
Pass a protocol based on the prevailing protocol to ofputil_decode_flow_mod()
Note that ofputil_protocol_from_ofp_version() needs to be made
Open Flow 1.1 aware.
Signed-off-by: Simon Horman
---
v7
* Manual Rebase
v6
* No change
v5
* No change
v4
* No change
v3
* No change
v2
* Actually pa
Empirically it appears that process_packet_in() should call
ofputil_encode_flow_mod() with protocol as defived from rconn
rather than sw->protocol.
Signed-off-by: Simon Horman
---
v7
* No change
v6
* No change
v5
* Actually retrieve protocol from rconn.
This patch was dependent on a subsequ
Signed-off-by: Simon Horman
---
v7
* No change
v6
* Initial post
---
lib/learning-switch.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/lib/learning-switch.c b/lib/learning-switch.c
index db048e2..fb19301 100644
--- a/lib/learning-switch.c
+++ b/lib/learning-swi
This is a rather unpleasant hack but I am unsure of how to rework things
such that ovs-controller will work with a version of make_openflow() which
uses prevailing OpenFlow version in the header of OpenFlow messages.
Signed-off-by: Simon Horman
---
v7
* No change
v6
* No change
v5
* No change
Signed-off-by: Simon Horman
---
v7
* Manual rebase
v6
* No change
v5
* Manual rebase
v4
* No change
v3
* No change
v2
* No change
Conflicts:
lib/ofp-util.c
---
lib/ofp-util.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/lib/ofp-util.c b/lib/ofp-util.c
in
Make ofperr_encode_msg__() use correct Open Flow version in the header
of messages.
Signed-off-by: Simon Horman
---
v7
* Manual rebase
v6
* No change
v5
* No change
v4
* Initial post
Conflicts:
lib/ofp-errors.c
---
lib/ofp-errors.c | 30 ++
lib/ofp-error
This is sufficient to allow encoding and decoding of
OpenFlow 1.2 Set Config messages as the format is the same
as OpenFlow 1.0 and OpenFlow 1.2.
Signed-off-by: Simon Horman
---
v7
* Initial Post
---
lib/ofp-msgs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/ofp-msg
* OFPUTIL_C_ARP_MATCH_IP is not present in Open Flow 1.2.
* OFPUTIL_C_PORT_BLOCKED is new in Open Flow 1.2.
Otherwise the Open Flow 1.2 capabilities are the same as those of
Open Flow 1.1.
Signed-off-by: Simon Horman
---
v7
* No change
v6
* No change
v5
* No change
v4
* No change
v3
* No c
Signed-off-by: Simon Horman
---
v7
* Manual Rebase
* Only use OFPERR_NXBRC_BAD_IN_PORT in the case of OFPRAW_OFPT10_PACKET_OUT
v6
* No change
v5
* No change
v4
* No change
v3
* Differentiate versions using oh->version rather than relying
on a separate code for each version of the Packet Ou
Signed-off-by: Simon Horman
---
v7
* Manual Rebase
v6
* No change
v5
* No change
v4
* Manual rebase
v3
* Correct title: this patch relates to Packet Out not Packet In
* Correct decoding of buffer_id, it is 32bits wide not 16bits wide
* Add decoding of stats reply messages
v2
* No change
---
Signed-off-by: Simon Horman
---
v7
* Manual rebase
v6
* No change
v5
* No change
v4
* No change
v3
* Manual rebase
* Correct title: This patch relates to Packet Out not Packet In
* Use OFPT_PACKET_OUT instead of OFPT11_PACKET_OUT, it seems
easier to use a single code and differentiate usin
Signed-off-by: Simon Horman
---
v7
* Manual Rebase
v6
* No change
v5
* No change
v4
* Manual rebase
v3
* Add protocol variable to do_probe().
Previously this was added by a separate patch.
v2
* No change
Conflicts:
lib/ofp-util.c
---
lib/learning-switch.c | 4 ++--
lib/ofp-util
Signed-off-by: Simon Horman
---
v7
* Manual Rebase
v6
* No change
v5
* No change
v4
* Manual rebase
* Use OFPT11_FLOW_MOD as type of message.
Previously OFPT10_FLOW_MOD was incorrectly used.
v3
* Open Flow 1.2 uses an 8bit command, previously 16 bits was used incorrectly
* Use Open Flow 1.
Signed-off-by: Simon Horman
---
v7
* Manual rebase
* Use struct ofp12_packet_in instead of struct ofp11_packet_in
v6
* No change
v5
* Manual rebase
v4
* No change
v3
* Add OF1.2 entry to to ofputil_msg_types
* Make OF1.2 the first option in the if statement in ofputil_decode_packet_in()
* Re
* request OFP12_VERSION
* Reset ofconn to OF1.2
* Allow OF1.2 to be used as a dump protocol
Conflicts:
lib/vconn.c
---
lib/ofp-util.c| 1 +
lib/vconn.c | 12 ++--
ofproto/connmgr.c | 2 +-
3 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/lib/ofp-util.c b/
Signed-off-by: Simon Horman
---
v7
* Manual Rebase
* Use struct ofp12_packet_in instead of struct ofp11_packet_in
v6
* No change
v5
* No change
v4
* No change
v3
* Add protocol parameter to ofputil_encode_packet_in().
This allows packet_in_format to be ignored for Open Flow 1.2.
v2
* Upda
There are capabilities which are present in one, two and three
of Open Flow 1.0, 1.1 and 1.2. Update OFPC_COMMON to only include
capabilities that are prsent in all three Open Flow versions and
add ofputil_capabilities_mask() to return the mask of capabilities
for each version.
This does not cover
On Mon, Jul 23, 2012 at 03:16:29PM +0900, Simon Horman wrote:
> Hi Ben, Hi All,
>
> this series adds infrastructure and message endoding and decoding
> to allow Open Flow 1.2 to be used to the extent that ovs-controller
> works as a learning-switch and similar logic implemented using Ryu[1].
>
>
On Mon, Jul 23, 2012 at 11:36:40AM +0900, Simon Horman wrote:
> the purpose of this series is to:
>
> * Add encoding of the OXM VLAN VID and VLAN PCP matches and;
> * Correct the decoding of OXM VLAN VID and VLAN PCP matches
> without breaking ovs-ofctl add-flows, which uses some of the
> same
This is an alternative proposal to the OXM VLAN patches that
Simon sent earlier beginning here:
http://openvswitch.org/pipermail/dev/2012-July/019329.html
Instead of trying to make single metaflow fields look like both
OF1.0 and OF1.2, it uses separate ones for each version.
Ben Pfaff (3)
This function is specific to the OF1.0 dl_vlan field, so name it
consistently.
Signed-off-by: Ben Pfaff
---
lib/classifier.c |2 +-
lib/flow.c |2 +-
lib/flow.h |2 +-
lib/meta-flow.c |2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/lib/classifie
OpenFlow 1.0 and 1.2 have notions of VLAN that are different
enough to warrant separate "meta-flow" fields, which this commit
adds.
Signed-off-by: Ben Pfaff
---
lib/classifier.c | 25 +
lib/classifier.h |3 +++
lib/flow.c | 11 +++
lib/flow.h |
Giving these fields names that are the same as the OpenFlow 1.0 struct
member names should help make it clear what they are for.
Signed-off-by: Ben Pfaff
---
lib/meta-flow.c | 40
lib/meta-flow.h |4 ++--
2 files changed, 22 insertions(+), 22 deleti
From: Simon Horman
Signed-off-by: Simon Horman
Signed-off-by: Ben Pfaff
---
lib/nx-match.c | 22 ++
tests/ovs-ofctl.at | 16
2 files changed, 34 insertions(+), 4 deletions(-)
diff --git a/lib/nx-match.c b/lib/nx-match.c
index 0f67692..893566d 10064
From: Simon Horman
Signed-off-by: Simon Horman
Signed-off-by: Ben Pfaff
---
lib/meta-flow.c|4 +++-
lib/meta-flow.h|1 +
tests/ovs-ofctl.at |4
3 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/lib/meta-flow.c b/lib/meta-flow.c
index 101409a..c50cfc5 10064
From: Simon Horman
Signed-off-by: Simon Horman
Signed-off-by: Ben Pfaff
---
tests/ovs-ofctl.at| 10 ++
utilities/ovs-ofctl.c | 24
2 files changed, 34 insertions(+), 0 deletions(-)
diff --git a/tests/ovs-ofctl.at b/tests/ovs-ofctl.at
index c9a349c..f4f
From: Simon Horman
Signed-off-by: Simon Horman
Signed-off-by: Ben Pfaff
---
Simon, this is from your [PATCH 5/6] OXM: Allow VLAN VID match
to be masked
---
tests/ovs-ofctl.at | 20
1 files changed, 20 insertions(+), 0 deletions(-)
diff --git a/tests/ovs-ofctl.at b/tests
56 matches
Mail list logo
