Re: [ovs-dev] [PATCH] PORTING: Document why OVS does not support hybrid ofproto+dpif providers.

2011-07-15 Thread Ben Pfaff
I adjusted the wording a bit to make it even more explicit that this is about the slow management CPU of a hardware switch and pushed this to master. Thanks, Ben. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [nic-401] ofproto-dpif: Do not mirror L2 multicast switch protocols to VLANs.

2011-07-15 Thread Justin Pettit
On Jul 11, 2011, at 3:44 PM, Ben Pfaff wrote: > +if (dst[0] == 0x01 && dst[1] == 0x00 && dst[2] == 0x0c) { > +/* Cisco OUI. */ > +if ((dst[3] & 0xfe) == 0xcc && > +(dst[4] & 0xfe) == 0xcc && > +(dst[5] & 0xfe) == 0xcc) { > +

Re: [ovs-dev] [nic-401] ofproto-dpif: Do not mirror L2 multicast switch protocols to VLANs.

2011-07-15 Thread Ben Pfaff
On Fri, Jul 15, 2011 at 09:59:35AM -0700, Justin Pettit wrote: > On Jul 11, 2011, at 3:44 PM, Ben Pfaff wrote: > > > +if (dst[0] == 0x01 && dst[1] == 0x00 && dst[2] == 0x0c) { > > +/* Cisco OUI. */ > > +if ((dst[3] & 0xfe) == 0xcc && > > +(dst[4] & 0

[ovs-dev] [PATCH] ovsdb: Log when remote connections are deconfigured.

2011-07-15 Thread Ben Pfaff
Recently I helped debug a scenario where ovsdb-server connected to a remote manager, then ovs-vsctl deleted the remote manager and soon after re-added it. The log was difficult to interpret because it showed two successful connection attempts to the same remote without showing a reason why the con

Re: [ovs-dev] [PATCH] ovsdb: Log when remote connections are deconfigured.

2011-07-15 Thread Justin Pettit
Looks good. --Justin On Jul 15, 2011, at 11:25 AM, Ben Pfaff wrote: > Recently I helped debug a scenario where ovsdb-server connected to a remote > manager, then ovs-vsctl deleted the remote manager and soon after re-added > it. The log was difficult to interpret because it showed two successf

[ovs-dev] [bundle 1/5] ofproto: Don't commit modifiers on OFPP_NONE outputs.

2011-07-15 Thread Ethan Jackson
This provides a minor optimization. --- ofproto/ofproto-dpif.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c index 7264355..4d9d5da 100644 --- a/ofproto/ofproto-dpif.c +++ b/ofproto/ofproto-dpif.c @@ -2935,6 +2935,8 @@ xla

[ovs-dev] [bundle 2/5] nicira-ext: Generalize nx_mp_fields into nx_hash_fields.

2011-07-15 Thread Ethan Jackson
Future patches will use nx_hash_fields for non-multipath related actions. This patch renames nx_mp_fields and creates a new flow_hash_fields() function. --- include/openflow/nicira-ext.h | 44 lib/flow.c| 17 +++ lib/flo

[ovs-dev] [bundle 3/5] ofproto-dpif: Store bonding enabled flag on ofport.

2011-07-15 Thread Ethan Jackson
This simplifies the implementation of future patches. --- ofproto/ofproto-dpif.c | 18 -- 1 files changed, 12 insertions(+), 6 deletions(-) diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c index 4d9d5da..a6eb0db 100644 --- a/ofproto/ofproto-dpif.c +++ b/ofproto/ofpro

[ovs-dev] [bundle 4/5] ofputil: Export ofputil_check_output_port().

2011-07-15 Thread Ethan Jackson
Future patches will use this function outside of the ofputil module. --- lib/ofp-util.c |7 --- lib/ofp-util.h |1 + 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/lib/ofp-util.c b/lib/ofp-util.c index 00f9ce8..39bd0d1 100644 --- a/lib/ofp-util.c +++ b/lib/ofp-util.c @@

[ovs-dev] [bundle 5/5] vswitch: Implement bundle action.

2011-07-15 Thread Ethan Jackson
This patch creates a new action called "bundle". Bundles are a way to implement a simple form of multipath in OpenFlow by grouping several ports in a single output-like action. --- include/openflow/nicira-ext.h | 75 - lib/automake.mk |2 + lib/bundle.c

[ovs-dev] [brcompat 1/4] ovs-ctl: Start ovs-vswitchd with correct niceness.

2011-07-15 Thread Ben Pfaff
--- utilities/ovs-ctl.in |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/utilities/ovs-ctl.in b/utilities/ovs-ctl.in index a149905..c783f3d 100755 --- a/utilities/ovs-ctl.in +++ b/utilities/ovs-ctl.in @@ -184,7 +184,7 @@ start () { if test X"$MLOCKALL" != Xno; the

[ovs-dev] [brcompat 2/4] ovs-lib: Allow "status" command to work as non-root.

2011-07-15 Thread Ben Pfaff
--- utilities/ovs-lib.sh.in | 12 +--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --git a/utilities/ovs-lib.sh.in b/utilities/ovs-lib.sh.in index 179d85e..f53d4af 100644 --- a/utilities/ovs-lib.sh.in +++ b/utilities/ovs-lib.sh.in @@ -84,6 +84,12 @@ fi ## Daemons ## ## -

[ovs-dev] [brcompat 3/4] debian: Remove obsolete comment.

2011-07-15 Thread Ben Pfaff
The comment is obsolete because the switch now starts by default, without prior configuration. --- debian/openvswitch-switch.template |5 - 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/debian/openvswitch-switch.template b/debian/openvswitch-switch.template index 82f4e52.

[ovs-dev] [brcompat 4/4] debian: Add support for bridge compatibility.

2011-07-15 Thread Ben Pfaff
This adds support for bridge compatibility to the generic Open vSwitch init scripts and to the Debian packaging. See https://bugs.launchpad.net/ubuntu/+source/openvswitch/+bug/808224. --- debian/.gitignore|1 + debian/automake.mk |3 + debian/control