[ovs-dev] Oflops on openvSwitch

2011-07-11 Thread Usman Ajmal
I believe Oflops is for use with Openflow (available for download from here). Any idea if it can be used with Open vSwitch? or if someone has already used it? -- Usman _

Re: [ovs-dev] Oflops on openvSwitch

2011-07-11 Thread Justin Pettit
Please don't cross-post. For everyone else's benefit, this question was answered by Rob Sherwood on the other list you posted this question to: https://mailman.stanford.edu/pipermail/openflow-dev/2011-July/000893.html --Justin On Jul 11, 2011, at 4:42 AM, Usman Ajmal wrote: > I beli

Re: [ovs-dev] [PATCH 1/1] datapath: add key support to CAPWAP tunnel

2011-07-11 Thread Jesse Gross
On Sun, Jul 10, 2011 at 6:18 PM, Valient Gough wrote: > Add tunnel key support to CAPWAP vport.  Uses the optional WSI field in a > CAPWAP header to store a 64bit key.  It can also be used without keys, in > which > case it is backward compatible with the old code.  Documentation about the > WSI

[ovs-dev] [PATCH] configure: Pass correct -target option to "cgcc" in the common case.

2011-07-11 Thread Ben Pfaff
The "cgcc" script included with sparse guesses the target architecture based on the host architecture instead of based on the GCC architecture. This means that it often guesses wrong on biarch systems, e.g. my Linux kernel is x86_64 but userspace is i686 and thus GCC targets i686 by default. This

[ovs-dev] [nic-401] ofproto-dpif: Do not mirror L2 multicast switch protocols to VLANs.

2011-07-11 Thread Ben Pfaff
Mirroring certain protocols interpreted by switches to a VLAN can deceive the switch that receives it. Drop such packets instead of mirroring them. CC: David Tsai NIC-401. --- ofproto/ofproto-dpif.c | 41 - 1 files changed, 40 insertions(+), 1 deletions

[ovs-dev] [nic-401] ofproto-dpif: Do not mirror L2 multicast switch protocols to VLANs.

2011-07-11 Thread Ben Pfaff
Mirroring certain protocols interpreted by switches to a VLAN can deceive the switch that receives it. Drop such packets instead of mirroring them. CC: David Tsai NIC-401. --- Now with documentation. ofproto/ofproto-dpif.c | 41 - vswitchd/vswitch.xml

Re: [ovs-dev] [PATCH] configure: Pass correct -target option to "cgcc" in the common case.

2011-07-11 Thread Ethan Jackson
Looks fine to me. Ethan On Mon, Jul 11, 2011 at 13:58, Ben Pfaff wrote: > The "cgcc" script included with sparse guesses the target architecture > based on the host architecture instead of based on the GCC architecture. > This means that it often guesses wrong on biarch systems, e.g. my Linux >

Re: [ovs-dev] [PATCH] configure: Pass correct -target option to "cgcc" in the common case.

2011-07-11 Thread Ben Pfaff
Thanks, I pushed this. On Mon, Jul 11, 2011 at 04:08:52PM -0700, Ethan Jackson wrote: > Looks fine to me. > > Ethan > > On Mon, Jul 11, 2011 at 13:58, Ben Pfaff wrote: > > The "cgcc" script included with sparse guesses the target architecture > > based on the host architecture instead of based

Re: [ovs-dev] [ovs-bugtool 1/4] ovs-bugtool: Restore RHEL support.

2011-07-11 Thread Ethan Jackson
This seems fine to me. I looked at the supplied diff, and a diff versus xen-bugtool. I'm not completely sure of the value in restoring the whitespace as the files differ significantly anyways. That said, it probably doesn't matter either way. Seems fine. Ethan On Thu, Jun 30, 2011 at 14:57, Be

Re: [ovs-dev] [ovs-bugtool 2/4] ovs-bugtool: Make available outside of Debian packages.

2011-07-11 Thread Ethan Jackson
>  EXTRA_DIST += \ >        utilities/ovs-appctl.8.in \ > +       utilities/ovs-bugtool \ > +       utilities/ovs-bugtool.8 \ >        utilities/ovs-controller.8.in \ >        utilities/ovs-ctl.in \ >        utilities/ovs-dpctl.8.in \ > @@ -68,7 +72,8 @@ man_MANS += \ >        utilities/ovs-vlan-bu

Re: [ovs-dev] [ovs-bugtool 3/4] ovs-bugtool: Turn off "group" and "other" permissions for generated files.

2011-07-11 Thread Ethan Jackson
Looks Good. Ethan On Thu, Jun 30, 2011 at 14:57, Ben Pfaff wrote: > ovs-bugtool's output is potentially sensitive, so it seems best not to > allow anyone but the owner to read it.  This commit disables "group" and > "other" bits in the Unix ACL. > --- >  utilities/ovs-bugtool |    5 + >  1 f

Re: [ovs-dev] [ovs-bugtool 4/4] ovs-bugtool: Dump dpkg-related information as well as RPM-related info.

2011-07-11 Thread Ethan Jackson
Seems fine assuming you tried it. Ethan On Thu, Jun 30, 2011 at 14:57, Ben Pfaff wrote: > --- >  utilities/ovs-bugtool |    6 ++ >  1 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/utilities/ovs-bugtool b/utilities/ovs-bugtool > index f5fdb00..40dbb6c 100755 > --- a/utilitie

[ovs-dev] [PATCH] tests: Fix deprecated use of qw.

2011-07-11 Thread Ethan Jackson
This causes tests to fail on my system with the following error. Use of qw(...) as parentheses is deprecated at /home/root/ovs/tests/flowgen.pl line 35. --- tests/flowgen.pl | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/flowgen.pl b/tests/flowgen.pl index

Re: [ovs-dev] [ovs-bugtool 3/4] ovs-bugtool: Turn off "group" and "other" permissions for generated files.

2011-07-11 Thread Reid Price
LGTM too, not sure if you added the new empty line on purpose On Mon, Jul 11, 2011 at 6:31 PM, Ethan Jackson wrote: > Looks Good. > > Ethan > > On Thu, Jun 30, 2011 at 14:57, Ben Pfaff wrote: > > ovs-bugtool's output is potentially sensitive, so it seems best not to > > allow anyone but the own

[ovs-dev] [PATCH] datapath: An expanded table should be larger than its predecessor

2011-07-11 Thread Simon Horman
This resolves what appears to be a think-o in tbl_expand() * Old Logic: Always create tables with TBL_MIN_BUCKETS buckets * New Logic: Create tables twice as big as their predecessor When sending 10,000 flows through ovs-vswitchd: * Old Logic: CPU bound in tbl_lookup(), significant packet loss *